# HG changeset patch # User Yuya Nishihara # Date 2019-01-07 12:29:58 # Node ID b153a4aa06f839328b4bd5a8a733ed6af22c057e # Parent 14271b524d76fddb9accd2177deb75e03e9db7bd amend: refactor commit date handling There's no need to parse a date tuple. Just do it for user option. diff --git a/mercurial/cmdutil.py b/mercurial/cmdutil.py --- a/mercurial/cmdutil.py +++ b/mercurial/cmdutil.py @@ -2441,16 +2441,13 @@ def amend(ui, repo, old, extra, pats, op extra.update(wctx.extra()) user = opts.get('user') or old.user() - date = opts.get('date') or old.date() - - if ui.configbool('rewrite', 'update-timestamp'): - if opts.get('date'): - pass - else: - date = dateutil.makedate() - - # Parse the date to allow comparison between date and old.date() - date = dateutil.parsedate(date) + + if opts.get('date'): + date = dateutil.parsedate(opts.get('date')) + elif ui.configbool('rewrite', 'update-timestamp'): + date = dateutil.makedate() + else: + date = old.date() if len(old.parents()) > 1: # ctx.files() isn't reliable for merges, so fall back to the