# HG changeset patch # User Gregory Szorc # Date 2014-05-28 02:10:22 # Node ID b3213b9fafed0a7363945248ca10a4e55a244fe8 # Parent f221eb0531d9e90a305ea425674fd146d337294c run-tests: exit with non-0 exit code when tests fail or warn As part of the run-tests.py refactor, run-tests.py accidentally started exiting with 0 for most test runs. This patch restores the expected behavior. diff --git a/tests/run-tests.py b/tests/run-tests.py --- a/tests/run-tests.py +++ b/tests/run-tests.py @@ -1318,6 +1318,8 @@ class TextTestRunner(unittest.TextTestRu if self._runner.options.time: self.printtimes(result.times) + return result + def printtimes(self, times): self.stream.writeln('# Producing time report') times.sort(key=lambda t: (t[1], t[0]), reverse=True) @@ -1537,7 +1539,12 @@ class TestRunner(object): if self.options.verbose: verbosity = 2 runner = TextTestRunner(self, verbosity=verbosity) - runner.run(suite) + result = runner.run(suite) + + if result.failures: + failed = True + if result.warned: + warned = True if self.options.anycoverage: self._outputcoverage()