# HG changeset patch # User Mads Kiilerich # Date 2013-10-03 12:50:47 # Node ID b3de50b0c7aa464fdf73ece8c4e5ee8af59b4242 # Parent 681f7b9213a45c89192f34e41b2ffddab98a367e check-code: check that '>' is used for continued lines Continued lines do not get the SALT mangling. diff --git a/contrib/check-code.py b/contrib/check-code.py --- a/contrib/check-code.py +++ b/contrib/check-code.py @@ -120,7 +120,7 @@ utestpats = [ (uprefix + r'.*\|\| echo.*(fail|error)', "explicit exit code checks unnecessary"), (uprefix + r'set -e', "don't use set -e"), - (uprefix + r'\s', "don't indent commands, use > for continued lines"), + (uprefix + r'(\s|fi\b|done\b)', "use > for continued lines"), (r'^ saved backup bundle to \$TESTTMP.*\.hg$', winglobmsg), (r'^ changeset .* references (corrupted|missing) \$TESTTMP/.*[^)]$', winglobmsg), diff --git a/tests/test-walk.t b/tests/test-walk.t --- a/tests/test-walk.t +++ b/tests/test-walk.t @@ -3,11 +3,11 @@ $ mkdir -p beans $ for b in kidney navy turtle borlotti black pinto; do > echo $b > beans/$b - $ done + > done $ mkdir -p mammals/Procyonidae $ for m in cacomistle coatimundi raccoon; do > echo $m > mammals/Procyonidae/$m - $ done + > done $ echo skunk > mammals/skunk $ echo fennel > fennel $ echo fenugreek > fenugreek