# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@fb.com>
# Date 2014-10-09 11:27:01
# Node ID b5492b6bc7e864a0869c634bbf92b3d7eb031ab8
# Parent  f8a4ce6fb27a8b32baeb3bd27e3e1510f87105b0

baseset: drop custom __add__ method

This add method is enforcing non-laziness, disabling multiple optimisations.

Benchmarks do not spot any significant differences but real usecase may. This
will also be important for further improvements to addset later in this series.

diff --git a/mercurial/revset.py b/mercurial/revset.py
--- a/mercurial/revset.py
+++ b/mercurial/revset.py
@@ -2388,14 +2388,6 @@ class baseset(abstractsmartset):
         This is part of the mandatory API for smartset."""
         return baseset([y for y in self if y in other])
 
-    def __add__(self, other):
-        """Returns a new object with the union of the two collections.
-
-        This is part of the mandatory API for smartset."""
-        s = self.set()
-        l = [r for r in other if r not in s]
-        return baseset(list(self) + l)
-
     def isascending(self):
         """Returns True if the collection is ascending order, False if not.