# HG changeset patch # User Martin von Zweigbergk # Date 2019-01-17 01:34:59 # Node ID b87a009d1b3b5776ee8ab256a048d816c990d274 # Parent 57c462db87fdb6120ba44762ac2bfbf39c74b1a3 localrepo: use context manager for locks in commit() Differential Revision: https://phab.mercurial-scm.org/D5623 diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py --- a/mercurial/localrepo.py +++ b/mercurial/localrepo.py @@ -2409,11 +2409,8 @@ class localrepository(object): match.explicitdir = vdirs.append match.bad = fail - wlock = lock = None - try: - wlock = self.wlock() - lock = self.lock() # for recent changelog (see issue4368) - + # lock() for recent changelog (see issue4368) + with self.wlock(), self.lock(): wctx = self[None] merge = len(wctx.parents()) > 1 @@ -2485,9 +2482,6 @@ class localrepository(object): _('note: commit message saved in %s\n') % msgfn) raise - finally: - lockmod.release(lock, wlock) - def commithook(node=hex(ret), parent1=hookp1, parent2=hookp2): # hack for command that use a temporary commit (eg: histedit) # temporary commit got stripped before hook release