# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@octobus.net>
# Date 2019-04-13 18:57:50
# Node ID bc15e37ecc1658f57a6769f2373d6185ca80d7a3
# Parent  d6437f4144377b0c4bc25798c8f072bce99835f0

repoview: fix conditional around unserved changesets

The conditional could lead to wrong computation since we have more unserved
changesets than just the "secret" phase.

In addition, now that we have efficient caching of phased changesets, we don't
need the conditional anymore.

diff --git a/mercurial/repoview.py b/mercurial/repoview.py
--- a/mercurial/repoview.py
+++ b/mercurial/repoview.py
@@ -93,8 +93,8 @@ def computeunserved(repo, visibilityexce
     assert not repo.changelog.filteredrevs
     # fast path in simple case to avoid impact of non optimised code
     hiddens = filterrevs(repo, 'visible')
-    if phases.hassecret(repo):
-        secrets = repo._phasecache.getrevset(repo, phases.remotehiddenphases)
+    secrets = repo._phasecache.getrevset(repo, phases.remotehiddenphases)
+    if secrets:
         return frozenset(hiddens | frozenset(secrets))
     else:
         return hiddens