# HG changeset patch # User Anton Shestakov # Date 2015-06-12 08:09:59 # Node ID bcc02516f384abb4b31a92dae4785a26c4bfbe50 # Parent e0c09398c237d35683cb1a4a89047f15dbda2895 hgweb: don't point graph links at tip hash where it doesn't make sense Some pages, e.g. bookmarks, help and summary don't have a meaningful revision context: they always either show information about tip or about the whole repo (and not about any specific changeset). And error pages can just show hgweb error messages, not related to any repo or changeset. When monoblue style was added in 91b0ada2d94b, however, all graph links had tried to point at some hash, and on such pages as described above it didn't make sense. On error pages '{node|short}' is empty string anyway. Of course, it worked, but seeing such pages without revision context provide links with hashes is a bit confusing (unless you keep current tip hash in your head at all times) and wasn't consistent with other template styles, other pages in monoblue and even other links on the same page. Let's just link to '/graph', which is equal to '/graph/tip'. diff --git a/mercurial/templates/monoblue/bookmarks.tmpl b/mercurial/templates/monoblue/bookmarks.tmpl --- a/mercurial/templates/monoblue/bookmarks.tmpl +++ b/mercurial/templates/monoblue/bookmarks.tmpl @@ -21,7 +21,7 @@
  • summary
  • shortlog
  • changelog
  • -
  • graph
  • +
  • graph
  • tags
  • bookmarks
  • branches
  • diff --git a/mercurial/templates/monoblue/branches.tmpl b/mercurial/templates/monoblue/branches.tmpl --- a/mercurial/templates/monoblue/branches.tmpl +++ b/mercurial/templates/monoblue/branches.tmpl @@ -21,7 +21,7 @@
  • summary
  • shortlog
  • changelog
  • -
  • graph
  • +
  • graph
  • tags
  • bookmarks
  • branches
  • diff --git a/mercurial/templates/monoblue/error.tmpl b/mercurial/templates/monoblue/error.tmpl --- a/mercurial/templates/monoblue/error.tmpl +++ b/mercurial/templates/monoblue/error.tmpl @@ -21,7 +21,7 @@
  • summary
  • shortlog
  • changelog
  • -
  • graph
  • +
  • graph
  • tags
  • bookmarks
  • branches
  • diff --git a/mercurial/templates/monoblue/help.tmpl b/mercurial/templates/monoblue/help.tmpl --- a/mercurial/templates/monoblue/help.tmpl +++ b/mercurial/templates/monoblue/help.tmpl @@ -21,7 +21,7 @@
  • summary
  • shortlog
  • changelog
  • -
  • graph
  • +
  • graph
  • tags
  • bookmarks
  • branches
  • diff --git a/mercurial/templates/monoblue/helptopics.tmpl b/mercurial/templates/monoblue/helptopics.tmpl --- a/mercurial/templates/monoblue/helptopics.tmpl +++ b/mercurial/templates/monoblue/helptopics.tmpl @@ -21,7 +21,7 @@
  • summary
  • shortlog
  • changelog
  • -
  • graph
  • +
  • graph
  • tags
  • bookmarks
  • branches
  • diff --git a/mercurial/templates/monoblue/notfound.tmpl b/mercurial/templates/monoblue/notfound.tmpl --- a/mercurial/templates/monoblue/notfound.tmpl +++ b/mercurial/templates/monoblue/notfound.tmpl @@ -21,7 +21,7 @@
  • summary
  • shortlog
  • changelog
  • -
  • graph
  • +
  • graph
  • tags
  • bookmarks
  • branches
  • diff --git a/mercurial/templates/monoblue/search.tmpl b/mercurial/templates/monoblue/search.tmpl --- a/mercurial/templates/monoblue/search.tmpl +++ b/mercurial/templates/monoblue/search.tmpl @@ -21,7 +21,7 @@
  • summary
  • shortlog
  • changelog
  • -
  • graph
  • +
  • graph
  • tags
  • bookmarks
  • branches
  • diff --git a/mercurial/templates/monoblue/summary.tmpl b/mercurial/templates/monoblue/summary.tmpl --- a/mercurial/templates/monoblue/summary.tmpl +++ b/mercurial/templates/monoblue/summary.tmpl @@ -21,7 +21,7 @@
  • summary
  • shortlog
  • changelog
  • -
  • graph
  • +
  • graph
  • tags
  • bookmarks
  • branches
  • diff --git a/mercurial/templates/monoblue/tags.tmpl b/mercurial/templates/monoblue/tags.tmpl --- a/mercurial/templates/monoblue/tags.tmpl +++ b/mercurial/templates/monoblue/tags.tmpl @@ -21,7 +21,7 @@
  • summary
  • shortlog
  • changelog
  • -
  • graph
  • +
  • graph
  • tags
  • bookmarks
  • branches