# HG changeset patch # User Martin von Zweigbergk # Date 2020-10-07 03:37:35 # Node ID bd2df58366b1b19908eb0f8eaf72d692a65195f8 # Parent bdd2cdf9e24843123e30f3a01462c94b94cfbcef errors: name arguments to CommandError constructor Because readability counts. Differential Revision: https://phab.mercurial-scm.org/D9164 diff --git a/mercurial/dispatch.py b/mercurial/dispatch.py --- a/mercurial/dispatch.py +++ b/mercurial/dispatch.py @@ -492,13 +492,13 @@ def _callcatch(ui, func): % (inst.args[0], b" ".join(inst.args[1])) ) except error.CommandError as inst: - if inst.args[0]: + if inst.command: ui.pager(b'help') - msgbytes = pycompat.bytestr(inst.args[1]) - ui.warn(_(b"hg %s: %s\n") % (inst.args[0], msgbytes)) - commands.help_(ui, inst.args[0], full=False, command=True) + msgbytes = pycompat.bytestr(inst.message) + ui.warn(_(b"hg %s: %s\n") % (inst.command, msgbytes)) + commands.help_(ui, inst.command, full=False, command=True) else: - ui.warn(_(b"hg: %s\n") % inst.args[1]) + ui.warn(_(b"hg: %s\n") % inst.message) ui.warn(_(b"(use 'hg help -v' for a list of global options)\n")) except error.ParseError as inst: _formatparse(ui.warn, inst) diff --git a/mercurial/error.py b/mercurial/error.py --- a/mercurial/error.py +++ b/mercurial/error.py @@ -100,6 +100,11 @@ class ManifestLookupError(LookupError): class CommandError(Exception): """Exception raised on errors in parsing the command line.""" + def __init__(self, command, message): + self.command = command + self.message = message + super(CommandError, self).__init__() + __bytes__ = _tobytes