# HG changeset patch # User Pulkit Goyal # Date 2019-02-11 12:34:35 # Node ID bfc49f1df61523c21cdd1eb47efafb54bb4b2797 # Parent 0531dff73d0b4c2da085c05cb6b797a4dab7a9c9 branchmap: move __init__ up in branchcache class Making __init__ the first function defined helps understanding the class much better. Differential Revision: https://phab.mercurial-scm.org/D5931 diff --git a/mercurial/branchmap.py b/mercurial/branchmap.py --- a/mercurial/branchmap.py +++ b/mercurial/branchmap.py @@ -148,6 +148,21 @@ class branchcache(dict): This field can be used to avoid changelog reads when determining if a branch head closes a branch or not. """ + + def __init__(self, entries=(), tipnode=nullid, tiprev=nullrev, + filteredhash=None, closednodes=None): + super(branchcache, self).__init__(entries) + self.tipnode = tipnode + self.tiprev = tiprev + self.filteredhash = filteredhash + # closednodes is a set of nodes that close their branch. If the branch + # cache has been updated, it may contain nodes that are no longer + # heads. + if closednodes is None: + self._closednodes = set() + else: + self._closednodes = closednodes + @classmethod def fromfile(cls, repo): f = None @@ -207,20 +222,6 @@ class branchcache(dict): filename = '%s-%s' % (filename, repo.filtername) return filename - def __init__(self, entries=(), tipnode=nullid, tiprev=nullrev, - filteredhash=None, closednodes=None): - super(branchcache, self).__init__(entries) - self.tipnode = tipnode - self.tiprev = tiprev - self.filteredhash = filteredhash - # closednodes is a set of nodes that close their branch. If the branch - # cache has been updated, it may contain nodes that are no longer - # heads. - if closednodes is None: - self._closednodes = set() - else: - self._closednodes = closednodes - def validfor(self, repo): """Is the cache content valid regarding a repo