# HG changeset patch # User Long Vu # Date 2013-12-03 18:28:04 # Node ID c5f0574034ef3304b4834312f1e651f321d0516a # Parent 4c96c50ef9372ca8ee496ddf3556ce2c3f7f4062 largefiles: call super class method with proper kwargs to respect API Since the localrepositoyry.push() method in mercurial/localrepo.py is defined this way: def push(self, remote, force=False, revs=None, newbranch=False): it is better for largefiles to call push() on the super class with proper kwargs to respect the API. This will avoid breaking other extensions overriding the push method this way: def push(self, remote, force=False, **kwargs): diff --git a/hgext/largefiles/reposetup.py b/hgext/largefiles/reposetup.py --- a/hgext/largefiles/reposetup.py +++ b/hgext/largefiles/reposetup.py @@ -445,8 +445,8 @@ def reposetup(ui, repo): for f in files if lfutil.isstandin(f) and f in ctx])) lfcommands.uploadlfiles(ui, self, remote, toupload) - return super(lfilesrepo, self).push(remote, force, revs, - newbranch) + return super(lfilesrepo, self).push(remote, force=force, revs=revs, + newbranch=newbranch) def _subdirlfs(self, files, lfiles): '''