# HG changeset patch # User Durham Goode # Date 2014-04-30 22:36:38 # Node ID c77418938d051c1aa9376de6dde338cb1f3ba400 # Parent e2031c8ca4f8939a21fea454cb64b7a2744d9c8d transaction: fix file descriptor leak for journal.backupfiles The journal.backupfiles descriptor wasn't being closed. This resulted in hgsubversion test runs having a bagillion descriptors open, which crashed on platforms with low open file limits (like OSX). diff --git a/mercurial/transaction.py b/mercurial/transaction.py --- a/mercurial/transaction.py +++ b/mercurial/transaction.py @@ -220,6 +220,7 @@ class transaction(object): if self.count != 0: return self.file.close() + self.backupsfile.close() self.entries = [] if self.after: self.after() @@ -243,6 +244,7 @@ class transaction(object): self.count = 0 self.usages = 0 self.file.close() + self.backupsfile.close() if self.onabort is not None: self.onabort()