# HG changeset patch # User Pierre-Yves David # Date 2015-09-24 07:59:26 # Node ID cce8ebd3140773c0a95fedb4b3835be55385dbc3 # Parent 4a8e21578e1426757ff5bc71ac383d840e6251de match: remove a mutable default argument Mutable default arguments are know to the state of California to cause bugs. diff --git a/mercurial/scmutil.py b/mercurial/scmutil.py --- a/mercurial/scmutil.py +++ b/mercurial/scmutil.py @@ -753,7 +753,7 @@ def expandpats(pats): ret.append(kindpat) return ret -def matchandpats(ctx, pats=[], opts={}, globbed=False, default='relpath', +def matchandpats(ctx, pats=(), opts={}, globbed=False, default='relpath', badfn=None): '''Return a matcher and the patterns that were used. The matcher will warn about bad matches, unless an alternate badfn callback