# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 2024-10-23 02:41:04
# Node ID d01af74e67b4bae58ce1d180b644cdbb13fa07b0
# Parent  d37d8dfe65bd9fb7a3a17e3930fc3b4a85ba4ba4

interfaces: convert `repository.imanifeststorage` from zope `Attribute` attrs

This is the same transformation as b455dfddfed0 did for dirstate.

diff --git a/mercurial/interfaces/repository.py b/mercurial/interfaces/repository.py
--- a/mercurial/interfaces/repository.py
+++ b/mercurial/interfaces/repository.py
@@ -28,10 +28,16 @@ if typing.TYPE_CHECKING:
         urlutil,
     )
 
+    # TODO: make a protocol class for this
+    NodeConstants = Any
+
     # TODO: create a Protocol class, since importing uimod here causes a cycle
     #  that confuses pytype.
     Ui = Any
 
+    # TODO: make a protocol class for this
+    Vfs = Any
+
 # Local repository feature string.
 
 # Revlogs are being used for file storage.
@@ -1297,34 +1303,30 @@ class imanifestrevisionwritable(imanifes
 class imanifeststorage(Protocol):
     """Storage interface for manifest data."""
 
-    nodeconstants = interfaceutil.Attribute(
-        """nodeconstants used by the current repository."""
-    )
-
-    tree = interfaceutil.Attribute(
-        """The path to the directory this manifest tracks.
-
-        The empty bytestring represents the root manifest.
-        """
-    )
-
-    index = interfaceutil.Attribute(
-        """An ``ifilerevisionssequence`` instance."""
-    )
-
-    opener = interfaceutil.Attribute(
-        """VFS opener to use to access underlying files used for storage.
-
-        TODO this is revlog specific and should not be exposed.
-        """
-    )
-
-    fulltextcache = interfaceutil.Attribute(
-        """Dict with cache of fulltexts.
-
-        TODO this doesn't feel appropriate for the storage interface.
-        """
-    )
+    nodeconstants: NodeConstants
+    """nodeconstants used by the current repository."""
+
+    tree: bytes
+    """The path to the directory this manifest tracks.
+
+    The empty bytestring represents the root manifest.
+    """
+
+    index: ifilerevisionssequence
+    """An ``ifilerevisionssequence`` instance."""
+
+    opener: Vfs
+    """VFS opener to use to access underlying files used for storage.
+
+    TODO this is revlog specific and should not be exposed.
+    """
+
+    # TODO: finish type hints
+    fulltextcache: dict
+    """Dict with cache of fulltexts.
+
+    TODO this doesn't feel appropriate for the storage interface.
+    """
 
     def __len__(self):
         """Obtain the number of revisions stored for this manifest."""