# HG changeset patch
# User Martin von Zweigbergk <martinvonz@google.com>
# Date 2019-07-26 15:43:57
# Node ID d3d1a3afe7aa5f2d72e08bbd83c676a6b3adb46a
# Parent  0101db49606fadfd8b14785346cc5160e65376d0

fix: warn when a fixer doesn't have a configured command

It seems we currently produce an empty command line and then decide to
not run it, but it seems better to skip that part too.

Differential Revision: https://phab.mercurial-scm.org/D7085

diff --git a/hgext/fix.py b/hgext/fix.py
--- a/hgext/fix.py
+++ b/hgext/fix.py
@@ -800,7 +800,11 @@ def getfixers(ui):
         # dangerous to let it affect all files. It would be pointless to let it
         # affect no files. There is no reasonable subset of files to use as the
         # default.
-        if pattern is None:
+        if command is None:
+            ui.warn(
+                _(b'fixer tool has no command configuration: %s\n') % (name,)
+            )
+        elif pattern is None:
             ui.warn(
                 _(b'fixer tool has no pattern configuration: %s\n') % (name,)
             )
diff --git a/tests/test-fix.t b/tests/test-fix.t
--- a/tests/test-fix.t
+++ b/tests/test-fix.t
@@ -1338,6 +1338,8 @@ pattern config is missing, and that we o
   fixer tool has no pattern configuration: nopattern
   $ cat foo bar
   foobar (no-eol)
+  $ hg fix --debug --working-dir --config "fix.nocommand:pattern=foo.bar"
+  fixer tool has no command configuration: nocommand
 
   $ cd ..