# HG changeset patch # User Pierre-Yves David # Date 2015-05-20 22:40:47 # Node ID dc02a284e034e077d82dd435b15deedeaa1a5086 # Parent b5a8bc09b0dbd91594d0713b61f82dd00f07af21 sshpeer: rename 'size' to 'data' in doublepipe We are about to add 'write' support, the argument will be either an int or a string. diff --git a/mercurial/sshpeer.py b/mercurial/sshpeer.py --- a/mercurial/sshpeer.py +++ b/mercurial/sshpeer.py @@ -81,10 +81,11 @@ class doublepipe(object): def readline(self): return self._call('readline') - def _call(self, methname, size=None): + def _call(self, methname, data=None): """call on "main", forward output of "side" while blocking """ - if size == 0 or self._main.closed: + # data can be '' or 0 + if (data is not None and not data) or self._main.closed: _forwardoutput(self._ui, self._side) return '' while True: @@ -93,10 +94,10 @@ class doublepipe(object): _forwardoutput(self._ui, self._side) if mainready: meth = getattr(self._main, methname) - if size is None: + if data is None: return meth() else: - return meth(size) + return meth(data) def close(self): return self._main.close()