# HG changeset patch
# User Kevin Bullock <kbullock+mercurial@ringworld.org>
# Date 2016-05-06 13:45:56
# Node ID e05bdc01505febfed2da784006059960c59d80d1
# Parent  3879d02cd1cc5b86ab23a4280115bcf37375dd61

check-code: add a rule banning `env -u`

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -133,6 +133,7 @@ testpats = [
     (r'\|&', "don't use |&, use 2>&1"),
     (r'\w =  +\w', "only one space after = allowed"),
     (r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"),
+    (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'")
   ],
   # warnings
   [