# HG changeset patch # User Matt Mackall # Date 2014-05-09 19:46:50 # Node ID e4f451c8c05c7795ad32b19c6e3ead6e51bc8066 # Parent 19d6fec60b8113fe88b290acee47f89213be7efc resolve: simplify "finished" message The recently introduced message was: no unresolved files; you may continue your unfinished operation This had three problems: - looks a bit like an error message because it's not saying "we've just resolved the last file" - refers to "unfinished operation", which won't be the case with "update" or "merge" - introduces semicolons to error messages, which is stylistically questionable I've simplified this to: no more unresolved files In the future, if we want to prompt someone to continue a particular operation, we should use a hint style: no more unresolved files (use 'hg graft --continue' to finish grafting) diff --git a/mercurial/commands.py b/mercurial/commands.py --- a/mercurial/commands.py +++ b/mercurial/commands.py @@ -4981,8 +4981,7 @@ def resolve(ui, repo, *pats, **opts): # this with the list/show operation because we want list/show to remain # machine readable. if not list(ms.unresolved()) and not show: - ui.write(_('no unresolved files; ')) - ui.write(_('you may continue your unfinished operation\n')) + ui.status(_('no more unresolved files\n')) return ret diff --git a/tests/test-add.t b/tests/test-add.t --- a/tests/test-add.t +++ b/tests/test-add.t @@ -107,7 +107,7 @@ should fail M a ? a.orig $ hg resolve -m a - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg ci -m merge Issue683: peculiarity with hg revert of an removed then added file diff --git a/tests/test-backout.t b/tests/test-backout.t --- a/tests/test-backout.t +++ b/tests/test-backout.t @@ -490,7 +490,7 @@ Test usage of `hg resolve` in case of co merging foo my foo@b71750c4b0fd+ other foo@a30dd8addae3 ancestor foo@913609522437 premerge successful - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg status M foo ? foo.orig diff --git a/tests/test-commit-amend.t b/tests/test-commit-amend.t --- a/tests/test-commit-amend.t +++ b/tests/test-commit-amend.t @@ -586,7 +586,7 @@ Amend a merge changeset (with renames an merging cc incomplete! (edit conflicts, then use 'hg resolve --mark') [1] $ hg resolve -m cc - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg ci -m 'merge bar' $ hg log --config diff.git=1 -pr . changeset: 23:d51446492733 diff --git a/tests/test-commit-unresolved.t b/tests/test-commit-unresolved.t --- a/tests/test-commit-unresolved.t +++ b/tests/test-commit-unresolved.t @@ -41,7 +41,7 @@ Correct the conflict without marking the Mark the conflict as resolved and commit $ hg resolve -m A - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg commit -m "Merged" $ cd .. diff --git a/tests/test-convert-svn-sink.t b/tests/test-convert-svn-sink.t --- a/tests/test-convert-svn-sink.t +++ b/tests/test-convert-svn-sink.t @@ -352,7 +352,7 @@ Branchy history [1] $ hg --cwd b revert -r 2 b $ hg --cwd b resolve -m b - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg --cwd b ci -d '5 0' -m 'merge' Expect 4 changes diff --git a/tests/test-fileset.t b/tests/test-fileset.t --- a/tests/test-fileset.t +++ b/tests/test-fileset.t @@ -154,7 +154,7 @@ Test merge states b2 $ echo e > b2 $ hg resolve -m b2 - no unresolved files; you may continue your unfinished operation + no more unresolved files $ fileset 'resolved()' b2 $ fileset 'unresolved()' diff --git a/tests/test-graft.t b/tests/test-graft.t --- a/tests/test-graft.t +++ b/tests/test-graft.t @@ -220,7 +220,7 @@ Fix up: $ echo b > e $ hg resolve -m e - no unresolved files; you may continue your unfinished operation + no more unresolved files Continue with a revision should fail: @@ -355,7 +355,7 @@ Resolve conflicted graft [255] $ hg resolve --all merging a - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg graft -c grafting revision 1 $ hg export tip --git @@ -384,7 +384,7 @@ Resolve conflicted graft with rename [255] $ hg resolve --all merging a and b to b - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg graft -c grafting revision 2 $ hg export tip --git diff --git a/tests/test-histedit-fold-non-commute.t b/tests/test-histedit-fold-non-commute.t --- a/tests/test-histedit-fold-non-commute.t +++ b/tests/test-histedit-fold-non-commute.t @@ -95,7 +95,7 @@ edit the history fix up $ echo 'I can haz no commute' > e $ hg resolve --mark e - no unresolved files; you may continue your unfinished operation + no more unresolved files $ cat > cat.py < import sys > print open(sys.argv[1]).read() @@ -130,7 +130,7 @@ fix up just continue this time $ hg revert -r 'p1()' e $ hg resolve --mark e - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg histedit --continue 2>&1 | fixbundle 0 files updated, 0 files merged, 0 files removed, 0 files unresolved 0 files updated, 0 files merged, 0 files removed, 0 files unresolved diff --git a/tests/test-histedit-fold.t b/tests/test-histedit-fold.t --- a/tests/test-histedit-fold.t +++ b/tests/test-histedit-fold.t @@ -217,7 +217,7 @@ should effectively drop the changes from U file $ hg revert -r 'p1()' file $ hg resolve --mark file - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg histedit --continue 0 files updated, 0 files merged, 0 files removed, 0 files unresolved saved backup bundle to $TESTTMP/*-backup.hg (glob) @@ -277,7 +277,7 @@ dropped revision. > 5 > EOF $ hg resolve --mark file - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg commit -m '+5.2' created new head $ echo 6 >> file diff --git a/tests/test-histedit-non-commute.t b/tests/test-histedit-non-commute.t --- a/tests/test-histedit-non-commute.t +++ b/tests/test-histedit-non-commute.t @@ -154,7 +154,7 @@ edit the history fix up $ echo 'I can haz no commute' > e $ hg resolve --mark e - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg histedit --continue 2>&1 | fixbundle 0 files updated, 0 files merged, 0 files removed, 0 files unresolved merging e @@ -168,7 +168,7 @@ former children. just continue this time $ hg revert -r 'p1()' e $ hg resolve --mark e - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg histedit --continue 2>&1 | fixbundle 0 files updated, 0 files merged, 0 files removed, 0 files unresolved 0 files updated, 0 files merged, 0 files removed, 0 files unresolved @@ -241,7 +241,7 @@ edit the history, this time with a fold $ echo 'I can haz no commute' > e $ hg resolve --mark e - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg histedit --continue 2>&1 | fixbundle 0 files updated, 0 files merged, 0 files removed, 0 files unresolved merging e @@ -251,7 +251,7 @@ edit the history, this time with a fold second edit also fails, but just continue $ hg revert -r 'p1()' e $ hg resolve --mark e - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg histedit --continue 2>&1 | fixbundle 0 files updated, 0 files merged, 0 files removed, 0 files unresolved 0 files updated, 0 files merged, 0 files removed, 0 files unresolved diff --git a/tests/test-keyword.t b/tests/test-keyword.t --- a/tests/test-keyword.t +++ b/tests/test-keyword.t @@ -1058,7 +1058,7 @@ conflict: keyword should stay outside co resolve to local $ HGMERGE=internal:local hg resolve -a - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg commit -m localresolve $ cat m $Id: m 800511b3a22d Thu, 01 Jan 1970 00:00:00 +0000 test $ diff --git a/tests/test-lfconvert.t b/tests/test-lfconvert.t --- a/tests/test-lfconvert.t +++ b/tests/test-lfconvert.t @@ -132,7 +132,7 @@ add some changesets to rename/remove/mer [1] $ hg cat -r . sub/maybelarge.dat > stuff/maybelarge.dat $ hg resolve -m stuff/maybelarge.dat - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg commit -m"merge" $ hg log -G --template "{rev}:{node|short} {desc|firstline}\n" @ 5:4884f215abda merge diff --git a/tests/test-log.t b/tests/test-log.t --- a/tests/test-log.t +++ b/tests/test-log.t @@ -990,7 +990,7 @@ log -p -R repo [1] $ echo 'merge 1' > foo $ hg resolve -m foo - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg ci -m "First merge, related" $ hg merge 4 @@ -1002,7 +1002,7 @@ log -p -R repo [1] $ echo 'merge 2' > foo $ hg resolve -m foo - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg ci -m "Last merge, related" $ hg log --graph diff --git a/tests/test-merge-types.t b/tests/test-merge-types.t --- a/tests/test-merge-types.t +++ b/tests/test-merge-types.t @@ -50,7 +50,7 @@ Symlink is local parent, executable is o a is a symlink: a -> symlink $ hg resolve a --tool internal:other - no unresolved files; you may continue your unfinished operation + no more unresolved files $ tellmeabout a a is an executable file with content: a diff --git a/tests/test-merge7.t b/tests/test-merge7.t --- a/tests/test-merge7.t +++ b/tests/test-merge7.t @@ -57,7 +57,7 @@ resolve conflict > EOF $ rm -f *.orig $ hg resolve -m test.txt - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg commit -m "Merge 1" change test-a again diff --git a/tests/test-mq-qnew.t b/tests/test-mq-qnew.t --- a/tests/test-mq-qnew.t +++ b/tests/test-mq-qnew.t @@ -158,7 +158,7 @@ plain headers merging a incomplete! (edit conflicts, then use 'hg resolve --mark') 0 files updated, 0 files merged, 0 files removed, 1 files unresolved use 'hg resolve' to retry unresolved file merges or 'hg update -C .' to abandon - no unresolved files; you may continue your unfinished operation + no more unresolved files abort: cannot manage merge changesets $ rm -r sandbox @@ -232,7 +232,7 @@ hg headers merging a incomplete! (edit conflicts, then use 'hg resolve --mark') 0 files updated, 0 files merged, 0 files removed, 1 files unresolved use 'hg resolve' to retry unresolved file merges or 'hg update -C .' to abandon - no unresolved files; you may continue your unfinished operation + no more unresolved files abort: cannot manage merge changesets $ rm -r sandbox diff --git a/tests/test-rebase-bookmarks.t b/tests/test-rebase-bookmarks.t --- a/tests/test-rebase-bookmarks.t +++ b/tests/test-rebase-bookmarks.t @@ -168,7 +168,7 @@ rebase --continue with bookmarks present [1] $ echo 'c' > c $ hg resolve --mark c - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg rebase --continue saved backup bundle to $TESTTMP/a3/.hg/strip-backup/3d5fa227f4b5-backup.hg (glob) $ hg tglog diff --git a/tests/test-rebase-check-restore.t b/tests/test-rebase-check-restore.t --- a/tests/test-rebase-check-restore.t +++ b/tests/test-rebase-check-restore.t @@ -76,7 +76,7 @@ Solve the conflict and go on: $ echo 'conflict solved' > A $ rm A.orig $ hg resolve -m A - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg rebase --continue $ hg tglog @@ -130,7 +130,7 @@ Solve the conflict and go on: $ echo 'conflict solved' > A $ rm A.orig $ hg resolve -m A - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg rebase --continue saved backup bundle to $TESTTMP/a2/.hg/strip-backup/*-backup.hg (glob) diff --git a/tests/test-rebase-conflicts.t b/tests/test-rebase-conflicts.t --- a/tests/test-rebase-conflicts.t +++ b/tests/test-rebase-conflicts.t @@ -77,7 +77,7 @@ Conclude rebase: $ echo 'resolved merge' >common $ hg resolve -m common - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg rebase --continue saved backup bundle to $TESTTMP/a/.hg/strip-backup/*-backup.hg (glob) diff --git a/tests/test-rebase-detach.t b/tests/test-rebase-detach.t --- a/tests/test-rebase-detach.t +++ b/tests/test-rebase-detach.t @@ -374,7 +374,7 @@ Ensure --continue restores a correct sta unresolved conflicts (see hg resolve, then hg rebase --continue) [1] $ hg resolve --all -t internal:local - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg rebase -c saved backup bundle to $TESTTMP/a7/.hg/strip-backup/6215fafa5447-backup.hg (glob) $ hg log -G --template "{rev}:{phase} '{desc}' {branches}\n" diff --git a/tests/test-rebase-interruptions.t b/tests/test-rebase-interruptions.t --- a/tests/test-rebase-interruptions.t +++ b/tests/test-rebase-interruptions.t @@ -104,7 +104,7 @@ Solve the conflict and go on: $ echo 'conflict solved' > A $ rm A.orig $ hg resolve -m A - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg rebase --continue warning: new changesets detected on source branch, not stripping diff --git a/tests/test-rebase-mq-skip.t b/tests/test-rebase-mq-skip.t --- a/tests/test-rebase-mq-skip.t +++ b/tests/test-rebase-mq-skip.t @@ -111,7 +111,7 @@ already has one local mq patch [1] $ HGMERGE=internal:local hg resolve --all - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg rebase --continue saved backup bundle to $TESTTMP/b/.hg/strip-backup/*-backup.hg (glob) diff --git a/tests/test-rebase-mq.t b/tests/test-rebase-mq.t --- a/tests/test-rebase-mq.t +++ b/tests/test-rebase-mq.t @@ -69,7 +69,7 @@ Fix the 1st conflict: $ echo mq1r1 > f $ hg resolve -m f - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg rebase -c merging f warning: conflicts during merge. @@ -81,7 +81,7 @@ Fix the 2nd conflict: $ echo mq1r1mq2 > f $ hg resolve -m f - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg rebase -c saved backup bundle to $TESTTMP/a/.hg/strip-backup/*-backup.hg (glob) diff --git a/tests/test-rebase-parameters.t b/tests/test-rebase-parameters.t --- a/tests/test-rebase-parameters.t +++ b/tests/test-rebase-parameters.t @@ -454,7 +454,7 @@ Test --tool parameter: U c2 $ hg resolve -m c2 - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg rebase -c --tool internal:fail tool option will be ignored saved backup bundle to $TESTTMP/b3/.hg/strip-backup/*-backup.hg (glob) diff --git a/tests/test-resolve.t b/tests/test-resolve.t --- a/tests/test-resolve.t +++ b/tests/test-resolve.t @@ -39,7 +39,7 @@ resolve the failure $ echo resolved > file $ hg resolve -m file - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg commit -m 'resolved' resolve -l should error since no merge in progress diff --git a/tests/test-shelve.t b/tests/test-shelve.t --- a/tests/test-shelve.t +++ b/tests/test-shelve.t @@ -294,7 +294,7 @@ attempt to continue $ hg revert -r . a/a $ hg resolve -m a/a - no unresolved files; you may continue your unfinished operation + no more unresolved files $ hg commit -m 'commit while unshelve in progress' abort: unshelve already in progress