# HG changeset patch # User Matt Harbison # Date 2019-12-14 23:23:37 # Node ID e5f69e3bb3f61a5f7d3525094450ed41bd3f70a8 # Parent 8376d5d62d36f6189600d5fda2d9df253157283c ui: use a context manager to handle file streams in edit() Differential Revision: https://phab.mercurial-scm.org/D7669 diff --git a/mercurial/ui.py b/mercurial/ui.py --- a/mercurial/ui.py +++ b/mercurial/ui.py @@ -1766,9 +1766,8 @@ class ui(object): prefix=b'hg-' + extra[b'prefix'] + b'-', suffix=suffix, dir=rdir ) try: - f = os.fdopen(fd, 'wb') - f.write(util.tonativeeol(text)) - f.close() + with os.fdopen(fd, 'wb') as f: + f.write(util.tonativeeol(text)) environ = {b'HGUSER': user} if b'transplant_source' in extra: @@ -1794,9 +1793,8 @@ class ui(object): blockedtag=b'editor', ) - f = open(name, 'rb') - t = util.fromnativeeol(f.read()) - f.close() + with open(name, 'rb') as f: + t = util.fromnativeeol(f.read()) finally: os.unlink(name)