# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@ens-lyon.org>
# Date 2016-04-14 08:27:18
# Node ID ee56a86e278299281f4a3b6dd1b46ab26b7aea36
# Parent  d9539959167df7cb3acd08c4ab53d8e8a7f027cb

crecord: drop the extra confirmation screen

The commit confirmation is not very useful -- it gives no way to view what you
have selected, so you're blindly choosing whether to proceed or not, and it adds
a lot of unnecessary friction to committing. In addition, we now have a working
'review' choice for those who really want to review the final change.

Ryan McElroy initially submitted a config option to make this optional, but we
never saw a V2. However as the freeze is near and curses have never been
officially out of the door, I think it is worth skipping the config and trying
getting it right for this release.

diff --git a/mercurial/crecord.py b/mercurial/crecord.py
--- a/mercurial/crecord.py
+++ b/mercurial/crecord.py
@@ -1600,8 +1600,7 @@ are you sure you want to review/edit and
         elif keypressed in ['a']:
             self.toggleamend(self.opts, test)
         elif keypressed in ["c"]:
-            if self.confirmcommit():
-                return True
+            return True
         elif test and keypressed in ['X']:
             return True
         elif keypressed in ["r"]: