# HG changeset patch
# User Martin von Zweigbergk <martinvonz@google.com>
# Date 2020-02-28 19:32:27
# Node ID f0021fbedea91a23fef640ffe311656fda403d45
# Parent  6a34e438461bd1dd8b07c56ca8af30bbf5a7772c

cleanup: remove redundant clearing of mergestate in rebase and shelve

`repo.commit()` now clears the merge state even if it ends up not
creating a commit because there were no changes to commit.

Differential Revision: https://phab.mercurial-scm.org/D8197

diff --git a/hgext/rebase.py b/hgext/rebase.py
--- a/hgext/rebase.py
+++ b/hgext/rebase.py
@@ -548,11 +548,6 @@ class rebaseruntime(object):
                     date=date,
                 )
 
-            if newnode is None:
-                # If it ended up being a no-op commit, then the normal
-                # merge state clean-up path doesn't happen, so do it
-                # here. Fix issue5494
-                mergemod.mergestate.clean(repo)
             return newnode
 
     def _rebasenode(self, tr, rev, allowdivergence, progressfn):
diff --git a/mercurial/shelve.py b/mercurial/shelve.py
--- a/mercurial/shelve.py
+++ b/mercurial/shelve.py
@@ -827,10 +827,6 @@ def unshelvecontinue(ui, repo, state, op
                 )
 
         if newnode is None:
-            # If it ended up being a no-op commit, then the normal
-            # merge state clean-up path doesn't happen, so do it
-            # here. Fix issue5494
-            merge.mergestate.clean(repo)
             shelvectx = state.pendingctx
             msg = _(
                 b'note: unshelved changes already existed '
@@ -1031,10 +1027,6 @@ def _rebaserestoredcommit(
             )
 
         if newnode is None:
-            # If it ended up being a no-op commit, then the normal
-            # merge state clean-up path doesn't happen, so do it
-            # here. Fix issue5494
-            merge.mergestate.clean(repo)
             shelvectx = tmpwctx
             msg = _(
                 b'note: unshelved changes already existed '