# HG changeset patch # User Kyle Lippincott # Date 2020-01-21 20:10:35 # Node ID f0a4084f82d6382d73a29d02e85112a43f75ebc5 # Parent 3246cd5310b0fbd2abb52f7d93d353650539db7a cext: change two more vars to Py_ssize_t in manifest.c D7913 fixed a compiler warning with a signedness conflict in a ternary operator by changing the types of some variables to be Py_ssize_t instead of size_t or int. That commit missed these two cases since they aren't warned about (at least on my compiler). Both of these variables are produced by operations on variables that are themselves Py_ssize_t now/already, so they should keep the same type. Differential Revision: https://phab.mercurial-scm.org/D7964 diff --git a/mercurial/cext/manifest.c b/mercurial/cext/manifest.c --- a/mercurial/cext/manifest.c +++ b/mercurial/cext/manifest.c @@ -80,7 +80,7 @@ static PyObject *hashflags(line *l) PyObject *hash = nodeof(l); /* 40 for hash, 1 for null byte, 1 for newline */ - size_t hplen = plen + 42; + Py_ssize_t hplen = plen + 42; Py_ssize_t flen = l->len - hplen; PyObject *flags; PyObject *tup; @@ -525,7 +525,7 @@ static int lazymanifest_setitem( PyObject *pyflags; char *flags; Py_ssize_t flen; - size_t dlen; + Py_ssize_t dlen; char *dest; int i; line new;