# HG changeset patch # User Pierre-Yves David # Date 2015-06-12 02:02:24 # Node ID f140d6207cca33f0e6dfa75b65bd34382e600ee1 # Parent 15412bba5a68e7a66e430b26a313297b3ba8817c revset: use parentsets.min in _children As stated in the comment, using the smartset 'min' will give more opportunity to be smart. It give a small but significant boost to the performance. Most of the time is still spend doing the actual computation but at least we can scrap some performance when it makes sense. revset #0: roots(0:tip) plain 0) 0.046600 1) 0.044109 94% diff --git a/mercurial/revset.py b/mercurial/revset.py --- a/mercurial/revset.py +++ b/mercurial/revset.py @@ -622,9 +622,7 @@ def _children(repo, narrow, parentset): return baseset() cs = set() pr = repo.changelog.parentrevs - # XXX this should be 'parentset.min()' assuming 'parentset' is a smartset - # (and if it is not, it should.) - minrev = min(parentset) + minrev = parentset.min() for r in narrow: if r <= minrev: continue