# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 2019-06-15 01:58:53
# Node ID f305f1d7d5597d990d06a6cdd06f29fe1798e89c
# Parent  a4a468b00d44c38644a127572fad752dc09b9893

rust-filepatterns: add comment about Windows path handling

As I replied to the Phabricator message, this is wrong. And I even suspect
it wouldn't compile because of multiple type mismatches.

I think, in Rust where type system is rock solid, we can live with UTF-8
strings except for the bottom storage layer and the top UI/command layer.
We'll still have to get around undecodable characters not to be lost, but
I think it's okay to drop such filenames from match result if they don't
match in UTF-8 world, not in Latin-1 world.

diff --git a/rust/hg-core/src/utils/files.rs b/rust/hg-core/src/utils/files.rs
--- a/rust/hg-core/src/utils/files.rs
+++ b/rust/hg-core/src/utils/files.rs
@@ -9,6 +9,8 @@ pub fn get_path_from_bytes(bytes: &[u8])
     }
     #[cfg(windows)]
     {
+        // TODO: convert from Windows MBCS (ANSI encoding) to WTF8.
+        // Perhaps, the return type would have to be Result<PathBuf>.
         use std::os::windows::ffi::OsStrExt;
         os_str = std::ffi::OsString::from_wide(bytes);
     }