# HG changeset patch # User Pierre-Yves David # Date 2023-10-10 08:01:57 # Node ID f70ce1aedbcb502d2c8055da228a58ac107d37fe # Parent 3314c41c3759ddd4422e0a02ada90f0556550a41 manifestrevlog: flag some inconsistency in bundle/union repo inheritance This "work" but still, this is weird, let us point it out. diff --git a/mercurial/bundlerepo.py b/mercurial/bundlerepo.py --- a/mercurial/bundlerepo.py +++ b/mercurial/bundlerepo.py @@ -204,6 +204,8 @@ class bundlemanifest(bundlerevlog, manif dirlogstarts=None, dir=b'', ): + # XXX manifestrevlog is not actually a revlog , so mixing it with + # bundlerevlog is not a good idea. manifest.manifestrevlog.__init__(self, nodeconstants, opener, tree=dir) bundlerevlog.__init__( self, diff --git a/mercurial/unionrepo.py b/mercurial/unionrepo.py --- a/mercurial/unionrepo.py +++ b/mercurial/unionrepo.py @@ -205,6 +205,8 @@ class unionchangelog(unionrevlog, change class unionmanifest(unionrevlog, manifest.manifestrevlog): def __init__(self, nodeconstants, opener, opener2, linkmapper): + # XXX manifestrevlog is not actually a revlog , so mixing it with + # bundlerevlog is not a good idea. manifest.manifestrevlog.__init__(self, nodeconstants, opener) manifest2 = manifest.manifestrevlog(nodeconstants, opener2) unionrevlog.__init__(