# HG changeset patch # User Boris Feld # Date 2018-10-18 23:52:16 # Node ID f8154ddaaed32e1559f694ea78ce4e21eba92ac6 # Parent 1f0c5c9a1765b5e8a922cf52aeb7694941646ab6 run-tests: explicitly declare the list of dropped environment variable It will make the list clearer and more maintainable. diff --git a/tests/run-tests.py b/tests/run-tests.py --- a/tests/run-tests.py +++ b/tests/run-tests.py @@ -1110,9 +1110,23 @@ class Test(unittest.TestCase): env['COLUMNS'] = '80' env['TERM'] = 'xterm' - for k in ('HG HGPROF CDPATH GREP_OPTIONS http_proxy no_proxy ' + - 'HGPLAIN HGPLAINEXCEPT EDITOR VISUAL PAGER ' + - 'NO_PROXY CHGDEBUG').split(): + dropped = [ + 'CDPATH', + 'CHGDEBUG', + 'EDITOR', + 'GREP_OPTIONS', + 'HG', + 'HGPLAIN', + 'HGPLAINEXCEPT', + 'HGPROF', + 'http_proxy', + 'no_proxy', + 'NO_PROXY', + 'PAGER', + 'VISUAL', + ] + + for k in dropped: if k in env: del env[k]