# HG changeset patch # User Phil Cohen # Date 2017-08-25 04:30:51 # Node ID fa6309c5761dbe55781df0e99c71eb30ec17ab85 # Parent 61b267a99fea8d7f6b9fa6dceade50044709df1d simplemerge: stop accepting, and passing, file parameters Differential Revision: https://phab.mercurial-scm.org/D381 diff --git a/contrib/simplemerge b/contrib/simplemerge --- a/contrib/simplemerge +++ b/contrib/simplemerge @@ -85,9 +85,6 @@ try: raise ParseError(_('wrong number of arguments')) local, base, other = args sys.exit(simplemerge.simplemerge(uimod.ui.load(), - local, - base, - other, filebackedctx(local), filebackedctx(base), filebackedctx(other), diff --git a/mercurial/filemerge.py b/mercurial/filemerge.py --- a/mercurial/filemerge.py +++ b/mercurial/filemerge.py @@ -341,7 +341,7 @@ def _premerge(repo, fcd, fco, fca, toolc labels = _defaultconflictlabels if len(labels) < 3: labels.append('base') - r = simplemerge.simplemerge(ui, a, b, c, fcd, fca, fco, + r = simplemerge.simplemerge(ui, fcd, fca, fco, quiet=True, label=labels, repo=repo) if not r: ui.debug(" premerge successful\n") @@ -372,7 +372,7 @@ def _merge(repo, mynode, orig, fcd, fco, ui = repo.ui - r = simplemerge.simplemerge(ui, a, b, c, fcd, fca, fco, + r = simplemerge.simplemerge(ui, fcd, fca, fco, label=labels, mode=mode, repo=repo) return True, r, False @@ -425,7 +425,7 @@ def _imergeauto(repo, mynode, orig, fcd, assert localorother is not None tool, toolpath, binary, symlink = toolconf a, b, c, back = files - r = simplemerge.simplemerge(repo.ui, a, b, c, fcd, fca, fco, + r = simplemerge.simplemerge(repo.ui, fcd, fca, fco, label=labels, localorother=localorother, repo=repo) return True, r diff --git a/mercurial/simplemerge.py b/mercurial/simplemerge.py --- a/mercurial/simplemerge.py +++ b/mercurial/simplemerge.py @@ -419,8 +419,8 @@ def _picklabels(defaults, overrides): return [name_a, name_b, name_base] -def simplemerge(ui, localfile, basefile, otherfile, - localctx=None, basectx=None, otherctx=None, repo=None, **opts): +def simplemerge(ui, localctx=None, basectx=None, otherctx=None, repo=None, + **opts): """Performs the simplemerge algorithm. {local|base|other}ctx are optional. If passed, they (local/base/other) will