# HG changeset patch # User Yuya Nishihara # Date 2015-10-12 08:14:47 # Node ID ff6baf32b3ba2dddf0609adc621b1a4eaeca08aa # Parent 79d86ab65c9def3fdd65ec972bc5fa89688a19ff revset: eliminate temporary reference to subset in limit() and last() diff --git a/mercurial/revset.py b/mercurial/revset.py --- a/mercurial/revset.py +++ b/mercurial/revset.py @@ -1297,7 +1297,6 @@ def limit(repo, subset, x): except (TypeError, ValueError): # i18n: "limit" is a keyword raise error.ParseError(_("limit expects a number")) - ss = subset os = getset(repo, fullreposet(repo), l[0]) result = [] it = iter(os) @@ -1305,7 +1304,7 @@ def limit(repo, subset, x): y = next(it, None) if y is None: break - elif y in ss: + elif y in subset: result.append(y) return baseset(result) @@ -1323,7 +1322,6 @@ def last(repo, subset, x): except (TypeError, ValueError): # i18n: "last" is a keyword raise error.ParseError(_("last expects a number")) - ss = subset os = getset(repo, fullreposet(repo), l[0]) os.reverse() result = [] @@ -1332,7 +1330,7 @@ def last(repo, subset, x): y = next(it, None) if y is None: break - elif y in ss: + elif y in subset: result.append(y) return baseset(result)