errors: remove trailing "!" in messages about creating new heads on push

Differential Revision: https://phab.mercurial-scm.org/D9380

mercurial/discovery.py

@@ -399,12 +399,12 b' def checkheads(pushop):'
                 closedbranches.add(tag)
         closedbranches = closedbranches & set(newbranches)
         if closedbranches:
-            errmsg = _(b"push creates new remote branches: %s (%d closed)!") % (
+            errmsg = _(b"push creates new remote branches: %s (%d closed)") % (
                 branchnames,
                 len(closedbranches),
             )
         else:
-            errmsg = _(b"push creates new remote branches: %s!") % branchnames
+            errmsg = _(b"push creates new remote branches: %s") % branchnames
         hint = _(b"use 'hg push --new-branch' to create new remote branches")
         raise error.Abort(errmsg, hint=hint)
 
@@ -469,15 +469,15 b' def checkheads(pushop):'
             if errormsg is None:
                 if branch not in (b'default', None):
                     errormsg = _(
-                        b"push creates new remote head %s on branch '%s'!"
+                        b"push creates new remote head %s on branch '%s'"
                     ) % (short(dhs[0]), branch,)
                 elif repo[dhs[0]].bookmarks():
                     errormsg = _(
                         b"push creates new remote head %s "
-                        b"with bookmark '%s'!"
+                        b"with bookmark '%s'"
                     ) % (short(dhs[0]), repo[dhs[0]].bookmarks()[0])
                 else:
-                    errormsg = _(b"push creates new remote head %s!") % short(
+                    errormsg = _(b"push creates new remote head %s") % short(
                         dhs[0]
                     )
                 if unsyncedheads:

tests/test-bookflow.t

@@ -140,7 +140,7 b' the bookmark should not move if it diver'
   $ cd ../b
   $ # make sure we cannot push after bookmarks diverged
   $ hg push -B X | grep abort
-  abort: push creates new remote head * with bookmark 'X'! (glob)
+  abort: push creates new remote head * with bookmark 'X' (glob)
   (pull and merge or see 'hg help push' for details about pushing new heads)
   [1]
   $ hg pull -u | grep divergent

tests/test-bookmarks-pushpull.t

@@ -740,7 +740,7 b' diverging a remote bookmark fails'
   $ hg push http://localhost:$HGPORT2/
   pushing to http://localhost:$HGPORT2/
   searching for changes
-  abort: push creates new remote head c922c0139ca0 with bookmark 'Y'!
+  abort: push creates new remote head c922c0139ca0 with bookmark 'Y'
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
   $ hg -R ../a book
@@ -757,7 +757,7 b' Unrelated marker does not alter the deci'
   $ hg push http://localhost:$HGPORT2/
   pushing to http://localhost:$HGPORT2/
   searching for changes
-  abort: push creates new remote head c922c0139ca0 with bookmark 'Y'!
+  abort: push creates new remote head c922c0139ca0 with bookmark 'Y'
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
   $ hg -R ../a book
@@ -1053,7 +1053,7 b' pushing an existing but divergent bookma'
   pushing to $TESTTMP/addmarks
   searching for changes
   remote has heads on branch 'default' that are not known locally: a2a606d9ff1b
-  abort: push creates new remote head 54694f811df9 with bookmark 'X'!
+  abort: push creates new remote head 54694f811df9 with bookmark 'X'
   (pull and merge or see 'hg help push' for details about pushing new heads)
   [255]
   $ cd ../addmarks

tests/test-exchange-obsmarkers-case-A3.t

@@ -199,7 +199,7 b' check it complains about multiple heads'
   $ hg push -R main -r 'desc(A1)' pushdest
   pushing to pushdest
   searching for changes
-  abort: push creates new remote head e5ea8f9c7314!
+  abort: push creates new remote head e5ea8f9c7314
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
   $ cd ..

tests/test-obsolete-checkheads.t

@@ -95,7 +95,7 b' Abort: old will still be an head because'
   $ hg push
   pushing to $TESTTMP/remote
   searching for changes
-  abort: push creates new remote head 71e3228bffe1!
+  abort: push creates new remote head 71e3228bffe1
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 
@@ -155,7 +155,7 b' Push should abort on new head'
   $ hg push -r 'desc("other")'
   pushing to $TESTTMP/remote
   searching for changes
-  abort: push creates new remote head d7d41ccbd4de!
+  abort: push creates new remote head d7d41ccbd4de
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 
@@ -267,7 +267,7 b' We do not have enought data to take the '
   pushing to $TESTTMP/remote
   searching for changes
   remote has heads on branch 'default' that are not known locally: c70b08862e08
-  abort: push creates new remote head 71e3228bffe1!
+  abort: push creates new remote head 71e3228bffe1
   (pull and merge or see 'hg help push' for details about pushing new heads)
   [255]
 
@@ -317,6 +317,6 b' setup'
   $ hg push
   pushing to $TESTTMP/remote
   searching for changes
-  abort: push creates new remote head 350a93b716be!
+  abort: push creates new remote head 350a93b716be
   (merge or see 'hg help push' for details about pushing new heads)
   [255]

tests/test-phases-exchange.t

@@ -1015,7 +1015,7 b' appear on the remote side.'
   $ hg push -r 435b5d83910c ../mu
   pushing to ../mu
   searching for changes
-  abort: push creates new remote head 435b5d83910c!
+  abort: push creates new remote head 435b5d83910c
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
   $ hg push -fr 435b5d83910c ../mu # because the push will create new visible head

tests/test-push-checkheads-multibranches-E3.t

@@ -87,7 +87,7 b' Actual testing'
   $ hg push -r 'desc("C1")'
   pushing to $TESTTMP/E1/server
   searching for changes
-  abort: push creates new remote head dc44c53142f0!
+  abort: push creates new remote head dc44c53142f0
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 

tests/test-push-checkheads-partial-C1.t

@@ -78,7 +78,7 b' Actual testing'
   $ hg push
   pushing to $TESTTMP/C1/server
   searching for changes
-  abort: push creates new remote head 25c56d33e4c4!
+  abort: push creates new remote head 25c56d33e4c4
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 

tests/test-push-checkheads-partial-C2.t

@@ -79,7 +79,7 b' Actual testing'
   $ hg push --rev 'desc(A1)'
   pushing to $TESTTMP/C2/server
   searching for changes
-  abort: push creates new remote head f6082bc4ffef!
+  abort: push creates new remote head f6082bc4ffef
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 

tests/test-push-checkheads-partial-C3.t

@@ -78,7 +78,7 b' Actual testing'
   $ hg push
   pushing to $TESTTMP/C3/server
   searching for changes
-  abort: push creates new remote head 0f88766e02d6!
+  abort: push creates new remote head 0f88766e02d6
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 

tests/test-push-checkheads-partial-C4.t

@@ -79,7 +79,7 b' Actual testing'
   $ hg push --rev 'desc(C0)'
   pushing to $TESTTMP/C4/server
   searching for changes
-  abort: push creates new remote head 0f88766e02d6!
+  abort: push creates new remote head 0f88766e02d6
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 

tests/test-push-checkheads-unpushed-D1.t

@@ -71,7 +71,7 b' Actual testing'
   $ hg push -r 'desc(B0)'
   pushing to $TESTTMP/D1/server
   searching for changes
-  abort: push creates new remote head 74ff5441d343!
+  abort: push creates new remote head 74ff5441d343
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 

tests/test-push-checkheads-unpushed-D2.t

@@ -92,7 +92,7 b' Actual testing'
   $ hg push --rev 'desc(C0)'
   pushing to $TESTTMP/D2/server
   searching for changes
-  abort: push creates new remote head 0f88766e02d6!
+  abort: push creates new remote head 0f88766e02d6
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 

tests/test-push-checkheads-unpushed-D3.t

@@ -91,13 +91,13 b' Actual testing'
   $ hg push --rev 'desc(A1)'
   pushing to $TESTTMP/D3/server
   searching for changes
-  abort: push creates new remote head f6082bc4ffef!
+  abort: push creates new remote head f6082bc4ffef
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
   $ hg push --rev 'desc(B1)'
   pushing to $TESTTMP/D3/server
   searching for changes
-  abort: push creates new remote head 25c56d33e4c4!
+  abort: push creates new remote head 25c56d33e4c4
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 
@@ -109,7 +109,7 b' In this case, even a bare push is creati'
   $ hg push
   pushing to $TESTTMP/D3/server
   searching for changes
-  abort: push creates new remote head 25c56d33e4c4!
+  abort: push creates new remote head 25c56d33e4c4
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 

tests/test-push-checkheads-unpushed-D4.t

@@ -109,7 +109,7 b' Actual testing (new branch only)'
   $ hg push --rev 'desc(A1)'
   pushing to $TESTTMP/D4/server
   searching for changes
-  abort: push creates new remote head f6082bc4ffef!
+  abort: push creates new remote head f6082bc4ffef
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 

tests/test-push-checkheads-unpushed-D5.t

@@ -98,7 +98,7 b' Actual testing'
   $ hg push --rev 'desc(B1)'
   pushing to $TESTTMP/D5/server
   searching for changes
-  abort: push creates new remote head 25c56d33e4c4!
+  abort: push creates new remote head 25c56d33e4c4
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
   $ hg push --rev 'desc(A1)'

tests/test-push-checkheads-unpushed-D6.t

@@ -79,7 +79,7 b' Actual testing'
   $ hg push --rev 'desc(C0)'
   pushing to $TESTTMP/D6/server
   searching for changes
-  abort: push creates new remote head 0f88766e02d6!
+  abort: push creates new remote head 0f88766e02d6
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 

tests/test-push-warn.t

@@ -31,7 +31,7 b' Specifying a revset that evaluates to nu'
   pushing to ../a
   searching for changes
   remote has heads on branch 'default' that are not known locally: 1c9246a22a0a
-  abort: push creates new remote head 1e108cc5548c!
+  abort: push creates new remote head 1e108cc5548c
   (pull and merge or see 'hg help push' for details about pushing new heads)
   [255]
 
@@ -49,7 +49,7 b' Specifying a revset that evaluates to nu'
   remote has heads on branch 'default' that are not known locally: 1c9246a22a0a
   new remote heads on branch 'default':
    1e108cc5548c
-  abort: push creates new remote head 1e108cc5548c!
+  abort: push creates new remote head 1e108cc5548c
   (pull and merge or see 'hg help push' for details about pushing new heads)
   [255]
 
@@ -66,7 +66,7 b' Specifying a revset that evaluates to nu'
   $ hg push ../a
   pushing to ../a
   searching for changes
-  abort: push creates new remote head 1e108cc5548c!
+  abort: push creates new remote head 1e108cc5548c
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 
@@ -119,7 +119,7 b' Specifying a revset that evaluates to nu'
   $ hg push ../c
   pushing to ../c
   searching for changes
-  abort: push creates new remote head 6346d66eb9f5!
+  abort: push creates new remote head 6346d66eb9f5
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 
@@ -132,7 +132,7 b' Specifying a revset that evaluates to nu'
   $ hg push -r 3 ../c
   pushing to ../c
   searching for changes
-  abort: push creates new remote head a5dda829a167!
+  abort: push creates new remote head a5dda829a167
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 
@@ -142,7 +142,7 b' Specifying a revset that evaluates to nu'
   new remote heads on branch 'default':
    a5dda829a167
    ee8fbc7a0295
-  abort: push creates new remote head a5dda829a167!
+  abort: push creates new remote head a5dda829a167
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 
@@ -232,14 +232,14 b' Push on existing branch and new branch:'
   $ hg push ../f
   pushing to ../f
   searching for changes
-  abort: push creates new remote branches: c!
+  abort: push creates new remote branches: c
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
   $ hg push -r 4 -r 5 ../f
   pushing to ../f
   searching for changes
-  abort: push creates new remote branches: c!
+  abort: push creates new remote branches: c
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
@@ -253,14 +253,14 b' Multiple new branches:'
   $ hg push ../f
   pushing to ../f
   searching for changes
-  abort: push creates new remote branches: c, d!
+  abort: push creates new remote branches: c, d
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
   $ hg push -r 4 -r 6 ../f
   pushing to ../f
   searching for changes
-  abort: push creates new remote branches: c, d!
+  abort: push creates new remote branches: c, d
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
@@ -276,7 +276,7 b' Fail on multiple head push:'
   $ hg push -r 4 -r 7 ../f
   pushing to ../f
   searching for changes
-  abort: push creates new remote head 0b715ef6ff8f on branch 'a'!
+  abort: push creates new remote head 0b715ef6ff8f on branch 'a'
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 
@@ -353,7 +353,7 b' Failed push of new named branch:'
   $ hg push -r 12 -r 13 ../f
   pushing to ../f
   searching for changes
-  abort: push creates new remote branches: e!
+  abort: push creates new remote branches: e
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
@@ -425,7 +425,7 b" multiple new heads but also doesn't repo"
   pushing to h
   searching for changes
   remote has heads on branch 'default' that are not known locally: 534543e22c29 764f8ec07b96 afe7cc7679f5 ce4212fc8847
-  abort: push creates new remote head 97bd0c84d346!
+  abort: push creates new remote head 97bd0c84d346
   (pull and merge or see 'hg help push' for details about pushing new heads)
   [255]
   $ hg -R h up -q 0; echo x > h/b; hg -R h ci -qAmx
@@ -433,7 +433,7 b" multiple new heads but also doesn't repo"
   pushing to h
   searching for changes
   remote has heads on branch 'default' that are not known locally: 18ddb72c4590 534543e22c29 764f8ec07b96 afe7cc7679f5 and 1 others
-  abort: push creates new remote head 97bd0c84d346!
+  abort: push creates new remote head 97bd0c84d346
   (pull and merge or see 'hg help push' for details about pushing new heads)
   [255]
   $ hg -R i push h -v
@@ -442,7 +442,7 b" multiple new heads but also doesn't repo"
   remote has heads on branch 'default' that are not known locally: 18ddb72c4590 534543e22c29 764f8ec07b96 afe7cc7679f5 ce4212fc8847
   new remote heads on branch 'default':
    97bd0c84d346
-  abort: push creates new remote head 97bd0c84d346!
+  abort: push creates new remote head 97bd0c84d346
   (pull and merge or see 'hg help push' for details about pushing new heads)
   [255]
 
@@ -477,7 +477,7 b' Check prepush logic with merged branches'
   $ hg -R k push -r a j
   pushing to j
   searching for changes
-  abort: push creates new remote branches: b!
+  abort: push creates new remote branches: b
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
@@ -513,7 +513,7 b' Prepush -r should not allow you to sneak'
   $ hg push ../l -b b
   pushing to ../l
   searching for changes
-  abort: push creates new remote head 451211cc22b0 on branch 'a'!
+  abort: push creates new remote head 451211cc22b0 on branch 'a'
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 
@@ -763,14 +763,14 b' outgoing:'
   $ hg push inner
   pushing to inner
   searching for changes
-  abort: push creates new remote head 7d0f4fb6cf04 on branch 'A'!
+  abort: push creates new remote head 7d0f4fb6cf04 on branch 'A'
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 
   $ hg push inner -r4 -r5
   pushing to inner
   searching for changes
-  abort: push creates new remote head 7d0f4fb6cf04 on branch 'A'!
+  abort: push creates new remote head 7d0f4fb6cf04 on branch 'A'
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 
@@ -786,7 +786,7 b' Test fail hook'
   pushing to inner
   searching for changes
   running fail-push hook
-  abort: push creates new remote head 7d0f4fb6cf04 on branch 'A'!
+  abort: push creates new remote head 7d0f4fb6cf04 on branch 'A'
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 
@@ -815,7 +815,7 b' When there is a single closed branch'
   $ hg push ../x
   pushing to ../x
   searching for changes
-  abort: push creates new remote branches: foo (1 closed)!
+  abort: push creates new remote branches: foo (1 closed)
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
@@ -828,7 +828,7 b' When there is more than one closed branc'
   $ hg push ../x
   pushing to ../x
   searching for changes
-  abort: push creates new remote branches: bar, foo (2 closed)!
+  abort: push creates new remote branches: bar, foo (2 closed)
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
@@ -840,7 +840,7 b' When there are more than one new branche'
   $ hg push ../x
   pushing to ../x
   searching for changes
-  abort: push creates new remote branches: bar, bar1, foo (2 closed)!
+  abort: push creates new remote branches: bar, bar1, foo (2 closed)
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 

tests/test-push.t

@@ -385,7 +385,7 b' Test `commands.push.require-revs`'
   $ hg push -b default
   pushing to $TESTTMP/test-require-revs-dest
   searching for changes
-  abort: push creates new remote head [0-9a-f]+! (re)
+  abort: push creates new remote head [0-9a-f]+ (re)
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
 (demonstrate that even though we don't have anything to exchange, we're still

tests/test-subrepo.t

@@ -571,7 +571,7 b' push -f'
   no changes made to subrepo s/ss since last push to $TESTTMP/t/s/ss
   pushing subrepo s to $TESTTMP/t/s
   searching for changes
-  abort: push creates new remote head 12a213df6fa9! (in subrepository "s")
+  abort: push creates new remote head 12a213df6fa9 (in subrepository "s")
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
   $ hg push -f
@@ -1013,7 +1013,7 b' Issue1977: multirepo push should fail if'
   created new head
   $ hg -R repo2 ci -m3
   $ hg -q -R repo2 push
-  abort: push creates new remote head cc505f09a8b2! (in subrepository "s")
+  abort: push creates new remote head cc505f09a8b2 (in subrepository "s")
   (merge or see 'hg help push' for details about pushing new heads)
   [255]
   $ hg -R repo update

tests/test-treediscovery-legacy.t

@@ -285,7 +285,7 b' Local is superset:'
   $ hg push $remote
   pushing to http://localhost:$HGPORT/
   searching for changes
-  abort: push creates new remote branches: both, name1!
+  abort: push creates new remote branches: both, name1
   (use 'hg push --new-branch' to create new remote branches)
   [255]
   $ hg push $remote --new-branch

tests/test-treediscovery.t

@@ -269,7 +269,7 b' Local is superset:'
   $ hg push $remote
   pushing to http://localhost:$HGPORT/
   searching for changes
-  abort: push creates new remote branches: both, name1!
+  abort: push creates new remote branches: both, name1
   (use 'hg push --new-branch' to create new remote branches)
   [255]
   $ hg push $remote --new-branch