interfaces: create a new folder for interfaces and move repository.py in it

I was trying to understand current interfaces and write new ones and I realized
we need to improve how current interfaces are organised. This creates a
dedicated folder for defining interfaces and move `repository.py` which defines
all the current interfaces inside it.

Differential Revision: https://phab.mercurial-scm.org/D6741

contrib/import-checker.py

@@ -28,6 +28,7 b' allowsymbolimports = ('
     'mercurial.hgweb.common',
     'mercurial.hgweb.request',
     'mercurial.i18n',
+    'mercurial.interfaces',
     'mercurial.node',
     # for revlog to re-export constant to extensions
     'mercurial.revlogutils.constants',

hgext/lfs/__init__.py

@@ -141,13 +141,16 b' from mercurial import ('
     minifileset,
     node,
     pycompat,
-    repository,
     revlog,
     scmutil,
     templateutil,
     util,
 )
 
+from mercurial.interfaces import (
+    repository,
+)
+
 from . import (
     blobstore,
     wireprotolfsserver,

hgext/lfs/wrapper.py

@@ -21,7 +21,6 b' from mercurial import ('
     exchange,
     exthelper,
     localrepo,
-    repository,
     revlog,
     scmutil,
     upgrade,
@@ -30,6 +29,10 b' from mercurial import ('
     wireprotov1server,
 )
 
+from mercurial.interfaces import (
+    repository,
+)
+
 from mercurial.utils import (
     storageutil,
     stringutil,

hgext/narrow/__init__.py

@@ -17,6 +17,9 b" testedwith = 'ships-with-hg-core'"
 from mercurial import (
     localrepo,
     registrar,
+)
+
+from mercurial.interfaces import (
     repository,
 )
 

hgext/narrow/narrowbundle2.py

@@ -23,10 +23,12 b' from mercurial import ('
     localrepo,
     narrowspec,
     repair,
-    repository,
     util,
     wireprototypes,
 )
+from mercurial.interfaces import (
+    repository,
+)
 from mercurial.utils import (
     stringutil,
 )

hgext/narrow/narrowcommands.py

@@ -25,12 +25,14 b' from mercurial import ('
     pycompat,
     registrar,
     repair,
-    repository,
     repoview,
     sparse,
     util,
     wireprototypes,
 )
+from mercurial.interfaces import (
+    repository,
+)
 
 table = {}
 command = registrar.command(table)

hgext/sqlitestore.py

@@ -70,10 +70,12 b' from mercurial import ('
     mdiff,
     pycompat,
     registrar,
-    repository,
     util,
     verify,
 )
+from mercurial.interfaces import (
+    repository,
+)
 from mercurial.utils import (
     interfaceutil,
     storageutil,

mercurial/changegroup.py

@@ -25,8 +25,11 b' from . import ('
     mdiff,
     phases,
     pycompat,
+    util,
+)
+
+from .interfaces import (
     repository,
-    util,
 )
 
 _CHANGEGROUPV1_DELTA_HEADER = struct.Struct("20s20s20s20s")

mercurial/exchange.py

@@ -34,7 +34,6 b' from . import ('
     phases,
     pushkey,
     pycompat,
-    repository,
     scmutil,
     sslutil,
     streamclone,
@@ -42,6 +41,9 b' from . import ('
     util,
     wireprototypes,
 )
+from .interfaces import (
+    repository,
+)
 from .utils import (
     stringutil,
 )

mercurial/exchangev2.py

@@ -22,8 +22,10 b' from . import ('
     narrowspec,
     phases,
     pycompat,
+    setdiscovery,
+)
+from .interfaces import (
     repository,
-    setdiscovery,
 )
 
 def pull(pullop):

mercurial/filelog.py

@@ -14,8 +14,10 b' from .node import ('
 )
 from . import (
     error,
+    revlog,
+)
+from .interfaces import (
     repository,
-    revlog,
 )
 from .utils import (
     interfaceutil,

mercurial/hg.py

@@ -39,7 +39,6 b' from . import ('
     node,
     phases,
     pycompat,
-    repository as repositorymod,
     scmutil,
     sshpeer,
     statichttprepo,
@@ -51,6 +50,10 b' from . import ('
     vfs as vfsmod,
 )
 
+from .interfaces import (
+    repository as repositorymod,
+)
+
 release = lock.release
 
 # shared features

mercurial/httppeer.py

@@ -16,12 +16,14 b' import struct'
 import weakref
 
 from .i18n import _
+from .interfaces import (
+    repository,
+)
 from . import (
     bundle2,
     error,
     httpconnection,
     pycompat,
-    repository,
     statichttprepo,
     url as urlmod,
     util,

mercurial/interfaces/repository.py

@@ -7,11 +7,11 b''
 
 from __future__ import absolute_import
 
-from .i18n import _
-from . import (
+from ..i18n import _
+from .. import (
     error,
 )
-from .utils import (
+from ..utils import (
     interfaceutil,
 )
 

mercurial/localrepo.py

@@ -52,7 +52,6 b' from . import ('
     phases,
     pushkey,
     pycompat,
-    repository,
     repoview,
     revset,
     revsetlang,
@@ -66,6 +65,11 b' from . import ('
     util,
     vfs as vfsmod,
 )
+
+from .interfaces import (
+    repository,
+)
+
 from .utils import (
     interfaceutil,
     procutil,

mercurial/manifest.py

@@ -24,10 +24,12 b' from . import ('
     mdiff,
     policy,
     pycompat,
-    repository,
     revlog,
     util,
 )
+from .interfaces import (
+    repository,
+)
 from .utils import (
     interfaceutil,
 )

mercurial/narrowspec.py

@@ -8,11 +8,13 b''
 from __future__ import absolute_import
 
 from .i18n import _
+from .interfaces import (
+    repository,
+)
 from . import (
     error,
     match as matchmod,
     merge,
-    repository,
     scmutil,
     sparse,
     util,

mercurial/revlog.py

@@ -65,10 +65,12 b' from . import ('
     mdiff,
     policy,
     pycompat,
-    repository,
     templatefilters,
     util,
 )
+from .interfaces import (
+    repository,
+)
 from .revlogutils import (
     deltas as deltautil,
     flagutil,

mercurial/revlogutils/constants.py

@@ -9,7 +9,7 b''
 
 from __future__ import absolute_import
 
-from .. import (
+from ..interfaces import (
     repository,
 )
 

mercurial/streamclone.py

@@ -12,13 +12,15 b' import os'
 import struct
 
 from .i18n import _
+from .interfaces import (
+    repository,
+)
 from . import (
     cacheutil,
     error,
     narrowspec,
     phases,
     pycompat,
-    repository,
     store,
     util,
 )

mercurial/testing/storage.py

@@ -17,6 +17,8 b' from ..node import ('
 from .. import (
     error,
     mdiff,
+)
+from ..interfaces import (
     repository,
 )
 from ..utils import (

mercurial/utils/storageutil.py

@@ -22,8 +22,8 b' from .. import ('
     error,
     mdiff,
     pycompat,
-    repository,
 )
+from ..interfaces import repository
 
 _nullhash = hashlib.sha1(nullid)
 

mercurial/wireprotov1peer.py

@@ -22,10 +22,12 b' from . import ('
     error,
     pushkey as pushkeymod,
     pycompat,
-    repository,
     util,
     wireprototypes,
 )
+from .interfaces import (
+    repository,
+)
 from .utils import (
     interfaceutil,
 )

setup.py

@@ -1067,6 +1067,7 b" packages = ['mercurial',"
             'mercurial.cext',
             'mercurial.cffi',
             'mercurial.hgweb',
+            'mercurial.interfaces',
             'mercurial.pure',
             'mercurial.thirdparty',
             'mercurial.thirdparty.attr',

tests/notcapable

@@ -6,7 +6,8 b' then'
 fi
 
 cat > notcapable-$CAP.py << EOF
-from mercurial import extensions, localrepo, repository
+from mercurial import extensions, localrepo
+from mercurial.interfaces import repository
 def extsetup(ui):
     extensions.wrapfunction(repository.peer, 'capable', wrapcapable)
     extensions.wrapfunction(localrepo.localrepository, 'peer', wrappeer)

tests/pullext.py

@@ -13,6 +13,8 b' from mercurial import ('
     error,
     extensions,
     localrepo,
+)
+from mercurial.interfaces import (
     repository,
 )
 

tests/simplestorerepo.py

@@ -32,11 +32,13 b' from mercurial import ('
     localrepo,
     mdiff,
     pycompat,
-    repository,
     revlog,
     store,
     verify,
 )
+from mercurial.interfaces import (
+    repository,
+)
 from mercurial.utils import (
     cborutil,
     interfaceutil,

tests/test-check-interfaces.py

@@ -14,6 +14,9 b" if subprocess.call(['python', '%s/hghave"
                     'test-repo']):
     sys.exit(80)
 
+from mercurial.interfaces import (
+    repository,
+)
 from mercurial.thirdparty.zope import (
     interface as zi,
 )
@@ -27,7 +30,6 b' from mercurial import ('
     localrepo,
     manifest,
     pycompat,
-    repository,
     revlog,
     sshpeer,
     statichttprepo,

tests/wireprotosimplecache.py

@@ -10,12 +10,14 b' from __future__ import absolute_import'
 from mercurial import (
     extensions,
     registrar,
-    repository,
     util,
     wireprotoserver,
     wireprototypes,
     wireprotov2server,
 )
+from mercurial.interfaces import (
+    repository,
+)
 from mercurial.utils import (
     interfaceutil,
     stringutil,