check-code: fix check for trailing whitespace on continued lines too

The tests in test-annotate.t and test-import-git.t that relied on trailing
space in a file created by a here string is now masked by a literal 'EOL'
string that is removed.

contrib/check-code.py

@@ -1,450 +1,450
 #!/usr/bin/env python
 #
 # check-code - a style and portability checker for Mercurial
 #
 # Copyright 2010 Matt Mackall <[e-mail]>
 #
 # This software may be used and distributed according to the terms of the
 # GNU General Public License version 2 or any later version.
 
 import re, glob, os, sys
 import keyword
 import optparse
 
 def repquote(m):
     t = re.sub(r"\w", "x", m.group('text'))
     t = re.sub(r"[^\s\nx]", "o", t)
     return m.group('quote') + t + m.group('quote')
 
 def reppython(m):
     comment = m.group('comment')
     if comment:
         return "#" * len(comment)
     return repquote(m)
 
 def repcomment(m):
     return m.group(1) + "#" * len(m.group(2))
 
 def repccomment(m):
     t = re.sub(r"((?<=\n) )|\S", "x", m.group(2))
     return m.group(1) + t + "*/"
 
 def repcallspaces(m):
     t = re.sub(r"\n\s+", "\n", m.group(2))
     return m.group(1) + t
 
 def repinclude(m):
     return m.group(1) + "<foo>"
 
 def rephere(m):
     t = re.sub(r"\S", "x", m.group(2))
     return m.group(1) + t
 
 
 testpats = [
   [
     (r'pushd|popd', "don't use 'pushd' or 'popd', use 'cd'"),
     (r'\W\$?\(\([^\)\n]*\)\)', "don't use (()) or $(()), use 'expr'"),
     (r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"),
     (r'sed.*-i', "don't use 'sed -i', use a temporary file"),
     (r'\becho\b.*\\n', "don't use 'echo \\n', use printf"),
     (r'echo -n', "don't use 'echo -n', use printf"),
     (r'(^| )wc[^|]*$\n(?!.*\(re\))', "filter wc output"),
     (r'head -c', "don't use 'head -c', use 'dd'"),
     (r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"),
     (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"),
     (r'printf.*\\([1-9]|0\d)', "don't use 'printf \NNN', use Python"),
     (r'printf.*\\x', "don't use printf \\x, use Python"),
     (r'\$\(.*\)', "don't use $(expr), use `expr`"),
     (r'rm -rf \*', "don't use naked rm -rf, target a directory"),
     (r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w',
      "use egrep for extended grep syntax"),
     (r'/bin/', "don't use explicit paths for tools"),
     (r'[^\n]\Z', "no trailing newline"),
     (r'export.*=', "don't export and assign at once"),
     (r'^source\b', "don't use 'source', use '.'"),
     (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"),
     (r'ls +[^|\n-]+ +-', "options to 'ls' must come before filenames"),
     (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),
     (r'^stop\(\)', "don't use 'stop' as a shell function name"),
     (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),
     (r'^alias\b.*=', "don't use alias, use a function"),
     (r'if\s*!', "don't use '!' to negate exit status"),
     (r'/dev/u?random', "don't use entropy, use /dev/zero"),
     (r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"),
     (r'^( *)\t', "don't use tabs to indent"),
   ],
   # warnings
   [
     (r'^function', "don't use 'function', use old style"),
     (r'^diff.*-\w*N', "don't use 'diff -N'"),
     (r'\$PWD', "don't use $PWD, use `pwd`"),
     (r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"),
   ]
 ]
 
 testfilters = [
     (r"( *)(#([^\n]*\S)?)", repcomment),
     (r"<<(\S+)((.|\n)*?\n\1)", rephere),
 ]
 
 uprefix = r"^  \$ "
 utestpats = [
   [
-    (r'^(\S.*||  \$ .*)[ \t]\n', "trailing whitespace on non-output"),
+    (r'^(\S.*||  [$>] .*)[ \t]\n', "trailing whitespace on non-output"),
     (uprefix + r'.*\|\s*sed[^|>\n]*\n',
      "use regex test output patterns instead of sed"),
     (uprefix + r'(true|exit 0)', "explicit zero exit unnecessary"),
     (uprefix + r'.*(?<!\[)\$\?', "explicit exit code checks unnecessary"),
     (uprefix + r'.*\|\| echo.*(fail|error)',
      "explicit exit code checks unnecessary"),
     (uprefix + r'set -e', "don't use set -e"),
     (uprefix + r'\s', "don't indent commands, use > for continued lines"),
     (r'^  saved backup bundle to \$TESTTMP.*\.hg$',
      "use (glob) to match Windows paths too"),
   ],
   # warnings
   []
 ]
 
 for i in [0, 1]:
     for p, m in testpats[i]:
         if p.startswith(r'^'):
             p = r"^  [$>] (%s)" % p[1:]
         else:
             p = r"^  [$>] .*(%s)" % p
         utestpats[i].append((p, m))
 
 utestfilters = [
     (r"( *)(#([^\n]*\S)?)", repcomment),
 ]
 
 pypats = [
   [
     (r'^\s*def\s*\w+\s*\(.*,\s*\(',
      "tuple parameter unpacking not available in Python 3+"),
     (r'lambda\s*\(.*,.*\)',
      "tuple parameter unpacking not available in Python 3+"),
     (r'(?<!def)\s+(cmp)\(', "cmp is not available in Python 3+"),
     (r'\breduce\s*\(.*', "reduce is not available in Python 3+"),
     (r'\.has_key\b', "dict.has_key is not available in Python 3+"),
     (r'^\s*\t', "don't use tabs"),
     (r'\S;\s*\n', "semicolon"),
     (r'[^_]_\("[^"]+"\s*%', "don't use % inside _()"),
     (r"[^_]_\('[^']+'\s*%", "don't use % inside _()"),
     (r'\w,\w', "missing whitespace after ,"),
     (r'\w[+/*\-<>]\w', "missing whitespace in expression"),
     (r'^\s+\w+=\w+[^,)\n]$', "missing whitespace in assignment"),
     (r'(\s+)try:\n((?:\n|\1\s.*\n)+?)\1except.*?:\n'
      r'((?:\n|\1\s.*\n)+?)\1finally:', 'no try/except/finally in Py2.4'),
     (r'.{81}', "line too long"),
     (r' x+[xo][\'"]\n\s+[\'"]x', 'string join across lines with no space'),
     (r'[^\n]\Z', "no trailing newline"),
     (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
 #    (r'^\s+[^_ \n][^_. \n]+_[^_\n]+\s*=',
 #     "don't use underbars in identifiers"),
     (r'^\s+(self\.)?[A-za-z][a-z0-9]+[A-Z]\w* = ',
      "don't use camelcase in identifiers"),
     (r'^\s*(if|while|def|class|except|try)\s[^[\n]*:\s*[^\\n]#\s]+',
      "linebreak after :"),
     (r'class\s[^( \n]+:', "old-style class, use class foo(object)"),
     (r'class\s[^( \n]+\(\):',
      "class foo() not available in Python 2.4, use class foo(object)"),
     (r'\b(%s)\(' % '|'.join(keyword.kwlist),
      "Python keyword is not a function"),
     (r',]', "unneeded trailing ',' in list"),
 #    (r'class\s[A-Z][^\(]*\((?!Exception)',
 #     "don't capitalize non-exception classes"),
 #    (r'in range\(', "use xrange"),
 #    (r'^\s*print\s+', "avoid using print in core and extensions"),
     (r'[\x80-\xff]', "non-ASCII character literal"),
     (r'("\')\.format\(', "str.format() not available in Python 2.4"),
     (r'^\s*with\s+', "with not available in Python 2.4"),
     (r'\.isdisjoint\(', "set.isdisjoint not available in Python 2.4"),
     (r'^\s*except.* as .*:', "except as not available in Python 2.4"),
     (r'^\s*os\.path\.relpath', "relpath not available in Python 2.4"),
     (r'(?<!def)\s+(any|all|format)\(',
      "any/all/format not available in Python 2.4"),
     (r'(?<!def)\s+(callable)\(',
      "callable not available in Python 3, use getattr(f, '__call__', None)"),
     (r'if\s.*\selse', "if ... else form not available in Python 2.4"),
     (r'^\s*(%s)\s\s' % '|'.join(keyword.kwlist),
      "gratuitous whitespace after Python keyword"),
     (r'([\(\[][ \t]\S)|(\S[ \t][\)\]])', "gratuitous whitespace in () or []"),
 #    (r'\s\s=', "gratuitous whitespace before ="),
     (r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S',
      "missing whitespace around operator"),
     (r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\s',
      "missing whitespace around operator"),
     (r'\s(\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S',
      "missing whitespace around operator"),
     (r'[^^+=*/!<>&| %-](\s=|=\s)[^= ]',
      "wrong whitespace around ="),
     (r'raise Exception', "don't raise generic exceptions"),
     (r' is\s+(not\s+)?["\'0-9-]', "object comparison with literal"),
     (r' [=!]=\s+(True|False|None)',
      "comparison with singleton, use 'is' or 'is not' instead"),
     (r'^\s*(while|if) [01]:',
      "use True/False for constant Boolean expression"),
     (r'(?:(?<!def)\s+|\()hasattr',
      'hasattr(foo, bar) is broken, use util.safehasattr(foo, bar) instead'),
     (r'opener\([^)]*\).read\(',
      "use opener.read() instead"),
     (r'BaseException', 'not in Py2.4, use Exception'),
     (r'os\.path\.relpath', 'os.path.relpath is not in Py2.5'),
     (r'opener\([^)]*\).write\(',
      "use opener.write() instead"),
     (r'[\s\(](open|file)\([^)]*\)\.read\(',
      "use util.readfile() instead"),
     (r'[\s\(](open|file)\([^)]*\)\.write\(',
      "use util.readfile() instead"),
     (r'^[\s\(]*(open(er)?|file)\([^)]*\)',
      "always assign an opened file to a variable, and close it afterwards"),
     (r'[\s\(](open|file)\([^)]*\)\.',
      "always assign an opened file to a variable, and close it afterwards"),
     (r'(?i)descendent', "the proper spelling is descendAnt"),
     (r'\.debug\(\_', "don't mark debug messages for translation"),
     (r'\.strip\(\)\.split\(\)', "no need to strip before splitting"),
     (r'^\s*except\s*:', "warning: naked except clause", r'#.*re-raises'),
     (r':\n(    )*( ){1,3}[^ ]', "must indent 4 spaces"),
   ],
   # warnings
   [
     (r'ui\.(status|progress|write|note|warn)\([\'\"]x',
      "warning: unwrapped ui message"),
   ]
 ]
 
 pyfilters = [
     (r"""(?msx)(?P<comment>\#.*?$)|
          ((?P<quote>('''|\"\"\"|(?<!')'(?!')|(?<!")"(?!")))
           (?P<text>(([^\\]|\\.)*?))
           (?P=quote))""", reppython),
 ]
 
 cpats = [
   [
     (r'//', "don't use //-style comments"),
     (r'^  ', "don't use spaces to indent"),
     (r'\S\t', "don't use tabs except for indent"),
     (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
     (r'.{81}', "line too long"),
     (r'(while|if|do|for)\(', "use space after while/if/do/for"),
     (r'return\(', "return is not a function"),
     (r' ;', "no space before ;"),
     (r'\w+\* \w+', "use int *foo, not int* foo"),
     (r'\([^\)]+\) \w+', "use (int)foo, not (int) foo"),
     (r'\w+ (\+\+|--)', "use foo++, not foo ++"),
     (r'\w,\w', "missing whitespace after ,"),
     (r'^[^#]\w[+/*]\w', "missing whitespace in expression"),
     (r'^#\s+\w', "use #foo, not # foo"),
     (r'[^\n]\Z', "no trailing newline"),
     (r'^\s*#import\b', "use only #include in standard C code"),
   ],
   # warnings
   []
 ]
 
 cfilters = [
     (r'(/\*)(((\*(?!/))|[^*])*)\*/', repccomment),
     (r'''(?P<quote>(?<!")")(?P<text>([^"]|\\")+)"(?!")''', repquote),
     (r'''(#\s*include\s+<)([^>]+)>''', repinclude),
     (r'(\()([^)]+\))', repcallspaces),
 ]
 
 inutilpats = [
   [
     (r'\bui\.', "don't use ui in util"),
   ],
   # warnings
   []
 ]
 
 inrevlogpats = [
   [
     (r'\brepo\.', "don't use repo in revlog"),
   ],
   # warnings
   []
 ]
 
 checks = [
     ('python', r'.*\.(py|cgi)$', pyfilters, pypats),
     ('test script', r'(.*/)?test-[^.~]*$', testfilters, testpats),
     ('c', r'.*\.c$', cfilters, cpats),
     ('unified test', r'.*\.t$', utestfilters, utestpats),
     ('layering violation repo in revlog', r'mercurial/revlog\.py', pyfilters,
      inrevlogpats),
     ('layering violation ui in util', r'mercurial/util\.py', pyfilters,
      inutilpats),
 ]
 
 class norepeatlogger(object):
     def __init__(self):
         self._lastseen = None
 
     def log(self, fname, lineno, line, msg, blame):
         """print error related a to given line of a given file.
 
         The faulty line will also be printed but only once in the case
         of multiple errors.
 
         :fname: filename
         :lineno: line number
         :line: actual content of the line
         :msg: error message
         """
         msgid = fname, lineno, line
         if msgid != self._lastseen:
             if blame:
                 print "%s:%d (%s):" % (fname, lineno, blame)
             else:
                 print "%s:%d:" % (fname, lineno)
             print " > %s" % line
             self._lastseen = msgid
         print " " + msg
 
 _defaultlogger = norepeatlogger()
 
 def getblame(f):
     lines = []
     for l in os.popen('hg annotate -un %s' % f):
         start, line = l.split(':', 1)
         user, rev = start.split()
         lines.append((line[1:-1], user, rev))
     return lines
 
 def checkfile(f, logfunc=_defaultlogger.log, maxerr=None, warnings=False,
               blame=False, debug=False, lineno=True):
     """checks style and portability of a given file
 
     :f: filepath
     :logfunc: function used to report error
               logfunc(filename, linenumber, linecontent, errormessage)
     :maxerr: number of error to display before arborting.
              Set to false (default) to report all errors
 
     return True if no error is found, False otherwise.
     """
     blamecache = None
     result = True
     for name, match, filters, pats in checks:
         if debug:
             print name, f
         fc = 0
         if not re.match(match, f):
             if debug:
                 print "Skipping %s for %s it doesn't match %s" % (
                        name, match, f)
             continue
         fp = open(f)
         pre = post = fp.read()
         fp.close()
         if "no-" + "check-code" in pre:
             if debug:
                 print "Skipping %s for %s it has no- and check-code" % (
                        name, f)
             break
         for p, r in filters:
             post = re.sub(p, r, post)
         if warnings:
             pats = pats[0] + pats[1]
         else:
             pats = pats[0]
         # print post # uncomment to show filtered version
 
         if debug:
             print "Checking %s for %s" % (name, f)
 
         prelines = None
         errors = []
         for pat in pats:
             if len(pat) == 3:
                 p, msg, ignore = pat
             else:
                 p, msg = pat
                 ignore = None
 
             # fix-up regexes for multiline searches
             po = p
             # \s doesn't match \n
             p = re.sub(r'(?<!\\)\\s', r'[ \\t]', p)
             # [^...] doesn't match newline
             p = re.sub(r'(?<!\\)\[\^', r'[^\\n', p)
 
             #print po, '=>', p
 
             pos = 0
             n = 0
             for m in re.finditer(p, post, re.MULTILINE):
                 if prelines is None:
                     prelines = pre.splitlines()
                     postlines = post.splitlines(True)
 
                 start = m.start()
                 while n < len(postlines):
                     step = len(postlines[n])
                     if pos + step > start:
                         break
                     pos += step
                     n += 1
                 l = prelines[n]
 
                 if "check-code" + "-ignore" in l:
                     if debug:
                         print "Skipping %s for %s:%s (check-code -ignore)" % (
                             name, f, n)
                     continue
                 elif ignore and re.search(ignore, l, re.MULTILINE):
                     continue
                 bd = ""
                 if blame:
                     bd = 'working directory'
                     if not blamecache:
                         blamecache = getblame(f)
                     if n < len(blamecache):
                         bl, bu, br = blamecache[n]
                         if bl == l:
                             bd = '%s@%s' % (bu, br)
                 errors.append((f, lineno and n + 1, l, msg, bd))
                 result = False
 
         errors.sort()
         for e in errors:
             logfunc(*e)
             fc += 1
             if maxerr and fc >= maxerr:
                 print " (too many errors, giving up)"
                 break
 
     return result
 
 if __name__ == "__main__":
     parser = optparse.OptionParser("%prog [options] [files]")
     parser.add_option("-w", "--warnings", action="store_true",
                       help="include warning-level checks")
     parser.add_option("-p", "--per-file", type="int",
                       help="max warnings per file")
     parser.add_option("-b", "--blame", action="store_true",
                       help="use annotate to generate blame info")
     parser.add_option("", "--debug", action="store_true",
                       help="show debug information")
     parser.add_option("", "--nolineno", action="store_false",
                       dest='lineno', help="don't show line numbers")
 
     parser.set_defaults(per_file=15, warnings=False, blame=False, debug=False,
                         lineno=True)
     (options, args) = parser.parse_args()
 
     if len(args) == 0:
         check = glob.glob("*")
     else:
         check = args
 
     ret = 0
     for f in check:
         if not checkfile(f, maxerr=options.per_file, warnings=options.warnings,
                          blame=options.blame, debug=options.debug,
                          lineno=options.lineno):
             ret = 1
     sys.exit(ret)

tests/test-annotate.t

@@ -1,322 +1,322
   $ HGMERGE=true; export HGMERGE
 
 init
 
   $ hg init repo
   $ cd repo
 
 commit
 
   $ echo 'a' > a
   $ hg ci -A -m test -u nobody -d '1 0'
   adding a
 
 annotate -c
 
   $ hg annotate -c a
   8435f90966e4: a
 
 annotate -cl
 
   $ hg annotate -cl a
   8435f90966e4:1: a
 
 annotate -d
 
   $ hg annotate -d a
   Thu Jan 01 00:00:01 1970 +0000: a
 
 annotate -n
 
   $ hg annotate -n a
   0: a
 
 annotate -nl
 
   $ hg annotate -nl a
   0:1: a
 
 annotate -u
 
   $ hg annotate -u a
   nobody: a
 
 annotate -cdnu
 
   $ hg annotate -cdnu a
   nobody 0 8435f90966e4 Thu Jan 01 00:00:01 1970 +0000: a
 
 annotate -cdnul
 
   $ hg annotate -cdnul a
   nobody 0 8435f90966e4 Thu Jan 01 00:00:01 1970 +0000:1: a
 
   $ cat <<EOF >>a
   > a
   > a
   > EOF
   $ hg ci -ma1 -d '1 0'
   $ hg cp a b
   $ hg ci -mb -d '1 0'
   $ cat <<EOF >> b
   > b4
   > b5
   > b6
   > EOF
   $ hg ci -mb2 -d '2 0'
 
 annotate -n b
 
   $ hg annotate -n b
   0: a
   1: a
   1: a
   3: b4
   3: b5
   3: b6
 
 annotate --no-follow b
 
   $ hg annotate --no-follow b
   2: a
   2: a
   2: a
   3: b4
   3: b5
   3: b6
 
 annotate -nl b
 
   $ hg annotate -nl b
   0:1: a
   1:2: a
   1:3: a
   3:4: b4
   3:5: b5
   3:6: b6
 
 annotate -nf b
 
   $ hg annotate -nf b
   0 a: a
   1 a: a
   1 a: a
   3 b: b4
   3 b: b5
   3 b: b6
 
 annotate -nlf b
 
   $ hg annotate -nlf b
   0 a:1: a
   1 a:2: a
   1 a:3: a
   3 b:4: b4
   3 b:5: b5
   3 b:6: b6
 
   $ hg up -C 2
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ cat <<EOF >> b
   > b4
   > c
   > b5
   > EOF
   $ hg ci -mb2.1 -d '2 0'
   created new head
   $ hg merge
   merging b
   0 files updated, 1 files merged, 0 files removed, 0 files unresolved
   (branch merge, don't forget to commit)
   $ hg ci -mmergeb -d '3 0'
 
 annotate after merge
 
   $ hg annotate -nf b
   0 a: a
   1 a: a
   1 a: a
   3 b: b4
   4 b: c
   3 b: b5
 
 annotate after merge with -l
 
   $ hg annotate -nlf b
   0 a:1: a
   1 a:2: a
   1 a:3: a
   3 b:4: b4
   4 b:5: c
   3 b:5: b5
 
   $ hg up -C 1
   0 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ hg cp a b
   $ cat <<EOF > b
   > a
   > z
   > a
   > EOF
   $ hg ci -mc -d '3 0'
   created new head
   $ hg merge
   merging b
   0 files updated, 1 files merged, 0 files removed, 0 files unresolved
   (branch merge, don't forget to commit)
   $ cat <<EOF >> b
   > b4
   > c
   > b5
   > EOF
   $ echo d >> b
   $ hg ci -mmerge2 -d '4 0'
 
 annotate after rename merge
 
   $ hg annotate -nf b
   0 a: a
   6 b: z
   1 a: a
   3 b: b4
   4 b: c
   3 b: b5
   7 b: d
 
 annotate after rename merge with -l
 
   $ hg annotate -nlf b
   0 a:1: a
   6 b:2: z
   1 a:3: a
   3 b:4: b4
   4 b:5: c
   3 b:5: b5
   7 b:7: d
 
 Issue2807: alignment of line numbers with -l
 
   $ echo more >> b
   $ hg ci -mmore -d '5 0'
   $ echo more >> b
   $ hg ci -mmore -d '6 0'
   $ echo more >> b
   $ hg ci -mmore -d '7 0'
   $ hg annotate -nlf b
    0 a: 1: a
    6 b: 2: z
    1 a: 3: a
    3 b: 4: b4
    4 b: 5: c
    3 b: 5: b5
    7 b: 7: d
    8 b: 8: more
    9 b: 9: more
   10 b:10: more
 
 linkrev vs rev
 
   $ hg annotate -r tip -n a
   0: a
   1: a
   1: a
 
 linkrev vs rev with -l
 
   $ hg annotate -r tip -nl a
   0:1: a
   1:2: a
   1:3: a
 
 Issue589: "undelete" sequence leads to crash
 
 annotate was crashing when trying to --follow something
 
 like A -> B -> A
 
 generate ABA rename configuration
 
   $ echo foo > foo
   $ hg add foo
   $ hg ci -m addfoo
   $ hg rename foo bar
   $ hg ci -m renamefoo
   $ hg rename bar foo
   $ hg ci -m renamebar
 
 annotate after ABA with follow
 
   $ hg annotate --follow foo
   foo: foo
 
 missing file
 
   $ hg ann nosuchfile
   abort: nosuchfile: no such file in rev e9e6b4fa872f
   [255]
 
 annotate file without '\n' on last line
 
   $ printf "" > c
   $ hg ci -A -m test -u nobody -d '1 0'
   adding c
   $ hg annotate c
   $ printf "a\nb" > c
   $ hg ci -m test
   $ hg annotate c
   [0-9]+: a (re)
   [0-9]+: b (re)
 
 Test annotate with whitespace options
 
   $ cd ..
   $ hg init repo-ws
   $ cd repo-ws
   $ cat > a <<EOF
   > aa
   > 
   > b b
   > EOF
   $ hg ci -Am "adda"
   adding a
-  $ cat > a <<EOF
+  $ sed 's/EOL$//g' > a <<EOF
   > a  a
   > 
-  >  
+  >  EOL
   > b  b
   > EOF
   $ hg ci -m "changea"
 
 Annotate with no option
 
   $ hg annotate a
   1: a  a
   0: 
   1:  
   1: b  b
 
 Annotate with --ignore-space-change
 
   $ hg annotate --ignore-space-change a
   1: a  a
   1: 
   0:  
   0: b  b
 
 Annotate with --ignore-all-space
 
   $ hg annotate --ignore-all-space a
   0: a  a
   0: 
   1:  
   0: b  b
 
 Annotate with --ignore-blank-lines (similar to no options case)
 
   $ hg annotate --ignore-blank-lines a
   1: a  a
   0: 
   1:  
   1: b  b
 
   $ cd ..

tests/test-import-git.t

@@ -1,611 +1,611
   $ hg init repo
   $ cd repo
 
 New file:
 
   $ hg import -d "1000000 0" -mnew - <<EOF
   > diff --git a/new b/new
   > new file mode 100644
   > index 0000000..7898192
   > --- /dev/null
   > +++ b/new
   > @@ -0,0 +1 @@
   > +a
   > EOF
   applying patch from stdin
 
   $ hg tip -q
   0:ae3ee40d2079
 
 New empty file:
 
   $ hg import -d "1000000 0" -mempty - <<EOF
   > diff --git a/empty b/empty
   > new file mode 100644
   > EOF
   applying patch from stdin
 
   $ hg tip -q
   1:ab199dc869b5
 
   $ hg locate empty
   empty
 
 chmod +x:
 
   $ hg import -d "1000000 0" -msetx - <<EOF
   > diff --git a/new b/new
   > old mode 100644
   > new mode 100755
   > EOF
   applying patch from stdin
 
 #if execbit
   $ hg tip -q
   2:3a34410f282e
   $ test -x new
   $ hg rollback -q
 #else
   $ hg tip -q
   1:ab199dc869b5
 #endif
 
 Copy and removing x bit:
 
   $ hg import -f -d "1000000 0" -mcopy - <<EOF
   > diff --git a/new b/copy
   > old mode 100755
   > new mode 100644
   > similarity index 100%
   > copy from new
   > copy to copy
   > diff --git a/new b/copyx
   > similarity index 100%
   > copy from new
   > copy to copyx
   > EOF
   applying patch from stdin
 
   $ test -f copy
 #if execbit
   $ test ! -x copy
   $ test -x copyx
   $ hg tip -q
   2:21dfaae65c71
 #else
   $ hg tip -q
   2:0efdaa8e3bf3
 #endif
 
   $ hg up -qCr1
   $ hg rollback -q
 
 Copy (like above but independent of execbit):
 
   $ hg import -d "1000000 0" -mcopy - <<EOF
   > diff --git a/new b/copy
   > similarity index 100%
   > copy from new
   > copy to copy
   > diff --git a/new b/copyx
   > similarity index 100%
   > copy from new
   > copy to copyx
   > EOF
   applying patch from stdin
 
   $ hg tip -q
   2:0efdaa8e3bf3
   $ test -f copy
 
   $ cat copy
   a
 
   $ hg cat copy
   a
 
 Rename:
 
   $ hg import -d "1000000 0" -mrename - <<EOF
   > diff --git a/copy b/rename
   > similarity index 100%
   > rename from copy
   > rename to rename
   > EOF
   applying patch from stdin
 
   $ hg tip -q
   3:b1f57753fad2
 
   $ hg locate
   copyx
   empty
   new
   rename
 
 Delete:
 
   $ hg import -d "1000000 0" -mdelete - <<EOF
   > diff --git a/copyx b/copyx
   > deleted file mode 100755
   > index 7898192..0000000
   > --- a/copyx
   > +++ /dev/null
   > @@ -1 +0,0 @@
   > -a
   > EOF
   applying patch from stdin
 
   $ hg tip -q
   4:1bd1da94b9b2
 
   $ hg locate
   empty
   new
   rename
 
   $ test -f copyx
   [1]
 
 Regular diff:
 
   $ hg import -d "1000000 0" -mregular - <<EOF
   > diff --git a/rename b/rename
   > index 7898192..72e1fe3 100644
   > --- a/rename
   > +++ b/rename
   > @@ -1 +1,5 @@
   >  a
   > +a
   > +a
   > +a
   > +a
   > EOF
   applying patch from stdin
 
   $ hg tip -q
   5:46fe99cb3035
 
 Copy and modify:
 
   $ hg import -d "1000000 0" -mcopymod - <<EOF
   > diff --git a/rename b/copy2
   > similarity index 80%
   > copy from rename
   > copy to copy2
   > index 72e1fe3..b53c148 100644
   > --- a/rename
   > +++ b/copy2
   > @@ -1,5 +1,5 @@
   >  a
   >  a
   > -a
   > +b
   >  a
   >  a
   > EOF
   applying patch from stdin
 
   $ hg tip -q
   6:ffeb3197c12d
 
   $ hg cat copy2
   a
   a
   b
   a
   a
 
 Rename and modify:
 
   $ hg import -d "1000000 0" -mrenamemod - <<EOF
   > diff --git a/copy2 b/rename2
   > similarity index 80%
   > rename from copy2
   > rename to rename2
   > index b53c148..8f81e29 100644
   > --- a/copy2
   > +++ b/rename2
   > @@ -1,5 +1,5 @@
   >  a
   >  a
   >  b
   > -a
   > +c
   >  a
   > EOF
   applying patch from stdin
 
   $ hg tip -q
   7:401aede9e6bb
 
   $ hg locate copy2
   [1]
   $ hg cat rename2
   a
   a
   b
   c
   a
 
 One file renamed multiple times:
 
   $ hg import -d "1000000 0" -mmultirenames - <<EOF
   > diff --git a/rename2 b/rename3
   > rename from rename2
   > rename to rename3
   > diff --git a/rename2 b/rename3-2
   > rename from rename2
   > rename to rename3-2
   > EOF
   applying patch from stdin
 
   $ hg tip -q
   8:2ef727e684e8
 
   $ hg log -vr. --template '{rev} {files} / {file_copies}\n'
   8 rename2 rename3 rename3-2 / rename3 (rename2)rename3-2 (rename2)
 
   $ hg locate rename2 rename3 rename3-2
   rename3
   rename3-2
 
   $ hg cat rename3
   a
   a
   b
   c
   a
 
   $ hg cat rename3-2
   a
   a
   b
   c
   a
 
   $ echo foo > foo
   $ hg add foo
   $ hg ci -m 'add foo'
 
 Binary files and regular patch hunks:
 
   $ hg import -d "1000000 0" -m binaryregular - <<EOF
   > diff --git a/binary b/binary
   > new file mode 100644
   > index 0000000000000000000000000000000000000000..593f4708db84ac8fd0f5cc47c634f38c013fe9e4
   > GIT binary patch
   > literal 4
   > Lc\${NkU|;|M00aO5
   > 
   > diff --git a/foo b/foo2
   > rename from foo
   > rename to foo2
   > EOF
   applying patch from stdin
 
   $ hg tip -q
   10:27377172366e
 
   $ cat foo2
   foo
 
   $ hg manifest --debug | grep binary
   045c85ba38952325e126c70962cc0f9d9077bc67 644   binary
 
 Multiple binary files:
 
   $ hg import -d "1000000 0" -m multibinary - <<EOF
   > diff --git a/mbinary1 b/mbinary1
   > new file mode 100644
   > index 0000000000000000000000000000000000000000..593f4708db84ac8fd0f5cc47c634f38c013fe9e4
   > GIT binary patch
   > literal 4
   > Lc\${NkU|;|M00aO5
   > 
   > diff --git a/mbinary2 b/mbinary2
   > new file mode 100644
   > index 0000000000000000000000000000000000000000..112363ac1917b417ffbd7f376ca786a1e5fa7490
   > GIT binary patch
   > literal 5
   > Mc\${NkU|\`?^000jF3jhEB
   > 
   > EOF
   applying patch from stdin
 
   $ hg tip -q
   11:18b73a84b4ab
 
   $ hg manifest --debug | grep mbinary
   045c85ba38952325e126c70962cc0f9d9077bc67 644   mbinary1
   a874b471193996e7cb034bb301cac7bdaf3e3f46 644   mbinary2
 
 Filenames with spaces:
 
-  $ hg import -d "1000000 0" -m spaces - <<EOF
+  $ sed 's,EOL$,,g' <<EOF | hg import -d "1000000 0" -m spaces -
   > diff --git a/foo bar b/foo bar
   > new file mode 100644
   > index 0000000..257cc56
   > --- /dev/null
-  > +++ b/foo bar	
+  > +++ b/foo bar	EOL
   > @@ -0,0 +1 @@
   > +foo
   > EOF
   applying patch from stdin
 
   $ hg tip -q
   12:47500ce1614e
 
   $ cat "foo bar"
   foo
 
 Copy then modify the original file:
 
   $ hg import -d "1000000 0" -m copy-mod-orig - <<EOF
   > diff --git a/foo2 b/foo2
   > index 257cc56..fe08ec6 100644
   > --- a/foo2
   > +++ b/foo2
   > @@ -1 +1,2 @@
   >  foo
   > +new line
   > diff --git a/foo2 b/foo3
   > similarity index 100%
   > copy from foo2
   > copy to foo3
   > EOF
   applying patch from stdin
 
   $ hg tip -q
   13:6757efb07ea9
 
   $ cat foo3
   foo
 
 Move text file and patch as binary
 
   $ echo a > text2
   $ hg ci -Am0
   adding text2
   $ hg import -d "1000000 0" -m rename-as-binary - <<"EOF"
   > diff --git a/text2 b/binary2
   > rename from text2
   > rename to binary2
   > index 78981922613b2afb6025042ff6bd878ac1994e85..10efcb362e9f3b3420fcfbfc0e37f3dc16e29757
   > GIT binary patch
   > literal 5
   > Mc$`b*O5$Pw00T?_*Z=?k
   > 
   > EOF
   applying patch from stdin
 
   $ cat binary2
   a
   b
   \x00 (no-eol) (esc)
 
   $ hg st --copies --change .
   A binary2
     text2
   R text2
 
 Invalid base85 content
 
   $ hg rollback
   repository tip rolled back to revision 14 (undo import)
   working directory now based on revision 14
   $ hg revert -aq
   $ hg import -d "1000000 0" -m invalid-binary - <<"EOF"
   > diff --git a/text2 b/binary2
   > rename from text2
   > rename to binary2
   > index 78981922613b2afb6025042ff6bd878ac1994e85..10efcb362e9f3b3420fcfbfc0e37f3dc16e29757
   > GIT binary patch
   > literal 5
   > Mc$`b*O.$Pw00T?_*Z=?k
   > 
   > EOF
   applying patch from stdin
   abort: could not decode "binary2" binary patch: bad base85 character at position 6
   [255]
 
   $ hg revert -aq
   $ hg import -d "1000000 0" -m rename-as-binary - <<"EOF"
   > diff --git a/text2 b/binary2
   > rename from text2
   > rename to binary2
   > index 78981922613b2afb6025042ff6bd878ac1994e85..10efcb362e9f3b3420fcfbfc0e37f3dc16e29757
   > GIT binary patch
   > literal 6
   > Mc$`b*O5$Pw00T?_*Z=?k
   > 
   > EOF
   applying patch from stdin
   abort: "binary2" length is 5 bytes, should be 6
   [255]
 
   $ hg revert -aq
   $ hg import -d "1000000 0" -m rename-as-binary - <<"EOF"
   > diff --git a/text2 b/binary2
   > rename from text2
   > rename to binary2
   > index 78981922613b2afb6025042ff6bd878ac1994e85..10efcb362e9f3b3420fcfbfc0e37f3dc16e29757
   > GIT binary patch
   > Mc$`b*O5$Pw00T?_*Z=?k
   > 
   > EOF
   applying patch from stdin
   abort: could not extract "binary2" binary data
   [255]
 
 Simulate a copy/paste turning LF into CRLF (issue2870)
 
   $ hg revert -aq
   $ cat > binary.diff <<"EOF"
   > diff --git a/text2 b/binary2
   > rename from text2
   > rename to binary2
   > index 78981922613b2afb6025042ff6bd878ac1994e85..10efcb362e9f3b3420fcfbfc0e37f3dc16e29757
   > GIT binary patch
   > literal 5
   > Mc$`b*O5$Pw00T?_*Z=?k
   > 
   > EOF
   >>> fp = file('binary.diff', 'rb')
   >>> data = fp.read()
   >>> fp.close()
   >>> file('binary.diff', 'wb').write(data.replace('\n', '\r\n'))
   $ rm binary2
   $ hg import --no-commit binary.diff
   applying binary.diff
 
   $ cd ..
 
 Consecutive import with renames (issue2459)
 
   $ hg init issue2459
   $ cd issue2459
   $ hg import --no-commit --force - <<EOF
   > diff --git a/a b/a
   > new file mode 100644
   > EOF
   applying patch from stdin
   $ hg import --no-commit --force - <<EOF
   > diff --git a/a b/b
   > rename from a
   > rename to b
   > EOF
   applying patch from stdin
   a has not been committed yet, so no copy data will be stored for b.
   $ hg debugstate
   a   0         -1 unset               b
   $ hg ci -m done
   $ cd ..
 
 Renames and strip
 
   $ hg init renameandstrip
   $ cd renameandstrip
   $ echo a > a
   $ hg ci -Am adda
   adding a
   $ hg import --no-commit -p2 - <<EOF
   > diff --git a/foo/a b/foo/b
   > rename from foo/a
   > rename to foo/b
   > EOF
   applying patch from stdin
   $ hg st --copies
   A b
     a
   R a
 
 Renames, similarity and git diff
 
   $ hg revert -aC
   undeleting a
   forgetting b
   $ rm b
   $ hg import --similarity 90 --no-commit - <<EOF
   > diff --git a/a b/b
   > rename from a
   > rename to b
   > EOF
   applying patch from stdin
   $ hg st --copies
   A b
     a
   R a
   $ cd ..
 
 Pure copy with existing destination
 
   $ hg init copytoexisting
   $ cd copytoexisting
   $ echo a > a
   $ echo b > b
   $ hg ci -Am add
   adding a
   adding b
   $ hg import --no-commit - <<EOF
   > diff --git a/a b/b
   > copy from a
   > copy to b
   > EOF
   applying patch from stdin
   abort: cannot create b: destination already exists
   [255]
   $ cat b
   b
 
 Copy and changes with existing destination
 
   $ hg import --no-commit - <<EOF
   > diff --git a/a b/b
   > copy from a
   > copy to b
   > --- a/a
   > +++ b/b
   > @@ -1,1 +1,2 @@
   > a
   > +b
   > EOF
   applying patch from stdin
   cannot create b: destination already exists
   1 out of 1 hunks FAILED -- saving rejects to file b.rej
   abort: patch failed to apply
   [255]
   $ cat b
   b
 
 #if symlink
 
   $ ln -s b linkb
   $ hg add linkb
   $ hg ci -m addlinkb
   $ hg import --no-commit - <<EOF
   > diff --git a/linkb b/linkb
   > deleted file mode 120000
   > --- a/linkb
   > +++ /dev/null
   > @@ -1,1 +0,0 @@
   > -badhunk
   > \ No newline at end of file
   > EOF
   applying patch from stdin
   patching file linkb
   Hunk #1 FAILED at 0
   1 out of 1 hunks FAILED -- saving rejects to file linkb.rej
   abort: patch failed to apply
   [255]
   $ hg st
   ? b.rej
   ? linkb.rej
 
 #endif
 
 Test corner case involving copies and multiple hunks (issue3384)
 
   $ hg revert -qa
   $ hg import --no-commit - <<EOF
   > diff --git a/a b/c
   > copy from a
   > copy to c
   > --- a/a
   > +++ b/c
   > @@ -1,1 +1,2 @@
   >  a
   > +a
   > @@ -2,1 +2,2 @@
   >  a
   > +a
   > diff --git a/a b/a
   > --- a/a
   > +++ b/a
   > @@ -1,1 +1,2 @@
   >  a
   > +b
   > EOF
   applying patch from stdin
 
   $ cd ..