churn: do not crash on malformed lines in alias file

hgext/churn.py

@@ -129,10 +129,14 b' def churn(ui, repo, *pats, **opts):'
         aliases = repo.wjoin('.hgchurn')
     if aliases:
         for l in open(aliases, "r"):
-            if not l.strip():
-                continue
+            try:
             alias, actual = l.split('=' in l and '=' or None, 1)
             amap[alias.strip()] = actual.strip()
+            except ValueError:
+                l = l.strip()
+                if l:
+                    ui.warn(_("skipping malformed alias: %s\n" % l))
+                continue
 
     rate = countrate(ui, repo, amap, *pats, **opts).items()
     if not rate:

tests/test-churn

@@ -40,6 +40,7 b' cat > ../aliases <<EOF'
 user1 alias1
 
 user3 alias3
+not-an-alias
 EOF
 hg churn --aliases ../aliases
 echo % churn with .hgchurn

tests/test-churn.out

@@ -16,10 +16,12 b' user1 2 ***************************'
 user2      2 ***************************************************************
 user1      1 ********************************
 % churn with aliases
+skipping malformed alias: not-an-alias
 alias3      3 **************************************************************
 alias1      3 **************************************************************
 user2       2 *****************************************
 % churn with .hgchurn
+skipping malformed alias: not-an-alias
 alias3      3 **************************************************************
 alias1      3 **************************************************************
 user2       2 *****************************************