revlog: make sure the files are closed after an exception happens

This prevents a corruption when the writes happen after the truncate
initiated by the transaction rollback.

mercurial/revlog.py

@@ -977,6 +977,7 b' class revlog(object):'
 
         tr.add(self.datafile, dataoff)
         df = self.opener(self.datafile, 'w')
+        try:
         calc = self._io.size
         for r in xrange(self.count()):
             start = self.start(r) + (r + 1) * calc
@@ -984,8 +985,10 b' class revlog(object):'
             fp.seek(start)
             d = fp.read(length)
             df.write(d)
+        finally:
+            df.close()
+
         fp.close()
-        df.close()
         fp = self.opener(self.indexfile, 'w', atomictemp=True)
         self.version &= ~(REVLOGNGINLINEDATA)
         self._inline = False
@@ -993,6 +996,7 b' class revlog(object):'
             e = self._io.packentry(self.index[i], self.node, self.version, i)
             fp.write(e)
 
+        fp.close()
         # if we don't call rename, the temp file will never replace the
         # real index
         fp.rename()
@@ -1013,7 +1017,12 b' class revlog(object):'
         if not self._inline:
             dfh = self.opener(self.datafile, "a")
         ifh = self.opener(self.indexfile, "a+")
+        try:
         return self._addrevision(text, transaction, link, p1, p2, d, ifh, dfh)
+        finally:
+            if dfh:
+                dfh.close()
+            ifh.close()
 
     def _addrevision(self, text, transaction, link, p1, p2, d, ifh, dfh):
         node = hash(text, p1, p2)
@@ -1154,6 +1163,7 b' class revlog(object):'
             transaction.add(self.datafile, end)
             dfh = self.opener(self.datafile, "a")
 
+        try:
         # loop through our set of deltas
         chain = None
         for chunk in revs:
@@ -1234,6 +1244,10 b' class revlog(object):'
             base = self.base(t)
             start = self.start(base)
             end = self.end(t)
+        finally:
+            if dfh:
+                dfh.close()
+            ifh.close()
 
         return node