upstream/mercurial-mirror Commit - r41992:867883d4

1

#!/usr/bin/env python

1

#!/usr/bin/env python

2

#

2

#

3

# check-code - a style and portability checker for Mercurial

3

# check-code - a style and portability checker for Mercurial

4

#

4

#

5

6

#

6

#

7

# This software may be used and distributed according to the terms of the

7

# This software may be used and distributed according to the terms of the

8

# GNU General Public License version 2 or any later version.

8

# GNU General Public License version 2 or any later version.

9

10

"""style and portability checker for Mercurial

10

"""style and portability checker for Mercurial

11

12

when a rule triggers wrong, do one of the following (prefer one from top):

12

when a rule triggers wrong, do one of the following (prefer one from top):

13

* do the work-around the rule suggests

13

* do the work-around the rule suggests

14

* doublecheck that it is a false match

14

* doublecheck that it is a false match

15

* improve the rule pattern

15

* improve the rule pattern

16

* add an ignore pattern to the rule (3rd arg) which matches your good line

16

* add an ignore pattern to the rule (3rd arg) which matches your good line

17

(you can append a short comment and match this, like: #re-raises)

17

(you can append a short comment and match this, like: #re-raises)

18

* change the pattern to a warning and list the exception in test-check-code-hg

18

* change the pattern to a warning and list the exception in test-check-code-hg

19

* ONLY use no--check-code for skipping entire files from external sources

19

* ONLY use no--check-code for skipping entire files from external sources

20

"""

20

"""

21

22

from __future__ import absolute_import, print_function

22

from __future__ import absolute_import, print_function

23

import glob

23

import glob

24

import keyword

24

import keyword

25

import optparse

25

import optparse

26

import os

26

import os

27

import re

27

import re

28

import sys

28

import sys

29

if sys.version_info[0] < 3:

29

if sys.version_info[0] < 3:

30

opentext = open

30

opentext = open

31

else:

31

else:

32

def opentext(f):

32

def opentext(f):

33

return open(f, encoding='latin1')

33

return open(f, encoding='latin1')

34

try:

34

try:

35

xrange

35

xrange

36

except NameError:

36

except NameError:

37

xrange = range

37

xrange = range

38

try:

38

try:

39

import re2

39

import re2

40

except ImportError:

40

except ImportError:

41

re2 = None

41

re2 = None

42

43

import testparseutil

44

43

def compilere(pat, multiline=False):

45

def compilere(pat, multiline=False):

44

if multiline:

46

if multiline:

45

pat = '(?m)' + pat

47

pat = '(?m)' + pat

46

if re2:

48

if re2:

47

try:

49

try:

48

return re2.compile(pat)

50

return re2.compile(pat)

49

except re2.error:

51

except re2.error:

50

pass

52

pass

51

return re.compile(pat)

53

return re.compile(pat)

52

54

53

# check "rules depending on implementation of repquote()" in each

55

# check "rules depending on implementation of repquote()" in each

54

# patterns (especially pypats), before changing around repquote()

56

# patterns (especially pypats), before changing around repquote()

55

_repquotefixedmap = {' ': ' ', '\n': '\n', '.': 'p', ':': 'q',

57

_repquotefixedmap = {' ': ' ', '\n': '\n', '.': 'p', ':': 'q',

56

'%': '%', '\\': 'b', '*': 'A', '+': 'P', '-': 'M'}

58

'%': '%', '\\': 'b', '*': 'A', '+': 'P', '-': 'M'}

57

def _repquoteencodechr(i):

59

def _repquoteencodechr(i):

58

if i > 255:

60

if i > 255:

59

return 'u'

61

return 'u'

60

c = chr(i)

62

c = chr(i)

61

if c in _repquotefixedmap:

63

if c in _repquotefixedmap:

62

return _repquotefixedmap[c]

64

return _repquotefixedmap[c]

63

if c.isalpha():

65

if c.isalpha():

64

return 'x'

66

return 'x'

65

if c.isdigit():

67

if c.isdigit():

66

return 'n'

68

return 'n'

67

return 'o'

69

return 'o'

68

_repquotett = ''.join(_repquoteencodechr(i) for i in xrange(256))

70

_repquotett = ''.join(_repquoteencodechr(i) for i in xrange(256))

69

71

70

def repquote(m):

72

def repquote(m):

71

t = m.group('text')

73

t = m.group('text')

72

t = t.translate(_repquotett)

74

t = t.translate(_repquotett)

73

return m.group('quote') + t + m.group('quote')

75

return m.group('quote') + t + m.group('quote')

74

76

75

def reppython(m):

77

def reppython(m):

76

comment = m.group('comment')

78

comment = m.group('comment')

77

if comment:

79

if comment:

78

l = len(comment.rstrip())

80

l = len(comment.rstrip())

79

return "#" * l + comment[l:]

81

return "#" * l + comment[l:]

80

return repquote(m)

82

return repquote(m)

81

83

82

def repcomment(m):

84

def repcomment(m):

83

return m.group(1) + "#" * len(m.group(2))

85

return m.group(1) + "#" * len(m.group(2))

84

86

85

def repccomment(m):

87

def repccomment(m):

86

t = re.sub(r"((?<=\n) )|\S", "x", m.group(2))

88

t = re.sub(r"((?<=\n) )|\S", "x", m.group(2))

87

return m.group(1) + t + "*/"

89

return m.group(1) + t + "*/"

88

90

89

def repcallspaces(m):

91

def repcallspaces(m):

90

t = re.sub(r"\n\s+", "\n", m.group(2))

92

t = re.sub(r"\n\s+", "\n", m.group(2))

91

return m.group(1) + t

93

return m.group(1) + t

92

94

93

def repinclude(m):

95

def repinclude(m):

94

return m.group(1) + "<foo>"

96

return m.group(1) + "<foo>"

95

97

96

def rephere(m):

98

def rephere(m):

97

t = re.sub(r"\S", "x", m.group(2))

99

t = re.sub(r"\S", "x", m.group(2))

98

return m.group(1) + t

100

return m.group(1) + t

99

101

100

102

101

testpats = [

103

testpats = [

102

[

104

[

103

(r'\b(push|pop)d\b', "don't use 'pushd' or 'popd', use 'cd'"),

105

(r'\b(push|pop)d\b', "don't use 'pushd' or 'popd', use 'cd'"),

104

(r'\W\$?$\([^$\n]*\)\)', "don't use (()) or $(()), use 'expr'"),

106

(r'\W\$?$\([^$\n]*\)\)', "don't use (()) or $(()), use 'expr'"),

105

(r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"),

107

(r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"),

106

(r'(?<!hg )grep.* -a', "don't use 'grep -a', use in-line python"),

108

(r'(?<!hg )grep.* -a', "don't use 'grep -a', use in-line python"),

107

(r'sed.*-i', "don't use 'sed -i', use a temporary file"),

109

(r'sed.*-i', "don't use 'sed -i', use a temporary file"),

108

(r'\becho\b.*\\n', "don't use 'echo \\n', use printf"),

110

(r'\becho\b.*\\n', "don't use 'echo \\n', use printf"),

109

(r'echo -n', "don't use 'echo -n', use printf"),

111

(r'echo -n', "don't use 'echo -n', use printf"),

110

(r'(^|\|\s*)\bwc\b[^|]*$\n(?!.*$re$)', "filter wc output"),

112

(r'(^|\|\s*)\bwc\b[^|]*$\n(?!.*$re$)', "filter wc output"),

111

(r'head -c', "don't use 'head -c', use 'dd'"),

113

(r'head -c', "don't use 'head -c', use 'dd'"),

112

(r'tail -n', "don't use the '-n' option to tail, just use '-<num>'"),

114

(r'tail -n', "don't use the '-n' option to tail, just use '-<num>'"),

113

(r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"),

115

(r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"),

114

(r'\bls\b.*-\w*R', "don't use 'ls -R', use 'find'"),

116

(r'\bls\b.*-\w*R', "don't use 'ls -R', use 'find'"),

115

(r'printf.*[^\\]\\([1-9]|0\d)', r"don't use 'printf \NNN', use Python"),

117

(r'printf.*[^\\]\\([1-9]|0\d)', r"don't use 'printf \NNN', use Python"),

116

(r'printf.*[^\\]\\x', "don't use printf \\x, use Python"),

118

(r'printf.*[^\\]\\x', "don't use printf \\x, use Python"),

117

(r'\$$.*$', "don't use $(expr), use `expr`"),

119

(r'\$$.*$', "don't use $(expr), use `expr`"),

118

(r'rm -rf \*', "don't use naked rm -rf, target a directory"),

120

(r'rm -rf \*', "don't use naked rm -rf, target a directory"),

119

(r'\[[^\]]+==', '[ foo == bar ] is a bashism, use [ foo = bar ] instead'),

121

(r'\[[^\]]+==', '[ foo == bar ] is a bashism, use [ foo = bar ] instead'),

120

(r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w',

122

(r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w',

121

"use egrep for extended grep syntax"),

123

"use egrep for extended grep syntax"),

122

(r'(^|\|\s*)e?grep .*\\S', "don't use \\S in regular expression"),

124

(r'(^|\|\s*)e?grep .*\\S', "don't use \\S in regular expression"),

123

(r'(?<!!)/bin/', "don't use explicit paths for tools"),

125

(r'(?<!!)/bin/', "don't use explicit paths for tools"),

124

(r'#!.*/bash', "don't use bash in shebang, use sh"),

126

(r'#!.*/bash', "don't use bash in shebang, use sh"),

125

(r'[^\n]\Z', "no trailing newline"),

127

(r'[^\n]\Z', "no trailing newline"),

126

(r'export .*=', "don't export and assign at once"),

128

(r'export .*=', "don't export and assign at once"),

127

(r'^source\b', "don't use 'source', use '.'"),

129

(r'^source\b', "don't use 'source', use '.'"),

128

(r'touch -d', "don't use 'touch -d', use 'touch -t' instead"),

130

(r'touch -d', "don't use 'touch -d', use 'touch -t' instead"),

129

(r'\bls +[^|\n-]+ +-', "options to 'ls' must come before filenames"),

131

(r'\bls +[^|\n-]+ +-', "options to 'ls' must come before filenames"),

130

(r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),

132

(r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),

131

(r'^stop', "don't use 'stop' as a shell function name"),

133

(r'^stop', "don't use 'stop' as a shell function name"),

132

(r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),

134

(r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),

133

(r'\[\[\s+[^\]]*\]\]', "don't use '[[ ]]', use '[ ]'"),

135

(r'\[\[\s+[^\]]*\]\]', "don't use '[[ ]]', use '[ ]'"),

134

(r'^alias\b.*=', "don't use alias, use a function"),

136

(r'^alias\b.*=', "don't use alias, use a function"),

135

(r'if\s*!', "don't use '!' to negate exit status"),

137

(r'if\s*!', "don't use '!' to negate exit status"),

136

(r'/dev/u?random', "don't use entropy, use /dev/zero"),

138

(r'/dev/u?random', "don't use entropy, use /dev/zero"),

137

(r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"),

139

(r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"),

138

(r'sed (-e )?\'(\d+|/[^/]*/)i(?!\\\n)',

140

(r'sed (-e )?\'(\d+|/[^/]*/)i(?!\\\n)',

139

"put a backslash-escaped newline after sed 'i' command"),

141

"put a backslash-escaped newline after sed 'i' command"),

140

(r'^diff *-\w*[uU].*$\n(^ \$ |^$)', "prefix diff -u/-U with cmp"),

142

(r'^diff *-\w*[uU].*$\n(^ \$ |^$)', "prefix diff -u/-U with cmp"),

141

(r'^\s+(if)? diff *-\w*[uU]', "prefix diff -u/-U with cmp"),

143

(r'^\s+(if)? diff *-\w*[uU]', "prefix diff -u/-U with cmp"),

142

(r'[\s="`\']python\s(?!bindings)', "don't use 'python', use '$PYTHON'"),

144

(r'[\s="`\']python\s(?!bindings)', "don't use 'python', use '$PYTHON'"),

143

(r'seq ', "don't use 'seq', use $TESTDIR/seq.py"),

145

(r'seq ', "don't use 'seq', use $TESTDIR/seq.py"),

144

(r'\butil\.Abort\b', "directly use error.Abort"),

146

(r'\butil\.Abort\b', "directly use error.Abort"),

145

(r'\|&', "don't use |&, use 2>&1"),

147

(r'\|&', "don't use |&, use 2>&1"),

146

(r'\w = +\w', "only one space after = allowed"),

148

(r'\w = +\w', "only one space after = allowed"),

147

(r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"),

149

(r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"),

148

(r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),

150

(r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),

149

(r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),

151

(r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),

150

(r'grep.* -[ABC]', "don't use grep's context flags"),

152

(r'grep.* -[ABC]', "don't use grep's context flags"),

151

(r'find.*-printf',

153

(r'find.*-printf',

152

"don't use 'find -printf', it doesn't exist on BSD find(1)"),

154

"don't use 'find -printf', it doesn't exist on BSD find(1)"),

153

(r'\$RANDOM ', "don't use bash-only $RANDOM to generate random values"),

155

(r'\$RANDOM ', "don't use bash-only $RANDOM to generate random values"),

154

],

156

],

155

# warnings

157

# warnings

156

[

158

[

157

(r'^function', "don't use 'function', use old style"),

159

(r'^function', "don't use 'function', use old style"),

158

(r'^diff.*-\w*N', "don't use 'diff -N'"),

160

(r'^diff.*-\w*N', "don't use 'diff -N'"),

159

(r'\$PWD|\${PWD}', "don't use $PWD, use `pwd`"),

161

(r'\$PWD|\${PWD}', "don't use $PWD, use `pwd`"),

160

(r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"),

162

(r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"),

161

(r'kill (`|\$\()', "don't use kill, use killdaemons.py")

163

(r'kill (`|\$\()', "don't use kill, use killdaemons.py")

162

]

164

]

163

]

165

]

164

166

165

testfilters = [

167

testfilters = [

166

(r"( *)(#([^!][^\n]*\S)?)", repcomment),

168

(r"( *)(#([^!][^\n]*\S)?)", repcomment),

167

(r"<<(\S+)((.|\n)*?\n\1)", rephere),

169

(r"<<(\S+)((.|\n)*?\n\1)", rephere),

168

]

170

]

169

171

170

uprefix = r"^ \$ "

172

uprefix = r"^ \$ "

171

utestpats = [

173

utestpats = [

172

[

174

[

173

(r'^(\S.*|| [$>] \S.*)[ \t]\n', "trailing whitespace on non-output"),

175

(r'^(\S.*|| [$>] \S.*)[ \t]\n', "trailing whitespace on non-output"),

174

(uprefix + r'.*\|\s*sed[^|>\n]*\n',

176

(uprefix + r'.*\|\s*sed[^|>\n]*\n',

175

"use regex test output patterns instead of sed"),

177

"use regex test output patterns instead of sed"),

176

(uprefix + r'(true|exit 0)', "explicit zero exit unnecessary"),

178

(uprefix + r'(true|exit 0)', "explicit zero exit unnecessary"),

177

(uprefix + r'.*(?<!\[)\$\?', "explicit exit code checks unnecessary"),

179

(uprefix + r'.*(?<!\[)\$\?', "explicit exit code checks unnecessary"),

178

(uprefix + r'.*\|\| echo.*(fail|error)',

180

(uprefix + r'.*\|\| echo.*(fail|error)',

179

"explicit exit code checks unnecessary"),

181

"explicit exit code checks unnecessary"),

180

(uprefix + r'set -e', "don't use set -e"),

182

(uprefix + r'set -e', "don't use set -e"),

181

(uprefix + r'(\s|fi\b|done\b)', "use > for continued lines"),

183

(uprefix + r'(\s|fi\b|done\b)', "use > for continued lines"),

182

(uprefix + r'.*:\.\S*/', "x:.y in a path does not work on msys, rewrite "

184

(uprefix + r'.*:\.\S*/', "x:.y in a path does not work on msys, rewrite "

183

"as x://.y, or see `hg log -k msys` for alternatives", r'-\S+:\.|' #-Rxxx

185

"as x://.y, or see `hg log -k msys` for alternatives", r'-\S+:\.|' #-Rxxx

184

'# no-msys'), # in test-pull.t which is skipped on windows

186

'# no-msys'), # in test-pull.t which is skipped on windows

185

(r'^ [^$>].*27\.0\.0\.1',

187

(r'^ [^$>].*27\.0\.0\.1',

186

'use $LOCALIP not an explicit loopback address'),

188

'use $LOCALIP not an explicit loopback address'),

187

(r'^ (?![>$] ).*\$LOCALIP.*[^)]$',

189

(r'^ (?![>$] ).*\$LOCALIP.*[^)]$',

188

'mark $LOCALIP output lines with (glob) to help tests in BSD jails'),

190

'mark $LOCALIP output lines with (glob) to help tests in BSD jails'),

189

(r'^ (cat|find): .*: \$ENOENT\$',

191

(r'^ (cat|find): .*: \$ENOENT\$',

190

'use test -f to test for file existence'),

192

'use test -f to test for file existence'),

191

(r'^ diff -[^ -]*p',

193

(r'^ diff -[^ -]*p',

192

"don't use (external) diff with -p for portability"),

194

"don't use (external) diff with -p for portability"),

193

(r' readlink ', 'use readlink.py instead of readlink'),

195

(r' readlink ', 'use readlink.py instead of readlink'),

194

(r'^ [-+][-+][-+] .* [-+]0000 $glob$',

196

(r'^ [-+][-+][-+] .* [-+]0000 $glob$',

195

"glob timezone field in diff output for portability"),

197

"glob timezone field in diff output for portability"),

196

(r'^ @@ -[0-9]+ [+][0-9]+,[0-9]+ @@',

198

(r'^ @@ -[0-9]+ [+][0-9]+,[0-9]+ @@',

197

"use '@@ -N* +N,n @@ (glob)' style chunk header for portability"),

199

"use '@@ -N* +N,n @@ (glob)' style chunk header for portability"),

198

(r'^ @@ -[0-9]+,[0-9]+ [+][0-9]+ @@',

200

(r'^ @@ -[0-9]+,[0-9]+ [+][0-9]+ @@',

199

"use '@@ -N,n +N* @@ (glob)' style chunk header for portability"),

201

"use '@@ -N,n +N* @@ (glob)' style chunk header for portability"),

200

(r'^ @@ -[0-9]+ [+][0-9]+ @@',

202

(r'^ @@ -[0-9]+ [+][0-9]+ @@',

201

"use '@@ -N* +N* @@ (glob)' style chunk header for portability"),

203

"use '@@ -N* +N* @@ (glob)' style chunk header for portability"),

202

(uprefix + r'hg( +-[^ ]+( +[^ ]+)?)* +extdiff'

204

(uprefix + r'hg( +-[^ ]+( +[^ ]+)?)* +extdiff'

203

r'( +(-[^ po-]+|--(?!program|option)[^ ]+|[^-][^ ]*))*$',

205

r'( +(-[^ po-]+|--(?!program|option)[^ ]+|[^-][^ ]*))*$',

204

"use $RUNTESTDIR/pdiff via extdiff (or -o/-p for false-positives)"),

206

"use $RUNTESTDIR/pdiff via extdiff (or -o/-p for false-positives)"),

205

],

207

],

206

# warnings

208

# warnings

207

[

209

[

208

(r'^ (?!.*\$LOCALIP)[^*?/\n]* $glob$$',

210

(r'^ (?!.*\$LOCALIP)[^*?/\n]* $glob$$',

209

"glob match with no glob string (?, *, /, and $LOCALIP)"),

211

"glob match with no glob string (?, *, /, and $LOCALIP)"),

210

]

212

]

211

]

213

]

212

214

213

# transform plain test rules to unified test's

215

# transform plain test rules to unified test's

214

for i in [0, 1]:

216

for i in [0, 1]:

215

for tp in testpats[i]:

217

for tp in testpats[i]:

216

p = tp[0]

218

p = tp[0]

217

m = tp[1]

219

m = tp[1]

218

if p.startswith(r'^'):

220

if p.startswith(r'^'):

219

p = r"^ [$>] (%s)" % p[1:]

221

p = r"^ [$>] (%s)" % p[1:]

220

else:

222

else:

221

p = r"^ [$>] .*(%s)" % p

223

p = r"^ [$>] .*(%s)" % p

222

utestpats[i].append((p, m) + tp[2:])

224

utestpats[i].append((p, m) + tp[2:])

223

225

224

# don't transform the following rules:

226

# don't transform the following rules:

225

# " > \t" and " \t" should be allowed in unified tests

227

# " > \t" and " \t" should be allowed in unified tests

226

testpats[0].append((r'^( *)\t', "don't use tabs to indent"))

228

testpats[0].append((r'^( *)\t', "don't use tabs to indent"))

227

utestpats[0].append((r'^( ?)\t', "don't use tabs to indent"))

229

utestpats[0].append((r'^( ?)\t', "don't use tabs to indent"))

228

230

229

utestfilters = [

231

utestfilters = [

230

(r"<<(\S+)((.|\n)*?\n > \1)", rephere),

232

(r"<<(\S+)((.|\n)*?\n > \1)", rephere),

231

(r"( +)(#([^!][^\n]*\S)?)", repcomment),

233

(r"( +)(#([^!][^\n]*\S)?)", repcomment),

232

]

234

]

233

235

234

# common patterns to check *.py

236

# common patterns to check *.py

235

commonpypats = [

237

commonpypats = [

236

[

238

[

237

(r'\\$', 'Use () to wrap long lines in Python, not \\'),

239

(r'\\$', 'Use () to wrap long lines in Python, not \\'),

238

(r'^\s*def\s*\w+\s*\(.*,\s*\(',

240

(r'^\s*def\s*\w+\s*\(.*,\s*\(',

239

"tuple parameter unpacking not available in Python 3+"),

241

"tuple parameter unpacking not available in Python 3+"),

240

(r'lambda\s*$.*,.*$',

242

(r'lambda\s*$.*,.*$',

241

"tuple parameter unpacking not available in Python 3+"),

243

"tuple parameter unpacking not available in Python 3+"),

242

(r'(?<!def)\s+(cmp)\(', "cmp is not available in Python 3+"),

244

(r'(?<!def)\s+(cmp)\(', "cmp is not available in Python 3+"),

243

(r'(?<!\.)\breduce\s*\(.*', "reduce is not available in Python 3+"),

245

(r'(?<!\.)\breduce\s*\(.*', "reduce is not available in Python 3+"),

244

(r'\bdict\(.*=', 'dict() is different in Py2 and 3 and is slower than {}',

246

(r'\bdict\(.*=', 'dict() is different in Py2 and 3 and is slower than {}',

245

'dict-from-generator'),

247

'dict-from-generator'),

246

(r'\.has_key\b', "dict.has_key is not available in Python 3+"),

248

(r'\.has_key\b', "dict.has_key is not available in Python 3+"),

247

(r'\s<>\s', '<> operator is not available in Python 3+, use !='),

249

(r'\s<>\s', '<> operator is not available in Python 3+, use !='),

248

(r'^\s*\t', "don't use tabs"),

250

(r'^\s*\t', "don't use tabs"),

249

(r'\S;\s*\n', "semicolon"),

251

(r'\S;\s*\n', "semicolon"),

250

(r'[^_]_\([ \t\n]*(?:"[^"]+"[ \t\n+]*)+%', "don't use % inside _()"),

252

(r'[^_]_\([ \t\n]*(?:"[^"]+"[ \t\n+]*)+%', "don't use % inside _()"),

251

(r"[^_]_\([ \t\n]*(?:'[^']+'[ \t\n+]*)+%", "don't use % inside _()"),

253

(r"[^_]_\([ \t\n]*(?:'[^']+'[ \t\n+]*)+%", "don't use % inside _()"),

252

(r'(\w|\)),\w', "missing whitespace after ,"),

254

(r'(\w|\)),\w', "missing whitespace after ,"),

253

(r'(\w|\))[+/*\-<>]\w', "missing whitespace in expression"),

255

(r'(\w|\))[+/*\-<>]\w', "missing whitespace in expression"),

254

(r'^\s+(\w|\.)+=\w[^,()\n]*$', "missing whitespace in assignment"),

256

(r'^\s+(\w|\.)+=\w[^,()\n]*$', "missing whitespace in assignment"),

255

(r'\w\s=\s\s+\w', "gratuitous whitespace after ="),

257

(r'\w\s=\s\s+\w', "gratuitous whitespace after ="),

256

((

258

((

257

# a line ending with a colon, potentially with trailing comments

259

# a line ending with a colon, potentially with trailing comments

258

r':([ \t]*#[^\n]*)?\n'

260

r':([ \t]*#[^\n]*)?\n'

259

# one that is not a pass and not only a comment

261

# one that is not a pass and not only a comment

260

r'(?P<indent>[ \t]+)[^#][^\n]+\n'

262

r'(?P<indent>[ \t]+)[^#][^\n]+\n'

261

# more lines at the same indent level

263

# more lines at the same indent level

262

r'((?P=indent)[^\n]+\n)*'

264

r'((?P=indent)[^\n]+\n)*'

263

# a pass at the same indent level, which is bogus

265

# a pass at the same indent level, which is bogus

264

r'(?P=indent)pass[ \t\n#]'

266

r'(?P=indent)pass[ \t\n#]'

265

), 'omit superfluous pass'),

267

), 'omit superfluous pass'),

266

(r'[^\n]\Z', "no trailing newline"),

268

(r'[^\n]\Z', "no trailing newline"),

267

(r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),

269

(r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),

268

# (r'^\s+[^_ \n][^_. \n]+_[^_\n]+\s*=',

270

# (r'^\s+[^_ \n][^_. \n]+_[^_\n]+\s*=',

269

# "don't use underbars in identifiers"),

271

# "don't use underbars in identifiers"),

270

(r'^\s+(self\.)?[A-Za-z][a-z0-9]+[A-Z]\w* = ',

272

(r'^\s+(self\.)?[A-Za-z][a-z0-9]+[A-Z]\w* = ',

271

"don't use camelcase in identifiers", r'#.*camelcase-required'),

273

"don't use camelcase in identifiers", r'#.*camelcase-required'),

272

274

273

"linebreak after :"),

275

"linebreak after :"),

274

(r'class\s[^( \n]+:', "old-style class, use class foo(object)",

276

(r'class\s[^( \n]+:', "old-style class, use class foo(object)",

275

r'#.*old-style'),

277

r'#.*old-style'),

276

(r'class\s[^( \n]+:',

278

(r'class\s[^( \n]+:',

277

"class foo() creates old style object, use class foo(object)",

279

"class foo() creates old style object, use class foo(object)",

278

r'#.*old-style'),

280

r'#.*old-style'),

279

(r'\b(%s)\(' % '|'.join(k for k in keyword.kwlist

281

(r'\b(%s)\(' % '|'.join(k for k in keyword.kwlist

280

if k not in ('print', 'exec')),

282

if k not in ('print', 'exec')),

281

"Python keyword is not a function"),

283

"Python keyword is not a function"),

282

(r',]', "unneeded trailing ',' in list"),

284

(r',]', "unneeded trailing ',' in list"),

283

# (r'class\s[A-Z][^\(]*\((?!Exception)',

285

# (r'class\s[A-Z][^\(]*\((?!Exception)',

284

# "don't capitalize non-exception classes"),

286

# "don't capitalize non-exception classes"),

285

# (r'in range\(', "use xrange"),

287

# (r'in range\(', "use xrange"),

286

# (r'^\s*print\s+', "avoid using print in core and extensions"),

288

# (r'^\s*print\s+', "avoid using print in core and extensions"),

287

(r'[\x80-\xff]', "non-ASCII character literal"),

289

(r'[\x80-\xff]', "non-ASCII character literal"),

288

(r'("\')\.format\(', "str.format() has no bytes counterpart, use %"),

290

(r'("\')\.format\(', "str.format() has no bytes counterpart, use %"),

289

(r'^\s*(%s)\s\s' % '|'.join(keyword.kwlist),

291

(r'^\s*(%s)\s\s' % '|'.join(keyword.kwlist),

290

"gratuitous whitespace after Python keyword"),

292

"gratuitous whitespace after Python keyword"),

291

(r'([$\[][ \t]\S)|(\S[ \t][$\]])', "gratuitous whitespace in () or []"),

293

(r'([$\[][ \t]\S)|(\S[ \t][$\]])', "gratuitous whitespace in () or []"),

292

# (r'\s\s=', "gratuitous whitespace before ="),

294

# (r'\s\s=', "gratuitous whitespace before ="),

293

(r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S',

295

(r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S',

294

"missing whitespace around operator"),

296

"missing whitespace around operator"),

295

(r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\s',

297

(r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\s',

296

"missing whitespace around operator"),

298

"missing whitespace around operator"),

297

(r'\s(\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S',

299

(r'\s(\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S',

298

"missing whitespace around operator"),

300

"missing whitespace around operator"),

299

(r'[^^+=*/!<>&| %-](\s=|=\s)[^= ]',

301

(r'[^^+=*/!<>&| %-](\s=|=\s)[^= ]',

300

"wrong whitespace around ="),

302

"wrong whitespace around ="),

301

(r'\([^()]*( =[^=]|[^<>!=]= )',

303

(r'\([^()]*( =[^=]|[^<>!=]= )',

302

"no whitespace around = for named parameters"),

304

"no whitespace around = for named parameters"),

303

(r'raise [^,(]+, ($[^$]+\)|[^,]+)$',

305

(r'raise [^,(]+, ($[^$]+\)|[^,]+)$',

304

"don't use old-style two-argument raise, use Exception(message)"),

306

"don't use old-style two-argument raise, use Exception(message)"),

305

(r' is\s+(not\s+)?["\'0-9-]', "object comparison with literal"),

307

(r' is\s+(not\s+)?["\'0-9-]', "object comparison with literal"),

306

(r' [=!]=\s+(True|False|None)',

308

(r' [=!]=\s+(True|False|None)',

307

"comparison with singleton, use 'is' or 'is not' instead"),

309

"comparison with singleton, use 'is' or 'is not' instead"),

308

(r'^\s*(while|if) [01]:',

310

(r'^\s*(while|if) [01]:',

309

"use True/False for constant Boolean expression"),

311

"use True/False for constant Boolean expression"),

310

(r'^\s*if False(:| +and)', 'Remove code instead of using `if False`'),

312

(r'^\s*if False(:| +and)', 'Remove code instead of using `if False`'),

311

(r'(?:(?<!def)\s+|\()hasattr\(',

313

(r'(?:(?<!def)\s+|\()hasattr\(',

312

'hasattr(foo, bar) is broken on py2, use util.safehasattr(foo, bar) '

314

'hasattr(foo, bar) is broken on py2, use util.safehasattr(foo, bar) '

313

'instead', r'#.*hasattr-py3-only'),

315

'instead', r'#.*hasattr-py3-only'),

314

(r'opener$[^)]*$.read\(',

316

(r'opener$[^)]*$.read\(',

315

"use opener.read() instead"),

317

"use opener.read() instead"),

316

(r'opener$[^)]*$.write\(',

318

(r'opener$[^)]*$.write\(',

317

"use opener.write() instead"),

319

"use opener.write() instead"),

318

(r'(?i)descend[e]nt', "the proper spelling is descendAnt"),

320

(r'(?i)descend[e]nt', "the proper spelling is descendAnt"),

319

(r'\.debug\(\_', "don't mark debug messages for translation"),

321

(r'\.debug\(\_', "don't mark debug messages for translation"),

320

(r'\.strip\.split', "no need to strip before splitting"),

322

(r'\.strip\.split', "no need to strip before splitting"),

321

(r'^\s*except\s*:', "naked except clause", r'#.*re-raises'),

323

(r'^\s*except\s*:', "naked except clause", r'#.*re-raises'),

322

(r'^\s*except\s([^$,]+|\([^$]+\))\s*,',

324

(r'^\s*except\s([^$,]+|\([^$]+\))\s*,',

323

'legacy exception syntax; use "as" instead of ","'),

325

'legacy exception syntax; use "as" instead of ","'),

324

(r'release$.*wlock, .*lock$', "wrong lock release order"),

326

(r'release$.*wlock, .*lock$', "wrong lock release order"),

325

(r'\bdef\s+__bool__\b', "__bool__ should be __nonzero__ in Python 2"),

327

(r'\bdef\s+__bool__\b', "__bool__ should be __nonzero__ in Python 2"),

326

(r'os\.path\.join$.*, *(""|\'\')$',

328

(r'os\.path\.join$.*, *(""|\'\')$',

327

"use pathutil.normasprefix(path) instead of os.path.join(path, '')"),

329

"use pathutil.normasprefix(path) instead of os.path.join(path, '')"),

328

(r'\s0[0-7]+\b', 'legacy octal syntax; use "0o" prefix instead of "0"'),

330

(r'\s0[0-7]+\b', 'legacy octal syntax; use "0o" prefix instead of "0"'),

329

# XXX only catch mutable arguments on the first line of the definition

331

# XXX only catch mutable arguments on the first line of the definition

330

(r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),

332

(r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),

331

(r'\butil\.Abort\b', "directly use error.Abort"),

333

(r'\butil\.Abort\b', "directly use error.Abort"),

332

(r'^@(\w*\.)?cachefunc', "module-level @cachefunc is risky, please avoid"),

334

(r'^@(\w*\.)?cachefunc', "module-level @cachefunc is risky, please avoid"),

333

(r'^import Queue', "don't use Queue, use pycompat.queue.Queue + "

335

(r'^import Queue', "don't use Queue, use pycompat.queue.Queue + "

334

"pycompat.queue.Empty"),

336

"pycompat.queue.Empty"),

335

(r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"),

337

(r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"),

336

(r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"),

338

(r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"),

337

(r'^import SocketServer', "don't use SockerServer, use util.socketserver"),

339

(r'^import SocketServer', "don't use SockerServer, use util.socketserver"),

338

(r'^import urlparse', "don't use urlparse, use util.urlreq"),

340

(r'^import urlparse', "don't use urlparse, use util.urlreq"),

339

(r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"),

341

(r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"),

340

(r'^import cPickle', "don't use cPickle, use util.pickle"),

342

(r'^import cPickle', "don't use cPickle, use util.pickle"),

341

(r'^import pickle', "don't use pickle, use util.pickle"),

343

(r'^import pickle', "don't use pickle, use util.pickle"),

342

(r'^import httplib', "don't use httplib, use util.httplib"),

344

(r'^import httplib', "don't use httplib, use util.httplib"),

343

(r'^import BaseHTTPServer', "use util.httpserver instead"),

345

(r'^import BaseHTTPServer', "use util.httpserver instead"),

344

(r'^(from|import) mercurial\.(cext|pure|cffi)',

346

(r'^(from|import) mercurial\.(cext|pure|cffi)',

345

"use mercurial.policy.importmod instead"),

347

"use mercurial.policy.importmod instead"),

346

(r'\.next', "don't use .next(), use next(...)"),

348

(r'\.next', "don't use .next(), use next(...)"),

347

(r'([a-z]*).revision\(\1\.node\(',

349

(r'([a-z]*).revision\(\1\.node\(',

348

"don't convert rev to node before passing to revision(nodeorrev)"),

350

"don't convert rev to node before passing to revision(nodeorrev)"),

349

(r'platform\.system', "don't use platform.system(), use pycompat"),

351

(r'platform\.system', "don't use platform.system(), use pycompat"),

350

352

351

],

353

],

352

# warnings

354

# warnings

353

[

355

[

354

]

356

]

355

]

357

]

356

358

357

# patterns to check normal *.py files

359

# patterns to check normal *.py files

358

pypats = [

360

pypats = [

359

[

361

[

360

# Ideally, these should be placed in "commonpypats" for

362

# Ideally, these should be placed in "commonpypats" for

361

# consistency of coding rules in Mercurial source tree.

363

# consistency of coding rules in Mercurial source tree.

362

# But on the other hand, these are not so seriously required for

364

# But on the other hand, these are not so seriously required for

363

# python code fragments embedded in test scripts. Fixing test

365

# python code fragments embedded in test scripts. Fixing test

364

# scripts for these patterns requires many changes, and has less

366

# scripts for these patterns requires many changes, and has less

365

# profit than effort.

367

# profit than effort.

366

(r'.{81}', "line too long"),

368

(r'.{81}', "line too long"),

367

(r'raise Exception', "don't raise generic exceptions"),

369

(r'raise Exception', "don't raise generic exceptions"),

368

(r'[\s$](open|file)\([^)]*$\.read\(',

370

(r'[\s$](open|file)\([^)]*$\.read\(',

369

"use util.readfile() instead"),

371

"use util.readfile() instead"),

370

(r'[\s$](open|file)\([^)]*$\.write\(',

372

(r'[\s$](open|file)\([^)]*$\.write\(',

371

"use util.writefile() instead"),

373

"use util.writefile() instead"),

372

(r'^[\s$]*(open(er)?|file)\([^)]*$(?!\.close)',

374

(r'^[\s$]*(open(er)?|file)\([^)]*$(?!\.close)',

373

"always assign an opened file to a variable, and close it afterwards"),

375

"always assign an opened file to a variable, and close it afterwards"),

374

(r'[\s$](open|file)\([^)]*$\.(?!close)',

376

(r'[\s$](open|file)\([^)]*$\.(?!close)',

375

"always assign an opened file to a variable, and close it afterwards"),

377

"always assign an opened file to a variable, and close it afterwards"),

376

(r':\n( )*( ){1,3}[^ ]', "must indent 4 spaces"),

378

(r':\n( )*( ){1,3}[^ ]', "must indent 4 spaces"),

377

(r'^import atexit', "don't use atexit, use ui.atexit"),

379

(r'^import atexit', "don't use atexit, use ui.atexit"),

378

380

379

# rules depending on implementation of repquote()

381

# rules depending on implementation of repquote()

380

(r' x+[xpqo%APM][\'"]\n\s+[\'"]x',

382

(r' x+[xpqo%APM][\'"]\n\s+[\'"]x',

381

'string join across lines with no space'),

383

'string join across lines with no space'),

382

(r'''(?x)ui\.(status|progress|write|note|warn)\(

384

(r'''(?x)ui\.(status|progress|write|note|warn)\(

383

[ \t\n#]*

385

[ \t\n#]*

384

(?# any strings/comments might precede a string, which

386

(?# any strings/comments might precede a string, which

385

# contains translatable message)

387

# contains translatable message)

386

((['"]|\'\'\'|""")[ \npq%bAPMxno]*(['"]|\'\'\'|""")[ \t\n#]+)*

388

((['"]|\'\'\'|""")[ \npq%bAPMxno]*(['"]|\'\'\'|""")[ \t\n#]+)*

387

(?# sequence consisting of below might precede translatable message

389

(?# sequence consisting of below might precede translatable message

388

# - formatting string: "% 10s", "%05d", "% -3.2f", "%*s", "%%" ...

390

# - formatting string: "% 10s", "%05d", "% -3.2f", "%*s", "%%" ...

389

# - escaped character: "\\", "\n", "\0" ...

391

# - escaped character: "\\", "\n", "\0" ...

390

# - character other than '%', 'b' as '\', and 'x' as alphabet)

392

# - character other than '%', 'b' as '\', and 'x' as alphabet)

391

(['"]|\'\'\'|""")

393

(['"]|\'\'\'|""")

392

((%([ n]?[PM]?([np]+|A))?x)|%%|b[bnx]|[ \nnpqAPMo])*x

394

((%([ n]?[PM]?([np]+|A))?x)|%%|b[bnx]|[ \nnpqAPMo])*x

393

(?# this regexp can't use [^...] style,

395

(?# this regexp can't use [^...] style,

394

# because _preparepats forcibly adds "\n" into [^...],

396

# because _preparepats forcibly adds "\n" into [^...],

395

# even though this regexp wants match it against "\n")''',

397

# even though this regexp wants match it against "\n")''',

396

"missing _() in ui message (use () to hide false-positives)"),

398

"missing _() in ui message (use () to hide false-positives)"),

397

] + commonpypats[0],

399

] + commonpypats[0],

398

# warnings

400

# warnings

399

[

401

[

400

# rules depending on implementation of repquote()

402

# rules depending on implementation of repquote()

401

(r'(^| )pp +xxxxqq[ \n][^\n]', "add two newlines after '.. note::'"),

403

(r'(^| )pp +xxxxqq[ \n][^\n]', "add two newlines after '.. note::'"),

402

] + commonpypats[1]

404

] + commonpypats[1]

403

]

405

]

404

406

407

# patterns to check *.py for embedded ones in test script

408

embeddedpypats = [

409

[

410

] + commonpypats[0],

411

# warnings

412

[

413

] + commonpypats[1]

414

]

415

405

# common filters to convert *.py

416

# common filters to convert *.py

406

commonpyfilters = [

417

commonpyfilters = [

407

(r"""(?msx)(?P<comment>\#.*?$)|

418

(r"""(?msx)(?P<comment>\#.*?$)|

408

((?P<quote>('''|\"\"\"|(?<!')'(?!')|(?<!")"(?!")))

419

((?P<quote>('''|\"\"\"|(?<!')'(?!')|(?<!")"(?!")))

409

(?P<text>(([^\\]|\\.)*?))

420

(?P<text>(([^\\]|\\.)*?))

410

(?P=quote))""", reppython),

421

(?P=quote))""", reppython),

411

]

422

]

412

423

413

# filters to convert normal *.py files

424

# filters to convert normal *.py files

414

pyfilters = [

425

pyfilters = [

415

] + commonpyfilters

426

] + commonpyfilters

416

427

417

# non-filter patterns

428

# non-filter patterns

418

pynfpats = [

429

pynfpats = [

419

[

430

[

420

(r'pycompat\.osname\s*[=!]=\s*[\'"]nt[\'"]', "use pycompat.iswindows"),

431

(r'pycompat\.osname\s*[=!]=\s*[\'"]nt[\'"]', "use pycompat.iswindows"),

421

(r'pycompat\.osname\s*[=!]=\s*[\'"]posix[\'"]', "use pycompat.isposix"),

432

(r'pycompat\.osname\s*[=!]=\s*[\'"]posix[\'"]', "use pycompat.isposix"),

422

(r'pycompat\.sysplatform\s*[!=]=\s*[\'"]darwin[\'"]',

433

(r'pycompat\.sysplatform\s*[!=]=\s*[\'"]darwin[\'"]',

423

"use pycompat.isdarwin"),

434

"use pycompat.isdarwin"),

424

],

435

],

425

# warnings

436

# warnings

426

[],

437

[],

427

]

438

]

428

439

440

# filters to convert *.py for embedded ones in test script

441

embeddedpyfilters = [

442

] + commonpyfilters

443

429

# extension non-filter patterns

444

# extension non-filter patterns

430

pyextnfpats = [

445

pyextnfpats = [

431

[(r'^"""\n?[A-Z]', "don't capitalize docstring title")],

446

[(r'^"""\n?[A-Z]', "don't capitalize docstring title")],

432

# warnings

447

# warnings

433

[],

448

[],

434

]

449

]

435

450

436

txtfilters = []

451

txtfilters = []

437

452

438

txtpats = [

453

txtpats = [

439

[

454

[

440

(r'\s$', 'trailing whitespace'),

455

(r'\s$', 'trailing whitespace'),

441

('.. note::[ \n][^\n]', 'add two newlines after note::')

456

('.. note::[ \n][^\n]', 'add two newlines after note::')

442

],

457

],

443

[]

458

[]

444

]

459

]

445

460

446

cpats = [

461

cpats = [

447

[

462

[

448

(r'//', "don't use //-style comments"),

463

(r'//', "don't use //-style comments"),

449

(r'\S\t', "don't use tabs except for indent"),

464

(r'\S\t', "don't use tabs except for indent"),

450

(r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),

465

(r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),

451

(r'.{81}', "line too long"),

466

(r'.{81}', "line too long"),

452

(r'(while|if|do|for)\(', "use space after while/if/do/for"),

467

(r'(while|if|do|for)\(', "use space after while/if/do/for"),

453

(r'return\(', "return is not a function"),

468

(r'return\(', "return is not a function"),

454

(r' ;', "no space before ;"),

469

(r' ;', "no space before ;"),

455

(r'[^;] \)', "no space before )"),

470

(r'[^;] \)', "no space before )"),

456

(r'[)][{]', "space between ) and {"),

471

(r'[)][{]', "space between ) and {"),

457

(r'\w+\* \w+', "use int *foo, not int* foo"),

472

(r'\w+\* \w+', "use int *foo, not int* foo"),

458

(r'\W$[^$]+\) \w+', "use (int)foo, not (int) foo"),

473

(r'\W$[^$]+\) \w+', "use (int)foo, not (int) foo"),

459

(r'\w+ (\+\+|--)', "use foo++, not foo ++"),

474

(r'\w+ (\+\+|--)', "use foo++, not foo ++"),

460

(r'\w,\w', "missing whitespace after ,"),

475

(r'\w,\w', "missing whitespace after ,"),

461

(r'^[^#]\w[+/*]\w', "missing whitespace in expression"),

476

(r'^[^#]\w[+/*]\w', "missing whitespace in expression"),

462

(r'\w\s=\s\s+\w', "gratuitous whitespace after ="),

477

(r'\w\s=\s\s+\w', "gratuitous whitespace after ="),

463

(r'^#\s+\w', "use #foo, not # foo"),

478

(r'^#\s+\w', "use #foo, not # foo"),

464

(r'[^\n]\Z', "no trailing newline"),

479

(r'[^\n]\Z', "no trailing newline"),

465

(r'^\s*#import\b', "use only #include in standard C code"),

480

(r'^\s*#import\b', "use only #include in standard C code"),

466

(r'strcpy\(', "don't use strcpy, use strlcpy or memcpy"),

481

(r'strcpy\(', "don't use strcpy, use strlcpy or memcpy"),

467

(r'strcat\(', "don't use strcat"),

482

(r'strcat\(', "don't use strcat"),

468

483

469

# rules depending on implementation of repquote()

484

# rules depending on implementation of repquote()

470

],

485

],

471

# warnings

486

# warnings

472

[

487

[

473

# rules depending on implementation of repquote()

488

# rules depending on implementation of repquote()

474

]

489

]

475

]

490

]

476

491

477

cfilters = [

492

cfilters = [

478

(r'(/\*)(((\*(?!/))|[^*])*)\*/', repccomment),

493

(r'(/\*)(((\*(?!/))|[^*])*)\*/', repccomment),

479

(r'''(?P<quote>(?<!")")(?P<text>([^"]|\\")+)"(?!")''', repquote),

494

(r'''(?P<quote>(?<!")")(?P<text>([^"]|\\")+)"(?!")''', repquote),

480

(r'''(#\s*include\s+<)([^>]+)>''', repinclude),

495

(r'''(#\s*include\s+<)([^>]+)>''', repinclude),

481

(r'($)([^)]+$)', repcallspaces),

496

(r'($)([^)]+$)', repcallspaces),

482

]

497

]

483

498

484

inutilpats = [

499

inutilpats = [

485

[

500

[

486

(r'\bui\.', "don't use ui in util"),

501

(r'\bui\.', "don't use ui in util"),

487

],

502

],

488

# warnings

503

# warnings

489

[]

504

[]

490

]

505

]

491

506

492

inrevlogpats = [

507

inrevlogpats = [

493

[

508

[

494

(r'\brepo\.', "don't use repo in revlog"),

509

(r'\brepo\.', "don't use repo in revlog"),

495

],

510

],

496

# warnings

511

# warnings

497

[]

512

[]

498

]

513

]

499

514

500

webtemplatefilters = []

515

webtemplatefilters = []

501

516

502

webtemplatepats = [

517

webtemplatepats = [

503

[],

518

[],

504

[

519

[

505

(r'{desc(\|(?!websub|firstline)[^\|]*)+}',

520

(r'{desc(\|(?!websub|firstline)[^\|]*)+}',

506

'follow desc keyword with either firstline or websub'),

521

'follow desc keyword with either firstline or websub'),

507

]

522

]

508

]

523

]

509

524

510

allfilesfilters = []

525

allfilesfilters = []

511

526

512

allfilespats = [

527

allfilespats = [

513

[

528

[

514

(r'(http|https)://[a-zA-Z0-9./]*selenic.com/',

529

(r'(http|https)://[a-zA-Z0-9./]*selenic.com/',

515

'use mercurial-scm.org domain URL'),

530

'use mercurial-scm.org domain URL'),

516

(r'mercurial@selenic\.com',

531

(r'mercurial@selenic\.com',

517

'use mercurial-scm.org domain for mercurial ML address'),

532

'use mercurial-scm.org domain for mercurial ML address'),

518

(r'mercurial-devel@selenic\.com',

533

(r'mercurial-devel@selenic\.com',

519

'use mercurial-scm.org domain for mercurial-devel ML address'),

534

'use mercurial-scm.org domain for mercurial-devel ML address'),

520

],

535

],

521

# warnings

536

# warnings

522

[],

537

[],

523

]

538

]

524

539

525

py3pats = [

540

py3pats = [

526

[

541

[

527

(r'os\.environ', "use encoding.environ instead (py3)", r'#.*re-exports'),

542

(r'os\.environ', "use encoding.environ instead (py3)", r'#.*re-exports'),

528

(r'os\.name', "use pycompat.osname instead (py3)"),

543

(r'os\.name', "use pycompat.osname instead (py3)"),

529

(r'os\.getcwd', "use encoding.getcwd instead (py3)", r'#.*re-exports'),

544

(r'os\.getcwd', "use encoding.getcwd instead (py3)", r'#.*re-exports'),

530

(r'os\.sep', "use pycompat.ossep instead (py3)"),

545

(r'os\.sep', "use pycompat.ossep instead (py3)"),

531

(r'os\.pathsep', "use pycompat.ospathsep instead (py3)"),

546

(r'os\.pathsep', "use pycompat.ospathsep instead (py3)"),

532

(r'os\.altsep', "use pycompat.osaltsep instead (py3)"),

547

(r'os\.altsep', "use pycompat.osaltsep instead (py3)"),

533

(r'sys\.platform', "use pycompat.sysplatform instead (py3)"),

548

(r'sys\.platform', "use pycompat.sysplatform instead (py3)"),

534

(r'getopt\.getopt', "use pycompat.getoptb instead (py3)"),

549

(r'getopt\.getopt', "use pycompat.getoptb instead (py3)"),

535

(r'os\.getenv', "use encoding.environ.get instead"),

550

(r'os\.getenv', "use encoding.environ.get instead"),

536

(r'os\.setenv', "modifying the environ dict is not preferred"),

551

(r'os\.setenv', "modifying the environ dict is not preferred"),

537

(r'(?<!pycompat\.)xrange', "use pycompat.xrange instead (py3)"),

552

(r'(?<!pycompat\.)xrange', "use pycompat.xrange instead (py3)"),

538

],

553

],

539

# warnings

554

# warnings

540

[],

555

[],

541

]

556

]

542

557

543

checks = [

558

checks = [

544

('python', r'.*\.(py|cgi)$', r'^#!.*python', pyfilters, pypats),

559

('python', r'.*\.(py|cgi)$', r'^#!.*python', pyfilters, pypats),

545

('python', r'.*\.(py|cgi)$', r'^#!.*python', [], pynfpats),

560

('python', r'.*\.(py|cgi)$', r'^#!.*python', [], pynfpats),

546

('python', r'.*hgext.*\.py$', '', [], pyextnfpats),

561

('python', r'.*hgext.*\.py$', '', [], pyextnfpats),

547

('python 3', r'.*(hgext|mercurial)/(?!demandimport|policy|pycompat).*\.py',

562

('python 3', r'.*(hgext|mercurial)/(?!demandimport|policy|pycompat).*\.py',

548

'', pyfilters, py3pats),

563

'', pyfilters, py3pats),

549

('test script', r'(.*/)?test-[^.~]*$', '', testfilters, testpats),

564

('test script', r'(.*/)?test-[^.~]*$', '', testfilters, testpats),

550

('c', r'.*\.[ch]$', '', cfilters, cpats),

565

('c', r'.*\.[ch]$', '', cfilters, cpats),

551

('unified test', r'.*\.t$', '', utestfilters, utestpats),

566

('unified test', r'.*\.t$', '', utestfilters, utestpats),

552

('layering violation repo in revlog', r'mercurial/revlog\.py', '',

567

('layering violation repo in revlog', r'mercurial/revlog\.py', '',

553

pyfilters, inrevlogpats),

568

pyfilters, inrevlogpats),

554

('layering violation ui in util', r'mercurial/util\.py', '', pyfilters,

569

('layering violation ui in util', r'mercurial/util\.py', '', pyfilters,

555

inutilpats),

570

inutilpats),

556

('txt', r'.*\.txt$', '', txtfilters, txtpats),

571

('txt', r'.*\.txt$', '', txtfilters, txtpats),

557

('web template', r'mercurial/templates/.*\.tmpl', '',

572

('web template', r'mercurial/templates/.*\.tmpl', '',

558

webtemplatefilters, webtemplatepats),

573

webtemplatefilters, webtemplatepats),

559

('all except for .po', r'.*(?<!\.po)$', '',

574

('all except for .po', r'.*(?<!\.po)$', '',

560

allfilesfilters, allfilespats),

575

allfilesfilters, allfilespats),

561

]

576

]

562

577

578

# (desc,

579

# func to pick up embedded code fragments,

580

# list of patterns to convert target files

581

# list of patterns to detect errors/warnings)

582

embeddedchecks = [

583

('embedded python',

584

testparseutil.pyembedded, embeddedpyfilters, embeddedpypats)

585

]

586

563

def _preparepats():

587

def _preparepats():

564

def preparefailandwarn(failandwarn):

588

def preparefailandwarn(failandwarn):

565

for pats in failandwarn:

589

for pats in failandwarn:

566

for i, pseq in enumerate(pats):

590

for i, pseq in enumerate(pats):

567

# fix-up regexes for multi-line searches

591

# fix-up regexes for multi-line searches

568

p = pseq[0]

592

p = pseq[0]

569

# \s doesn't match \n (done in two steps)

593

# \s doesn't match \n (done in two steps)

570

# first, we replace \s that appears in a set already

594

# first, we replace \s that appears in a set already

571

p = re.sub(r'\[\\s', r'[ \\t', p)

595

p = re.sub(r'\[\\s', r'[ \\t', p)

572

# now we replace other \s instances.

596

# now we replace other \s instances.

573

p = re.sub(r'(?<!(\\|\[))\\s', r'[ \\t]', p)

597

p = re.sub(r'(?<!(\\|\[))\\s', r'[ \\t]', p)

574

# [^...] doesn't match newline

598

# [^...] doesn't match newline

575

p = re.sub(r'(?<!\\)\[\^', r'[^\\n', p)

599

p = re.sub(r'(?<!\\)\[\^', r'[^\\n', p)

576

600

577

pats[i] = (re.compile(p, re.MULTILINE),) + pseq[1:]

601

pats[i] = (re.compile(p, re.MULTILINE),) + pseq[1:]

578

602

579

def preparefilters(filters):

603

def preparefilters(filters):

580

for i, flt in enumerate(filters):

604

for i, flt in enumerate(filters):

581

filters[i] = re.compile(flt[0]), flt[1]

605

filters[i] = re.compile(flt[0]), flt[1]

582

606

583

for cs in (checks,):

607

for cs in (checks, embeddedchecks):

584

for c in cs:

608

for c in cs:

585

failandwarn = c[-1]

609

failandwarn = c[-1]

586

preparefailandwarn(failandwarn)

610

preparefailandwarn(failandwarn)

587

611

588

filters = c[-2]

612

filters = c[-2]

589

preparefilters(filters)

613

preparefilters(filters)

590

614

591

class norepeatlogger(object):

615

class norepeatlogger(object):

592

def __init__(self):

616

def __init__(self):

593

self._lastseen = None

617

self._lastseen = None

594

618

595

def log(self, fname, lineno, line, msg, blame):

619

def log(self, fname, lineno, line, msg, blame):

596

"""print error related a to given line of a given file.

620

"""print error related a to given line of a given file.

597

621

598

The faulty line will also be printed but only once in the case

622

The faulty line will also be printed but only once in the case

599

of multiple errors.

623

of multiple errors.

600

624

601

:fname: filename

625

:fname: filename

602

:lineno: line number

626

:lineno: line number

603

:line: actual content of the line

627

:line: actual content of the line

604

:msg: error message

628

:msg: error message

605

"""

629

"""

606

msgid = fname, lineno, line

630

msgid = fname, lineno, line

607

if msgid != self._lastseen:

631

if msgid != self._lastseen:

608

if blame:

632

if blame:

609

print("%s:%d (%s):" % (fname, lineno, blame))

633

print("%s:%d (%s):" % (fname, lineno, blame))

610

else:

634

else:

611

print("%s:%d:" % (fname, lineno))

635

print("%s:%d:" % (fname, lineno))

612

print(" > %s" % line)

636

print(" > %s" % line)

613

self._lastseen = msgid

637

self._lastseen = msgid

614

print(" " + msg)

638

print(" " + msg)

615

639

616

_defaultlogger = norepeatlogger()

640

_defaultlogger = norepeatlogger()

617

641

618

def getblame(f):

642

def getblame(f):

619

lines = []

643

lines = []

620

for l in os.popen('hg annotate -un %s' % f):

644

for l in os.popen('hg annotate -un %s' % f):

621

start, line = l.split(':', 1)

645

start, line = l.split(':', 1)

622

user, rev = start.split()

646

user, rev = start.split()

623

lines.append((line[1:-1], user, rev))

647

lines.append((line[1:-1], user, rev))

624

return lines

648

return lines

625

649

626

def checkfile(f, logfunc=_defaultlogger.log, maxerr=None, warnings=False,

650

def checkfile(f, logfunc=_defaultlogger.log, maxerr=None, warnings=False,

627

blame=False, debug=False, lineno=True):

651

blame=False, debug=False, lineno=True):

628

"""checks style and portability of a given file

652

"""checks style and portability of a given file

629

653

630

:f: filepath

654

:f: filepath

631

:logfunc: function used to report error

655

:logfunc: function used to report error

632

logfunc(filename, linenumber, linecontent, errormessage)

656

logfunc(filename, linenumber, linecontent, errormessage)

633

:maxerr: number of error to display before aborting.

657

:maxerr: number of error to display before aborting.

634

Set to false (default) to report all errors

658

Set to false (default) to report all errors

635

659

636

return True if no error is found, False otherwise.

660

return True if no error is found, False otherwise.

637

"""

661

"""

638

result = True

662

result = True

639

663

640

try:

664

try:

641

with opentext(f) as fp:

665

with opentext(f) as fp:

642

try:

666

try:

643

pre = fp.read()

667

pre = fp.read()

644

except UnicodeDecodeError as e:

668

except UnicodeDecodeError as e:

645

print("%s while reading %s" % (e, f))

669

print("%s while reading %s" % (e, f))

646

return result

670

return result

647

except IOError as e:

671

except IOError as e:

648

print("Skipping %s, %s" % (f, str(e).split(':', 1)[0]))

672

print("Skipping %s, %s" % (f, str(e).split(':', 1)[0]))

649

return result

673

return result

650

674

651

# context information shared while single checkfile() invocation

675

# context information shared while single checkfile() invocation

652

context = {'blamecache': None}

676

context = {'blamecache': None}

653

677

654

for name, match, magic, filters, pats in checks:

678

for name, match, magic, filters, pats in checks:

655

if debug:

679

if debug:

656

print(name, f)

680

print(name, f)

657

if not (re.match(match, f) or (magic and re.search(magic, pre))):

681

if not (re.match(match, f) or (magic and re.search(magic, pre))):

658

if debug:

682

if debug:

659

print("Skipping %s for %s it doesn't match %s" % (

683

print("Skipping %s for %s it doesn't match %s" % (

660

name, match, f))

684

name, match, f))

661

continue

685

continue

662

if "no-" "check-code" in pre:

686

if "no-" "check-code" in pre:

663

# If you're looking at this line, it's because a file has:

687

# If you're looking at this line, it's because a file has:

664

# no- check- code

688

# no- check- code

665

# but the reason to output skipping is to make life for

689

# but the reason to output skipping is to make life for

666

# tests easier. So, instead of writing it with a normal

690

# tests easier. So, instead of writing it with a normal

667

# spelling, we write it with the expected spelling from

691

# spelling, we write it with the expected spelling from

668

# tests/test-check-code.t

692

# tests/test-check-code.t

669

print("Skipping %s it has no-che?k-code (glob)" % f)

693

print("Skipping %s it has no-che?k-code (glob)" % f)

670

return "Skip" # skip checking this file

694

return "Skip" # skip checking this file

671

695

672

fc = _checkfiledata(name, f, pre, filters, pats, context,

696

fc = _checkfiledata(name, f, pre, filters, pats, context,

673

logfunc, maxerr, warnings, blame, debug, lineno)

697

logfunc, maxerr, warnings, blame, debug, lineno)

674

if fc:

698

if fc:

675

result = False

699

result = False

676

700

701

if f.endswith('.t') and "no-" "check-code" not in pre:

702

if debug:

703

print("Checking embedded code in %s" % (f))

704

705

prelines = pre.splitlines()

706

embeddederros = []

707

for name, embedded, filters, pats in embeddedchecks:

708

# "reset curmax at each repetition" treats maxerr as "max

709

# nubmer of errors in an actual file per entry of

710

# (embedded)checks"

711

curmaxerr = maxerr

712

713

for found in embedded(f, prelines, embeddederros):

714

filename, starts, ends, code = found

715

fc = _checkfiledata(name, f, code, filters, pats, context,

716

logfunc, curmaxerr, warnings, blame, debug,

717

lineno, offset=starts - 1)

718

if fc:

719

result = False

720

if curmaxerr:

721

if fc >= curmaxerr:

722

break

723

curmaxerr -= fc

724

677

return result

725

return result

678

726

679

def _checkfiledata(name, f, filedata, filters, pats, context,

727

def _checkfiledata(name, f, filedata, filters, pats, context,

680

logfunc, maxerr, warnings, blame, debug, lineno,

728

logfunc, maxerr, warnings, blame, debug, lineno,

681

offset=None):

729

offset=None):

682

"""Execute actual error check for file data

730

"""Execute actual error check for file data

683

731

684

:name: of the checking category

732

:name: of the checking category

685

:f: filepath

733

:f: filepath

686

:filedata: content of a file

734

:filedata: content of a file

687

:filters: to be applied before checking

735

:filters: to be applied before checking

688

:pats: to detect errors

736

:pats: to detect errors

689

:context: a dict of information shared while single checkfile() invocation

737

:context: a dict of information shared while single checkfile() invocation

690

Valid keys: 'blamecache'.

738

Valid keys: 'blamecache'.

691

:logfunc: function used to report error

739

:logfunc: function used to report error

692

logfunc(filename, linenumber, linecontent, errormessage)

740

logfunc(filename, linenumber, linecontent, errormessage)

693

:maxerr: number of error to display before aborting, or False to

741

:maxerr: number of error to display before aborting, or False to

694

report all errors

742

report all errors

695

:warnings: whether warning level checks should be applied

743

:warnings: whether warning level checks should be applied

696

:blame: whether blame information should be displayed at error reporting

744

:blame: whether blame information should be displayed at error reporting

697

:debug: whether debug information should be displayed

745

:debug: whether debug information should be displayed

698

:lineno: whether lineno should be displayed at error reporting

746

:lineno: whether lineno should be displayed at error reporting

699

:offset: line number offset of 'filedata' in 'f' for checking

747

:offset: line number offset of 'filedata' in 'f' for checking

700

an embedded code fragment, or None (offset=0 is different

748

an embedded code fragment, or None (offset=0 is different

701

from offset=None)

749

from offset=None)

702

750

703

returns number of detected errors.

751

returns number of detected errors.

704

"""

752

"""

705

blamecache = context['blamecache']

753

blamecache = context['blamecache']

706

if offset is None:

754

if offset is None:

707

lineoffset = 0

755

lineoffset = 0

708

else:

756

else:

709

lineoffset = offset

757

lineoffset = offset

710

758

711

fc = 0

759

fc = 0

712

pre = post = filedata

760

pre = post = filedata

713

761

714

if True: # TODO: get rid of this redundant 'if' block

762

if True: # TODO: get rid of this redundant 'if' block

715

for p, r in filters:

763

for p, r in filters:

716

post = re.sub(p, r, post)

764

post = re.sub(p, r, post)

717

nerrs = len(pats[0]) # nerr elements are errors

765

nerrs = len(pats[0]) # nerr elements are errors

718

if warnings:

766

if warnings:

719

pats = pats[0] + pats[1]

767

pats = pats[0] + pats[1]

720

else:

768

else:

721

pats = pats[0]

769

pats = pats[0]

722

# print post # uncomment to show filtered version

770

# print post # uncomment to show filtered version

723

771

724

if debug:

772

if debug:

725

print("Checking %s for %s" % (name, f))

773

print("Checking %s for %s" % (name, f))

726

774

727

prelines = None

775

prelines = None

728

errors = []

776

errors = []

729

for i, pat in enumerate(pats):

777

for i, pat in enumerate(pats):

730

if len(pat) == 3:

778

if len(pat) == 3:

731

p, msg, ignore = pat

779

p, msg, ignore = pat

732

else:

780

else:

733

p, msg = pat

781

p, msg = pat

734

ignore = None

782

ignore = None

735

if i >= nerrs:

783

if i >= nerrs:

736

msg = "warning: " + msg

784

msg = "warning: " + msg

737

785

738

pos = 0

786

pos = 0

739

n = 0

787

n = 0

740

for m in p.finditer(post):

788

for m in p.finditer(post):

741

if prelines is None:

789

if prelines is None:

742

prelines = pre.splitlines()

790

prelines = pre.splitlines()

743

postlines = post.splitlines(True)

791

postlines = post.splitlines(True)

744

792

745

start = m.start()

793

start = m.start()

746

while n < len(postlines):

794

while n < len(postlines):

747

step = len(postlines[n])

795

step = len(postlines[n])

748

if pos + step > start:

796

if pos + step > start:

749

break

797

break

750

pos += step

798

pos += step

751

n += 1

799

n += 1

752

l = prelines[n]

800

l = prelines[n]

753

801

754

if ignore and re.search(ignore, l, re.MULTILINE):

802

if ignore and re.search(ignore, l, re.MULTILINE):

755

if debug:

803

if debug:

756

print("Skipping %s for %s:%s (ignore pattern)" % (

804

print("Skipping %s for %s:%s (ignore pattern)" % (

757

name, f, (n + lineoffset)))

805

name, f, (n + lineoffset)))

758

continue

806

continue

759

bd = ""

807

bd = ""

760

if blame:

808

if blame:

761

bd = 'working directory'

809

bd = 'working directory'

762

if blamecache is None:

810

if blamecache is None:

763

blamecache = getblame(f)

811

blamecache = getblame(f)

764

context['blamecache'] = blamecache

812

context['blamecache'] = blamecache

765

if (n + lineoffset) < len(blamecache):

813

if (n + lineoffset) < len(blamecache):

766

bl, bu, br = blamecache[(n + lineoffset)]

814

bl, bu, br = blamecache[(n + lineoffset)]

767

if offset is None and bl == l:

815

if offset is None and bl == l:

768

bd = '%s@%s' % (bu, br)

816

bd = '%s@%s' % (bu, br)

769

elif offset is not None and bl.endswith(l):

817

elif offset is not None and bl.endswith(l):

770

# "offset is not None" means "checking

818

# "offset is not None" means "checking

771

# embedded code fragment". In this case,

819

# embedded code fragment". In this case,

772

# "l" does not have information about the

820

# "l" does not have information about the

773

# beginning of an *original* line in the

821

# beginning of an *original* line in the

774

# file (e.g. ' > ').

822

# file (e.g. ' > ').

775

# Therefore, use "str.endswith()", and

823

# Therefore, use "str.endswith()", and

776

# show "maybe" for a little loose

824

# show "maybe" for a little loose

777

# examination.

825

# examination.

778

bd = '%s@%s, maybe' % (bu, br)

826

bd = '%s@%s, maybe' % (bu, br)

779

827

780

errors.append((f, lineno and (n + lineoffset + 1), l, msg, bd))

828

errors.append((f, lineno and (n + lineoffset + 1), l, msg, bd))

781

829

782

errors.sort()

830

errors.sort()

783

for e in errors:

831

for e in errors:

784

logfunc(*e)

832

logfunc(*e)

785

fc += 1

833

fc += 1

786

if maxerr and fc >= maxerr:

834

if maxerr and fc >= maxerr:

787

print(" (too many errors, giving up)")

835

print(" (too many errors, giving up)")

788

break

836

break

789

837

790

return fc

838

return fc

791

839

792

def main():

840

def main():

793

parser = optparse.OptionParser("%prog [options] [files | -]")

841

parser = optparse.OptionParser("%prog [options] [files | -]")

794

parser.add_option("-w", "--warnings", action="store_true",

842

parser.add_option("-w", "--warnings", action="store_true",

795

help="include warning-level checks")

843

help="include warning-level checks")

796

parser.add_option("-p", "--per-file", type="int",

844

parser.add_option("-p", "--per-file", type="int",

797

help="max warnings per file")

845

help="max warnings per file")

798

parser.add_option("-b", "--blame", action="store_true",

846

parser.add_option("-b", "--blame", action="store_true",

799

help="use annotate to generate blame info")

847

help="use annotate to generate blame info")

800

parser.add_option("", "--debug", action="store_true",

848

parser.add_option("", "--debug", action="store_true",

801

help="show debug information")

849

help="show debug information")

802

parser.add_option("", "--nolineno", action="store_false",

850

parser.add_option("", "--nolineno", action="store_false",

803

dest='lineno', help="don't show line numbers")

851

dest='lineno', help="don't show line numbers")

804

852

805

parser.set_defaults(per_file=15, warnings=False, blame=False, debug=False,

853

parser.set_defaults(per_file=15, warnings=False, blame=False, debug=False,

806

lineno=True)

854

lineno=True)

807

(options, args) = parser.parse_args()

855

(options, args) = parser.parse_args()

808

856

809

if len(args) == 0:

857

if len(args) == 0:

810

check = glob.glob("*")

858

check = glob.glob("*")

811

elif args == ['-']:

859

elif args == ['-']:

812

# read file list from stdin

860

# read file list from stdin

813

check = sys.stdin.read().splitlines()

861

check = sys.stdin.read().splitlines()

814

else:

862

else:

815

check = args

863

check = args

816

864

817

_preparepats()

865

_preparepats()

818

866

819

ret = 0

867

ret = 0

820

for f in check:

868

for f in check:

821

if not checkfile(f, maxerr=options.per_file, warnings=options.warnings,

869

if not checkfile(f, maxerr=options.per_file, warnings=options.warnings,

822

blame=options.blame, debug=options.debug,

870

blame=options.blame, debug=options.debug,

823

lineno=options.lineno):

871

lineno=options.lineno):

824

ret = 1

872

ret = 1

825

return ret

873

return ret

826

874

827

if __name__ == "__main__":

875

if __name__ == "__main__":

828

sys.exit(main())

876

sys.exit(main())

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

             #!/usr/bin/env python
             #
             # check-code - a style and portability checker for Mercurial
             #
             # Copyright 2010 Matt Mackall <mpm@selenic.com>
             #
             # This software may be used and distributed according to the terms of the
             # GNU General Public License version 2 or any later version.
             """style and portability checker for Mercurial
             when a rule triggers wrong, do one of the following (prefer one from top):
              * do the work-around the rule suggests
              * doublecheck that it is a false match
              * improve the rule pattern
              * add an ignore pattern to the rule (3rd arg) which matches your good line
                (you can append a short comment and match this, like: #re-raises)
              * change the pattern to a warning and list the exception in test-check-code-hg
              * ONLY use no--check-code for skipping entire files from external sources
             """
             from __future__ import absolute_import, print_function
             import glob
             import keyword
             import optparse
             import os
             import re
             import sys
             if sys.version_info[0] < 3:
                 opentext = open
             else:
                 def opentext(f):
                     return open(f, encoding='latin1')
             try:
                 xrange
             except NameError:
                 xrange = range
             try:
                 import re2
             except ImportError:
                 re2 = None
+            import testparseutil
             def compilere(pat, multiline=False):
                 if multiline:
                     pat = '(?m)' + pat
                 if re2:
                     try:
                         return re2.compile(pat)
                     except re2.error:
                         pass
                 return re.compile(pat)
             # check "rules depending on implementation of repquote()" in each
             # patterns (especially pypats), before changing around repquote()
             _repquotefixedmap = {' ': ' ', '\n': '\n', '.': 'p', ':': 'q',
                                  '%': '%', '\\': 'b', '*': 'A', '+': 'P', '-': 'M'}
             def _repquoteencodechr(i):
                 if i > 255:
                     return 'u'
                 c = chr(i)
                 if c in _repquotefixedmap:
                     return _repquotefixedmap[c]
                 if c.isalpha():
                     return 'x'
                 if c.isdigit():
                     return 'n'
                 return 'o'
             _repquotett = ''.join(_repquoteencodechr(i) for i in xrange(256))
             def repquote(m):
                 t = m.group('text')
                 t = t.translate(_repquotett)
                 return m.group('quote') + t + m.group('quote')
             def reppython(m):
                 comment = m.group('comment')
                 if comment:
                     l = len(comment.rstrip())
                     return "#" * l + comment[l:]
                 return repquote(m)
             def repcomment(m):
                 return m.group(1) + "#" * len(m.group(2))
             def repccomment(m):
                 t = re.sub(r"((?<=\n) )|\S", "x", m.group(2))
                 return m.group(1) + t + "*/"
             def repcallspaces(m):
                 t = re.sub(r"\n\s+", "\n", m.group(2))
                 return m.group(1) + t
             def repinclude(m):
                 return m.group(1) + "<foo>"
             def rephere(m):
                 t = re.sub(r"\S", "x", m.group(2))
                 return m.group(1) + t
             testpats = [
               [
                 (r'\b(push|pop)d\b', "don't use 'pushd' or 'popd', use 'cd'"),
                 (r'\W\$?\(\([^\)\n]*\)\)', "don't use (()) or $(()), use 'expr'"),
                 (r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"),
                 (r'(?<!hg )grep.* -a', "don't use 'grep -a', use in-line python"),
                 (r'sed.*-i', "don't use 'sed -i', use a temporary file"),
                 (r'\becho\b.*\\n', "don't use 'echo \\n', use printf"),
                 (r'echo -n', "don't use 'echo -n', use printf"),
                 (r'(^|\|\s*)\bwc\b[^|]*$\n(?!.*\(re\))', "filter wc output"),
                 (r'head -c', "don't use 'head -c', use 'dd'"),
                 (r'tail -n', "don't use the '-n' option to tail, just use '-<num>'"),
                 (r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"),
                 (r'\bls\b.*-\w*R', "don't use 'ls -R', use 'find'"),
                 (r'printf.*[^\\]\\([1-9]|0\d)', r"don't use 'printf \NNN', use Python"),
                 (r'printf.*[^\\]\\x', "don't use printf \\x, use Python"),
                 (r'\$\(.*\)', "don't use $(expr), use `expr`"),
                 (r'rm -rf \*', "don't use naked rm -rf, target a directory"),
                 (r'\[[^\]]+==', '[ foo == bar ] is a bashism, use [ foo = bar ] instead'),
                 (r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w',
                  "use egrep for extended grep syntax"),
                 (r'(^|\|\s*)e?grep .*\\S', "don't use \\S in regular expression"),
                 (r'(?<!!)/bin/', "don't use explicit paths for tools"),
                 (r'#!.*/bash', "don't use bash in shebang, use sh"),
                 (r'[^\n]\Z', "no trailing newline"),
                 (r'export .*=', "don't export and assign at once"),
                 (r'^source\b', "don't use 'source', use '.'"),
                 (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"),
                 (r'\bls +[^|\n-]+ +-', "options to 'ls' must come before filenames"),
                 (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),
                 (r'^stop\(\)', "don't use 'stop' as a shell function name"),
                 (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),
                 (r'\[\[\s+[^\]]*\]\]', "don't use '[[ ]]', use '[ ]'"),
                 (r'^alias\b.*=', "don't use alias, use a function"),
                 (r'if\s*!', "don't use '!' to negate exit status"),
                 (r'/dev/u?random', "don't use entropy, use /dev/zero"),
                 (r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"),
                 (r'sed (-e )?\'(\d+|/[^/]*/)i(?!\\\n)',
                  "put a backslash-escaped newline after sed 'i' command"),
                 (r'^diff *-\w*[uU].*$\n(^  \$ |^$)', "prefix diff -u/-U with cmp"),
                 (r'^\s+(if)? diff *-\w*[uU]', "prefix diff -u/-U with cmp"),
                 (r'[\s="`\']python\s(?!bindings)', "don't use 'python', use '$PYTHON'"),
                 (r'seq ', "don't use 'seq', use $TESTDIR/seq.py"),
                 (r'\butil\.Abort\b', "directly use error.Abort"),
                 (r'\|&', "don't use |&, use 2>&1"),
                 (r'\w =  +\w', "only one space after = allowed"),
                 (r'\bsed\b.*[^\\]\\n', "don't use 'sed ... \\n', use a \\ and a newline"),
                 (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),
                 (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),
                 (r'grep.* -[ABC]', "don't use grep's context flags"),
                 (r'find.*-printf',
                  "don't use 'find -printf', it doesn't exist on BSD find(1)"),
                 (r'\$RANDOM ', "don't use bash-only $RANDOM to generate random values"),
               ],
               # warnings
               [
                 (r'^function', "don't use 'function', use old style"),
                 (r'^diff.*-\w*N', "don't use 'diff -N'"),
                 (r'\$PWD|\${PWD}', "don't use $PWD, use `pwd`"),
                 (r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"),
                 (r'kill (`|\$\()', "don't use kill, use killdaemons.py")
               ]
             ]
             testfilters = [
                 (r"( *)(#([^!][^\n]*\S)?)", repcomment),
                 (r"<<(\S+)((.|\n)*?\n\1)", rephere),
             ]
             uprefix = r"^  \$ "
             utestpats = [
               [
                 (r'^(\S.*||  [$>] \S.*)[ \t]\n', "trailing whitespace on non-output"),
                 (uprefix + r'.*\|\s*sed[^|>\n]*\n',
                  "use regex test output patterns instead of sed"),
                 (uprefix + r'(true|exit 0)', "explicit zero exit unnecessary"),
                 (uprefix + r'.*(?<!\[)\$\?', "explicit exit code checks unnecessary"),
                 (uprefix + r'.*\|\| echo.*(fail|error)',
                  "explicit exit code checks unnecessary"),
                 (uprefix + r'set -e', "don't use set -e"),
                 (uprefix + r'(\s|fi\b|done\b)', "use > for continued lines"),
                 (uprefix + r'.*:\.\S*/', "x:.y in a path does not work on msys, rewrite "
                  "as x://.y, or see `hg log -k msys` for alternatives", r'-\S+:\.|' #-Rxxx
                  '# no-msys'), # in test-pull.t which is skipped on windows
                 (r'^  [^$>].*27\.0\.0\.1',
                  'use $LOCALIP not an explicit loopback address'),
                 (r'^  (?![>$] ).*\$LOCALIP.*[^)]$',
                  'mark $LOCALIP output lines with (glob) to help tests in BSD jails'),
                 (r'^  (cat|find): .*: \$ENOENT\$',
                  'use test -f to test for file existence'),
                 (r'^  diff -[^ -]*p',
                  "don't use (external) diff with -p for portability"),
                 (r' readlink ', 'use readlink.py instead of readlink'),
                 (r'^  [-+][-+][-+] .* [-+]0000 \(glob\)',
                  "glob timezone field in diff output for portability"),
                 (r'^  @@ -[0-9]+ [+][0-9]+,[0-9]+ @@',
                  "use '@@ -N* +N,n @@ (glob)' style chunk header for portability"),
                 (r'^  @@ -[0-9]+,[0-9]+ [+][0-9]+ @@',
                  "use '@@ -N,n +N* @@ (glob)' style chunk header for portability"),
                 (r'^  @@ -[0-9]+ [+][0-9]+ @@',
                  "use '@@ -N* +N* @@ (glob)' style chunk header for portability"),
                 (uprefix + r'hg( +-[^ ]+( +[^ ]+)?)* +extdiff'
                  r'( +(-[^ po-]+|--(?!program|option)[^ ]+|[^-][^ ]*))*$',
                  "use $RUNTESTDIR/pdiff via extdiff (or -o/-p for false-positives)"),
               ],
               # warnings
               [
                 (r'^  (?!.*\$LOCALIP)[^*?/\n]* \(glob\)$',
                  "glob match with no glob string (?, *, /, and $LOCALIP)"),
               ]
             ]
             # transform plain test rules to unified test's
             for i in [0, 1]:
                 for tp in testpats[i]:
                     p = tp[0]
                     m = tp[1]
                     if p.startswith(r'^'):
                         p = r"^  [$>] (%s)" % p[1:]
                     else:
                         p = r"^  [$>] .*(%s)" % p
                     utestpats[i].append((p, m) + tp[2:])
             # don't transform the following rules:
             # "  > \t" and "  \t" should be allowed in unified tests
             testpats[0].append((r'^( *)\t', "don't use tabs to indent"))
             utestpats[0].append((r'^( ?)\t', "don't use tabs to indent"))
             utestfilters = [
                 (r"<<(\S+)((.|\n)*?\n  > \1)", rephere),
                 (r"( +)(#([^!][^\n]*\S)?)", repcomment),
             ]
             # common patterns to check *.py
             commonpypats = [
               [
                 (r'\\$', 'Use () to wrap long lines in Python, not \\'),
                 (r'^\s*def\s*\w+\s*\(.*,\s*\(',
                  "tuple parameter unpacking not available in Python 3+"),
                 (r'lambda\s*\(.*,.*\)',
                  "tuple parameter unpacking not available in Python 3+"),
                 (r'(?<!def)\s+(cmp)\(', "cmp is not available in Python 3+"),
                 (r'(?<!\.)\breduce\s*\(.*', "reduce is not available in Python 3+"),
                 (r'\bdict\(.*=', 'dict() is different in Py2 and 3 and is slower than {}',
                  'dict-from-generator'),
                 (r'\.has_key\b', "dict.has_key is not available in Python 3+"),
                 (r'\s<>\s', '<> operator is not available in Python 3+, use !='),
                 (r'^\s*\t', "don't use tabs"),
                 (r'\S;\s*\n', "semicolon"),
                 (r'[^_]_\([ \t\n]*(?:"[^"]+"[ \t\n+]*)+%', "don't use % inside _()"),
                 (r"[^_]_\([ \t\n]*(?:'[^']+'[ \t\n+]*)+%", "don't use % inside _()"),
                 (r'(\w|\)),\w', "missing whitespace after ,"),
                 (r'(\w|\))[+/*\-<>]\w', "missing whitespace in expression"),
                 (r'^\s+(\w|\.)+=\w[^,()\n]*$', "missing whitespace in assignment"),
                 (r'\w\s=\s\s+\w', "gratuitous whitespace after ="),
                 ((
                     # a line ending with a colon, potentially with trailing comments
                     r':([ \t]*#[^\n]*)?\n'
                     # one that is not a pass and not only a comment
                     r'(?P<indent>[ \t]+)[^#][^\n]+\n'
                     # more lines at the same indent level
                     r'((?P=indent)[^\n]+\n)*'
                     # a pass at the same indent level, which is bogus
                     r'(?P=indent)pass[ \t\n#]'
                   ), 'omit superfluous pass'),
                 (r'[^\n]\Z', "no trailing newline"),
                 (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
             #    (r'^\s+[^_ \n][^_. \n]+_[^_\n]+\s*=',
             #     "don't use underbars in identifiers"),
                 (r'^\s+(self\.)?[A-Za-z][a-z0-9]+[A-Z]\w* = ',
                  "don't use camelcase in identifiers", r'#.*camelcase-required'),
                 (r'^\s*(if|while|def|class|except|try)\s[^[\n]*:\s*[^\\n]#\s]+',
                  "linebreak after :"),
                 (r'class\s[^( \n]+:', "old-style class, use class foo(object)",
                  r'#.*old-style'),
                 (r'class\s[^( \n]+\(\):',
                  "class foo() creates old style object, use class foo(object)",
                  r'#.*old-style'),
                 (r'\b(%s)\(' % '|'.join(k for k in keyword.kwlist
                                         if k not in ('print', 'exec')),
                  "Python keyword is not a function"),
                 (r',]', "unneeded trailing ',' in list"),
             #    (r'class\s[A-Z][^\(]*\((?!Exception)',
             #     "don't capitalize non-exception classes"),
             #    (r'in range\(', "use xrange"),
             #    (r'^\s*print\s+', "avoid using print in core and extensions"),
                 (r'[\x80-\xff]', "non-ASCII character literal"),
                 (r'("\')\.format\(', "str.format() has no bytes counterpart, use %"),
                 (r'^\s*(%s)\s\s' % '|'.join(keyword.kwlist),
                  "gratuitous whitespace after Python keyword"),
                 (r'([\(\[][ \t]\S)|(\S[ \t][\)\]])', "gratuitous whitespace in () or []"),
             #    (r'\s\s=', "gratuitous whitespace before ="),
                 (r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S',
                  "missing whitespace around operator"),
                 (r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\s',
                  "missing whitespace around operator"),
                 (r'\s(\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S',
                  "missing whitespace around operator"),
                 (r'[^^+=*/!<>&| %-](\s=|=\s)[^= ]',
                  "wrong whitespace around ="),
                 (r'\([^()]*( =[^=]|[^<>!=]= )',
                  "no whitespace around = for named parameters"),
                 (r'raise [^,(]+, (\([^\)]+\)|[^,\(\)]+)$',
                  "don't use old-style two-argument raise, use Exception(message)"),
                 (r' is\s+(not\s+)?["\'0-9-]', "object comparison with literal"),
                 (r' [=!]=\s+(True|False|None)',
                  "comparison with singleton, use 'is' or 'is not' instead"),
                 (r'^\s*(while|if) [01]:',
                  "use True/False for constant Boolean expression"),
                 (r'^\s*if False(:| +and)', 'Remove code instead of using `if False`'),
                 (r'(?:(?<!def)\s+|\()hasattr\(',
                  'hasattr(foo, bar) is broken on py2, use util.safehasattr(foo, bar) '
                  'instead', r'#.*hasattr-py3-only'),
                 (r'opener\([^)]*\).read\(',
                  "use opener.read() instead"),
                 (r'opener\([^)]*\).write\(',
                  "use opener.write() instead"),
                 (r'(?i)descend[e]nt', "the proper spelling is descendAnt"),
                 (r'\.debug\(\_', "don't mark debug messages for translation"),
                 (r'\.strip\(\)\.split\(\)', "no need to strip before splitting"),
                 (r'^\s*except\s*:', "naked except clause", r'#.*re-raises'),
                 (r'^\s*except\s([^\(,]+|\([^\)]+\))\s*,',
                  'legacy exception syntax; use "as" instead of ","'),
                 (r'release\(.*wlock, .*lock\)', "wrong lock release order"),
                 (r'\bdef\s+__bool__\b', "__bool__ should be __nonzero__ in Python 2"),
                 (r'os\.path\.join\(.*, *(""|\'\')\)',
                  "use pathutil.normasprefix(path) instead of os.path.join(path, '')"),
                 (r'\s0[0-7]+\b', 'legacy octal syntax; use "0o" prefix instead of "0"'),
                 # XXX only catch mutable arguments on the first line of the definition
                 (r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),
                 (r'\butil\.Abort\b', "directly use error.Abort"),
                 (r'^@(\w*\.)?cachefunc', "module-level @cachefunc is risky, please avoid"),
                 (r'^import Queue', "don't use Queue, use pycompat.queue.Queue + "
                                    "pycompat.queue.Empty"),
                 (r'^import cStringIO', "don't use cStringIO.StringIO, use util.stringio"),
                 (r'^import urllib', "don't use urllib, use util.urlreq/util.urlerr"),
                 (r'^import SocketServer', "don't use SockerServer, use util.socketserver"),
                 (r'^import urlparse', "don't use urlparse, use util.urlreq"),
                 (r'^import xmlrpclib', "don't use xmlrpclib, use util.xmlrpclib"),
                 (r'^import cPickle', "don't use cPickle, use util.pickle"),
                 (r'^import pickle', "don't use pickle, use util.pickle"),
                 (r'^import httplib', "don't use httplib, use util.httplib"),
                 (r'^import BaseHTTPServer', "use util.httpserver instead"),
                 (r'^(from|import) mercurial\.(cext|pure|cffi)',
                  "use mercurial.policy.importmod instead"),
                 (r'\.next\(\)', "don't use .next(), use next(...)"),
                 (r'([a-z]*).revision\(\1\.node\(',
                  "don't convert rev to node before passing to revision(nodeorrev)"),
                 (r'platform\.system\(\)', "don't use platform.system(), use pycompat"),
               ],
               # warnings
               [
               ]
             ]
             # patterns to check normal *.py files
             pypats = [
               [
                 # Ideally, these should be placed in "commonpypats" for
                 # consistency of coding rules in Mercurial source tree.
                 # But on the other hand, these are not so seriously required for
                 # python code fragments embedded in test scripts. Fixing test
                 # scripts for these patterns requires many changes, and has less
                 # profit than effort.
                 (r'.{81}', "line too long"),
                 (r'raise Exception', "don't raise generic exceptions"),
                 (r'[\s\(](open|file)\([^)]*\)\.read\(',
                  "use util.readfile() instead"),
                 (r'[\s\(](open|file)\([^)]*\)\.write\(',
                  "use util.writefile() instead"),
                 (r'^[\s\(]*(open(er)?|file)\([^)]*\)(?!\.close\(\))',
                  "always assign an opened file to a variable, and close it afterwards"),
                 (r'[\s\(](open|file)\([^)]*\)\.(?!close\(\))',
                  "always assign an opened file to a variable, and close it afterwards"),
                 (r':\n(    )*( ){1,3}[^ ]', "must indent 4 spaces"),
                 (r'^import atexit', "don't use atexit, use ui.atexit"),
                 # rules depending on implementation of repquote()
                 (r' x+[xpqo%APM][\'"]\n\s+[\'"]x',
                  'string join across lines with no space'),
                 (r'''(?x)ui\.(status|progress|write|note|warn)\(
                      [ \t\n#]*
                      (?# any strings/comments might precede a string, which
                        # contains translatable message)
                      ((['"]|\'\'\'|""")[ \npq%bAPMxno]*(['"]|\'\'\'|""")[ \t\n#]+)*
                      (?# sequence consisting of below might precede translatable message
                        # - formatting string: "% 10s", "%05d", "% -3.2f", "%*s", "%%" ...
                        # - escaped character: "\\", "\n", "\0" ...
                        # - character other than '%', 'b' as '\', and 'x' as alphabet)
                      (['"]|\'\'\'|""")
                      ((%([ n]?[PM]?([np]+|A))?x)|%%|b[bnx]|[ \nnpqAPMo])*x
                      (?# this regexp can't use [^...] style,
                        # because _preparepats forcibly adds "\n" into [^...],
                        # even though this regexp wants match it against "\n")''',
                  "missing _() in ui message (use () to hide false-positives)"),
               ] + commonpypats[0],
               # warnings
               [
                 # rules depending on implementation of repquote()
                 (r'(^| )pp +xxxxqq[ \n][^\n]', "add two newlines after '.. note::'"),
               ] + commonpypats[1]
             ]
+            # patterns to check *.py for embedded ones in test script
+            embeddedpypats = [
+              [
+              ] + commonpypats[0],
+              # warnings
+              [
+              ] + commonpypats[1]
+            ]
             # common filters to convert *.py
             commonpyfilters = [
                 (r"""(?msx)(?P<comment>\#.*?$)|
                      ((?P<quote>('''|\"\"\"|(?<!')'(?!')|(?<!")"(?!")))
                       (?P<text>(([^\\]|\\.)*?))
                       (?P=quote))""", reppython),
             ]
             # filters to convert normal *.py files
             pyfilters = [
             ] + commonpyfilters
             # non-filter patterns
             pynfpats = [
                 [
                 (r'pycompat\.osname\s*[=!]=\s*[\'"]nt[\'"]', "use pycompat.iswindows"),
                 (r'pycompat\.osname\s*[=!]=\s*[\'"]posix[\'"]', "use pycompat.isposix"),
                 (r'pycompat\.sysplatform\s*[!=]=\s*[\'"]darwin[\'"]',
                  "use pycompat.isdarwin"),
                 ],
                 # warnings
                 [],
             ]
+            # filters to convert *.py for embedded ones in test script
+            embeddedpyfilters = [
+            ] + commonpyfilters
             # extension non-filter patterns
             pyextnfpats = [
                 [(r'^"""\n?[A-Z]', "don't capitalize docstring title")],
                 # warnings
                 [],
             ]
             txtfilters = []
             txtpats = [
               [
                 (r'\s$', 'trailing whitespace'),
                 ('.. note::[ \n][^\n]', 'add two newlines after note::')
               ],
               []
             ]
             cpats = [
               [
                 (r'//', "don't use //-style comments"),
                 (r'\S\t', "don't use tabs except for indent"),
                 (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
                 (r'.{81}', "line too long"),
                 (r'(while|if|do|for)\(', "use space after while/if/do/for"),
                 (r'return\(', "return is not a function"),
                 (r' ;', "no space before ;"),
                 (r'[^;] \)', "no space before )"),
                 (r'[)][{]', "space between ) and {"),
                 (r'\w+\* \w+', "use int *foo, not int* foo"),
                 (r'\W\([^\)]+\) \w+', "use (int)foo, not (int) foo"),
                 (r'\w+ (\+\+|--)', "use foo++, not foo ++"),
                 (r'\w,\w', "missing whitespace after ,"),
                 (r'^[^#]\w[+/*]\w', "missing whitespace in expression"),
                 (r'\w\s=\s\s+\w', "gratuitous whitespace after ="),
                 (r'^#\s+\w', "use #foo, not # foo"),
                 (r'[^\n]\Z', "no trailing newline"),
                 (r'^\s*#import\b', "use only #include in standard C code"),
                 (r'strcpy\(', "don't use strcpy, use strlcpy or memcpy"),
                 (r'strcat\(', "don't use strcat"),
                 # rules depending on implementation of repquote()
               ],
               # warnings
               [
                 # rules depending on implementation of repquote()
               ]
             ]
             cfilters = [
                 (r'(/\*)(((\*(?!/))|[^*])*)\*/', repccomment),
                 (r'''(?P<quote>(?<!")")(?P<text>([^"]|\\")+)"(?!")''', repquote),
                 (r'''(#\s*include\s+<)([^>]+)>''', repinclude),
                 (r'(\()([^)]+\))', repcallspaces),
             ]
             inutilpats = [
               [
                 (r'\bui\.', "don't use ui in util"),
               ],
               # warnings
               []
             ]
             inrevlogpats = [
               [
                 (r'\brepo\.', "don't use repo in revlog"),
               ],
               # warnings
               []
             ]
             webtemplatefilters = []
             webtemplatepats = [
               [],
               [
                 (r'{desc(\|(?!websub|firstline)[^\|]*)+}',
                  'follow desc keyword with either firstline or websub'),
               ]
             ]
             allfilesfilters = []
             allfilespats = [
               [
                 (r'(http|https)://[a-zA-Z0-9./]*selenic.com/',
                  'use mercurial-scm.org domain URL'),
                 (r'mercurial@selenic\.com',
                  'use mercurial-scm.org domain for mercurial ML address'),
                 (r'mercurial-devel@selenic\.com',
                  'use mercurial-scm.org domain for mercurial-devel ML address'),
               ],
               # warnings
               [],
             ]
             py3pats = [
               [
                 (r'os\.environ', "use encoding.environ instead (py3)", r'#.*re-exports'),
                 (r'os\.name', "use pycompat.osname instead (py3)"),
                 (r'os\.getcwd', "use encoding.getcwd instead (py3)", r'#.*re-exports'),
                 (r'os\.sep', "use pycompat.ossep instead (py3)"),
                 (r'os\.pathsep', "use pycompat.ospathsep instead (py3)"),
                 (r'os\.altsep', "use pycompat.osaltsep instead (py3)"),
                 (r'sys\.platform', "use pycompat.sysplatform instead (py3)"),
                 (r'getopt\.getopt', "use pycompat.getoptb instead (py3)"),
                 (r'os\.getenv', "use encoding.environ.get instead"),
                 (r'os\.setenv', "modifying the environ dict is not preferred"),
                 (r'(?<!pycompat\.)xrange', "use pycompat.xrange instead (py3)"),
               ],
               # warnings
               [],
             ]
             checks = [
                 ('python', r'.*\.(py|cgi)$', r'^#!.*python', pyfilters, pypats),
                 ('python', r'.*\.(py|cgi)$', r'^#!.*python', [], pynfpats),
                 ('python', r'.*hgext.*\.py$', '', [], pyextnfpats),
                 ('python 3', r'.*(hgext|mercurial)/(?!demandimport|policy|pycompat).*\.py',
                  '', pyfilters, py3pats),
                 ('test script', r'(.*/)?test-[^.~]*$', '', testfilters, testpats),
                 ('c', r'.*\.[ch]$', '', cfilters, cpats),
                 ('unified test', r'.*\.t$', '', utestfilters, utestpats),
                 ('layering violation repo in revlog', r'mercurial/revlog\.py', '',
                  pyfilters, inrevlogpats),
                 ('layering violation ui in util', r'mercurial/util\.py', '', pyfilters,
                  inutilpats),
                 ('txt', r'.*\.txt$', '', txtfilters, txtpats),
                 ('web template', r'mercurial/templates/.*\.tmpl', '',
                  webtemplatefilters, webtemplatepats),
                 ('all except for .po', r'.*(?<!\.po)$', '',
                  allfilesfilters, allfilespats),
             ]
+            # (desc,
+            #  func to pick up embedded code fragments,
+            #  list of patterns to convert target files
+            #  list of patterns to detect errors/warnings)
+            embeddedchecks = [
+                ('embedded python',
+                 testparseutil.pyembedded, embeddedpyfilters, embeddedpypats)
+            ]
             def _preparepats():
                 def preparefailandwarn(failandwarn):
                     for pats in failandwarn:
                         for i, pseq in enumerate(pats):
                             # fix-up regexes for multi-line searches
                             p = pseq[0]
                             # \s doesn't match \n (done in two steps)
                             # first, we replace \s that appears in a set already
                             p = re.sub(r'\[\\s', r'[ \\t', p)
                             # now we replace other \s instances.
                             p = re.sub(r'(?<!(\\|\[))\\s', r'[ \\t]', p)
                             # [^...] doesn't match newline
                             p = re.sub(r'(?<!\\)\[\^', r'[^\\n', p)
                             pats[i] = (re.compile(p, re.MULTILINE),) + pseq[1:]
                 def preparefilters(filters):
                     for i, flt in enumerate(filters):
                         filters[i] = re.compile(flt[0]), flt[1]
-                for cs in (checks,):
+                for cs in (checks, embeddedchecks):
                     for c in cs:
                         failandwarn = c[-1]
                         preparefailandwarn(failandwarn)
                         filters = c[-2]
                         preparefilters(filters)
             class norepeatlogger(object):
                 def __init__(self):
                     self._lastseen = None
                 def log(self, fname, lineno, line, msg, blame):
                     """print error related a to given line of a given file.
                     The faulty line will also be printed but only once in the case
                     of multiple errors.
                     :fname: filename
                     :lineno: line number
                     :line: actual content of the line
                     :msg: error message
                     """
                     msgid = fname, lineno, line
                     if msgid != self._lastseen:
                         if blame:
                             print("%s:%d (%s):" % (fname, lineno, blame))
                         else:
                             print("%s:%d:" % (fname, lineno))
                         print(" > %s" % line)
                         self._lastseen = msgid
                     print(" " + msg)
             _defaultlogger = norepeatlogger()
             def getblame(f):
                 lines = []
                 for l in os.popen('hg annotate -un %s' % f):
                     start, line = l.split(':', 1)
                     user, rev = start.split()
                     lines.append((line[1:-1], user, rev))
                 return lines
             def checkfile(f, logfunc=_defaultlogger.log, maxerr=None, warnings=False,
                           blame=False, debug=False, lineno=True):
                 """checks style and portability of a given file
                 :f: filepath
                 :logfunc: function used to report error
                           logfunc(filename, linenumber, linecontent, errormessage)
                 :maxerr: number of error to display before aborting.
                          Set to false (default) to report all errors
                 return True if no error is found, False otherwise.
                 """
                 result = True
                 try:
                     with opentext(f) as fp:
                         try:
                             pre = fp.read()
                         except UnicodeDecodeError as e:
                             print("%s while reading %s" % (e, f))
                             return result
                 except IOError as e:
                     print("Skipping %s, %s" % (f, str(e).split(':', 1)[0]))
                     return result
                 # context information shared while single checkfile() invocation
                 context = {'blamecache': None}
                 for name, match, magic, filters, pats in checks:
                     if debug:
                         print(name, f)
                     if not (re.match(match, f) or (magic and re.search(magic, pre))):
                         if debug:
                             print("Skipping %s for %s it doesn't match %s" % (
                                    name, match, f))
                         continue
                     if "no-" "check-code" in pre:
                         # If you're looking at this line, it's because a file has:
                         # no- check- code
                         # but the reason to output skipping is to make life for
                         # tests easier. So, instead of writing it with a normal
                         # spelling, we write it with the expected spelling from
                         # tests/test-check-code.t
                         print("Skipping %s it has no-che?k-code (glob)" % f)
                         return "Skip" # skip checking this file
                     fc = _checkfiledata(name, f, pre, filters, pats, context,
                                         logfunc, maxerr, warnings, blame, debug, lineno)
                     if fc:
                         result = False
+                if f.endswith('.t') and "no-" "check-code" not in pre:
+                    if debug:
+                        print("Checking embedded code in %s" % (f))
+                    prelines = pre.splitlines()
+                    embeddederros = []
+                    for name, embedded, filters, pats in embeddedchecks:
+                        # "reset curmax at each repetition" treats maxerr as "max
+                        # nubmer of errors in an actual file per entry of
+                        # (embedded)checks"
+                        curmaxerr = maxerr
+                        for found in embedded(f, prelines, embeddederros):
+                            filename, starts, ends, code = found
+                            fc = _checkfiledata(name, f, code, filters, pats, context,
+                                                logfunc, curmaxerr, warnings, blame, debug,
+                                                lineno, offset=starts - 1)
+                            if fc:
+                                result = False
+                                if curmaxerr:
+                                    if fc >= curmaxerr:
+                                        break
+                                    curmaxerr -= fc
                 return result
             def _checkfiledata(name, f, filedata, filters, pats, context,
                                logfunc, maxerr, warnings, blame, debug, lineno,
                                offset=None):
                 """Execute actual error check for file data
                 :name: of the checking category
                 :f: filepath
                 :filedata: content of a file
                 :filters: to be applied before checking
                 :pats: to detect errors
                 :context: a dict of information shared while single checkfile() invocation
                           Valid keys: 'blamecache'.
                 :logfunc: function used to report error
                           logfunc(filename, linenumber, linecontent, errormessage)
                 :maxerr: number of error to display before aborting, or False to
                          report all errors
                 :warnings: whether warning level checks should be applied
                 :blame: whether blame information should be displayed at error reporting
                 :debug: whether debug information should be displayed
                 :lineno: whether lineno should be displayed at error reporting
                 :offset: line number offset of 'filedata' in 'f' for checking
                          an embedded code fragment, or None (offset=0 is different
                          from offset=None)
                 returns number of detected errors.
                 """
                 blamecache = context['blamecache']
                 if offset is None:
                     lineoffset = 0
                 else:
                     lineoffset = offset
                 fc = 0
                 pre = post = filedata
                 if True: # TODO: get rid of this redundant 'if' block
                     for p, r in filters:
                         post = re.sub(p, r, post)
                     nerrs = len(pats[0]) # nerr elements are errors
                     if warnings:
                         pats = pats[0] + pats[1]
                     else:
                         pats = pats[0]
                     # print post # uncomment to show filtered version
                     if debug:
                         print("Checking %s for %s" % (name, f))
                     prelines = None
                     errors = []
                     for i, pat in enumerate(pats):
                         if len(pat) == 3:
                             p, msg, ignore = pat
                         else:
                             p, msg = pat
                             ignore = None
                         if i >= nerrs:
                             msg = "warning: " + msg
                         pos = 0
                         n = 0
                         for m in p.finditer(post):
                             if prelines is None:
                                 prelines = pre.splitlines()
                                 postlines = post.splitlines(True)
                             start = m.start()
                             while n < len(postlines):
                                 step = len(postlines[n])
                                 if pos + step > start:
                                     break
                                 pos += step
                                 n += 1
                             l = prelines[n]
                             if ignore and re.search(ignore, l, re.MULTILINE):
                                 if debug:
                                     print("Skipping %s for %s:%s (ignore pattern)" % (
                                         name, f, (n + lineoffset)))
                                 continue
                             bd = ""
                             if blame:
                                 bd = 'working directory'
                                 if blamecache is None:
                                     blamecache = getblame(f)
                                     context['blamecache'] = blamecache
                                 if (n + lineoffset) < len(blamecache):
                                     bl, bu, br = blamecache[(n + lineoffset)]
                                     if offset is None and bl == l:
                                         bd = '%s@%s' % (bu, br)
                                     elif offset is not None and bl.endswith(l):
                                         # "offset is not None" means "checking
                                         # embedded code fragment". In this case,
                                         # "l" does not have information about the
                                         # beginning of an *original* line in the
                                         # file (e.g. '  > ').
                                         # Therefore, use "str.endswith()", and
                                         # show "maybe" for a little loose
                                         # examination.
                                         bd = '%s@%s, maybe' % (bu, br)
                             errors.append((f, lineno and (n + lineoffset + 1), l, msg, bd))
                     errors.sort()
                     for e in errors:
                         logfunc(*e)
                         fc += 1
                         if maxerr and fc >= maxerr:
                             print(" (too many errors, giving up)")
                             break
                 return fc
             def main():
                 parser = optparse.OptionParser("%prog [options] [files | -]")
                 parser.add_option("-w", "--warnings", action="store_true",
                                   help="include warning-level checks")
                 parser.add_option("-p", "--per-file", type="int",
                                   help="max warnings per file")
                 parser.add_option("-b", "--blame", action="store_true",
                                   help="use annotate to generate blame info")
                 parser.add_option("", "--debug", action="store_true",
                                   help="show debug information")
                 parser.add_option("", "--nolineno", action="store_false",
                                   dest='lineno', help="don't show line numbers")
                 parser.set_defaults(per_file=15, warnings=False, blame=False, debug=False,
                                     lineno=True)
                 (options, args) = parser.parse_args()
                 if len(args) == 0:
                     check = glob.glob("*")
                 elif args == ['-']:
                     # read file list from stdin
                     check = sys.stdin.read().splitlines()
                 else:
                     check = args
                 _preparepats()
                 ret = 0
                 for f in check:
                     if not checkfile(f, maxerr=options.per_file, warnings=options.warnings,
                                      blame=options.blame, debug=options.debug,
                                      lineno=options.lineno):
                         ret = 1
                 return ret
             if __name__ == "__main__":
                 sys.exit(main())

               $ cat > correct.py <<NO_CHECK_EOF
               > def toto(arg1, arg2):
               >     del arg2
               >     return (5 + 6, 9)
               > NO_CHECK_EOF
               $ cat > wrong.py <<NO_CHECK_EOF
               > def toto( arg1, arg2):
               >     del(arg2)
               >     return ( 5+6, 9)
               > def badwrap():
               >     return 1 + \\
               >        2
               > NO_CHECK_EOF
               $ cat > quote.py <<NO_CHECK_EOF
               > # let's use quote in comments
               > (''' ( 4x5 )
               > but """\\''' and finally''',
               > """let's fool checkpatch""", '1+2',
               > '"""', 42+1, """and
               > ( 4-1 ) """, "( 1+1 )\" and ")
               > a, '\\\\\\\\', "\\\\\\" x-2", "c-1"
               > NO_CHECK_EOF
               $ cat > classstyle.py <<NO_CHECK_EOF
               > class newstyle_class(object):
               >     pass
               >
               > class oldstyle_class:
               >     pass
               >
               > class empty():
               >     pass
               >
               > no_class = 1:
               >     pass
               > NO_CHECK_EOF
               $ check_code="$TESTDIR"/../contrib/check-code.py
               $ "$check_code" ./wrong.py ./correct.py ./quote.py ./classstyle.py
               ./wrong.py:1:
                > def toto( arg1, arg2):
                gratuitous whitespace in () or []
               ./wrong.py:2:
                >     del(arg2)
                Python keyword is not a function
               ./wrong.py:3:
                >     return ( 5+6, 9)
                gratuitous whitespace in () or []
                missing whitespace in expression
               ./wrong.py:5:
                >     return 1 + \
                Use () to wrap long lines in Python, not \
               ./quote.py:5:
                > '"""', 42+1, """and
                missing whitespace in expression
               ./classstyle.py:4:
                > class oldstyle_class:
                old-style class, use class foo(object)
               ./classstyle.py:7:
                > class empty():
                class foo() creates old style object, use class foo(object)
               [1]
               $ cat > python3-compat.py << NO_CHECK_EOF
               > foo <> bar
               > reduce(lambda a, b: a + b, [1, 2, 3, 4])
               > dict(key=value)
               > NO_CHECK_EOF
               $ "$check_code" python3-compat.py
               python3-compat.py:1:
                > foo <> bar
                <> operator is not available in Python 3+, use !=
               python3-compat.py:2:
                > reduce(lambda a, b: a + b, [1, 2, 3, 4])
                reduce is not available in Python 3+
               python3-compat.py:3:
                > dict(key=value)
                dict() is different in Py2 and 3 and is slower than {}
               [1]
               $ cat > foo.c <<NO_CHECK_EOF
               > void narf() {
               > 	strcpy(foo, bar);
               > 	// strcpy_s is okay, but this comment is not
               > 	strcpy_s(foo, bar);
               > }
               > NO_CHECK_EOF
               $ "$check_code" ./foo.c
               ./foo.c:2:
                > 	strcpy(foo, bar);
                don't use strcpy, use strlcpy or memcpy
               ./foo.c:3:
                > 	// strcpy_s is okay, but this comment is not
                don't use //-style comments
               [1]
               $ cat > is-op.py <<NO_CHECK_EOF
               > # is-operator comparing number or string literal
               > x = None
               > y = x is 'foo'
               > y = x is "foo"
               > y = x is 5346
               > y = x is -6
               > y = x is not 'foo'
               > y = x is not "foo"
               > y = x is not 5346
               > y = x is not -6
               > NO_CHECK_EOF
               $ "$check_code" ./is-op.py
               ./is-op.py:3:
                > y = x is 'foo'
                object comparison with literal
               ./is-op.py:4:
                > y = x is "foo"
                object comparison with literal
               ./is-op.py:5:
                > y = x is 5346
                object comparison with literal
               ./is-op.py:6:
                > y = x is -6
                object comparison with literal
               ./is-op.py:7:
                > y = x is not 'foo'
                object comparison with literal
               ./is-op.py:8:
                > y = x is not "foo"
                object comparison with literal
               ./is-op.py:9:
                > y = x is not 5346
                object comparison with literal
               ./is-op.py:10:
                > y = x is not -6
                object comparison with literal
               [1]
               $ cat > for-nolineno.py <<NO_CHECK_EOF
               > except:
               > NO_CHECK_EOF
               $ "$check_code" for-nolineno.py --nolineno
               for-nolineno.py:0:
                > except:
                naked except clause
               [1]
               $ cat > warning.t <<NO_CHECK_EOF
               >   $ function warnonly {
               >   > }
               >   $ diff -N aaa
               >   $ function onwarn {}
               > NO_CHECK_EOF
               $ "$check_code" warning.t
               $ "$check_code" --warn warning.t
               warning.t:1:
                >   $ function warnonly {
                warning: don't use 'function', use old style
               warning.t:3:
                >   $ diff -N aaa
                warning: don't use 'diff -N'
               warning.t:4:
                >   $ function onwarn {}
                warning: don't use 'function', use old style
               [1]
               $ cat > error.t <<NO_CHECK_EOF
               >   $ [ foo == bar ]
               > NO_CHECK_EOF
               $ "$check_code" error.t
               error.t:1:
                >   $ [ foo == bar ]
                [ foo == bar ] is a bashism, use [ foo = bar ] instead
               [1]
               $ rm error.t
               $ cat > raise-format.py <<NO_CHECK_EOF
               > raise SomeException, message
               > # this next line is okay
               > raise SomeException(arg1, arg2)
               > NO_CHECK_EOF
               $ "$check_code" not-existing.py raise-format.py
               Skipping*not-existing.py* (glob)
               raise-format.py:1:
                > raise SomeException, message
                don't use old-style two-argument raise, use Exception(message)
               [1]
               $ cat <<NO_CHECK_EOF > tab.t
               > 	indent
               >   > 	heredoc
               > NO_CHECK_EOF
               $ "$check_code" tab.t
               tab.t:1:
                > 	indent
                don't use tabs to indent
               [1]
               $ rm tab.t
               $ cat > rst.py <<NO_CHECK_EOF
               > """problematic rst text
               >
               > .. note::
               >     wrong
               > """
               >
               > '''
               >
               > .. note::
               >
               >     valid
               >
               > new text
               >
               >     .. note::
               >
               >         also valid
               > '''
               >
               > """mixed
               >
               > .. note::
               >
               >   good
               >
               >     .. note::
               >         plus bad
               > """
               > NO_CHECK_EOF
               $ $check_code -w rst.py
               rst.py:3:
                > .. note::
                warning: add two newlines after '.. note::'
               rst.py:26:
                >     .. note::
                warning: add two newlines after '.. note::'
               [1]
               $ cat > ./map-inside-gettext.py <<NO_CHECK_EOF
               > print(_("map inside gettext %s" % v))
               >
               > print(_("concatenating " " by " " space %s" % v))
               > print(_("concatenating " + " by " + " '+' %s" % v))
               >
               > print(_("mapping operation in different line %s"
               >         % v))
               >
               > print(_(
               >         "leading spaces inside of '(' %s" % v))
               > NO_CHECK_EOF
               $ "$check_code" ./map-inside-gettext.py
               ./map-inside-gettext.py:1:
                > print(_("map inside gettext %s" % v))
                don't use % inside _()
               ./map-inside-gettext.py:3:
                > print(_("concatenating " " by " " space %s" % v))
                don't use % inside _()
               ./map-inside-gettext.py:4:
                > print(_("concatenating " + " by " + " '+' %s" % v))
                don't use % inside _()
               ./map-inside-gettext.py:6:
                > print(_("mapping operation in different line %s"
                don't use % inside _()
               ./map-inside-gettext.py:9:
                > print(_(
                don't use % inside _()
               [1]
             web templates
               $ mkdir -p mercurial/templates
               $ cat > mercurial/templates/example.tmpl <<NO_CHECK_EOF
               > {desc}
               > {desc|escape}
               > {desc|firstline}
               > {desc|websub}
               > NO_CHECK_EOF
               $ "$check_code" --warnings mercurial/templates/example.tmpl
               mercurial/templates/example.tmpl:2:
                > {desc|escape}
                warning: follow desc keyword with either firstline or websub
               [1]
             'string join across lines with no space' detection
               $ cat > stringjoin.py <<NO_CHECK_EOF
               > foo = (' foo'
               >        'bar foo.'
               >        'bar foo:'
               >        'bar foo@'
               >        'bar foo%'
               >        'bar foo*'
               >        'bar foo+'
               >        'bar foo-'
               >        'bar')
               > NO_CHECK_EOF
             'missing _() in ui message' detection
               $ cat > uigettext.py <<NO_CHECK_EOF
               > ui.status("% 10s %05d % -3.2f %*s %%"
               >           # this use '\\\\' instead of '\\', because the latter in
               >           # heredoc on shell becomes just '\'
               >           '\\\\ \n \t \0'
               >           """12345
               >           """
               >           '''.:*+-=
               >           ''' "%-6d \n 123456 .:*+-= foobar")
               > NO_CHECK_EOF
             superfluous pass
               $ cat > superfluous_pass.py <<NO_CHECK_EOF
               > # correct examples
               > if foo:
               >     pass
               > else:
               >     # comment-only line means still need pass
               >     pass
               > def nothing():
               >     pass
               > class empty(object):
               >     pass
               > if whatever:
               >     passvalue(value)
               > # bad examples
               > if foo:
               >     "foo"
               >     pass
               > else: # trailing comment doesn't fool checker
               >     wat()
               >     pass
               > def nothing():
               >     "docstring means no pass"
               >     pass
               > class empty(object):
               >     """multiline
               >     docstring also
               >     means no pass"""
               >     pass
               > NO_CHECK_EOF
             (Checking multiple invalid files at once examines whether caching
             translation table for repquote() works as expected or not. All files
             should break rules depending on result of repquote(), in this case)
               $ "$check_code" stringjoin.py uigettext.py superfluous_pass.py
               stringjoin.py:1:
                > foo = (' foo'
                string join across lines with no space
               stringjoin.py:2:
                >        'bar foo.'
                string join across lines with no space
               stringjoin.py:3:
                >        'bar foo:'
                string join across lines with no space
               stringjoin.py:4:
                >        'bar foo@'
                string join across lines with no space
               stringjoin.py:5:
                >        'bar foo%'
                string join across lines with no space
               stringjoin.py:6:
                >        'bar foo*'
                string join across lines with no space
               stringjoin.py:7:
                >        'bar foo+'
                string join across lines with no space
               stringjoin.py:8:
                >        'bar foo-'
                string join across lines with no space
               uigettext.py:1:
                > ui.status("% 10s %05d % -3.2f %*s %%"
                missing _() in ui message (use () to hide false-positives)
               superfluous_pass.py:14:
                > if foo:
                omit superfluous pass
               superfluous_pass.py:17:
                > else: # trailing comment doesn't fool checker
                omit superfluous pass
               superfluous_pass.py:20:
                > def nothing():
                omit superfluous pass
               superfluous_pass.py:23:
                > class empty(object):
                omit superfluous pass
               [1]
+            Check code fragments embedded in test script
+              $ cat > embedded-code.t <<NO_CHECK_EOF
+              > code fragment in doctest style
+              >   >>> x = (1,2)
+              >   ...
+              >   ... x = (1,2)
+              >
+              > code fragment in heredoc style
+              >   $ python <<EOF
+              >   > x = (1,2)
+              >   > EOF
+              >
+              > code fragment in file heredoc style
+              >   $ python > file.py <<EOF
+              >   > x = (1,2)
+              >   > EOF
+              > NO_CHECK_EOF
+              $ "$check_code" embedded-code.t
+              embedded-code.t:2:
+               > x = (1,2)
+               missing whitespace after ,
+              embedded-code.t:4:
+               > x = (1,2)
+               missing whitespace after ,
+              embedded-code.t:8:
+               > x = (1,2)
+               missing whitespace after ,
+              embedded-code.t:13:
+               > x = (1,2)
+               missing whitespace after ,
+              [1]
+            "max warnings per file" is shared by all embedded code fragments
+              $ "$check_code" --per-file=3 embedded-code.t
+              embedded-code.t:2:
+               > x = (1,2)
+               missing whitespace after ,
+              embedded-code.t:4:
+               > x = (1,2)
+               missing whitespace after ,
+              embedded-code.t:8:
+               > x = (1,2)
+               missing whitespace after ,
+               (too many errors, giving up)
+              [1]