Date validation must check for 32-bit width. Don't use assert to check.

mercurial/changelog.py

@@ -1,47 +1,50
 # changelog.py - changelog class for mercurial
 #
 # Copyright 2005 Matt Mackall <[e-mail]>
 #
 # This software may be used and distributed according to the terms
 # of the GNU General Public License, incorporated herein by reference.
 
 import os, time
 from revlog import *
 
 class changelog(revlog):
     def __init__(self, opener):
         revlog.__init__(self, opener, "00changelog.i", "00changelog.d")
 
     def extract(self, text):
         if not text:
             return (nullid, "", "0", [], "")
         last = text.index("\n\n")
         desc = text[last + 2:]
         l = text[:last].splitlines()
         manifest = bin(l[0])
         user = l[1]
         date = l[2]
         if " " not in date:
             date += " 0" # some tools used -d without a timezone
         files = l[3:]
         return (manifest, user, date, files, desc)
 
     def read(self, node):
         return self.extract(self.revision(node))
 
     def add(self, manifest, list, desc, transaction, p1=None, p2=None,
                   user=None, date=None):
         if date:
             # validate explicit (probably user-specified) date and
-            # time zone offset
+            # time zone offset. values must fit in signed 32 bits for
+            # current 32-bit linux runtimes.
             when, offset = map(int, date.split(' '))
-            time.localtime(when)
-            assert abs(offset) < 43200, 'bad time zone offset: %d' % offset
+            if abs(when) > 0x7fffffff:
+                raise ValueError('date exceeds 32 bits: %d' % when)
+            if abs(offset) >= 43200:
+                raise ValueError('impossible time zone offset: %d' % offset)
         else:
             if time.daylight: offset = time.altzone
             else: offset = time.timezone
             date = "%d %d" % (time.time(), offset)
         list.sort()
         l = [hex(manifest), user, date] + list + ["", desc]
         text = "\n".join(l)
         return self.addrevision(text, transaction, self.count(), p1, p2)