scheme: don't crash on invalid URLs

hgext/schemes.py

@@ -1,101 +1,104 b''
 # Copyright 2009, Alexander Solovyov <[e-mail]>
 #
 # This software may be used and distributed according to the terms of the
 # GNU General Public License version 2 or any later version.
 
 """extend schemes with shortcuts to repository swarms
 
 This extension allows you to specify shortcuts for parent URLs with a
 lot of repositories to act like a scheme, for example::
 
   [schemes]
   py = http://code.python.org/hg/
 
 After that you can use it like::
 
   hg clone py://trunk/
 
 Additionally there is support for some more complex schemas, for
 example used by Google Code::
 
   [schemes]
   gcode = http://{1}.googlecode.com/hg/
 
 The syntax is taken from Mercurial templates, and you have unlimited
 number of variables, starting with ``{1}`` and continuing with
 ``{2}``, ``{3}`` and so on. This variables will receive parts of URL
 supplied, split by ``/``. Anything not specified as ``{part}`` will be
 just appended to an URL.
 
 For convenience, the extension adds these schemes by default::
 
   [schemes]
   py = http://hg.python.org/
   bb = https://bitbucket.org/
   bb+ssh = ssh://[e-mail]/
   gcode = https://{1}.googlecode.com/hg/
   kiln = https://{1}.kilnhg.com/Repo/
 
 You can override a predefined scheme by defining a new scheme with the
 same name.
 """
 
 import os, re
 from mercurial import extensions, hg, templater, util
 from mercurial.i18n import _
 
 testedwith = 'internal'
 
 
 class ShortRepository(object):
     def __init__(self, url, scheme, templater):
         self.scheme = scheme
         self.templater = templater
         self.url = url
         try:
             self.parts = max(map(int, re.findall(r'\{(\d+)\}', self.url)))
         except ValueError:
             self.parts = 0
 
     def __repr__(self):
         return '<ShortRepository: %s>' % self.scheme
 
     def instance(self, ui, url, create):
         # Should this use the util.url class, or is manual parsing better?
-        url = url.split('://', 1)[1]
+        try:
+            url = url.split('://', 1)[1]
+        except IndexError:
+            raise util.Abort(_("no '://' in scheme url '%s'") % url)
         parts = url.split('/', self.parts)
         if len(parts) > self.parts:
             tail = parts[-1]
             parts = parts[:-1]
         else:
             tail = ''
         context = dict((str(i + 1), v) for i, v in enumerate(parts))
         url = ''.join(self.templater.process(self.url, context)) + tail
         return hg._peerlookup(url).instance(ui, url, create)
 
 def hasdriveletter(orig, path):
     if path:
         for scheme in schemes:
             if path.startswith(scheme + ':'):
                 return False
     return orig(path)
 
 schemes = {
     'py': 'http://hg.python.org/',
     'bb': 'https://bitbucket.org/',
     'bb+ssh': 'ssh://[e-mail]/',
     'gcode': 'https://{1}.googlecode.com/hg/',
     'kiln': 'https://{1}.kilnhg.com/Repo/'
     }
 
 def extsetup(ui):
     schemes.update(dict(ui.configitems('schemes')))
     t = templater.engine(lambda x: x)
     for scheme, url in schemes.items():
         if (os.name == 'nt' and len(scheme) == 1 and scheme.isalpha()
             and os.path.exists('%s:\\' % scheme)):
             raise util.Abort(_('custom scheme %s:// conflicts with drive '
                                'letter %s:\\\n') % (scheme, scheme.upper()))
         hg.schemes[scheme] = ShortRepository(url, scheme, t)
 
     extensions.wrapfunction(util, 'hasdriveletter', hasdriveletter)

tests/test-schemes.t

@@ -1,50 +1,59 b''
   $ "$TESTDIR/hghave" serve || exit 80
 
   $ cat <<EOF >> $HGRCPATH
   > [extensions]
   > schemes=
   > 
   > [schemes]
   > l = http://localhost:$HGPORT/
   > parts = http://{1}:$HGPORT/
   > z = file:\$PWD/
   > EOF
   $ hg init test
   $ cd test
   $ echo a > a
   $ hg ci -Am initial
   adding a
+
+invalid scheme
+
+  $ hg log -R z:z
+  abort: no '://' in scheme url 'z:z'
+  [255]
+
+http scheme
+
   $ hg serve -n test -p $HGPORT -d --pid-file=hg.pid -A access.log -E errors.log
   $ cat hg.pid >> $DAEMON_PIDS
   $ hg incoming l://
   comparing with l://
   searching for changes
   no changes found
   [1]
 
 check that {1} syntax works
 
   $ hg incoming --debug parts://localhost
   using http://localhost:$HGPORT/
   sending capabilities command
   comparing with parts://localhost/
   query 1; heads
   sending batch command
   searching for changes
   all remote heads known locally
   no changes found
   [1]
 
 check that paths are expanded
 
   $ PWD=`pwd` hg incoming z://
   comparing with z://
   searching for changes
   no changes found
   [1]
 
 errors
 
   $ cat errors.log
 
   $ cd ..