cleanupnodes: trust caller when "moves" is not None

If "moves" (indicating how to move bookmarks) is None, we fill it out
based on "replacements" (indicating which obsmarkers to add). If
"moves" is not None, we would still add items based on
"replacements". This makes it impossible to pass "moves={}" and not
move bookmarks, which surprised me. The only caller that currently
passes a value for "moves" was the rebase extension and there we were
already adding bookmark moves corresponding to obsmarker additions, so
it should not be impacted.

Differential Revision: https://phab.mercurial-scm.org/D5391

mercurial/scmutil.py

@@ -901,11 +901,12 b' def cleanupnodes(repo, replacements, ope'
             repls[key] = value
         replacements = repls
 
+    # Unfiltered repo is needed since nodes in replacements might be hidden.
+    unfi = repo.unfiltered()
+
     # Calculate bookmark movements
     if moves is None:
         moves = {}
-    # Unfiltered repo is needed since nodes in replacements might be hidden.
-    unfi = repo.unfiltered()
     for oldnodes, newnodes in replacements.items():
         for oldnode in oldnodes:
             if oldnode in moves: