upstream/mercurial-mirror Commit - r26808:b81b8dbe

1

#!/usr/bin/env python

1

#!/usr/bin/env python

2

#

2

#

3

# check-code - a style and portability checker for Mercurial

3

# check-code - a style and portability checker for Mercurial

4

#

4

#

5

6

#

6

#

7

# This software may be used and distributed according to the terms of the

7

# This software may be used and distributed according to the terms of the

8

# GNU General Public License version 2 or any later version.

8

# GNU General Public License version 2 or any later version.

9

10

"""style and portability checker for Mercurial

10

"""style and portability checker for Mercurial

11

12

when a rule triggers wrong, do one of the following (prefer one from top):

12

when a rule triggers wrong, do one of the following (prefer one from top):

13

* do the work-around the rule suggests

13

* do the work-around the rule suggests

14

* doublecheck that it is a false match

14

* doublecheck that it is a false match

15

* improve the rule pattern

15

* improve the rule pattern

16

* add an ignore pattern to the rule (3rd arg) which matches your good line

16

* add an ignore pattern to the rule (3rd arg) which matches your good line

17

(you can append a short comment and match this, like: #re-raises, # no-py24)

17

(you can append a short comment and match this, like: #re-raises, # no-py24)

18

* change the pattern to a warning and list the exception in test-check-code-hg

18

* change the pattern to a warning and list the exception in test-check-code-hg

19

* ONLY use no--check-code for skipping entire files from external sources

19

* ONLY use no--check-code for skipping entire files from external sources

20

"""

20

"""

21

22

import re, glob, os, sys

22

import re, glob, os, sys

23

import keyword

23

import keyword

24

import optparse

24

import optparse

25

try:

25

try:

26

import re2

26

import re2

27

except ImportError:

27

except ImportError:

28

re2 = None

28

re2 = None

29

30

def compilere(pat, multiline=False):

30

def compilere(pat, multiline=False):

31

if multiline:

31

if multiline:

32

pat = '(?m)' + pat

32

pat = '(?m)' + pat

33

if re2:

33

if re2:

34

try:

34

try:

35

return re2.compile(pat)

35

return re2.compile(pat)

36

except re2.error:

36

except re2.error:

37

pass

37

pass

38

return re.compile(pat)

38

return re.compile(pat)

39

40

def repquote(m):

40

def repquote(m):

41

fromc = '.:'

41

fromc = '.:'

42

tochr = 'pq'

42

tochr = 'pq'

43

def encodechr(i):

43

def encodechr(i):

44

if i > 255:

44

if i > 255:

45

return 'u'

45

return 'u'

46

c = chr(i)

46

c = chr(i)

47

if c in ' \n':

47

if c in ' \n':

48

return c

48

return c

49

if c.isalpha():

49

if c.isalpha():

50

return 'x'

50

return 'x'

51

if c.isdigit():

51

if c.isdigit():

52

return 'n'

52

return 'n'

53

try:

53

try:

54

return tochr[fromc.find(c)]

54

return tochr[fromc.find(c)]

55

except (ValueError, IndexError):

55

except (ValueError, IndexError):

56

return 'o'

56

return 'o'

57

t = m.group('text')

57

t = m.group('text')

58

tt = ''.join(encodechr(i) for i in xrange(256))

58

tt = ''.join(encodechr(i) for i in xrange(256))

59

t = t.translate(tt)

59

t = t.translate(tt)

60

return m.group('quote') + t + m.group('quote')

60

return m.group('quote') + t + m.group('quote')

61

62

def reppython(m):

62

def reppython(m):

63

comment = m.group('comment')

63

comment = m.group('comment')

64

if comment:

64

if comment:

65

l = len(comment.rstrip())

65

l = len(comment.rstrip())

66

return "#" * l + comment[l:]

66

return "#" * l + comment[l:]

67

return repquote(m)

67

return repquote(m)

68

69

def repcomment(m):

69

def repcomment(m):

70

return m.group(1) + "#" * len(m.group(2))

70

return m.group(1) + "#" * len(m.group(2))

71

72

def repccomment(m):

72

def repccomment(m):

73

t = re.sub(r"((?<=\n) )|\S", "x", m.group(2))

73

t = re.sub(r"((?<=\n) )|\S", "x", m.group(2))

74

return m.group(1) + t + "*/"

74

return m.group(1) + t + "*/"

75

76

def repcallspaces(m):

76

def repcallspaces(m):

77

t = re.sub(r"\n\s+", "\n", m.group(2))

77

t = re.sub(r"\n\s+", "\n", m.group(2))

78

return m.group(1) + t

78

return m.group(1) + t

79

80

def repinclude(m):

80

def repinclude(m):

81

return m.group(1) + "<foo>"

81

return m.group(1) + "<foo>"

82

83

def rephere(m):

83

def rephere(m):

84

t = re.sub(r"\S", "x", m.group(2))

84

t = re.sub(r"\S", "x", m.group(2))

85

return m.group(1) + t

85

return m.group(1) + t

86

87

88

testpats = [

88

testpats = [

89

[

89

[

90

(r'pushd|popd', "don't use 'pushd' or 'popd', use 'cd'"),

90

(r'pushd|popd', "don't use 'pushd' or 'popd', use 'cd'"),

91

(r'\W\$?$\([^$\n]*\)\)', "don't use (()) or $(()), use 'expr'"),

91

(r'\W\$?$\([^$\n]*\)\)', "don't use (()) or $(()), use 'expr'"),

92

(r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"),

92

(r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"),

93

(r'(?<!hg )grep.*-a', "don't use 'grep -a', use in-line python"),

93

(r'(?<!hg )grep.*-a', "don't use 'grep -a', use in-line python"),

94

(r'sed.*-i', "don't use 'sed -i', use a temporary file"),

94

(r'sed.*-i', "don't use 'sed -i', use a temporary file"),

95

(r'\becho\b.*\\n', "don't use 'echo \\n', use printf"),

95

(r'\becho\b.*\\n', "don't use 'echo \\n', use printf"),

96

(r'echo -n', "don't use 'echo -n', use printf"),

96

(r'echo -n', "don't use 'echo -n', use printf"),

97

(r'(^|\|\s*)\bwc\b[^|]*$\n(?!.*$re$)', "filter wc output"),

97

(r'(^|\|\s*)\bwc\b[^|]*$\n(?!.*$re$)', "filter wc output"),

98

(r'head -c', "don't use 'head -c', use 'dd'"),

98

(r'head -c', "don't use 'head -c', use 'dd'"),

99

(r'tail -n', "don't use the '-n' option to tail, just use '-<num>'"),

99

(r'tail -n', "don't use the '-n' option to tail, just use '-<num>'"),

100

(r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"),

100

(r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"),

101

(r'ls.*-\w*R', "don't use 'ls -R', use 'find'"),

101

(r'ls.*-\w*R', "don't use 'ls -R', use 'find'"),

102

(r'printf.*[^\\]\\([1-9]|0\d)', "don't use 'printf \NNN', use Python"),

102

(r'printf.*[^\\]\\([1-9]|0\d)', "don't use 'printf \NNN', use Python"),

103

(r'printf.*[^\\]\\x', "don't use printf \\x, use Python"),

103

(r'printf.*[^\\]\\x', "don't use printf \\x, use Python"),

104

(r'\$$.*$', "don't use $(expr), use `expr`"),

104

(r'\$$.*$', "don't use $(expr), use `expr`"),

105

(r'rm -rf \*', "don't use naked rm -rf, target a directory"),

105

(r'rm -rf \*', "don't use naked rm -rf, target a directory"),

106

(r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w',

106

(r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w',

107

"use egrep for extended grep syntax"),

107

"use egrep for extended grep syntax"),

108

(r'/bin/', "don't use explicit paths for tools"),

108

(r'/bin/', "don't use explicit paths for tools"),

109

(r'[^\n]\Z', "no trailing newline"),

109

(r'[^\n]\Z', "no trailing newline"),

110

(r'export.*=', "don't export and assign at once"),

110

(r'export.*=', "don't export and assign at once"),

111

(r'^source\b', "don't use 'source', use '.'"),

111

(r'^source\b', "don't use 'source', use '.'"),

112

(r'touch -d', "don't use 'touch -d', use 'touch -t' instead"),

112

(r'touch -d', "don't use 'touch -d', use 'touch -t' instead"),

113

(r'ls +[^|\n-]+ +-', "options to 'ls' must come before filenames"),

113

(r'ls +[^|\n-]+ +-', "options to 'ls' must come before filenames"),

114

(r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),

114

(r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),

115

(r'^stop', "don't use 'stop' as a shell function name"),

115

(r'^stop', "don't use 'stop' as a shell function name"),

116

(r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),

116

(r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),

117

(r'\[\[\s+[^\]]*\]\]', "don't use '[[ ]]', use '[ ]'"),

117

(r'\[\[\s+[^\]]*\]\]', "don't use '[[ ]]', use '[ ]'"),

118

(r'^alias\b.*=', "don't use alias, use a function"),

118

(r'^alias\b.*=', "don't use alias, use a function"),

119

(r'if\s*!', "don't use '!' to negate exit status"),

119

(r'if\s*!', "don't use '!' to negate exit status"),

120

(r'/dev/u?random', "don't use entropy, use /dev/zero"),

120

(r'/dev/u?random', "don't use entropy, use /dev/zero"),

121

(r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"),

121

(r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"),

122

(r'^( *)\t', "don't use tabs to indent"),

122

(r'^( *)\t', "don't use tabs to indent"),

123

(r'sed (-e )?\'(\d+|/[^/]*/)i(?!\\\n)',

123

(r'sed (-e )?\'(\d+|/[^/]*/)i(?!\\\n)',

124

"put a backslash-escaped newline after sed 'i' command"),

124

"put a backslash-escaped newline after sed 'i' command"),

125

(r'^diff *-\w*u.*$\n(^ \$ |^$)', "prefix diff -u with cmp"),

125

(r'^diff *-\w*u.*$\n(^ \$ |^$)', "prefix diff -u with cmp"),

126

(r'seq ', "don't use 'seq', use $TESTDIR/seq.py"),

126

(r'seq ', "don't use 'seq', use $TESTDIR/seq.py"),

127

(r'\butil\.Abort\b', "directly use error.Abort"),

127

(r'\butil\.Abort\b', "directly use error.Abort"),

128

(r'\|&', "don't use |&, use 2>&1"),

128

(r'\|&', "don't use |&, use 2>&1"),

129

],

129

],

130

# warnings

130

# warnings

131

[

131

[

132

(r'^function', "don't use 'function', use old style"),

132

(r'^function', "don't use 'function', use old style"),

133

(r'^diff.*-\w*N', "don't use 'diff -N'"),

133

(r'^diff.*-\w*N', "don't use 'diff -N'"),

134

(r'\$PWD|\${PWD}', "don't use $PWD, use `pwd`"),

134

(r'\$PWD|\${PWD}', "don't use $PWD, use `pwd`"),

135

(r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"),

135

(r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"),

136

(r'kill (`|\$\()', "don't use kill, use killdaemons.py")

136

(r'kill (`|\$\()', "don't use kill, use killdaemons.py")

137

]

137

]

138

]

138

]

139

140

testfilters = [

140

testfilters = [

141

(r"( *)(#([^\n]*\S)?)", repcomment),

141

(r"( *)(#([^\n]*\S)?)", repcomment),

142

(r"<<(\S+)((.|\n)*?\n\1)", rephere),

142

(r"<<(\S+)((.|\n)*?\n\1)", rephere),

143

]

143

]

144

145

winglobmsg = "use (glob) to match Windows paths too"

145

winglobmsg = "use (glob) to match Windows paths too"

146

uprefix = r"^ \$ "

146

uprefix = r"^ \$ "

147

utestpats = [

147

utestpats = [

148

[

148

[

149

(r'^(\S.*|| [$>] .*)[ \t]\n', "trailing whitespace on non-output"),

149

(r'^(\S.*|| [$>] .*)[ \t]\n', "trailing whitespace on non-output"),

150

(uprefix + r'.*\|\s*sed[^|>\n]*\n',

150

(uprefix + r'.*\|\s*sed[^|>\n]*\n',

151

"use regex test output patterns instead of sed"),

151

"use regex test output patterns instead of sed"),

152

(uprefix + r'(true|exit 0)', "explicit zero exit unnecessary"),

152

(uprefix + r'(true|exit 0)', "explicit zero exit unnecessary"),

153

(uprefix + r'.*(?<!\[)\$\?', "explicit exit code checks unnecessary"),

153

(uprefix + r'.*(?<!\[)\$\?', "explicit exit code checks unnecessary"),

154

(uprefix + r'.*\|\| echo.*(fail|error)',

154

(uprefix + r'.*\|\| echo.*(fail|error)',

155

"explicit exit code checks unnecessary"),

155

"explicit exit code checks unnecessary"),

156

(uprefix + r'set -e', "don't use set -e"),

156

(uprefix + r'set -e', "don't use set -e"),

157

(uprefix + r'(\s|fi\b|done\b)', "use > for continued lines"),

157

(uprefix + r'(\s|fi\b|done\b)', "use > for continued lines"),

158

(uprefix + r'.*:\.\S*/', "x:.y in a path does not work on msys, rewrite "

158

(uprefix + r'.*:\.\S*/', "x:.y in a path does not work on msys, rewrite "

159

"as x://.y, or see `hg log -k msys` for alternatives", r'-\S+:\.|' #-Rxxx

159

"as x://.y, or see `hg log -k msys` for alternatives", r'-\S+:\.|' #-Rxxx

160

'# no-msys'), # in test-pull.t which is skipped on windows

160

'# no-msys'), # in test-pull.t which is skipped on windows

161

(r'^ saved backup bundle to \$TESTTMP.*\.hg$', winglobmsg),

161

(r'^ saved backup bundle to \$TESTTMP.*\.hg$', winglobmsg),

162

(r'^ changeset .* references (corrupted|missing) \$TESTTMP/.*[^)]$',

162

(r'^ changeset .* references (corrupted|missing) \$TESTTMP/.*[^)]$',

163

winglobmsg),

163

winglobmsg),

164

(r'^ pulling from \$TESTTMP/.*[^)]$', winglobmsg,

164

(r'^ pulling from \$TESTTMP/.*[^)]$', winglobmsg,

165

'\$TESTTMP/unix-repo$'), # in test-issue1802.t which skipped on windows

165

'\$TESTTMP/unix-repo$'), # in test-issue1802.t which skipped on windows

166

(r'^ reverting (?!subrepo ).*/.*[^)]$', winglobmsg),

166

(r'^ reverting (?!subrepo ).*/.*[^)]$', winglobmsg),

167

(r'^ cloning subrepo \S+/.*[^)]$', winglobmsg),

167

(r'^ cloning subrepo \S+/.*[^)]$', winglobmsg),

168

(r'^ pushing to \$TESTTMP/.*[^)]$', winglobmsg),

168

(r'^ pushing to \$TESTTMP/.*[^)]$', winglobmsg),

169

(r'^ pushing subrepo \S+/\S+ to.*[^)]$', winglobmsg),

169

(r'^ pushing subrepo \S+/\S+ to.*[^)]$', winglobmsg),

170

(r'^ moving \S+/.*[^)]$', winglobmsg),

170

(r'^ moving \S+/.*[^)]$', winglobmsg),

171

(r'^ no changes made to subrepo since.*/.*[^)]$', winglobmsg),

171

(r'^ no changes made to subrepo since.*/.*[^)]$', winglobmsg),

172

(r'^ .*: largefile \S+ not available from file:.*/.*[^)]$', winglobmsg),

172

(r'^ .*: largefile \S+ not available from file:.*/.*[^)]$', winglobmsg),

173

(r'^ .*file://\$TESTTMP',

173

(r'^ .*file://\$TESTTMP',

174

'write "file:/*/$TESTTMP" + (glob) to match on windows too'),

174

'write "file:/*/$TESTTMP" + (glob) to match on windows too'),

175

(r'^ (cat|find): .*: No such file or directory',

175

(r'^ (cat|find): .*: No such file or directory',

176

'use test -f to test for file existence'),

176

'use test -f to test for file existence'),

177

],

177

],

178

# warnings

178

# warnings

179

[

179

[

180

(r'^ [^*?/\n]* $glob$$',

180

(r'^ [^*?/\n]* $glob$$',

181

"glob match with no glob character (?*/)"),

181

"glob match with no glob character (?*/)"),

182

]

182

]

183

]

183

]

184

185

for i in [0, 1]:

185

for i in [0, 1]:

186

for tp in testpats[i]:

186

for tp in testpats[i]:

187

p = tp[0]

187

p = tp[0]

188

m = tp[1]

188

m = tp[1]

189

if p.startswith(r'^'):

189

if p.startswith(r'^'):

190

p = r"^ [$>] (%s)" % p[1:]

190

p = r"^ [$>] (%s)" % p[1:]

191

else:

191

else:

192

p = r"^ [$>] .*(%s)" % p

192

p = r"^ [$>] .*(%s)" % p

193

utestpats[i].append((p, m) + tp[2:])

193

utestpats[i].append((p, m) + tp[2:])

194

195

utestfilters = [

195

utestfilters = [

196

(r"<<(\S+)((.|\n)*?\n > \1)", rephere),

196

(r"<<(\S+)((.|\n)*?\n > \1)", rephere),

197

(r"( *)(#([^\n]*\S)?)", repcomment),

197

(r"( *)(#([^\n]*\S)?)", repcomment),

198

]

198

]

199

200

pypats = [

200

pypats = [

201

[

201

[

202

(r'\([^)]*\*\w[^()]+\w+=', "can't pass varargs with keyword in Py2.5"),

203

(r'^\s*def\s*\w+\s*\(.*,\s*\(',

202

(r'^\s*def\s*\w+\s*\(.*,\s*\(',

204

"tuple parameter unpacking not available in Python 3+"),

203

"tuple parameter unpacking not available in Python 3+"),

205

(r'lambda\s*$.*,.*$',

204

(r'lambda\s*$.*,.*$',

206

"tuple parameter unpacking not available in Python 3+"),

205

"tuple parameter unpacking not available in Python 3+"),

207

(r'import (.+,[^.]+\.[^.]+|[^.]+\.[^.]+,)',

206

(r'import (.+,[^.]+\.[^.]+|[^.]+\.[^.]+,)',

208

'2to3 can\'t always rewrite "import qux, foo.bar", '

207

'2to3 can\'t always rewrite "import qux, foo.bar", '

209

'use "import foo.bar" on its own line instead.'),

208

'use "import foo.bar" on its own line instead.'),

210

(r'(?<!def)\s+(cmp)\(', "cmp is not available in Python 3+"),

209

(r'(?<!def)\s+(cmp)\(', "cmp is not available in Python 3+"),

211

(r'\breduce\s*\(.*', "reduce is not available in Python 3+"),

210

(r'\breduce\s*\(.*', "reduce is not available in Python 3+"),

212

(r'dict\(.*=', 'dict() is different in Py2 and 3 and is slower than {}',

211

(r'dict\(.*=', 'dict() is different in Py2 and 3 and is slower than {}',

213

'dict-from-generator'),

212

'dict-from-generator'),

214

(r'\.has_key\b', "dict.has_key is not available in Python 3+"),

213

(r'\.has_key\b', "dict.has_key is not available in Python 3+"),

215

(r'\s<>\s', '<> operator is not available in Python 3+, use !='),

214

(r'\s<>\s', '<> operator is not available in Python 3+, use !='),

216

(r'^\s*\t', "don't use tabs"),

215

(r'^\s*\t', "don't use tabs"),

217

(r'\S;\s*\n', "semicolon"),

216

(r'\S;\s*\n', "semicolon"),

218

(r'[^_]_\([ \t\n]*(?:"[^"]+"[ \t\n+]*)+%', "don't use % inside _()"),

217

(r'[^_]_\([ \t\n]*(?:"[^"]+"[ \t\n+]*)+%', "don't use % inside _()"),

219

(r"[^_]_\([ \t\n]*(?:'[^']+'[ \t\n+]*)+%", "don't use % inside _()"),

218

(r"[^_]_\([ \t\n]*(?:'[^']+'[ \t\n+]*)+%", "don't use % inside _()"),

220

(r'(\w|\)),\w', "missing whitespace after ,"),

219

(r'(\w|\)),\w', "missing whitespace after ,"),

221

(r'(\w|\))[+/*\-<>]\w', "missing whitespace in expression"),

220

(r'(\w|\))[+/*\-<>]\w', "missing whitespace in expression"),

222

(r'^\s+(\w|\.)+=\w[^,()\n]*$', "missing whitespace in assignment"),

221

(r'^\s+(\w|\.)+=\w[^,()\n]*$', "missing whitespace in assignment"),

223

(r'.{81}', "line too long"),

222

(r'.{81}', "line too long"),

224

(r' x+[xo][\'"]\n\s+[\'"]x', 'string join across lines with no space'),

223

(r' x+[xo][\'"]\n\s+[\'"]x', 'string join across lines with no space'),

225

(r'[^\n]\Z', "no trailing newline"),

224

(r'[^\n]\Z', "no trailing newline"),

226

(r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),

225

(r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),

227

# (r'^\s+[^_ \n][^_. \n]+_[^_\n]+\s*=',

226

# (r'^\s+[^_ \n][^_. \n]+_[^_\n]+\s*=',

228

# "don't use underbars in identifiers"),

227

# "don't use underbars in identifiers"),

229

(r'^\s+(self\.)?[A-za-z][a-z0-9]+[A-Z]\w* = ',

228

(r'^\s+(self\.)?[A-za-z][a-z0-9]+[A-Z]\w* = ',

230

"don't use camelcase in identifiers"),

229

"don't use camelcase in identifiers"),

231

230

232

"linebreak after :"),

231

"linebreak after :"),

233

(r'class\s[^( \n]+:', "old-style class, use class foo(object)"),

232

(r'class\s[^( \n]+:', "old-style class, use class foo(object)"),

234

(r'class\s[^( \n]+:',

233

(r'class\s[^( \n]+:',

235

"class foo() creates old style object, use class foo(object)"),

234

"class foo() creates old style object, use class foo(object)"),

236

(r'\b(%s)\(' % '|'.join(k for k in keyword.kwlist

235

(r'\b(%s)\(' % '|'.join(k for k in keyword.kwlist

237

if k not in ('print', 'exec')),

236

if k not in ('print', 'exec')),

238

"Python keyword is not a function"),

237

"Python keyword is not a function"),

239

(r',]', "unneeded trailing ',' in list"),

238

(r',]', "unneeded trailing ',' in list"),

240

# (r'class\s[A-Z][^\(]*\((?!Exception)',

239

# (r'class\s[A-Z][^\(]*\((?!Exception)',

241

# "don't capitalize non-exception classes"),

240

# "don't capitalize non-exception classes"),

242

# (r'in range\(', "use xrange"),

241

# (r'in range\(', "use xrange"),

243

# (r'^\s*print\s+', "avoid using print in core and extensions"),

242

# (r'^\s*print\s+', "avoid using print in core and extensions"),

244

(r'[\x80-\xff]', "non-ASCII character literal"),

243

(r'[\x80-\xff]', "non-ASCII character literal"),

245

(r'("\')\.format\(', "str.format() has no bytes counterpart, use %"),

244

(r'("\')\.format\(', "str.format() has no bytes counterpart, use %"),

246

(r'^\s*(%s)\s\s' % '|'.join(keyword.kwlist),

245

(r'^\s*(%s)\s\s' % '|'.join(keyword.kwlist),

247

"gratuitous whitespace after Python keyword"),

246

"gratuitous whitespace after Python keyword"),

248

(r'([$\[][ \t]\S)|(\S[ \t][$\]])', "gratuitous whitespace in () or []"),

247

(r'([$\[][ \t]\S)|(\S[ \t][$\]])', "gratuitous whitespace in () or []"),

249

# (r'\s\s=', "gratuitous whitespace before ="),

248

# (r'\s\s=', "gratuitous whitespace before ="),

250

(r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S',

249

(r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S',

251

"missing whitespace around operator"),

250

"missing whitespace around operator"),

252

(r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\s',

251

(r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\s',

253

"missing whitespace around operator"),

252

"missing whitespace around operator"),

254

(r'\s(\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S',

253

(r'\s(\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S',

255

"missing whitespace around operator"),

254

"missing whitespace around operator"),

256

(r'[^^+=*/!<>&| %-](\s=|=\s)[^= ]',

255

(r'[^^+=*/!<>&| %-](\s=|=\s)[^= ]',

257

"wrong whitespace around ="),

256

"wrong whitespace around ="),

258

(r'\([^()]*( =[^=]|[^<>!=]= )',

257

(r'\([^()]*( =[^=]|[^<>!=]= )',

259

"no whitespace around = for named parameters"),

258

"no whitespace around = for named parameters"),

260

(r'raise Exception', "don't raise generic exceptions"),

259

(r'raise Exception', "don't raise generic exceptions"),

261

(r'raise [^,(]+, ($[^$]+\)|[^,]+)$',

260

(r'raise [^,(]+, ($[^$]+\)|[^,]+)$',

262

"don't use old-style two-argument raise, use Exception(message)"),

261

"don't use old-style two-argument raise, use Exception(message)"),

263

(r' is\s+(not\s+)?["\'0-9-]', "object comparison with literal"),

262

(r' is\s+(not\s+)?["\'0-9-]', "object comparison with literal"),

264

(r' [=!]=\s+(True|False|None)',

263

(r' [=!]=\s+(True|False|None)',

265

"comparison with singleton, use 'is' or 'is not' instead"),

264

"comparison with singleton, use 'is' or 'is not' instead"),

266

(r'^\s*(while|if) [01]:',

265

(r'^\s*(while|if) [01]:',

267

"use True/False for constant Boolean expression"),

266

"use True/False for constant Boolean expression"),

268

(r'(?:(?<!def)\s+|\()hasattr',

267

(r'(?:(?<!def)\s+|\()hasattr',

269

'hasattr(foo, bar) is broken, use util.safehasattr(foo, bar) instead'),

268

'hasattr(foo, bar) is broken, use util.safehasattr(foo, bar) instead'),

270

(r'opener$[^)]*$.read\(',

269

(r'opener$[^)]*$.read\(',

271

"use opener.read() instead"),

270

"use opener.read() instead"),

272

(r'opener$[^)]*$.write\(',

271

(r'opener$[^)]*$.write\(',

273

"use opener.write() instead"),

272

"use opener.write() instead"),

274

(r'[\s$](open|file)\([^)]*$\.read\(',

273

(r'[\s$](open|file)\([^)]*$\.read\(',

275

"use util.readfile() instead"),

274

"use util.readfile() instead"),

276

(r'[\s$](open|file)\([^)]*$\.write\(',

275

(r'[\s$](open|file)\([^)]*$\.write\(',

277

"use util.writefile() instead"),

276

"use util.writefile() instead"),

278

(r'^[\s$]*(open(er)?|file)\([^)]*$',

277

(r'^[\s$]*(open(er)?|file)\([^)]*$',

279

"always assign an opened file to a variable, and close it afterwards"),

278

"always assign an opened file to a variable, and close it afterwards"),

280

(r'[\s$](open|file)\([^)]*$\.',

279

(r'[\s$](open|file)\([^)]*$\.',

281

"always assign an opened file to a variable, and close it afterwards"),

280

"always assign an opened file to a variable, and close it afterwards"),

282

(r'(?i)descend[e]nt', "the proper spelling is descendAnt"),

281

(r'(?i)descend[e]nt', "the proper spelling is descendAnt"),

283

(r'\.debug\(\_', "don't mark debug messages for translation"),

282

(r'\.debug\(\_', "don't mark debug messages for translation"),

284

(r'\.strip\.split', "no need to strip before splitting"),

283

(r'\.strip\.split', "no need to strip before splitting"),

285

(r'^\s*except\s*:', "naked except clause", r'#.*re-raises'),

284

(r'^\s*except\s*:', "naked except clause", r'#.*re-raises'),

286

(r'^\s*except\s([^$,]+|\([^$]+\))\s*,',

285

(r'^\s*except\s([^$,]+|\([^$]+\))\s*,',

287

'legacy exception syntax; use "as" instead of ","'),

286

'legacy exception syntax; use "as" instead of ","'),

288

(r':\n( )*( ){1,3}[^ ]', "must indent 4 spaces"),

287

(r':\n( )*( ){1,3}[^ ]', "must indent 4 spaces"),

289

(r'ui\.(status|progress|write|note|warn)\([\'\"]x',

288

(r'ui\.(status|progress|write|note|warn)\([\'\"]x',

290

"missing _() in ui message (use () to hide false-positives)"),

289

"missing _() in ui message (use () to hide false-positives)"),

291

(r'release$.*wlock, .*lock$', "wrong lock release order"),

290

(r'release$.*wlock, .*lock$', "wrong lock release order"),

292

(r'\b__bool__\b', "__bool__ should be __nonzero__ in Python 2"),

291

(r'\b__bool__\b', "__bool__ should be __nonzero__ in Python 2"),

293

(r'os\.path\.join$.*, *(""|\'\')$',

292

(r'os\.path\.join$.*, *(""|\'\')$',

294

"use pathutil.normasprefix(path) instead of os.path.join(path, '')"),

293

"use pathutil.normasprefix(path) instead of os.path.join(path, '')"),

295

(r'\s0[0-7]+\b', 'legacy octal syntax; use "0o" prefix instead of "0"'),

294

(r'\s0[0-7]+\b', 'legacy octal syntax; use "0o" prefix instead of "0"'),

296

# XXX only catch mutable arguments on the first line of the definition

295

# XXX only catch mutable arguments on the first line of the definition

297

(r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),

296

(r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),

298

(r'\butil\.Abort\b', "directly use error.Abort"),

297

(r'\butil\.Abort\b', "directly use error.Abort"),

299

],

298

],

300

# warnings

299

# warnings

301

[

300

[

302

(r'(^| )pp +xxxxqq[ \n][^\n]', "add two newlines after '.. note::'"),

301

(r'(^| )pp +xxxxqq[ \n][^\n]', "add two newlines after '.. note::'"),

303

]

302

]

304

]

303

]

305

304

306

pyfilters = [

305

pyfilters = [

307

(r"""(?msx)(?P<comment>\#.*?$)|

306

(r"""(?msx)(?P<comment>\#.*?$)|

308

((?P<quote>('''|\"\"\"|(?<!')'(?!')|(?<!")"(?!")))

307

((?P<quote>('''|\"\"\"|(?<!')'(?!')|(?<!")"(?!")))

309

(?P<text>(([^\\]|\\.)*?))

308

(?P<text>(([^\\]|\\.)*?))

310

(?P=quote))""", reppython),

309

(?P=quote))""", reppython),

311

]

310

]

312

311

313

txtfilters = []

312

txtfilters = []

314

313

315

txtpats = [

314

txtpats = [

316

[

315

[

317

('\s$', 'trailing whitespace'),

316

('\s$', 'trailing whitespace'),

318

('.. note::[ \n][^\n]', 'add two newlines after note::')

317

('.. note::[ \n][^\n]', 'add two newlines after note::')

319

],

318

],

320

[]

319

[]

321

]

320

]

322

321

323

cpats = [

322

cpats = [

324

[

323

[

325

(r'//', "don't use //-style comments"),

324

(r'//', "don't use //-style comments"),

326

(r'^ ', "don't use spaces to indent"),

325

(r'^ ', "don't use spaces to indent"),

327

(r'\S\t', "don't use tabs except for indent"),

326

(r'\S\t', "don't use tabs except for indent"),

328

(r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),

327

(r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),

329

(r'.{81}', "line too long"),

328

(r'.{81}', "line too long"),

330

(r'(while|if|do|for)\(', "use space after while/if/do/for"),

329

(r'(while|if|do|for)\(', "use space after while/if/do/for"),

331

(r'return\(', "return is not a function"),

330

(r'return\(', "return is not a function"),

332

(r' ;', "no space before ;"),

331

(r' ;', "no space before ;"),

333

(r'[^;] \)', "no space before )"),

332

(r'[^;] \)', "no space before )"),

334

(r'[)][{]', "space between ) and {"),

333

(r'[)][{]', "space between ) and {"),

335

(r'\w+\* \w+', "use int *foo, not int* foo"),

334

(r'\w+\* \w+', "use int *foo, not int* foo"),

336

(r'\W$[^$]+\) \w+', "use (int)foo, not (int) foo"),

335

(r'\W$[^$]+\) \w+', "use (int)foo, not (int) foo"),

337

(r'\w+ (\+\+|--)', "use foo++, not foo ++"),

336

(r'\w+ (\+\+|--)', "use foo++, not foo ++"),

338

(r'\w,\w', "missing whitespace after ,"),

337

(r'\w,\w', "missing whitespace after ,"),

339

(r'^[^#]\w[+/*]\w', "missing whitespace in expression"),

338

(r'^[^#]\w[+/*]\w', "missing whitespace in expression"),

340

(r'^#\s+\w', "use #foo, not # foo"),

339

(r'^#\s+\w', "use #foo, not # foo"),

341

(r'[^\n]\Z', "no trailing newline"),

340

(r'[^\n]\Z', "no trailing newline"),

342

(r'^\s*#import\b', "use only #include in standard C code"),

341

(r'^\s*#import\b', "use only #include in standard C code"),

343

],

342

],

344

# warnings

343

# warnings

345

[]

344

[]

346

]

345

]

347

346

348

cfilters = [

347

cfilters = [

349

(r'(/\*)(((\*(?!/))|[^*])*)\*/', repccomment),

348

(r'(/\*)(((\*(?!/))|[^*])*)\*/', repccomment),

350

(r'''(?P<quote>(?<!")")(?P<text>([^"]|\\")+)"(?!")''', repquote),

349

(r'''(?P<quote>(?<!")")(?P<text>([^"]|\\")+)"(?!")''', repquote),

351

(r'''(#\s*include\s+<)([^>]+)>''', repinclude),

350

(r'''(#\s*include\s+<)([^>]+)>''', repinclude),

352

(r'($)([^)]+$)', repcallspaces),

351

(r'($)([^)]+$)', repcallspaces),

353

]

352

]

354

353

355

inutilpats = [

354

inutilpats = [

356

[

355

[

357

(r'\bui\.', "don't use ui in util"),

356

(r'\bui\.', "don't use ui in util"),

358

],

357

],

359

# warnings

358

# warnings

360

[]

359

[]

361

]

360

]

362

361

363

inrevlogpats = [

362

inrevlogpats = [

364

[

363

[

365

(r'\brepo\.', "don't use repo in revlog"),

364

(r'\brepo\.', "don't use repo in revlog"),

366

],

365

],

367

# warnings

366

# warnings

368

[]

367

[]

369

]

368

]

370

369

371

webtemplatefilters = []

370

webtemplatefilters = []

372

371

373

webtemplatepats = [

372

webtemplatepats = [

374

[],

373

[],

375

[

374

[

376

(r'{desc(\|(?!websub|firstline)[^\|]*)+}',

375

(r'{desc(\|(?!websub|firstline)[^\|]*)+}',

377

'follow desc keyword with either firstline or websub'),

376

'follow desc keyword with either firstline or websub'),

378

]

377

]

379

]

378

]

380

379

381

checks = [

380

checks = [

382

('python', r'.*\.(py|cgi)$', r'^#!.*python', pyfilters, pypats),

381

('python', r'.*\.(py|cgi)$', r'^#!.*python', pyfilters, pypats),

383

('test script', r'(.*/)?test-[^.~]*$', '', testfilters, testpats),

382

('test script', r'(.*/)?test-[^.~]*$', '', testfilters, testpats),

384

('c', r'.*\.[ch]$', '', cfilters, cpats),

383

('c', r'.*\.[ch]$', '', cfilters, cpats),

385

('unified test', r'.*\.t$', '', utestfilters, utestpats),

384

('unified test', r'.*\.t$', '', utestfilters, utestpats),

386

('layering violation repo in revlog', r'mercurial/revlog\.py', '',

385

('layering violation repo in revlog', r'mercurial/revlog\.py', '',

387

pyfilters, inrevlogpats),

386

pyfilters, inrevlogpats),

388

('layering violation ui in util', r'mercurial/util\.py', '', pyfilters,

387

('layering violation ui in util', r'mercurial/util\.py', '', pyfilters,

389

inutilpats),

388

inutilpats),

390

('txt', r'.*\.txt$', '', txtfilters, txtpats),

389

('txt', r'.*\.txt$', '', txtfilters, txtpats),

391

('web template', r'mercurial/templates/.*\.tmpl', '',

390

('web template', r'mercurial/templates/.*\.tmpl', '',

392

webtemplatefilters, webtemplatepats),

391

webtemplatefilters, webtemplatepats),

393

]

392

]

394

393

395

def _preparepats():

394

def _preparepats():

396

for c in checks:

395

for c in checks:

397

failandwarn = c[-1]

396

failandwarn = c[-1]

398

for pats in failandwarn:

397

for pats in failandwarn:

399

for i, pseq in enumerate(pats):

398

for i, pseq in enumerate(pats):

400

# fix-up regexes for multi-line searches

399

# fix-up regexes for multi-line searches

401

p = pseq[0]

400

p = pseq[0]

402

# \s doesn't match \n

401

# \s doesn't match \n

403

p = re.sub(r'(?<!\\)\\s', r'[ \\t]', p)

402

p = re.sub(r'(?<!\\)\\s', r'[ \\t]', p)

404

# [^...] doesn't match newline

403

# [^...] doesn't match newline

405

p = re.sub(r'(?<!\\)\[\^', r'[^\\n', p)

404

p = re.sub(r'(?<!\\)\[\^', r'[^\\n', p)

406

405

407

pats[i] = (re.compile(p, re.MULTILINE),) + pseq[1:]

406

pats[i] = (re.compile(p, re.MULTILINE),) + pseq[1:]

408

filters = c[3]

407

filters = c[3]

409

for i, flt in enumerate(filters):

408

for i, flt in enumerate(filters):

410

filters[i] = re.compile(flt[0]), flt[1]

409

filters[i] = re.compile(flt[0]), flt[1]

411

_preparepats()

410

_preparepats()

412

411

413

class norepeatlogger(object):

412

class norepeatlogger(object):

414

def __init__(self):

413

def __init__(self):

415

self._lastseen = None

414

self._lastseen = None

416

415

417

def log(self, fname, lineno, line, msg, blame):

416

def log(self, fname, lineno, line, msg, blame):

418

"""print error related a to given line of a given file.

417

"""print error related a to given line of a given file.

419

418

420

The faulty line will also be printed but only once in the case

419

The faulty line will also be printed but only once in the case

421

of multiple errors.

420

of multiple errors.

422

421

423

:fname: filename

422

:fname: filename

424

:lineno: line number

423

:lineno: line number

425

:line: actual content of the line

424

:line: actual content of the line

426

:msg: error message

425

:msg: error message

427

"""

426

"""

428

msgid = fname, lineno, line

427

msgid = fname, lineno, line

429

if msgid != self._lastseen:

428

if msgid != self._lastseen:

430

if blame:

429

if blame:

431

print "%s:%d (%s):" % (fname, lineno, blame)

430

print "%s:%d (%s):" % (fname, lineno, blame)

432

else:

431

else:

433

print "%s:%d:" % (fname, lineno)

432

print "%s:%d:" % (fname, lineno)

434

print " > %s" % line

433

print " > %s" % line

435

self._lastseen = msgid

434

self._lastseen = msgid

436

print " " + msg

435

print " " + msg

437

436

438

_defaultlogger = norepeatlogger()

437

_defaultlogger = norepeatlogger()

439

438

440

def getblame(f):

439

def getblame(f):

441

lines = []

440

lines = []

442

for l in os.popen('hg annotate -un %s' % f):

441

for l in os.popen('hg annotate -un %s' % f):

443

start, line = l.split(':', 1)

442

start, line = l.split(':', 1)

444

user, rev = start.split()

443

user, rev = start.split()

445

lines.append((line[1:-1], user, rev))

444

lines.append((line[1:-1], user, rev))

446

return lines

445

return lines

447

446

448

def checkfile(f, logfunc=_defaultlogger.log, maxerr=None, warnings=False,

447

def checkfile(f, logfunc=_defaultlogger.log, maxerr=None, warnings=False,

449

blame=False, debug=False, lineno=True):

448

blame=False, debug=False, lineno=True):

450

"""checks style and portability of a given file

449

"""checks style and portability of a given file

451

450

452

:f: filepath

451

:f: filepath

453

:logfunc: function used to report error

452

:logfunc: function used to report error

454

logfunc(filename, linenumber, linecontent, errormessage)

453

logfunc(filename, linenumber, linecontent, errormessage)

455

:maxerr: number of error to display before aborting.

454

:maxerr: number of error to display before aborting.

456

Set to false (default) to report all errors

455

Set to false (default) to report all errors

457

456

458

return True if no error is found, False otherwise.

457

return True if no error is found, False otherwise.

459

"""

458

"""

460

blamecache = None

459

blamecache = None

461

result = True

460

result = True

462

461

463

try:

462

try:

464

fp = open(f)

463

fp = open(f)

465

except IOError as e:

464

except IOError as e:

466

print "Skipping %s, %s" % (f, str(e).split(':', 1)[0])

465

print "Skipping %s, %s" % (f, str(e).split(':', 1)[0])

467

return result

466

return result

468

pre = post = fp.read()

467

pre = post = fp.read()

469

fp.close()

468

fp.close()

470

469

471

for name, match, magic, filters, pats in checks:

470

for name, match, magic, filters, pats in checks:

472

if debug:

471

if debug:

473

print name, f

472

print name, f

474

fc = 0

473

fc = 0

475

if not (re.match(match, f) or (magic and re.search(magic, f))):

474

if not (re.match(match, f) or (magic and re.search(magic, f))):

476

if debug:

475

if debug:

477

print "Skipping %s for %s it doesn't match %s" % (

476

print "Skipping %s for %s it doesn't match %s" % (

478

name, match, f)

477

name, match, f)

479

continue

478

continue

480

if "no-" "check-code" in pre:

479

if "no-" "check-code" in pre:

481

print "Skipping %s it has no-" "check-code" % f

480

print "Skipping %s it has no-" "check-code" % f

482

return "Skip" # skip checking this file

481

return "Skip" # skip checking this file

483

for p, r in filters:

482

for p, r in filters:

484

post = re.sub(p, r, post)

483

post = re.sub(p, r, post)

485

nerrs = len(pats[0]) # nerr elements are errors

484

nerrs = len(pats[0]) # nerr elements are errors

486

if warnings:

485

if warnings:

487

pats = pats[0] + pats[1]

486

pats = pats[0] + pats[1]

488

else:

487

else:

489

pats = pats[0]

488

pats = pats[0]

490

# print post # uncomment to show filtered version

489

# print post # uncomment to show filtered version

491

490

492

if debug:

491

if debug:

493

print "Checking %s for %s" % (name, f)

492

print "Checking %s for %s" % (name, f)

494

493

495

prelines = None

494

prelines = None

496

errors = []

495

errors = []

497

for i, pat in enumerate(pats):

496

for i, pat in enumerate(pats):

498

if len(pat) == 3:

497

if len(pat) == 3:

499

p, msg, ignore = pat

498

p, msg, ignore = pat

500

else:

499

else:

501

p, msg = pat

500

p, msg = pat

502

ignore = None

501

ignore = None

503

if i >= nerrs:

502

if i >= nerrs:

504

msg = "warning: " + msg

503

msg = "warning: " + msg

505

504

506

pos = 0

505

pos = 0

507

n = 0

506

n = 0

508

for m in p.finditer(post):

507

for m in p.finditer(post):

509

if prelines is None:

508

if prelines is None:

510

prelines = pre.splitlines()

509

prelines = pre.splitlines()

511

postlines = post.splitlines(True)

510

postlines = post.splitlines(True)

512

511

513

start = m.start()

512

start = m.start()

514

while n < len(postlines):

513

while n < len(postlines):

515

step = len(postlines[n])

514

step = len(postlines[n])

516

if pos + step > start:

515

if pos + step > start:

517

break

516

break

518

pos += step

517

pos += step

519

n += 1

518

n += 1

520

l = prelines[n]

519

l = prelines[n]

521

520

522

if ignore and re.search(ignore, l, re.MULTILINE):

521

if ignore and re.search(ignore, l, re.MULTILINE):

523

if debug:

522

if debug:

524

print "Skipping %s for %s:%s (ignore pattern)" % (

523

print "Skipping %s for %s:%s (ignore pattern)" % (

525

name, f, n)

524

name, f, n)

526

continue

525

continue

527

bd = ""

526

bd = ""

528

if blame:

527

if blame:

529

bd = 'working directory'

528

bd = 'working directory'

530

if not blamecache:

529

if not blamecache:

531

blamecache = getblame(f)

530

blamecache = getblame(f)

532

if n < len(blamecache):

531

if n < len(blamecache):

533

bl, bu, br = blamecache[n]

532

bl, bu, br = blamecache[n]

534

if bl == l:

533

if bl == l:

535

bd = '%s@%s' % (bu, br)

534

bd = '%s@%s' % (bu, br)

536

535

537

errors.append((f, lineno and n + 1, l, msg, bd))

536

errors.append((f, lineno and n + 1, l, msg, bd))

538

result = False

537

result = False

539

538

540

errors.sort()

539

errors.sort()

541

for e in errors:

540

for e in errors:

542

logfunc(*e)

541

logfunc(*e)

543

fc += 1

542

fc += 1

544

if maxerr and fc >= maxerr:

543

if maxerr and fc >= maxerr:

545

print " (too many errors, giving up)"

544

print " (too many errors, giving up)"

546

break

545

break

547

546

548

return result

547

return result

549

548

550

if __name__ == "__main__":

549

if __name__ == "__main__":

551

parser = optparse.OptionParser("%prog [options] [files]")

550

parser = optparse.OptionParser("%prog [options] [files]")

552

parser.add_option("-w", "--warnings", action="store_true",

551

parser.add_option("-w", "--warnings", action="store_true",

553

help="include warning-level checks")

552

help="include warning-level checks")

554

parser.add_option("-p", "--per-file", type="int",

553

parser.add_option("-p", "--per-file", type="int",

555

help="max warnings per file")

554

help="max warnings per file")

556

parser.add_option("-b", "--blame", action="store_true",

555

parser.add_option("-b", "--blame", action="store_true",

557

help="use annotate to generate blame info")

556

help="use annotate to generate blame info")

558

parser.add_option("", "--debug", action="store_true",

557

parser.add_option("", "--debug", action="store_true",

559

help="show debug information")

558

help="show debug information")

560

parser.add_option("", "--nolineno", action="store_false",

559

parser.add_option("", "--nolineno", action="store_false",

561

dest='lineno', help="don't show line numbers")

560

dest='lineno', help="don't show line numbers")

562

561

563

parser.set_defaults(per_file=15, warnings=False, blame=False, debug=False,

562

parser.set_defaults(per_file=15, warnings=False, blame=False, debug=False,

564

lineno=True)

563

lineno=True)

565

(options, args) = parser.parse_args()

564

(options, args) = parser.parse_args()

566

565

567

if len(args) == 0:

566

if len(args) == 0:

568

check = glob.glob("*")

567

check = glob.glob("*")

569

else:

568

else:

570

check = args

569

check = args

571

570

572

ret = 0

571

ret = 0

573

for f in check:

572

for f in check:

574

if not checkfile(f, maxerr=options.per_file, warnings=options.warnings,

573

if not checkfile(f, maxerr=options.per_file, warnings=options.warnings,

575

blame=options.blame, debug=options.debug,

574

blame=options.blame, debug=options.debug,

576

lineno=options.lineno):

575

lineno=options.lineno):

577

ret = 1

576

ret = 1

578

sys.exit(ret)

577

sys.exit(ret)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

             #!/usr/bin/env python
             #
             # check-code - a style and portability checker for Mercurial
             #
             # Copyright 2010 Matt Mackall <mpm@selenic.com>
             #
             # This software may be used and distributed according to the terms of the
             # GNU General Public License version 2 or any later version.
             """style and portability checker for Mercurial
             when a rule triggers wrong, do one of the following (prefer one from top):
              * do the work-around the rule suggests
              * doublecheck that it is a false match
              * improve the rule pattern
              * add an ignore pattern to the rule (3rd arg) which matches your good line
                (you can append a short comment and match this, like: #re-raises, # no-py24)
              * change the pattern to a warning and list the exception in test-check-code-hg
              * ONLY use no--check-code for skipping entire files from external sources
             """
             import re, glob, os, sys
             import keyword
             import optparse
             try:
                 import re2
             except ImportError:
                 re2 = None
             def compilere(pat, multiline=False):
                 if multiline:
                     pat = '(?m)' + pat
                 if re2:
                     try:
                         return re2.compile(pat)
                     except re2.error:
                         pass
                 return re.compile(pat)
             def repquote(m):
                 fromc = '.:'
                 tochr = 'pq'
                 def encodechr(i):
                     if i > 255:
                         return 'u'
                     c = chr(i)
                     if c in ' \n':
                         return c
                     if c.isalpha():
                         return 'x'
                     if c.isdigit():
                         return 'n'
                     try:
                         return tochr[fromc.find(c)]
                     except (ValueError, IndexError):
                         return 'o'
                 t = m.group('text')
                 tt = ''.join(encodechr(i) for i in xrange(256))
                 t = t.translate(tt)
                 return m.group('quote') + t + m.group('quote')
             def reppython(m):
                 comment = m.group('comment')
                 if comment:
                     l = len(comment.rstrip())
                     return "#" * l + comment[l:]
                 return repquote(m)
             def repcomment(m):
                 return m.group(1) + "#" * len(m.group(2))
             def repccomment(m):
                 t = re.sub(r"((?<=\n) )|\S", "x", m.group(2))
                 return m.group(1) + t + "*/"
             def repcallspaces(m):
                 t = re.sub(r"\n\s+", "\n", m.group(2))
                 return m.group(1) + t
             def repinclude(m):
                 return m.group(1) + "<foo>"
             def rephere(m):
                 t = re.sub(r"\S", "x", m.group(2))
                 return m.group(1) + t
             testpats = [
               [
                 (r'pushd|popd', "don't use 'pushd' or 'popd', use 'cd'"),
                 (r'\W\$?\(\([^\)\n]*\)\)', "don't use (()) or $(()), use 'expr'"),
                 (r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"),
                 (r'(?<!hg )grep.*-a', "don't use 'grep -a', use in-line python"),
                 (r'sed.*-i', "don't use 'sed -i', use a temporary file"),
                 (r'\becho\b.*\\n', "don't use 'echo \\n', use printf"),
                 (r'echo -n', "don't use 'echo -n', use printf"),
                 (r'(^|\|\s*)\bwc\b[^|]*$\n(?!.*\(re\))', "filter wc output"),
                 (r'head -c', "don't use 'head -c', use 'dd'"),
                 (r'tail -n', "don't use the '-n' option to tail, just use '-<num>'"),
                 (r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"),
                 (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"),
                 (r'printf.*[^\\]\\([1-9]|0\d)', "don't use 'printf \NNN', use Python"),
                 (r'printf.*[^\\]\\x', "don't use printf \\x, use Python"),
                 (r'\$\(.*\)', "don't use $(expr), use `expr`"),
                 (r'rm -rf \*', "don't use naked rm -rf, target a directory"),
                 (r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w',
                  "use egrep for extended grep syntax"),
                 (r'/bin/', "don't use explicit paths for tools"),
                 (r'[^\n]\Z', "no trailing newline"),
                 (r'export.*=', "don't export and assign at once"),
                 (r'^source\b', "don't use 'source', use '.'"),
                 (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"),
                 (r'ls +[^|\n-]+ +-', "options to 'ls' must come before filenames"),
                 (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),
                 (r'^stop\(\)', "don't use 'stop' as a shell function name"),
                 (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),
                 (r'\[\[\s+[^\]]*\]\]', "don't use '[[ ]]', use '[ ]'"),
                 (r'^alias\b.*=', "don't use alias, use a function"),
                 (r'if\s*!', "don't use '!' to negate exit status"),
                 (r'/dev/u?random', "don't use entropy, use /dev/zero"),
                 (r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"),
                 (r'^( *)\t', "don't use tabs to indent"),
                 (r'sed (-e )?\'(\d+|/[^/]*/)i(?!\\\n)',
                  "put a backslash-escaped newline after sed 'i' command"),
                 (r'^diff *-\w*u.*$\n(^  \$ |^$)', "prefix diff -u with cmp"),
                 (r'seq ', "don't use 'seq', use $TESTDIR/seq.py"),
                 (r'\butil\.Abort\b', "directly use error.Abort"),
                 (r'\|&', "don't use |&, use 2>&1"),
               ],
               # warnings
               [
                 (r'^function', "don't use 'function', use old style"),
                 (r'^diff.*-\w*N', "don't use 'diff -N'"),
                 (r'\$PWD|\${PWD}', "don't use $PWD, use `pwd`"),
                 (r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"),
                 (r'kill (`|\$\()', "don't use kill, use killdaemons.py")
               ]
             ]
             testfilters = [
                 (r"( *)(#([^\n]*\S)?)", repcomment),
                 (r"<<(\S+)((.|\n)*?\n\1)", rephere),
             ]
             winglobmsg = "use (glob) to match Windows paths too"
             uprefix = r"^  \$ "
             utestpats = [
               [
                 (r'^(\S.*||  [$>] .*)[ \t]\n', "trailing whitespace on non-output"),
                 (uprefix + r'.*\|\s*sed[^|>\n]*\n',
                  "use regex test output patterns instead of sed"),
                 (uprefix + r'(true|exit 0)', "explicit zero exit unnecessary"),
                 (uprefix + r'.*(?<!\[)\$\?', "explicit exit code checks unnecessary"),
                 (uprefix + r'.*\|\| echo.*(fail|error)',
                  "explicit exit code checks unnecessary"),
                 (uprefix + r'set -e', "don't use set -e"),
                 (uprefix + r'(\s|fi\b|done\b)', "use > for continued lines"),
                 (uprefix + r'.*:\.\S*/', "x:.y in a path does not work on msys, rewrite "
                  "as x://.y, or see `hg log -k msys` for alternatives", r'-\S+:\.|' #-Rxxx
                  '# no-msys'), # in test-pull.t which is skipped on windows
                 (r'^  saved backup bundle to \$TESTTMP.*\.hg$', winglobmsg),
                 (r'^  changeset .* references (corrupted|missing) \$TESTTMP/.*[^)]$',
                  winglobmsg),
                 (r'^  pulling from \$TESTTMP/.*[^)]$', winglobmsg,
                  '\$TESTTMP/unix-repo$'), # in test-issue1802.t which skipped on windows
                 (r'^  reverting (?!subrepo ).*/.*[^)]$', winglobmsg),
                 (r'^  cloning subrepo \S+/.*[^)]$', winglobmsg),
                 (r'^  pushing to \$TESTTMP/.*[^)]$', winglobmsg),
                 (r'^  pushing subrepo \S+/\S+ to.*[^)]$', winglobmsg),
                 (r'^  moving \S+/.*[^)]$', winglobmsg),
                 (r'^  no changes made to subrepo since.*/.*[^)]$', winglobmsg),
                 (r'^  .*: largefile \S+ not available from file:.*/.*[^)]$', winglobmsg),
                 (r'^  .*file://\$TESTTMP',
                  'write "file:/*/$TESTTMP" + (glob) to match on windows too'),
                 (r'^  (cat|find): .*: No such file or directory',
                  'use test -f to test for file existence'),
               ],
               # warnings
               [
                 (r'^  [^*?/\n]* \(glob\)$',
                  "glob match with no glob character (?*/)"),
               ]
             ]
             for i in [0, 1]:
                 for tp in testpats[i]:
                     p = tp[0]
                     m = tp[1]
                     if p.startswith(r'^'):
                         p = r"^  [$>] (%s)" % p[1:]
                     else:
                         p = r"^  [$>] .*(%s)" % p
                     utestpats[i].append((p, m) + tp[2:])
             utestfilters = [
                 (r"<<(\S+)((.|\n)*?\n  > \1)", rephere),
                 (r"( *)(#([^\n]*\S)?)", repcomment),
             ]
             pypats = [
               [
-                (r'\([^)]*\*\w[^()]+\w+=', "can't pass varargs with keyword in Py2.5"),
                 (r'^\s*def\s*\w+\s*\(.*,\s*\(',
                  "tuple parameter unpacking not available in Python 3+"),
                 (r'lambda\s*\(.*,.*\)',
                  "tuple parameter unpacking not available in Python 3+"),
                 (r'import (.+,[^.]+\.[^.]+|[^.]+\.[^.]+,)',
                  '2to3 can\'t always rewrite "import qux, foo.bar", '
                  'use "import foo.bar" on its own line instead.'),
                 (r'(?<!def)\s+(cmp)\(', "cmp is not available in Python 3+"),
                 (r'\breduce\s*\(.*', "reduce is not available in Python 3+"),
                 (r'dict\(.*=', 'dict() is different in Py2 and 3 and is slower than {}',
                  'dict-from-generator'),
                 (r'\.has_key\b', "dict.has_key is not available in Python 3+"),
                 (r'\s<>\s', '<> operator is not available in Python 3+, use !='),
                 (r'^\s*\t', "don't use tabs"),
                 (r'\S;\s*\n', "semicolon"),
                 (r'[^_]_\([ \t\n]*(?:"[^"]+"[ \t\n+]*)+%', "don't use % inside _()"),
                 (r"[^_]_\([ \t\n]*(?:'[^']+'[ \t\n+]*)+%", "don't use % inside _()"),
                 (r'(\w|\)),\w', "missing whitespace after ,"),
                 (r'(\w|\))[+/*\-<>]\w', "missing whitespace in expression"),
                 (r'^\s+(\w|\.)+=\w[^,()\n]*$', "missing whitespace in assignment"),
                 (r'.{81}', "line too long"),
                 (r' x+[xo][\'"]\n\s+[\'"]x', 'string join across lines with no space'),
                 (r'[^\n]\Z', "no trailing newline"),
                 (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
             #    (r'^\s+[^_ \n][^_. \n]+_[^_\n]+\s*=',
             #     "don't use underbars in identifiers"),
                 (r'^\s+(self\.)?[A-za-z][a-z0-9]+[A-Z]\w* = ',
                  "don't use camelcase in identifiers"),
                 (r'^\s*(if|while|def|class|except|try)\s[^[\n]*:\s*[^\\n]#\s]+',
                  "linebreak after :"),
                 (r'class\s[^( \n]+:', "old-style class, use class foo(object)"),
                 (r'class\s[^( \n]+\(\):',
                  "class foo() creates old style object, use class foo(object)"),
                 (r'\b(%s)\(' % '|'.join(k for k in keyword.kwlist
                                         if k not in ('print', 'exec')),
                  "Python keyword is not a function"),
                 (r',]', "unneeded trailing ',' in list"),
             #    (r'class\s[A-Z][^\(]*\((?!Exception)',
             #     "don't capitalize non-exception classes"),
             #    (r'in range\(', "use xrange"),
             #    (r'^\s*print\s+', "avoid using print in core and extensions"),
                 (r'[\x80-\xff]', "non-ASCII character literal"),
                 (r'("\')\.format\(', "str.format() has no bytes counterpart, use %"),
                 (r'^\s*(%s)\s\s' % '|'.join(keyword.kwlist),
                  "gratuitous whitespace after Python keyword"),
                 (r'([\(\[][ \t]\S)|(\S[ \t][\)\]])', "gratuitous whitespace in () or []"),
             #    (r'\s\s=', "gratuitous whitespace before ="),
                 (r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S',
                  "missing whitespace around operator"),
                 (r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\s',
                  "missing whitespace around operator"),
                 (r'\s(\+=|-=|!=|<>|<=|>=|<<=|>>=|%=)\S',
                  "missing whitespace around operator"),
                 (r'[^^+=*/!<>&| %-](\s=|=\s)[^= ]',
                  "wrong whitespace around ="),
                 (r'\([^()]*( =[^=]|[^<>!=]= )',
                  "no whitespace around = for named parameters"),
                 (r'raise Exception', "don't raise generic exceptions"),
                 (r'raise [^,(]+, (\([^\)]+\)|[^,\(\)]+)$',
                  "don't use old-style two-argument raise, use Exception(message)"),
                 (r' is\s+(not\s+)?["\'0-9-]', "object comparison with literal"),
                 (r' [=!]=\s+(True|False|None)',
                  "comparison with singleton, use 'is' or 'is not' instead"),
                 (r'^\s*(while|if) [01]:',
                  "use True/False for constant Boolean expression"),
                 (r'(?:(?<!def)\s+|\()hasattr',
                  'hasattr(foo, bar) is broken, use util.safehasattr(foo, bar) instead'),
                 (r'opener\([^)]*\).read\(',
                  "use opener.read() instead"),
                 (r'opener\([^)]*\).write\(',
                  "use opener.write() instead"),
                 (r'[\s\(](open|file)\([^)]*\)\.read\(',
                  "use util.readfile() instead"),
                 (r'[\s\(](open|file)\([^)]*\)\.write\(',
                  "use util.writefile() instead"),
                 (r'^[\s\(]*(open(er)?|file)\([^)]*\)',
                  "always assign an opened file to a variable, and close it afterwards"),
                 (r'[\s\(](open|file)\([^)]*\)\.',
                  "always assign an opened file to a variable, and close it afterwards"),
                 (r'(?i)descend[e]nt', "the proper spelling is descendAnt"),
                 (r'\.debug\(\_', "don't mark debug messages for translation"),
                 (r'\.strip\(\)\.split\(\)', "no need to strip before splitting"),
                 (r'^\s*except\s*:', "naked except clause", r'#.*re-raises'),
                 (r'^\s*except\s([^\(,]+|\([^\)]+\))\s*,',
                  'legacy exception syntax; use "as" instead of ","'),
                 (r':\n(    )*( ){1,3}[^ ]', "must indent 4 spaces"),
                 (r'ui\.(status|progress|write|note|warn)\([\'\"]x',
                  "missing _() in ui message (use () to hide false-positives)"),
                 (r'release\(.*wlock, .*lock\)', "wrong lock release order"),
                 (r'\b__bool__\b', "__bool__ should be __nonzero__ in Python 2"),
                 (r'os\.path\.join\(.*, *(""|\'\')\)',
                  "use pathutil.normasprefix(path) instead of os.path.join(path, '')"),
                 (r'\s0[0-7]+\b', 'legacy octal syntax; use "0o" prefix instead of "0"'),
                 # XXX only catch mutable arguments on the first line of the definition
                 (r'def.*[( ]\w+=\{\}', "don't use mutable default arguments"),
                 (r'\butil\.Abort\b', "directly use error.Abort"),
               ],
               # warnings
               [
                 (r'(^| )pp +xxxxqq[ \n][^\n]', "add two newlines after '.. note::'"),
               ]
             ]
             pyfilters = [
                 (r"""(?msx)(?P<comment>\#.*?$)|
                      ((?P<quote>('''|\"\"\"|(?<!')'(?!')|(?<!")"(?!")))
                       (?P<text>(([^\\]|\\.)*?))
                       (?P=quote))""", reppython),
             ]
             txtfilters = []
             txtpats = [
               [
                 ('\s$', 'trailing whitespace'),
                 ('.. note::[ \n][^\n]', 'add two newlines after note::')
               ],
               []
             ]
             cpats = [
               [
                 (r'//', "don't use //-style comments"),
                 (r'^  ', "don't use spaces to indent"),
                 (r'\S\t', "don't use tabs except for indent"),
                 (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
                 (r'.{81}', "line too long"),
                 (r'(while|if|do|for)\(', "use space after while/if/do/for"),
                 (r'return\(', "return is not a function"),
                 (r' ;', "no space before ;"),
                 (r'[^;] \)', "no space before )"),
                 (r'[)][{]', "space between ) and {"),
                 (r'\w+\* \w+', "use int *foo, not int* foo"),
                 (r'\W\([^\)]+\) \w+', "use (int)foo, not (int) foo"),
                 (r'\w+ (\+\+|--)', "use foo++, not foo ++"),
                 (r'\w,\w', "missing whitespace after ,"),
                 (r'^[^#]\w[+/*]\w', "missing whitespace in expression"),
                 (r'^#\s+\w', "use #foo, not # foo"),
                 (r'[^\n]\Z', "no trailing newline"),
                 (r'^\s*#import\b', "use only #include in standard C code"),
               ],
               # warnings
               []
             ]
             cfilters = [
                 (r'(/\*)(((\*(?!/))|[^*])*)\*/', repccomment),
                 (r'''(?P<quote>(?<!")")(?P<text>([^"]|\\")+)"(?!")''', repquote),
                 (r'''(#\s*include\s+<)([^>]+)>''', repinclude),
                 (r'(\()([^)]+\))', repcallspaces),
             ]
             inutilpats = [
               [
                 (r'\bui\.', "don't use ui in util"),
               ],
               # warnings
               []
             ]
             inrevlogpats = [
               [
                 (r'\brepo\.', "don't use repo in revlog"),
               ],
               # warnings
               []
             ]
             webtemplatefilters = []
             webtemplatepats = [
               [],
               [
                 (r'{desc(\|(?!websub|firstline)[^\|]*)+}',
                  'follow desc keyword with either firstline or websub'),
               ]
             ]
             checks = [
                 ('python', r'.*\.(py|cgi)$', r'^#!.*python', pyfilters, pypats),
                 ('test script', r'(.*/)?test-[^.~]*$', '', testfilters, testpats),
                 ('c', r'.*\.[ch]$', '', cfilters, cpats),
                 ('unified test', r'.*\.t$', '', utestfilters, utestpats),
                 ('layering violation repo in revlog', r'mercurial/revlog\.py', '',
                  pyfilters, inrevlogpats),
                 ('layering violation ui in util', r'mercurial/util\.py', '', pyfilters,
                  inutilpats),
                 ('txt', r'.*\.txt$', '', txtfilters, txtpats),
                 ('web template', r'mercurial/templates/.*\.tmpl', '',
                  webtemplatefilters, webtemplatepats),
             ]
             def _preparepats():
                 for c in checks:
                     failandwarn = c[-1]
                     for pats in failandwarn:
                         for i, pseq in enumerate(pats):
                             # fix-up regexes for multi-line searches
                             p = pseq[0]
                             # \s doesn't match \n
                             p = re.sub(r'(?<!\\)\\s', r'[ \\t]', p)
                             # [^...] doesn't match newline
                             p = re.sub(r'(?<!\\)\[\^', r'[^\\n', p)
                             pats[i] = (re.compile(p, re.MULTILINE),) + pseq[1:]
                     filters = c[3]
                     for i, flt in enumerate(filters):
                         filters[i] = re.compile(flt[0]), flt[1]
             _preparepats()
             class norepeatlogger(object):
                 def __init__(self):
                     self._lastseen = None
                 def log(self, fname, lineno, line, msg, blame):
                     """print error related a to given line of a given file.
                     The faulty line will also be printed but only once in the case
                     of multiple errors.
                     :fname: filename
                     :lineno: line number
                     :line: actual content of the line
                     :msg: error message
                     """
                     msgid = fname, lineno, line
                     if msgid != self._lastseen:
                         if blame:
                             print "%s:%d (%s):" % (fname, lineno, blame)
                         else:
                             print "%s:%d:" % (fname, lineno)
                         print " > %s" % line
                         self._lastseen = msgid
                     print " " + msg
             _defaultlogger = norepeatlogger()
             def getblame(f):
                 lines = []
                 for l in os.popen('hg annotate -un %s' % f):
                     start, line = l.split(':', 1)
                     user, rev = start.split()
                     lines.append((line[1:-1], user, rev))
                 return lines
             def checkfile(f, logfunc=_defaultlogger.log, maxerr=None, warnings=False,
                           blame=False, debug=False, lineno=True):
                 """checks style and portability of a given file
                 :f: filepath
                 :logfunc: function used to report error
                           logfunc(filename, linenumber, linecontent, errormessage)
                 :maxerr: number of error to display before aborting.
                          Set to false (default) to report all errors
                 return True if no error is found, False otherwise.
                 """
                 blamecache = None
                 result = True
                 try:
                     fp = open(f)
                 except IOError as e:
                     print "Skipping %s, %s" % (f, str(e).split(':', 1)[0])
                     return result
                 pre = post = fp.read()
                 fp.close()
                 for name, match, magic, filters, pats in checks:
                     if debug:
                         print name, f
                     fc = 0
                     if not (re.match(match, f) or (magic and re.search(magic, f))):
                         if debug:
                             print "Skipping %s for %s it doesn't match %s" % (
                                    name, match, f)
                         continue
                     if "no-" "check-code" in pre:
                         print "Skipping %s it has no-" "check-code" % f
                         return "Skip" # skip checking this file
                     for p, r in filters:
                         post = re.sub(p, r, post)
                     nerrs = len(pats[0]) # nerr elements are errors
                     if warnings:
                         pats = pats[0] + pats[1]
                     else:
                         pats = pats[0]
                     # print post # uncomment to show filtered version
                     if debug:
                         print "Checking %s for %s" % (name, f)
                     prelines = None
                     errors = []
                     for i, pat in enumerate(pats):
                         if len(pat) == 3:
                             p, msg, ignore = pat
                         else:
                             p, msg = pat
                             ignore = None
                         if i >= nerrs:
                             msg = "warning: " + msg
                         pos = 0
                         n = 0
                         for m in p.finditer(post):
                             if prelines is None:
                                 prelines = pre.splitlines()
                                 postlines = post.splitlines(True)
                             start = m.start()
                             while n < len(postlines):
                                 step = len(postlines[n])
                                 if pos + step > start:
                                     break
                                 pos += step
                                 n += 1
                             l = prelines[n]
                             if ignore and re.search(ignore, l, re.MULTILINE):
                                 if debug:
                                     print "Skipping %s for %s:%s (ignore pattern)" % (
                                         name, f, n)
                                 continue
                             bd = ""
                             if blame:
                                 bd = 'working directory'
                                 if not blamecache:
                                     blamecache = getblame(f)
                                 if n < len(blamecache):
                                     bl, bu, br = blamecache[n]
                                     if bl == l:
                                         bd = '%s@%s' % (bu, br)
                             errors.append((f, lineno and n + 1, l, msg, bd))
                             result = False
                     errors.sort()
                     for e in errors:
                         logfunc(*e)
                         fc += 1
                         if maxerr and fc >= maxerr:
                             print " (too many errors, giving up)"
                             break
                 return result
             if __name__ == "__main__":
                 parser = optparse.OptionParser("%prog [options] [files]")
                 parser.add_option("-w", "--warnings", action="store_true",
                                   help="include warning-level checks")
                 parser.add_option("-p", "--per-file", type="int",
                                   help="max warnings per file")
                 parser.add_option("-b", "--blame", action="store_true",
                                   help="use annotate to generate blame info")
                 parser.add_option("", "--debug", action="store_true",
                                   help="show debug information")
                 parser.add_option("", "--nolineno", action="store_false",
                                   dest='lineno', help="don't show line numbers")
                 parser.set_defaults(per_file=15, warnings=False, blame=False, debug=False,
                                     lineno=True)
                 (options, args) = parser.parse_args()
                 if len(args) == 0:
                     check = glob.glob("*")
                 else:
                     check = args
                 ret = 0
                 for f in check:
                     if not checkfile(f, maxerr=options.per_file, warnings=options.warnings,
                                      blame=options.blame, debug=options.debug,
                                      lineno=options.lineno):
                         ret = 1
                 sys.exit(ret)