Show More
@@ -195,7 +195,7 b' Create a branch that delete a file previ' | |||
|
195 | 195 | |
|
196 | 196 | Merge: |
|
197 | 197 | - one with change to an unrelated file |
|
198 |
- one deleting and recreating the |
|
|
198 | - one deleting and recreating the file | |
|
199 | 199 | |
|
200 | 200 | Note: |
|
201 | 201 | | In this case, the merge get conflicting information since on one side we have |
@@ -294,8 +294,8 b' Merge:' | |||
|
294 | 294 | |
|
295 | 295 | |
|
296 | 296 | Note: |
|
297 | | In this case, the merge get conflicting information since each side have a | |
|
298 | | different way to reach 'f'. | |
|
297 | | In this case, one of the merge wrongly record a merge while there is none. | |
|
298 | | This lead to bad copy tracing information to be dug up. | |
|
299 | 299 | |
|
300 | 300 | final summary |
|
301 | 301 | |
@@ -453,11 +453,8 b' Merge:' | |||
|
453 | 453 | - one deleting and recreating the change |
|
454 | 454 | |
|
455 | 455 | Note: |
|
456 | | In this case, the merge get conflicting information since on one side we have | |
|
457 | | a "brand new" d. and one the other one we have "d renamed from c (itself | |
|
458 | | renamed from c)". | |
|
459 | | | |
|
460 | | The current code arbitrarily pick one side | |
|
456 | | In this case, one of the merge wrongly record a merge while there is none. | |
|
457 | | This lead to bad copy tracing information to be dug up. | |
|
461 | 458 | |
|
462 | 459 | $ hg status --copies --rev 'desc("b-1")' --rev 'desc("mBDm-0")' |
|
463 | 460 | M d |
@@ -475,14 +472,18 b' Note:' | |||
|
475 | 472 | M b |
|
476 | 473 | M d |
|
477 | 474 | |
|
478 | The recorded copy is different depending of where we started the merge from since | |
|
475 | The bugs makes recorded copy is different depending of where we started the merge from since | |
|
479 | 476 | |
|
480 | 477 | $ hg manifest --debug --rev 'desc("mBDm-0")' | grep '644 d' |
|
481 | 478 | 0bb5445dc4d02f4e0d86cf16f9f3a411d0f17744 644 d |
|
482 | 479 | $ hg manifest --debug --rev 'desc("mDBm-0")' | grep '644 d' |
|
483 | 480 | b004912a8510032a0350a74daa2803dadfb00e12 644 d |
|
484 | 481 | |
|
485 | This second b004912a8510032a0350a74daa2803dadfb00e12 seems wrong. We should record the merge | |
|
482 | The 0bb5445dc4d02f4e0d86cf16f9f3a411d0f17744 entry is wrong, since the file was | |
|
483 | deleted on one side (then recreate) and untouched on the other side, no "merge" | |
|
484 | has happened. The resulting `d` file is the untouched version from branch `D`, | |
|
485 | not a merge. | |
|
486 | ||
|
486 | 487 | $ hg manifest --debug --rev 'desc("d-2")' | grep '644 d' |
|
487 | 488 | b004912a8510032a0350a74daa2803dadfb00e12 644 d |
|
488 | 489 | $ hg manifest --debug --rev 'desc("b-1")' | grep '644 d' |
@@ -493,6 +494,8 b' This second b004912a8510032a0350a74daa28' | |||
|
493 | 494 | 1 10 b004912a8510 000000000000 000000000000 |
|
494 | 495 | 2 15 0bb5445dc4d0 01c2f5eabdc4 b004912a8510 |
|
495 | 496 | |
|
497 | (This `hg log` output if wrong, since no merge actually happened). | |
|
498 | ||
|
496 | 499 | $ hg log -Gfr 'desc("mBDm-0")' d |
|
497 | 500 | o 15 mBDm-0 simple merge - one way] |
|
498 | 501 | |\ |
@@ -505,8 +508,7 b' This second b004912a8510032a0350a74daa28' | |||
|
505 | 508 | o 0 i-0 initial commit: a b] |
|
506 | 509 | |
|
507 | 510 | |
|
508 | (That output seems wrong, if we had opportunity to record the merge, we should | |
|
509 | probably have recorded the merge). | |
|
511 | This `hg log` output is correct | |
|
510 | 512 | |
|
511 | 513 |
$ |
|
512 | 514 | o 14 d-2 re-add d] |
General Comments 0
You need to be logged in to leave comments.
Login now