progress: use stderr instead of stdout; check stderr.isatty()

This means that progress bars will continue to show on the terminal
when both stdin and stdout are redirected.

hgext/progress.py

@@ -1,189 +1,192 b''
 # progress.py show progress bars for some actions
 #
 # Copyright (C) 2010 Augie Fackler <[e-mail]>
 #
 # This program is free software; you can redistribute it and/or modify it
 # under the terms of the GNU General Public License as published by the
 # Free Software Foundation; either version 2 of the License, or (at your
 # option) any later version.
 #
 # This program is distributed in the hope that it will be useful, but
 # WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General
 # Public License for more details.
 #
 # You should have received a copy of the GNU General Public License along
 # with this program; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 """show progress bars for some actions
 
 This extension uses the progress information logged by hg commands
 to draw progress bars that are as informative as possible. Some progress
 bars only offer indeterminate information, while others have a definite
 end point.
 
 The following settings are available::
 
   [progress]
   delay = 3 # number of seconds (float) before showing the progress bar
   refresh = 0.1 # time in seconds between refreshes of the progress bar
   format = topic bar number # format of the progress bar
   width = <none> # if set, the maximum width of the progress information
                  # (that is, min(width, term width) will be used)
   clear-complete = True # clear the progress bar after it's done
   disable = False # if true, don't show a progress bar
+  assume-tty = False # if true, ALWAYS show a progress bar, unless
+                     # disable is given
 
 Valid entries for the format field are topic, bar, number, unit, and
 item. item defaults to the last 20 characters of the item, but this
 can be changed by adding either ``-<num>`` which would take the last
 num characters, or ``+<num>`` for the first num characters.
 """
 
 import sys
 import time
 
 from mercurial import extensions
 from mercurial import util
 
 def spacejoin(*args):
     return ' '.join(s for s in args if s)
 
 class progbar(object):
     def __init__(self, ui):
         self.ui = ui
         self.resetstate()
 
     def resetstate(self):
         self.topics = []
         self.printed = False
         self.lastprint = time.time() + float(self.ui.config(
             'progress', 'delay', default=3))
         self.indetcount = 0
         self.refresh = float(self.ui.config(
             'progress', 'refresh', default=0.1))
         self.order = self.ui.configlist(
             'progress', 'format',
             default=['topic', 'bar', 'number'])
 
     def show(self, topic, pos, item, unit, total):
         termwidth = self.width()
         self.printed = True
         head = ''
         needprogress = False
         tail = ''
         for indicator in self.order:
             add = ''
             if indicator == 'topic':
                 add = topic
             elif indicator == 'number':
                 if total:
                     add = ('% ' + str(len(str(total))) +
                            's/%s') % (pos, total)
                 else:
                     add = str(pos)
             elif indicator.startswith('item') and item:
                 slice = 'end'
                 if '-' in indicator:
                     wid = int(indicator.split('-')[1])
                 elif '+' in indicator:
                     slice = 'beginning'
                     wid = int(indicator.split('+')[1])
                 else:
                     wid = 20
                 if slice == 'end':
                     add = item[-wid:]
                 else:
                     add = item[:wid]
                 add += (wid - len(add)) * ' '
             elif indicator == 'bar':
                 add = ''
                 needprogress = True
             elif indicator == 'unit' and unit:
                 add = unit
             if not needprogress:
                 head = spacejoin(head, add)
             else:
                 tail = spacejoin(add, tail)
         if needprogress:
             used = 0
             if head:
                 used += len(head) + 1
             if tail:
                 used += len(tail) + 1
             progwidth = termwidth - used - 3
             if total:
                 amt = pos * progwidth // total
                 bar = '=' * (amt - 1)
                 if amt > 0:
                     bar += '>'
                 bar += ' ' * (progwidth - amt)
             else:
                 progwidth -= 3
                 self.indetcount += 1
                 # mod the count by twice the width so we can make the
                 # cursor bounce between the right and left sides
                 amt = self.indetcount % (2 * progwidth)
                 amt -= progwidth
                 bar = (' ' * int(progwidth - abs(amt)) + '<=>' +
                        ' ' * int(abs(amt)))
             prog = ''.join(('[', bar , ']'))
             out = spacejoin(head, prog, tail)
         else:
             out = spacejoin(head, tail)
-        sys.stdout.write('\r' + out[:termwidth])
-        sys.stdout.flush()
+        sys.stderr.write('\r' + out[:termwidth])
+        sys.stderr.flush()
 
     def clear(self):
-        sys.stdout.write('\r%s\r' % (' ' * self.width()))
+        sys.stderr.write('\r%s\r' % (' ' * self.width()))
 
     def complete(self):
         if self.ui.configbool('progress', 'clear-complete', default=True):
             self.clear()
         else:
-            sys.stdout.write('\n')
-        sys.stdout.flush()
+            sys.stderr.write('\n')
+        sys.stderr.flush()
 
     def width(self):
         tw = util.termwidth()
         return min(int(self.ui.config('progress', 'width', default=tw)), tw)
 
     def progress(self, orig, topic, pos, item='', unit='', total=None):
         if pos is None:
             if self.topics and self.topics[-1] == topic and self.printed:
                 self.complete()
                 self.resetstate()
         else:
             if topic not in self.topics:
                 self.topics.append(topic)
             now = time.time()
             if (now - self.lastprint >= self.refresh
                 and topic == self.topics[-1]):
                 self.lastprint = now
                 self.show(topic, pos, item, unit, total)
         return orig(topic, pos, item=item, unit=unit, total=total)
 
     def write(self, orig, *args):
         if self.printed:
             self.clear()
         return orig(*args)
 
 sharedprog = None
 
 def uisetup(ui):
     # Apps that derive a class from ui.ui() can use
     # setconfig('progress', 'disable', 'True') to disable this extension
     if ui.configbool('progress', 'disable'):
         return
-    if ui.interactive() and not ui.debugflag and not ui.quiet:
+    if ((sys.stderr.isatty() or ui.configbool('progress', 'assume-tty'))
+        and not ui.debugflag and not ui.quiet):
         # we instantiate one globally shared progress bar to avoid
         # competing progress bars when multiple UI objects get created
         global sharedprog
         if not sharedprog:
             sharedprog = progbar(ui)
         extensions.wrapfunction(ui, 'progress', sharedprog.progress)
         extensions.wrapfunction(ui, 'write', sharedprog.write)
         extensions.wrapfunction(ui, 'write_err', sharedprog.write)
 
 def reposetup(ui, repo):
     uisetup(repo.ui)

tests/test-progress

@@ -1,60 +1,59 b''
 #!/bin/sh
 
 cat > loop.py <<EOF
 from mercurial import commands
 
 def loop(ui, loops, **opts):
     loops = int(loops)
     total = None
     if loops >= 0:
         total = loops
     loops = abs(loops)
 
     for i in range(loops):
         ui.progress('loop', i, 'loop.%d' % i, 'loopnum', total)
     ui.progress('loop', None, 'loop.done', 'loopnum', total)
 
 commands.norepo += " loop"
 
 cmdtable = {
     "loop": (loop, [], 'hg loop LOOPS'),
 }
 EOF
 
 cat > filtercr.py <<EOF
 import sys, re
 for line in sys.stdin:
     line = re.sub(r'\r+[^\n]', lambda m: '\n' + m.group()[-1:], line)
     sys.stdout.write(line)
 EOF
 
 echo "[extensions]" >> $HGRCPATH
 echo "progress=" >> $HGRCPATH
 echo "loop=`pwd`/loop.py" >> $HGRCPATH
-echo "[ui]" >> $HGRCPATH
-echo "interactive=1" >> $HGRCPATH
+echo "[progress]" >> $HGRCPATH
+echo "assume-tty=1" >> $HGRCPATH
 
 echo '% test default params, display nothing because of delay'
-hg -y loop 3 | python filtercr.py
+hg -y loop 3 2>&1 | python filtercr.py
 
-echo "[progress]" >> $HGRCPATH
 echo "delay=0" >> $HGRCPATH
 echo "refresh=0" >> $HGRCPATH
 
 echo '% test with delay=0, refresh=0'
-hg -y loop 3 | python filtercr.py
+hg -y loop 3 2>&1 | python filtercr.py
 
 echo '% test refresh is taken in account'
-hg -y --config progress.refresh=100 loop 3 | python filtercr.py
+hg -y --config progress.refresh=100 loop 3 2>&1 | python filtercr.py
 
 echo '% test format options 1'
-hg -y --config 'progress.format=number topic item+2' loop 2 | python filtercr.py
+hg -y --config 'progress.format=number topic item+2' loop 2 2>&1 | python filtercr.py
 
 echo '% test format options 2'
-hg -y --config 'progress.format=number item-3 bar' loop 2 | python filtercr.py
+hg -y --config 'progress.format=number item-3 bar' loop 2 2>&1 | python filtercr.py
 
 echo '% test format options and indeterminate progress'
-hg -y --config 'progress.format=number item bar' loop -- -2 | python filtercr.py
+hg -y --config 'progress.format=number item bar' loop -- -2 2>&1 | python filtercr.py
 
 echo '% test immediate progress completion'
-hg -y loop 0 | python filtercr.py
+hg -y loop 0 2>&1 | python filtercr.py