tests: run most check-code sh checks on continued lines too

Some false errors are degraded to warnings and whitelisted.

contrib/check-code.py

@@ -1,437 +1,438
 #!/usr/bin/env python
 #
 # check-code - a style and portability checker for Mercurial
 #
 # Copyright 2010 Matt Mackall <[e-mail]>
 #
 # This software may be used and distributed according to the terms of the
 # GNU General Public License version 2 or any later version.
 
 import re, glob, os, sys
 import keyword
 import optparse
 
 def repquote(m):
     t = re.sub(r"\w", "x", m.group('text'))
     t = re.sub(r"[^\s\nx]", "o", t)
     return m.group('quote') + t + m.group('quote')
 
 def reppython(m):
     comment = m.group('comment')
     if comment:
         return "#" * len(comment)
     return repquote(m)
 
 def repcomment(m):
     return m.group(1) + "#" * len(m.group(2))
 
 def repccomment(m):
     t = re.sub(r"((?<=\n) )|\S", "x", m.group(2))
     return m.group(1) + t + "*/"
 
 def repcallspaces(m):
     t = re.sub(r"\n\s+", "\n", m.group(2))
     return m.group(1) + t
 
 def repinclude(m):
     return m.group(1) + "<foo>"
 
 def rephere(m):
     t = re.sub(r"\S", "x", m.group(2))
     return m.group(1) + t
 
 
 testpats = [
   [
     (r'pushd|popd', "don't use 'pushd' or 'popd', use 'cd'"),
     (r'\W\$?\(\([^\)\n]*\)\)', "don't use (()) or $(()), use 'expr'"),
-    (r'^function', "don't use 'function', use old style"),
     (r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"),
     (r'sed.*-i', "don't use 'sed -i', use a temporary file"),
     (r'echo.*\\n', "don't use 'echo \\n', use printf"),
     (r'echo -n', "don't use 'echo -n', use printf"),
-    (r'^diff.*-\w*N', "don't use 'diff -N'"),
     (r'(^| )wc[^|]*$\n(?!.*\(re\))', "filter wc output"),
     (r'head -c', "don't use 'head -c', use 'dd'"),
     (r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"),
     (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"),
     (r'printf.*\\([1-9]|0\d)', "don't use 'printf \NNN', use Python"),
     (r'printf.*\\x', "don't use printf \\x, use Python"),
     (r'\$\(.*\)', "don't use $(expr), use `expr`"),
     (r'rm -rf \*', "don't use naked rm -rf, target a directory"),
     (r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w',
      "use egrep for extended grep syntax"),
     (r'/bin/', "don't use explicit paths for tools"),
-    (r'\$PWD', "don't use $PWD, use `pwd`"),
     (r'[^\n]\Z', "no trailing newline"),
     (r'export.*=', "don't export and assign at once"),
-    (r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"),
     (r'^source\b', "don't use 'source', use '.'"),
     (r'touch -d', "don't use 'touch -d', use 'touch -t' instead"),
     (r'ls +[^|\n-]+ +-', "options to 'ls' must come before filenames"),
     (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),
     (r'^stop\(\)', "don't use 'stop' as a shell function name"),
     (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),
     (r'^alias\b.*=', "don't use alias, use a function"),
     (r'if\s*!', "don't use '!' to negate exit status"),
     (r'/dev/u?random', "don't use entropy, use /dev/zero"),
     (r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"),
     (r'^( *)\t', "don't use tabs to indent"),
   ],
   # warnings
-  []
+  [
+    (r'^function', "don't use 'function', use old style"),
+    (r'^diff.*-\w*N', "don't use 'diff -N'"),
+    (r'\$PWD', "don't use $PWD, use `pwd`"),
+    (r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"),
+  ]
 ]
 
 testfilters = [
     (r"( *)(#([^\n]*\S)?)", repcomment),
     (r"<<(\S+)((.|\n)*?\n\1)", rephere),
 ]
 
 uprefix = r"^  \$ "
 utestpats = [
   [
     (r'^(\S|  $ ).*(\S[ \t]+|^[ \t]+)\n', "trailing whitespace on non-output"),
     (uprefix + r'.*\|\s*sed', "use regex test output patterns instead of sed"),
     (uprefix + r'(true|exit 0)', "explicit zero exit unnecessary"),
     (uprefix + r'.*(?<!\[)\$\?', "explicit exit code checks unnecessary"),
     (uprefix + r'.*\|\| echo.*(fail|error)',
      "explicit exit code checks unnecessary"),
     (uprefix + r'set -e', "don't use set -e"),
     (uprefix + r'\s', "don't indent commands, use > for continued lines"),
   ],
   # warnings
   []
 ]
 
 for i in [0, 1]:
     for p, m in testpats[i]:
         if p.startswith(r'^'):
-            p = r"^  \$ (%s)" % p[1:]
+            p = r"^  [$>] (%s)" % p[1:]
         else:
-            p = r"^  \$ .*(%s)" % p
+            p = r"^  [$>] .*(%s)" % p
         utestpats[i].append((p, m))
 
 utestfilters = [
     (r"( *)(#([^\n]*\S)?)", repcomment),
 ]
 
 pypats = [
   [
     (r'^\s*def\s*\w+\s*\(.*,\s*\(',
      "tuple parameter unpacking not available in Python 3+"),
     (r'lambda\s*\(.*,.*\)',
      "tuple parameter unpacking not available in Python 3+"),
     (r'(?<!def)\s+(cmp)\(', "cmp is not available in Python 3+"),
     (r'\breduce\s*\(.*', "reduce is not available in Python 3+"),
     (r'\.has_key\b', "dict.has_key is not available in Python 3+"),
     (r'^\s*\t', "don't use tabs"),
     (r'\S;\s*\n', "semicolon"),
     (r'[^_]_\("[^"]+"\s*%', "don't use % inside _()"),
     (r"[^_]_\('[^']+'\s*%", "don't use % inside _()"),
     (r'\w,\w', "missing whitespace after ,"),
     (r'\w[+/*\-<>]\w', "missing whitespace in expression"),
     (r'^\s+\w+=\w+[^,)\n]$', "missing whitespace in assignment"),
     (r'(\s+)try:\n((?:\n|\1\s.*\n)+?)\1except.*?:\n'
      r'((?:\n|\1\s.*\n)+?)\1finally:', 'no try/except/finally in Py2.4'),
     (r'.{85}', "line too long"),
     (r' x+[xo][\'"]\n\s+[\'"]x', 'string join across lines with no space'),
     (r'[^\n]\Z', "no trailing newline"),
     (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
 #    (r'^\s+[^_ \n][^_. \n]+_[^_\n]+\s*=', "don't use underbars in identifiers"),
     (r'^\s+(self\.)?[A-za-z][a-z0-9]+[A-Z]\w* = ',
      "don't use camelcase in identifiers"),
     (r'^\s*(if|while|def|class|except|try)\s[^[\n]*:\s*[^\\n]#\s]+',
      "linebreak after :"),
     (r'class\s[^( \n]+:', "old-style class, use class foo(object)"),
     (r'class\s[^( \n]+\(\):',
      "class foo() not available in Python 2.4, use class foo(object)"),
     (r'\b(%s)\(' % '|'.join(keyword.kwlist),
      "Python keyword is not a function"),
     (r',]', "unneeded trailing ',' in list"),
 #    (r'class\s[A-Z][^\(]*\((?!Exception)',
 #     "don't capitalize non-exception classes"),
 #    (r'in range\(', "use xrange"),
 #    (r'^\s*print\s+', "avoid using print in core and extensions"),
     (r'[\x80-\xff]', "non-ASCII character literal"),
     (r'("\')\.format\(', "str.format() not available in Python 2.4"),
     (r'^\s*with\s+', "with not available in Python 2.4"),
     (r'\.isdisjoint\(', "set.isdisjoint not available in Python 2.4"),
     (r'^\s*except.* as .*:', "except as not available in Python 2.4"),
     (r'^\s*os\.path\.relpath', "relpath not available in Python 2.4"),
     (r'(?<!def)\s+(any|all|format)\(',
      "any/all/format not available in Python 2.4"),
     (r'(?<!def)\s+(callable)\(',
      "callable not available in Python 3, use getattr(f, '__call__', None)"),
     (r'if\s.*\selse', "if ... else form not available in Python 2.4"),
     (r'^\s*(%s)\s\s' % '|'.join(keyword.kwlist),
      "gratuitous whitespace after Python keyword"),
     (r'([\(\[][ \t]\S)|(\S[ \t][\)\]])', "gratuitous whitespace in () or []"),
 #    (r'\s\s=', "gratuitous whitespace before ="),
     (r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=)\S',
      "missing whitespace around operator"),
     (r'[^>< ](\+=|-=|!=|<>|<=|>=|<<=|>>=)\s',
      "missing whitespace around operator"),
     (r'\s(\+=|-=|!=|<>|<=|>=|<<=|>>=)\S',
      "missing whitespace around operator"),
     (r'[^^+=*/!<>&| -](\s=|=\s)[^= ]',
      "wrong whitespace around ="),
     (r'raise Exception', "don't raise generic exceptions"),
     (r' is\s+(not\s+)?["\'0-9-]', "object comparison with literal"),
     (r' [=!]=\s+(True|False|None)',
      "comparison with singleton, use 'is' or 'is not' instead"),
     (r'^\s*(while|if) [01]:',
      "use True/False for constant Boolean expression"),
     (r'(?:(?<!def)\s+|\()hasattr',
      'hasattr(foo, bar) is broken, use util.safehasattr(foo, bar) instead'),
     (r'opener\([^)]*\).read\(',
      "use opener.read() instead"),
     (r'BaseException', 'not in Py2.4, use Exception'),
     (r'os\.path\.relpath', 'os.path.relpath is not in Py2.5'),
     (r'opener\([^)]*\).write\(',
      "use opener.write() instead"),
     (r'[\s\(](open|file)\([^)]*\)\.read\(',
      "use util.readfile() instead"),
     (r'[\s\(](open|file)\([^)]*\)\.write\(',
      "use util.readfile() instead"),
     (r'^[\s\(]*(open(er)?|file)\([^)]*\)',
      "always assign an opened file to a variable, and close it afterwards"),
     (r'[\s\(](open|file)\([^)]*\)\.',
      "always assign an opened file to a variable, and close it afterwards"),
     (r'(?i)descendent', "the proper spelling is descendAnt"),
     (r'\.debug\(\_', "don't mark debug messages for translation"),
     (r'\.strip\(\)\.split\(\)', "no need to strip before splitting"),
   ],
   # warnings
   [
     (r'.{81}', "warning: line over 80 characters"),
     (r'^\s*except:$', "warning: naked except clause"),
     (r'ui\.(status|progress|write|note|warn)\([\'\"]x',
      "warning: unwrapped ui message"),
   ]
 ]
 
 pyfilters = [
     (r"""(?msx)(?P<comment>\#.*?$)|
          ((?P<quote>('''|\"\"\"|(?<!')'(?!')|(?<!")"(?!")))
           (?P<text>(([^\\]|\\.)*?))
           (?P=quote))""", reppython),
 ]
 
 cpats = [
   [
     (r'//', "don't use //-style comments"),
     (r'^  ', "don't use spaces to indent"),
     (r'\S\t', "don't use tabs except for indent"),
     (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
     (r'.{85}', "line too long"),
     (r'(while|if|do|for)\(', "use space after while/if/do/for"),
     (r'return\(', "return is not a function"),
     (r' ;', "no space before ;"),
     (r'\w+\* \w+', "use int *foo, not int* foo"),
     (r'\([^\)]+\) \w+', "use (int)foo, not (int) foo"),
     (r'\w+ (\+\+|--)', "use foo++, not foo ++"),
     (r'\w,\w', "missing whitespace after ,"),
     (r'^[^#]\w[+/*]\w', "missing whitespace in expression"),
     (r'^#\s+\w', "use #foo, not # foo"),
     (r'[^\n]\Z', "no trailing newline"),
     (r'^\s*#import\b', "use only #include in standard C code"),
   ],
   # warnings
   []
 ]
 
 cfilters = [
     (r'(/\*)(((\*(?!/))|[^*])*)\*/', repccomment),
     (r'''(?P<quote>(?<!")")(?P<text>([^"]|\\")+)"(?!")''', repquote),
     (r'''(#\s*include\s+<)([^>]+)>''', repinclude),
     (r'(\()([^)]+\))', repcallspaces),
 ]
 
 inutilpats = [
   [
     (r'\bui\.', "don't use ui in util"),
   ],
   # warnings
   []
 ]
 
 inrevlogpats = [
   [
     (r'\brepo\.', "don't use repo in revlog"),
   ],
   # warnings
   []
 ]
 
 checks = [
     ('python', r'.*\.(py|cgi)$', pyfilters, pypats),
     ('test script', r'(.*/)?test-[^.~]*$', testfilters, testpats),
     ('c', r'.*\.c$', cfilters, cpats),
     ('unified test', r'.*\.t$', utestfilters, utestpats),
     ('layering violation repo in revlog', r'mercurial/revlog\.py', pyfilters,
      inrevlogpats),
     ('layering violation ui in util', r'mercurial/util\.py', pyfilters,
      inutilpats),
 ]
 
 class norepeatlogger(object):
     def __init__(self):
         self._lastseen = None
 
     def log(self, fname, lineno, line, msg, blame):
         """print error related a to given line of a given file.
 
         The faulty line will also be printed but only once in the case
         of multiple errors.
 
         :fname: filename
         :lineno: line number
         :line: actual content of the line
         :msg: error message
         """
         msgid = fname, lineno, line
         if msgid != self._lastseen:
             if blame:
                 print "%s:%d (%s):" % (fname, lineno, blame)
             else:
                 print "%s:%d:" % (fname, lineno)
             print " > %s" % line
             self._lastseen = msgid
         print " " + msg
 
 _defaultlogger = norepeatlogger()
 
 def getblame(f):
     lines = []
     for l in os.popen('hg annotate -un %s' % f):
         start, line = l.split(':', 1)
         user, rev = start.split()
         lines.append((line[1:-1], user, rev))
     return lines
 
 def checkfile(f, logfunc=_defaultlogger.log, maxerr=None, warnings=False,
               blame=False, debug=False, lineno=True):
     """checks style and portability of a given file
 
     :f: filepath
     :logfunc: function used to report error
               logfunc(filename, linenumber, linecontent, errormessage)
     :maxerr: number of error to display before arborting.
              Set to false (default) to report all errors
 
     return True if no error is found, False otherwise.
     """
     blamecache = None
     result = True
     for name, match, filters, pats in checks:
         if debug:
             print name, f
         fc = 0
         if not re.match(match, f):
             if debug:
                 print "Skipping %s for %s it doesn't match %s" % (
                        name, match, f)
             continue
         fp = open(f)
         pre = post = fp.read()
         fp.close()
         if "no-" + "check-code" in pre:
             if debug:
                 print "Skipping %s for %s it has no- and check-code" % (
                        name, f)
             break
         for p, r in filters:
             post = re.sub(p, r, post)
         if warnings:
             pats = pats[0] + pats[1]
         else:
             pats = pats[0]
         # print post # uncomment to show filtered version
 
         if debug:
             print "Checking %s for %s" % (name, f)
 
         prelines = None
         errors = []
         for p, msg in pats:
             # fix-up regexes for multiline searches
             po = p
             # \s doesn't match \n
             p = re.sub(r'(?<!\\)\\s', r'[ \\t]', p)
             # [^...] doesn't match newline
             p = re.sub(r'(?<!\\)\[\^', r'[^\\n', p)
 
             #print po, '=>', p
 
             pos = 0
             n = 0
             for m in re.finditer(p, post, re.MULTILINE):
                 if prelines is None:
                     prelines = pre.splitlines()
                     postlines = post.splitlines(True)
 
                 start = m.start()
                 while n < len(postlines):
                     step = len(postlines[n])
                     if pos + step > start:
                         break
                     pos += step
                     n += 1
                 l = prelines[n]
 
                 if "check-code" + "-ignore" in l:
                     if debug:
                         print "Skipping %s for %s:%s (check-code -ignore)" % (
                             name, f, n)
                     continue
                 bd = ""
                 if blame:
                     bd = 'working directory'
                     if not blamecache:
                         blamecache = getblame(f)
                     if n < len(blamecache):
                         bl, bu, br = blamecache[n]
                         if bl == l:
                             bd = '%s@%s' % (bu, br)
                 errors.append((f, lineno and n + 1, l, msg, bd))
                 result = False
 
         errors.sort()
         for e in errors:
             logfunc(*e)
             fc += 1
             if maxerr and fc >= maxerr:
                 print " (too many errors, giving up)"
                 break
 
     return result
 
 if __name__ == "__main__":
     parser = optparse.OptionParser("%prog [options] [files]")
     parser.add_option("-w", "--warnings", action="store_true",
                       help="include warning-level checks")
     parser.add_option("-p", "--per-file", type="int",
                       help="max warnings per file")
     parser.add_option("-b", "--blame", action="store_true",
                       help="use annotate to generate blame info")
     parser.add_option("", "--debug", action="store_true",
                       help="show debug information")
     parser.add_option("", "--nolineno", action="store_false",
                       dest='lineno', help="don't show line numbers")
 
     parser.set_defaults(per_file=15, warnings=False, blame=False, debug=False,
                         lineno=True)
     (options, args) = parser.parse_args()
 
     if len(args) == 0:
         check = glob.glob("*")
     else:
         check = args
 
     ret = 0
     for f in check:
         if not checkfile(f, maxerr=options.per_file, warnings=options.warnings,
                          blame=options.blame, debug=options.debug,
                          lineno=options.lineno):
             ret = 1
     sys.exit(ret)

tests/test-check-code-hg.t

@@ -1,633 +1,646
   $ check_code="$TESTDIR"/../contrib/check-code.py
   $ cd "$TESTDIR"/..
   $ if hg identify -q > /dev/null; then :
   > else
   >     echo "skipped: not a Mercurial working dir" >&2
   >     exit 80
   > fi
   $ hg manifest | xargs "$check_code" || echo 'FAILURE IS NOT AN OPTION!!!'
 
   $ hg manifest | xargs "$check_code" --warnings --nolineno --per-file=0 || true
   contrib/check-code.py:0:
    > #    (r'^\s+[^_ \n][^_. \n]+_[^_\n]+\s*=', "don't use underbars in identifiers"),
    warning: line over 80 characters
   contrib/perf.py:0:
    >         except:
    warning: naked except clause
   contrib/perf.py:0:
    >     #timer(lambda: sum(map(len, repo.dirstate.status(m, [], False, False, False))))
    warning: line over 80 characters
   contrib/perf.py:0:
    >     except:
    warning: naked except clause
   contrib/setup3k.py:0:
    >         except:
    warning: naked except clause
   contrib/setup3k.py:0:
    >     except:
    warning: naked except clause
   contrib/setup3k.py:0:
    > except:
    warning: naked except clause
    warning: naked except clause
    warning: naked except clause
   contrib/shrink-revlog.py:0:
    >         except:
    warning: naked except clause
   doc/gendoc.py:0:
    >                "together with Mercurial. Help for other extensions is available "
    warning: line over 80 characters
   hgext/bugzilla.py:0:
    >                 raise util.Abort(_('cannot find bugzilla user id for %s or %s') %
    warning: line over 80 characters
   hgext/bugzilla.py:0:
    >             bzdir = self.ui.config('bugzilla', 'bzdir', '/var/www/html/bugzilla')
    warning: line over 80 characters
   hgext/convert/__init__.py:0:
    >           ('', 'ancestors', '', _('show current changeset in ancestor branches')),
    warning: line over 80 characters
   hgext/convert/bzr.py:0:
    >         except:
    warning: naked except clause
   hgext/convert/common.py:0:
    >             except:
    warning: naked except clause
   hgext/convert/common.py:0:
    >         except:
    warning: naked except clause
    warning: naked except clause
   hgext/convert/convcmd.py:0:
    >         except:
    warning: naked except clause
   hgext/convert/cvs.py:0:
    >                                 # /1 :pserver:[e-mail]:2401/cvsroot/foo Ah<Z
    warning: line over 80 characters
   hgext/convert/cvsps.py:0:
    >                     assert len(branches) == 1, 'unknown branch: %s' % e.mergepoint
    warning: line over 80 characters
   hgext/convert/cvsps.py:0:
    >                     ui.write('Ancestors: %s\n' % (','.join(r)))
    warning: unwrapped ui message
   hgext/convert/cvsps.py:0:
    >                     ui.write('Parent: %d\n' % cs.parents[0].id)
    warning: unwrapped ui message
   hgext/convert/cvsps.py:0:
    >                     ui.write('Parents: %s\n' %
    warning: unwrapped ui message
   hgext/convert/cvsps.py:0:
    >                 except:
    warning: naked except clause
   hgext/convert/cvsps.py:0:
    >                 ui.write('Branchpoints: %s \n' % ', '.join(branchpoints))
    warning: unwrapped ui message
   hgext/convert/cvsps.py:0:
    >             ui.write('Author: %s\n' % cs.author)
    warning: unwrapped ui message
   hgext/convert/cvsps.py:0:
    >             ui.write('Branch: %s\n' % (cs.branch or 'HEAD'))
    warning: unwrapped ui message
   hgext/convert/cvsps.py:0:
    >             ui.write('Date: %s\n' % util.datestr(cs.date,
    warning: unwrapped ui message
   hgext/convert/cvsps.py:0:
    >             ui.write('Log:\n')
    warning: unwrapped ui message
   hgext/convert/cvsps.py:0:
    >             ui.write('Members: \n')
    warning: unwrapped ui message
   hgext/convert/cvsps.py:0:
    >             ui.write('PatchSet %d \n' % cs.id)
    warning: unwrapped ui message
   hgext/convert/cvsps.py:0:
    >             ui.write('Tag%s: %s \n' % (['', 's'][len(cs.tags) > 1],
    warning: unwrapped ui message
   hgext/convert/git.py:0:
    >             except:
    warning: naked except clause
   hgext/convert/git.py:0:
    >             fh = self.gitopen('git diff-tree --name-only --root -r %s "%s^%s" --'
    warning: line over 80 characters
   hgext/convert/hg.py:0:
    >             # detect missing revlogs and abort on errors or populate self.ignored
    warning: line over 80 characters
   hgext/convert/hg.py:0:
    >             except:
    warning: naked except clause
    warning: naked except clause
   hgext/convert/hg.py:0:
    >         except:
    warning: naked except clause
   hgext/convert/monotone.py:0:
    >             except:
    warning: naked except clause
   hgext/convert/monotone.py:0:
    >         except:
    warning: naked except clause
   hgext/convert/subversion.py:0:
    >                 raise util.Abort(_('svn: branch has no revision %s') % to_revnum)
    warning: line over 80 characters
   hgext/convert/subversion.py:0:
    >             except:
    warning: naked except clause
   hgext/convert/subversion.py:0:
    >         args = [self.baseurl, relpaths, start, end, limit, discover_changed_paths,
    warning: line over 80 characters
   hgext/convert/subversion.py:0:
    >         self.trunkname = self.ui.config('convert', 'svn.trunk', 'trunk').strip('/')
    warning: line over 80 characters
   hgext/convert/subversion.py:0:
    >     except:
    warning: naked except clause
   hgext/convert/subversion.py:0:
    > def get_log_child(fp, url, paths, start, end, limit=0, discover_changed_paths=True,
    warning: line over 80 characters
   hgext/eol.py:0:
    >     if ui.configbool('eol', 'fix-trailing-newline', False) and s and s[-1] != '\n':
    warning: line over 80 characters
    warning: line over 80 characters
   hgext/gpg.py:0:
    >                 except:
    warning: naked except clause
   hgext/hgcia.py:0:
    > except:
    warning: naked except clause
   hgext/hgk.py:0:
    >         ui.write("%s%s\n" % (prefix, description.replace('\n', nlprefix).strip()))
    warning: line over 80 characters
   hgext/hgk.py:0:
    >         ui.write("parent %s\n" % p)
    warning: unwrapped ui message
   hgext/hgk.py:0:
    >         ui.write('k=%s\nv=%s\n' % (name, value))
    warning: unwrapped ui message
   hgext/hgk.py:0:
    >     ui.write("author %s %s %s\n" % (ctx.user(), int(date[0]), date[1]))
    warning: unwrapped ui message
   hgext/hgk.py:0:
    >     ui.write("branch %s\n\n" % ctx.branch())
    warning: unwrapped ui message
   hgext/hgk.py:0:
    >     ui.write("committer %s %s %s\n" % (committer, int(date[0]), date[1]))
    warning: unwrapped ui message
   hgext/hgk.py:0:
    >     ui.write("revision %d\n" % ctx.rev())
    warning: unwrapped ui message
   hgext/hgk.py:0:
    >     ui.write("tree %s\n" % short(ctx.changeset()[0])) # use ctx.node() instead ??
    warning: line over 80 characters
    warning: unwrapped ui message
   hgext/highlight/__init__.py:0:
    >     extensions.wrapfunction(webcommands, '_filerevision', filerevision_highlight)
    warning: line over 80 characters
   hgext/highlight/__init__.py:0:
    >     return ['/* pygments_style = %s */\n\n' % pg_style, fmter.get_style_defs('')]
    warning: line over 80 characters
   hgext/inotify/__init__.py:0:
    >             if self._inotifyon and not ignored and not subrepos and not self._dirty:
    warning: line over 80 characters
   hgext/inotify/server.py:0:
    >                     except:
    warning: naked except clause
   hgext/inotify/server.py:0:
    >             except:
    warning: naked except clause
   hgext/keyword.py:0:
    >     ui.note("hg ci -m '%s'\n" % msg)
    warning: unwrapped ui message
   hgext/mq.py:0:
    >                     raise util.Abort(_("cannot push --exact with applied patches"))
    warning: line over 80 characters
   hgext/mq.py:0:
    >                     raise util.Abort(_("cannot use --exact and --move together"))
    warning: line over 80 characters
   hgext/mq.py:0:
    >                     self.ui.warn(_('Tag %s overrides mq patch of the same name\n')
    warning: line over 80 characters
   hgext/mq.py:0:
    >                 except:
    warning: naked except clause
    warning: naked except clause
   hgext/mq.py:0:
    >             except:
    warning: naked except clause
    warning: naked except clause
    warning: naked except clause
    warning: naked except clause
   hgext/mq.py:0:
    >             raise util.Abort(_('cannot mix -l/--list with options or arguments'))
    warning: line over 80 characters
   hgext/mq.py:0:
    >             raise util.Abort(_('qfold cannot fold already applied patch %s') % p)
    warning: line over 80 characters
   hgext/mq.py:0:
    >           ('', 'move', None, _('reorder patch series and apply only the patch'))],
    warning: line over 80 characters
   hgext/mq.py:0:
    >           ('U', 'noupdate', None, _('do not update the new working directories')),
    warning: line over 80 characters
   hgext/mq.py:0:
    >           ('e', 'exact', None, _('apply the target patch to its recorded parent')),
    warning: line over 80 characters
   hgext/mq.py:0:
    >         except:
    warning: naked except clause
   hgext/mq.py:0:
    >         ui.write("mq:     %s\n" % ', '.join(m))
    warning: unwrapped ui message
   hgext/mq.py:0:
    >     repo.mq.qseries(repo, missing=opts.get('missing'), summary=opts.get('summary'))
    warning: line over 80 characters
   hgext/notify.py:0:
    >                 ui.note(_('notify: suppressing notification for merge %d:%s\n') %
    warning: line over 80 characters
   hgext/patchbomb.py:0:
    >                                                   binnode, seqno=idx, total=total)
    warning: line over 80 characters
   hgext/patchbomb.py:0:
    >             except:
    warning: naked except clause
   hgext/patchbomb.py:0:
    >             ui.write('Subject: %s\n' % subj)
    warning: unwrapped ui message
   hgext/patchbomb.py:0:
    >         p = mail.mimetextpatch('\n'.join(patchlines), 'x-patch', opts.get('test'))
    warning: line over 80 characters
   hgext/patchbomb.py:0:
    >         ui.write('From: %s\n' % sender)
    warning: unwrapped ui message
   hgext/record.py:0:
    >                                   ignoreblanklines=opts.get('ignore_blank_lines'))
    warning: line over 80 characters
   hgext/record.py:0:
    >                                   ignorewsamount=opts.get('ignore_space_change'),
    warning: line over 80 characters
   hgext/zeroconf/__init__.py:0:
    >             publish(name, desc, path, util.getport(u.config("web", "port", 8000)))
    warning: line over 80 characters
   hgext/zeroconf/__init__.py:0:
    >     except:
    warning: naked except clause
    warning: naked except clause
   mercurial/bundlerepo.py:0:
    >       is a bundlerepo for the obtained bundle when the original "other" is remote.
    warning: line over 80 characters
   mercurial/bundlerepo.py:0:
    >     "local" is a local repo from which to obtain the actual incoming changesets; it
    warning: line over 80 characters
   mercurial/bundlerepo.py:0:
    >     tmp = discovery.findcommonincoming(repo, other, heads=onlyheads, force=force)
    warning: line over 80 characters
   mercurial/commands.py:0:
    >                  "     size " + basehdr + "   link     p1     p2       nodeid\n")
    warning: line over 80 characters
   mercurial/commands.py:0:
    >                 raise util.Abort('cannot use localheads with old style discovery')
    warning: line over 80 characters
   mercurial/commands.py:0:
    >                 ui.note('branch %s\n' % data)
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >                 ui.note('node %s\n' % str(data))
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >                 ui.note('tag %s\n' % name)
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >                 ui.write("unpruned common: %s\n" % " ".join([short(n)
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >                 yield 'n', (r, list(set(p for p in cl.parentrevs(r) if p != -1)))
    warning: line over 80 characters
   mercurial/commands.py:0:
    >                 yield 'n', (r, list(set(p for p in rlog.parentrevs(r) if p != -1)))
    warning: line over 80 characters
   mercurial/commands.py:0:
    >             except:
    warning: naked except clause
   mercurial/commands.py:0:
    >             ui.status(_("(run 'hg heads .' to see heads, 'hg merge' to merge)\n"))
    warning: line over 80 characters
   mercurial/commands.py:0:
    >             ui.write("format: id, p1, p2, cset, delta base, len(delta)\n")
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >             ui.write("local is subset\n")
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >             ui.write("remote is subset\n")
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >             ui.write('    other            : ' + fmt2 % pcfmt(numoprev, numprev))
    warning: line over 80 characters
   mercurial/commands.py:0:
    >             ui.write('    where prev = p1  : ' + fmt2 % pcfmt(nump1prev, numprev))
    warning: line over 80 characters
   mercurial/commands.py:0:
    >             ui.write('    where prev = p2  : ' + fmt2 % pcfmt(nump2prev, numprev))
    warning: line over 80 characters
   mercurial/commands.py:0:
    >             ui.write('deltas against other : ' + fmt % pcfmt(numother, numdeltas))
    warning: line over 80 characters
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >             ui.write('deltas against p1    : ' + fmt % pcfmt(nump1, numdeltas))
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >             ui.write('deltas against p2    : ' + fmt % pcfmt(nump2, numdeltas))
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >         except:
    warning: naked except clause
   mercurial/commands.py:0:
    >         revs, checkout = hg.addbranchrevs(repo, other, branches, opts.get('rev'))
    warning: line over 80 characters
   mercurial/commands.py:0:
    >         ui.write("common heads: %s\n" % " ".join([short(n) for n in common]))
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >         ui.write("match: %s\n" % m(d[0]))
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >         ui.write('deltas against prev  : ' + fmt % pcfmt(numprev, numdeltas))
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >         ui.write('path %s\n' % k)
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >         ui.write('uncompressed data size (min/max/avg) : %d / %d / %d\n'
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >     Every ID must be a full-length hex node id string. Returns a list of 0s and 1s
    warning: line over 80 characters
   mercurial/commands.py:0:
    >     remoteurl, branches = hg.parseurl(ui.expandpath(remoteurl), opts.get('branch'))
    warning: line over 80 characters
   mercurial/commands.py:0:
    >     ui.write("digraph G {\n")
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >     ui.write("internal: %s %s\n" % d)
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >     ui.write("standard: %s\n" % util.datestr(d))
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >     ui.write('avg chain length  : ' + fmt % avgchainlen)
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >     ui.write('case-sensitive: %s\n' % (util.checkcase('.debugfsinfo')
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >     ui.write('compression ratio : ' + fmt % compratio)
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >     ui.write('delta size (min/max/avg)             : %d / %d / %d\n'
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >     ui.write('exec: %s\n' % (util.checkexec(path) and 'yes' or 'no'))
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >     ui.write('flags  : %s\n' % ', '.join(flags))
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >     ui.write('format : %d\n' % format)
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >     ui.write('full revision size (min/max/avg)     : %d / %d / %d\n'
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >     ui.write('revision size : ' + fmt2 % totalsize)
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >     ui.write('revisions     : ' + fmt2 % numrevs)
    warning: unwrapped ui message
    warning: unwrapped ui message
   mercurial/commands.py:0:
    >     ui.write('symlink: %s\n' % (util.checklink(path) and 'yes' or 'no'))
    warning: unwrapped ui message
   mercurial/commandserver.py:0:
    >         # the ui here is really the repo ui so take its baseui so we don't end up
    warning: line over 80 characters
   mercurial/context.py:0:
    >                 return self._manifestdelta[path], self._manifestdelta.flags(path)
    warning: line over 80 characters
   mercurial/dagparser.py:0:
    >             raise util.Abort(_("invalid character in dag description: %s...") % s)
    warning: line over 80 characters
   mercurial/dagparser.py:0:
    >         >>> dagtext([('n', (0, [-1])), ('C', 'my command line'), ('n', (1, [0]))])
    warning: line over 80 characters
   mercurial/dirstate.py:0:
    >                 if not st is None and not getkind(st.st_mode) in (regkind, lnkkind):
    warning: line over 80 characters
   mercurial/discovery.py:0:
    >     If onlyheads is given, only nodes ancestral to nodes in onlyheads (inclusive)
    warning: line over 80 characters
   mercurial/discovery.py:0:
    > def findcommonoutgoing(repo, other, onlyheads=None, force=False, commoninc=None):
    warning: line over 80 characters
   mercurial/dispatch.py:0:
    >                                                 " (.hg not found)") % os.getcwd())
    warning: line over 80 characters
   mercurial/dispatch.py:0:
    >         except:
    warning: naked except clause
   mercurial/dispatch.py:0:
    >         return lambda: runcommand(lui, None, cmd, args[:1], ui, options, d, [], {})
    warning: line over 80 characters
   mercurial/dispatch.py:0:
    >     def __init__(self, args, ui=None, repo=None, fin=None, fout=None, ferr=None):
    warning: line over 80 characters
   mercurial/dispatch.py:0:
    >     except:
    warning: naked except clause
   mercurial/hg.py:0:
    >     except:
    warning: naked except clause
   mercurial/hgweb/hgweb_mod.py:0:
    >             self.maxshortchanges = int(self.config("web", "maxshortchanges", 60))
    warning: line over 80 characters
   mercurial/keepalive.py:0:
    >         except:
    warning: naked except clause
   mercurial/keepalive.py:0:
    >     except:
    warning: naked except clause
   mercurial/localrepo.py:0:
    >                         # we return an integer indicating remote head count change
    warning: line over 80 characters
   mercurial/localrepo.py:0:
    >                     raise util.Abort(_("empty or missing revlog for %s") % fname)
    warning: line over 80 characters
    warning: line over 80 characters
   mercurial/localrepo.py:0:
    >                 if self._tagscache.tagtypes and name in self._tagscache.tagtypes:
    warning: line over 80 characters
   mercurial/localrepo.py:0:
    >                 self.hook("precommit", throw=True, parent1=hookp1, parent2=hookp2)
    warning: line over 80 characters
   mercurial/localrepo.py:0:
    >             # new requirements = old non-format requirements + new format-related
    warning: line over 80 characters
   mercurial/localrepo.py:0:
    >             except:
    warning: naked except clause
   mercurial/localrepo.py:0:
    >         """return status of files between two nodes or node and working directory
    warning: line over 80 characters
   mercurial/localrepo.py:0:
    >         '''Returns a tagscache object that contains various tags related caches.'''
    warning: line over 80 characters
   mercurial/manifest.py:0:
    >             return "".join(struct.pack(">lll", start, end, len(content)) + content
    warning: line over 80 characters
   mercurial/merge.py:0:
    >                 subrepo.submerge(repo, wctx, mctx, wctx.ancestor(mctx), overwrite)
    warning: line over 80 characters
   mercurial/patch.py:0:
    >                  modified, added, removed, copy, getfilectx, opts, losedata, prefix)
    warning: line over 80 characters
   mercurial/patch.py:0:
    >         diffhelpers.addlines(lr, self.hunk, self.lena, self.lenb, self.a, self.b)
    warning: line over 80 characters
   mercurial/patch.py:0:
    >         output.append(_(' %d files changed, %d insertions(+), %d deletions(-)\n')
    warning: line over 80 characters
   mercurial/patch.py:0:
    >     except:
    warning: naked except clause
   mercurial/pure/mpatch.py:0:
    >         frags.extend(reversed(new))                    # what was left at the end
    warning: line over 80 characters
   mercurial/repair.py:0:
    >         except:
    warning: naked except clause
   mercurial/repair.py:0:
    >     except:
    warning: naked except clause
   mercurial/revset.py:0:
    >         elif c.isalnum() or c in '._' or ord(c) > 127: # gather up a symbol/keyword
    warning: line over 80 characters
   mercurial/revset.py:0:
    >     Changesets that are the Nth ancestor (first parents only) of a changeset in set.
    warning: line over 80 characters
   mercurial/scmutil.py:0:
    >                         raise util.Abort(_("path '%s' is inside nested repo %r") %
    warning: line over 80 characters
   mercurial/scmutil.py:0:
    >             "requires features '%s' (upgrade Mercurial)") % "', '".join(missings))
    warning: line over 80 characters
   mercurial/scmutil.py:0:
    >         elif repo.dirstate[abs] != 'r' and (not good or not os.path.lexists(target)
    warning: line over 80 characters
   mercurial/setdiscovery.py:0:
    >     # treat remote heads (and maybe own heads) as a first implicit sample response
    warning: line over 80 characters
   mercurial/setdiscovery.py:0:
    >     undecided = dag.nodeset() # own nodes where I don't know if remote knows them
    warning: line over 80 characters
   mercurial/similar.py:0:
    >         repo.ui.progress(_('searching for similar files'), i, total=len(removed))
    warning: line over 80 characters
   mercurial/simplemerge.py:0:
    >         for zmatch, zend, amatch, aend, bmatch, bend in self.find_sync_regions():
    warning: line over 80 characters
   mercurial/sshrepo.py:0:
    >             self._abort(error.RepoError(_("no suitable response from remote hg")))
    warning: line over 80 characters
   mercurial/sshrepo.py:0:
    >         except:
    warning: naked except clause
   mercurial/subrepo.py:0:
    >                 other, self._repo = hg.clone(self._repo._subparent.ui, {}, other,
    warning: line over 80 characters
   mercurial/subrepo.py:0:
    >         msg = (_(' subrepository sources for %s differ (in checked out version)\n'
    warning: line over 80 characters
   mercurial/transaction.py:0:
    >             except:
    warning: naked except clause
   mercurial/ui.py:0:
    >                 traceback.print_exception(exc[0], exc[1], exc[2], file=self.ferr)
    warning: line over 80 characters
   mercurial/url.py:0:
    >             conn = httpsconnection(host, port, keyfile, certfile, *args, **kwargs)
    warning: line over 80 characters
   mercurial/util.py:0:
    >             except:
    warning: naked except clause
   mercurial/util.py:0:
    >     except:
    warning: naked except clause
   mercurial/verify.py:0:
    >                     except:
    warning: naked except clause
   mercurial/verify.py:0:
    >                 except:
    warning: naked except clause
   mercurial/wireproto.py:0:
    >         # Assuming the future to be filled with the result from the batched request
    warning: line over 80 characters
   mercurial/wireproto.py:0:
    >         '''remote must support _submitbatch(encbatch) and _submitone(op, encargs)'''
    warning: line over 80 characters
   mercurial/wireproto.py:0:
    >     All methods invoked on instances of this class are simply queued and return a
    warning: line over 80 characters
   mercurial/wireproto.py:0:
    >     The decorator returns a function which wraps this coroutine as a plain method,
    warning: line over 80 characters
   setup.py:0:
    >                 raise SystemExit("Python headers are required to build Mercurial")
    warning: line over 80 characters
   setup.py:0:
    >         except:
    warning: naked except clause
   setup.py:0:
    >     # build_py), it will not find osutil & friends, thinking that those modules are
    warning: line over 80 characters
   setup.py:0:
    >     except:
    warning: naked except clause
    warning: naked except clause
   setup.py:0:
    >     isironpython = platform.python_implementation().lower().find("ironpython") != -1
    warning: line over 80 characters
   setup.py:0:
    > except:
    warning: naked except clause
    warning: naked except clause
    warning: naked except clause
   tests/autodiff.py:0:
    >         ui.write('data lost for: %s\n' % fn)
    warning: unwrapped ui message
   tests/run-tests.py:0:
    >     except:
    warning: naked except clause
   tests/test-commandserver.py:0:
    >                         'hooks.pre-identify=python:test-commandserver.hook', 'id'],
    warning: line over 80 characters
   tests/test-commandserver.py:0:
    >     # the cached repo local hgrc contains ui.foo=bar, so showconfig should show it
    warning: line over 80 characters
   tests/test-commandserver.py:0:
    >     print '%c, %r' % (ch, re.sub('encoding: [a-zA-Z0-9-]+', 'encoding: ***', data))
    warning: line over 80 characters
+  tests/test-convert-mtn.t:0:
+   >   > function get_passphrase(keypair_id)
+   don't use 'function', use old style
   tests/test-filecache.py:0:
    >     except:
    warning: naked except clause
   tests/test-filecache.py:0:
    > if subprocess.call(['python', '%s/hghave' % os.environ['TESTDIR'], 'cacheable']):
    warning: line over 80 characters
+  tests/test-import-git.t:0:
+   >   > Mc\${NkU|\`?^000jF3jhEB
+   ^ must be quoted
+  tests/test-import.t:0:
+   >   > diff -Naur proj-orig/foo proj-new/foo
+   don't use 'diff -N'
+   don't use 'diff -N'
+  tests/test-schemes.t:0:
+   >   > z = file:\$PWD/
+   don't use $PWD, use `pwd`
   tests/test-ui-color.py:0:
    > testui.warn('warning\n')
    warning: unwrapped ui message
   tests/test-ui-color.py:0:
    > testui.write('buffered\n')
    warning: unwrapped ui message
   tests/test-walkrepo.py:0:
    >         print "Found %d repositories when I should have found 2" % (len(reposet),)
    warning: line over 80 characters
   tests/test-walkrepo.py:0:
    >         print "Found %d repositories when I should have found 3" % (len(reposet),)
    warning: line over 80 characters