setdiscovery: batch heads and known(ownheads)

This means that we now discover both subset conditions (local<remote and
remote<local) in a single roundtrip without ever constructing an actual
sample (which takes a bit of client CPU).

mercurial/setdiscovery.py

@@ -1,178 +1,193
 # setdiscovery.py - improved discovery of common nodeset for mercurial
 #
 # Copyright 2010 Benoit Boissinot <[e-mail]>
 # and Peter Arrenbrecht <[e-mail]>
 #
 # This software may be used and distributed according to the terms of the
 # GNU General Public License version 2 or any later version.
 
 from node import nullid
 from i18n import _
 import random, collections, util, dagutil
 
 def _updatesample(dag, nodes, sample, always, quicksamplesize=0):
     # if nodes is empty we scan the entire graph
     if nodes:
         heads = dag.headsetofconnecteds(nodes)
     else:
         heads = dag.heads()
     dist = {}
     visit = collections.deque(heads)
     seen = set()
     factor = 1
     while visit:
         curr = visit.popleft()
         if curr in seen:
             continue
         d = dist.setdefault(curr, 1)
         if d > factor:
             factor *= 2
         if d == factor:
             if curr not in always: # need this check for the early exit below
                 sample.add(curr)
                 if quicksamplesize and (len(sample) >= quicksamplesize):
                     return
         seen.add(curr)
         for p in dag.parents(curr):
             if not nodes or p in nodes:
                 dist.setdefault(p, d + 1)
                 visit.append(p)
 
 def _setupsample(dag, nodes, size):
     if len(nodes) <= size:
         return set(nodes), None, 0
     always = set(dag.heads())
     desiredlen = size - len(always)
     if desiredlen <= 0:
         # This could be bad if there are very many heads, all unknown to the
         # server. We're counting on long request support here.
         return always, None, desiredlen
     return always, set(), desiredlen
 
 def _takequicksample(dag, nodes, size, initial):
     always, sample, desiredlen = _setupsample(dag, nodes, size)
     if sample is None:
         return always
     if initial:
         fromset = None
     else:
         fromset = nodes
     _updatesample(dag, fromset, sample, always, quicksamplesize=desiredlen)
     sample.update(always)
     return sample
 
 def _takefullsample(dag, nodes, size):
     always, sample, desiredlen = _setupsample(dag, nodes, size)
     if sample is None:
         return always
     # update from heads
     _updatesample(dag, nodes, sample, always)
     # update from roots
     _updatesample(dag.inverse(), nodes, sample, always)
     assert sample
     if len(sample) > desiredlen:
         sample = set(random.sample(sample, desiredlen))
     elif len(sample) < desiredlen:
         more = desiredlen - len(sample)
         sample.update(random.sample(list(nodes - sample - always), more))
     sample.update(always)
     return sample
 
 def findcommonheads(ui, local, remote,
                     initialsamplesize=100,
                     fullsamplesize=200,
                     abortwhenunrelated=True):
     '''Return a tuple (common, anyincoming, remoteheads) used to identify
     missing nodes from or in remote.
 
     shortcutlocal determines whether we try use direct access to localrepo if
     remote is actually local.
     '''
     roundtrips = 0
     cl = local.changelog
     dag = dagutil.revlogdag(cl)
-    nodes = dag.nodeset()
 
-    # early exit if we know all the specified server heads already
+    # early exit if we know all the specified remote heads already
     ui.debug("query 1; heads\n")
     roundtrips += 1
+    ownheads = dag.heads()
+    sample = ownheads
+    if remote.local():
+        # stopgap until we have a proper localpeer that supports batch()
     srvheadhashes = remote.heads()
-
-    ## TODO We might want to request an additional random sample of the server's
-    ## nodes batched with the heads query here.
+        yesno = remote.known(dag.externalizeall(sample))
+    elif remote.capable('batch'):
+        batch = remote.batch()
+        srvheadhashesref = batch.heads()
+        yesnoref = batch.known(dag.externalizeall(sample))
+        batch.submit()
+        srvheadhashes = srvheadhashesref.value
+        yesno = yesnoref.value
+    else:
+        # compatibitity with pre-batch, but post-known remotes during 1.9 devel
+        srvheadhashes = remote.heads()
+        sample = []
 
     if cl.tip() == nullid:
         if srvheadhashes != [nullid]:
             return [nullid], True, srvheadhashes
         return [nullid], False, []
 
     # start actual discovery (we note this before the next "if" for
     # compatibility reasons)
     ui.status(_("searching for changes\n"))
 
     srvheads = dag.internalizeall(srvheadhashes, filterunknown=True)
     if len(srvheads) == len(srvheadhashes):
         ui.note("all remote heads known locally\n")
         return (srvheadhashes, False, srvheadhashes,)
 
+    if sample and util.all(yesno):
+        ui.note("all local heads known remotely\n")
+        ownheadhashes = dag.externalizeall(ownheads)
+        return (ownheadhashes, True, srvheadhashes,)
+
     # full blown discovery
-    undecided = nodes # own nodes where I don't know if the server knows them
+    undecided = dag.nodeset() # own nodes where I don't know if remote knows them
     common = set() # own nodes I know we both know
-    missing = set() # own nodes I know the server lacks
+    missing = set() # own nodes I know remote lacks
 
-    # treat remote heads as a first implicit sample response
+    # treat remote heads (and maybe own heads) as a first implicit sample response
     common.update(dag.ancestorset(srvheads))
     undecided.difference_update(common)
-    # use cheapish initial sample
-    if common:
-        ui.debug("taking initial sample\n")
-        sample = _takefullsample(dag, undecided, size=fullsamplesize)
-    else:
-        ui.debug("taking quick initial sample\n")
-        sample = _takequicksample(dag, nodes, size=initialsamplesize,
-                                  initial=True)
 
-    roundtrips += 1
-    ui.progress(_('searching'), roundtrips, unit=_('queries'))
-    ui.debug("query %i; still undecided: %i, sample size is: %i\n"
-             % (roundtrips, len(undecided), len(sample)))
-    # indices between sample and externalized version must match
-    sample = list(sample)
-    yesno = remote.known(dag.externalizeall(sample))
+    full = False
+    while undecided:
 
-    while undecided:
+        if sample:
         commoninsample = set(n for i, n in enumerate(sample) if yesno[i])
         common.update(dag.ancestorset(commoninsample, common))
 
         missinginsample = [n for i, n in enumerate(sample) if not yesno[i]]
         missing.update(dag.descendantset(missinginsample, missing))
 
         undecided.difference_update(missing)
         undecided.difference_update(common)
 
         if not undecided:
             break
 
+        if full:
         ui.note("sampling from both directions\n")
         sample = _takefullsample(dag, undecided, size=fullsamplesize)
+        elif common:
+            # use cheapish initial sample
+            ui.debug("taking initial sample\n")
+            sample = _takefullsample(dag, undecided, size=fullsamplesize)
+        else:
+            # use even cheaper initial sample
+            ui.debug("taking quick initial sample\n")
+            sample = _takequicksample(dag, undecided, size=initialsamplesize,
+                                      initial=True)
 
         roundtrips += 1
         ui.progress(_('searching'), roundtrips, unit=_('queries'))
         ui.debug("query %i; still undecided: %i, sample size is: %i\n"
                  % (roundtrips, len(undecided), len(sample)))
         # indices between sample and externalized version must match
         sample = list(sample)
         yesno = remote.known(dag.externalizeall(sample))
+        full = True
 
     result = dag.headsetofconnecteds(common)
     ui.progress(_('searching'), None)
     ui.debug("%d total queries\n" % roundtrips)
 
     if not result and srvheadhashes != [nullid]:
         if abortwhenunrelated:
             raise util.Abort(_("repository is unrelated"))
         else:
             ui.warn(_("warning: repository is unrelated\n"))
         return (set([nullid]), True, srvheadhashes,)
 
     return (dag.externalizeall(result), True, srvheadhashes,)

tests/test-http-proxy.t

@@ -1,120 +1,120
 
   $ hg init a
   $ cd a
   $ echo a > a
   $ hg ci -Ama -d '1123456789 0'
   adding a
   $ hg --config server.uncompressed=True serve -p $HGPORT -d --pid-file=hg.pid
   $ cat hg.pid >> $DAEMON_PIDS
   $ cd ..
   $ ("$TESTDIR/tinyproxy.py" $HGPORT1 localhost >proxy.log 2>&1 </dev/null &
   $ echo $! > proxy.pid)
   $ cat proxy.pid >> $DAEMON_PIDS
   $ sleep 2
 
 url for proxy, stream
 
   $ http_proxy=http://localhost:$HGPORT1/ hg --config http_proxy.always=True clone --uncompressed http://localhost:$HGPORT/ b
   streaming all changes
   3 files to transfer, 303 bytes of data
   transferred * bytes in * seconds (*/sec) (glob)
   updating to branch default
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ cd b
   $ hg verify
   checking changesets
   checking manifests
   crosschecking files in changesets and manifests
   checking files
   1 files, 1 changesets, 1 total revisions
   $ cd ..
 
 url for proxy, pull
 
   $ http_proxy=http://localhost:$HGPORT1/ hg --config http_proxy.always=True clone http://localhost:$HGPORT/ b-pull
   requesting all changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files
   updating to branch default
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ cd b-pull
   $ hg verify
   checking changesets
   checking manifests
   crosschecking files in changesets and manifests
   checking files
   1 files, 1 changesets, 1 total revisions
   $ cd ..
 
 host:port for proxy
 
   $ http_proxy=localhost:$HGPORT1 hg clone --config http_proxy.always=True http://localhost:$HGPORT/ c
   requesting all changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files
   updating to branch default
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 
 proxy url with user name and password
 
   $ http_proxy=http://user:passwd@localhost:$HGPORT1 hg clone --config http_proxy.always=True http://localhost:$HGPORT/ d
   requesting all changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files
   updating to branch default
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 
 url with user name and password
 
   $ http_proxy=http://user:passwd@localhost:$HGPORT1 hg clone --config http_proxy.always=True http://user:passwd@localhost:$HGPORT/ e
   requesting all changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files
   updating to branch default
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 
 bad host:port for proxy
 
   $ http_proxy=localhost:$HGPORT2 hg clone --config http_proxy.always=True http://localhost:$HGPORT/ f
   abort: error: Connection refused
   [255]
 
 do not use the proxy if it is in the no list
 
   $ http_proxy=localhost:$HGPORT1 hg clone --config http_proxy.no=localhost http://localhost:$HGPORT/ g
   requesting all changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files
   updating to branch default
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ cat proxy.log
   * - - [*] "GET http://localhost:$HGPORT/?cmd=capabilities HTTP/1.1" - - (glob)
   * - - [*] "GET http://localhost:$HGPORT/?cmd=stream_out HTTP/1.1" - - (glob)
   * - - [*] "GET http://localhost:$HGPORT/?cmd=listkeys HTTP/1.1" - - x-hgarg-1:namespace=bookmarks (glob)
   * - - [*] "GET http://localhost:$HGPORT/?cmd=capabilities HTTP/1.1" - - (glob)
-  * - - [*] "GET http://localhost:$HGPORT/?cmd=heads HTTP/1.1" - - (glob)
+  * - - [*] "GET http://localhost:$HGPORT/?cmd=batch HTTP/1.1" - - x-hgarg-1:cmds=heads+%3Bknown+nodes%3D (glob)
   * - - [*] "GET http://localhost:$HGPORT/?cmd=getbundle HTTP/1.1" - - x-hgarg-1:common=0000000000000000000000000000000000000000&heads=83180e7845de420a1bb46896fd5fe05294f8d629 (glob)
   * - - [*] "GET http://localhost:$HGPORT/?cmd=listkeys HTTP/1.1" - - x-hgarg-1:namespace=bookmarks (glob)
   * - - [*] "GET http://localhost:$HGPORT/?cmd=capabilities HTTP/1.1" - - (glob)
-  * - - [*] "GET http://localhost:$HGPORT/?cmd=heads HTTP/1.1" - - (glob)
+  * - - [*] "GET http://localhost:$HGPORT/?cmd=batch HTTP/1.1" - - x-hgarg-1:cmds=heads+%3Bknown+nodes%3D (glob)
   * - - [*] "GET http://localhost:$HGPORT/?cmd=getbundle HTTP/1.1" - - x-hgarg-1:common=0000000000000000000000000000000000000000&heads=83180e7845de420a1bb46896fd5fe05294f8d629 (glob)
   * - - [*] "GET http://localhost:$HGPORT/?cmd=listkeys HTTP/1.1" - - x-hgarg-1:namespace=bookmarks (glob)
   * - - [*] "GET http://localhost:$HGPORT/?cmd=capabilities HTTP/1.1" - - (glob)
-  * - - [*] "GET http://localhost:$HGPORT/?cmd=heads HTTP/1.1" - - (glob)
+  * - - [*] "GET http://localhost:$HGPORT/?cmd=batch HTTP/1.1" - - x-hgarg-1:cmds=heads+%3Bknown+nodes%3D (glob)
   * - - [*] "GET http://localhost:$HGPORT/?cmd=getbundle HTTP/1.1" - - x-hgarg-1:common=0000000000000000000000000000000000000000&heads=83180e7845de420a1bb46896fd5fe05294f8d629 (glob)
   * - - [*] "GET http://localhost:$HGPORT/?cmd=listkeys HTTP/1.1" - - x-hgarg-1:namespace=bookmarks (glob)
   * - - [*] "GET http://localhost:$HGPORT/?cmd=capabilities HTTP/1.1" - - (glob)
-  * - - [*] "GET http://localhost:$HGPORT/?cmd=heads HTTP/1.1" - - (glob)
+  * - - [*] "GET http://localhost:$HGPORT/?cmd=batch HTTP/1.1" - - x-hgarg-1:cmds=heads+%3Bknown+nodes%3D (glob)
   * - - [*] "GET http://localhost:$HGPORT/?cmd=getbundle HTTP/1.1" - - x-hgarg-1:common=0000000000000000000000000000000000000000&heads=83180e7845de420a1bb46896fd5fe05294f8d629 (glob)
   * - - [*] "GET http://localhost:$HGPORT/?cmd=listkeys HTTP/1.1" - - x-hgarg-1:namespace=bookmarks (glob)
 

tests/test-push-warn.t

@@ -1,720 +1,720
   $ echo "[extensions]" >> $HGRCPATH
   $ echo "graphlog=" >> $HGRCPATH
 
   $ hg init a
   $ cd a
   $ echo foo > t1
   $ hg add t1
   $ hg commit -m "1"
 
   $ cd ..
   $ hg clone a b
   updating to branch default
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 
   $ cd a
   $ echo foo > t2
   $ hg add t2
   $ hg commit -m "2"
 
   $ cd ../b
   $ echo foo > t3
   $ hg add t3
   $ hg commit -m "3"
 
   $ hg push ../a
   pushing to ../a
   searching for changes
   abort: push creates new remote head 1e108cc5548c!
   (you should pull and merge or use push -f to force)
   [255]
 
   $ hg push --debug ../a
   pushing to ../a
   query 1; heads
   searching for changes
   taking quick initial sample
   searching: 2 queries
-  query 2; still undecided: 2, sample size is: 2
+  query 2; still undecided: 1, sample size is: 1
   2 total queries
   new remote heads on branch 'default'
   new remote head 1e108cc5548c
   abort: push creates new remote head 1e108cc5548c!
   (you should pull and merge or use push -f to force)
   [255]
 
   $ hg pull ../a
   pulling from ../a
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files (+1 heads)
   (run 'hg heads' to see heads, 'hg merge' to merge)
 
   $ hg push ../a
   pushing to ../a
   searching for changes
   abort: push creates new remote head 1e108cc5548c!
   (did you forget to merge? use push -f to force)
   [255]
 
   $ hg merge
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   (branch merge, don't forget to commit)
 
   $ hg commit -m "4"
   $ hg push ../a
   pushing to ../a
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 2 changesets with 1 changes to 1 files
 
   $ cd ..
 
   $ hg init c
   $ cd c
   $ for i in 0 1 2; do
   >     echo $i >> foo
   >     hg ci -Am $i
   > done
   adding foo
   $ cd ..
 
   $ hg clone c d
   updating to branch default
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 
   $ cd d
   $ for i in 0 1; do
   >    hg co -C $i
   >    echo d-$i >> foo
   >    hg ci -m d-$i
   > done
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   created new head
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   created new head
 
   $ HGMERGE=true hg merge 3
   merging foo
   0 files updated, 1 files merged, 0 files removed, 0 files unresolved
   (branch merge, don't forget to commit)
 
   $ hg ci -m c-d
 
   $ hg push ../c
   pushing to ../c
   searching for changes
   abort: push creates new remote head 6346d66eb9f5!
   (did you forget to merge? use push -f to force)
   [255]
 
   $ hg push -r 2 ../c
   pushing to ../c
   searching for changes
   no changes found
 
   $ hg push -r 3 ../c
   pushing to ../c
   searching for changes
   abort: push creates new remote head a5dda829a167!
   (did you forget to merge? use push -f to force)
   [255]
 
   $ hg push -v -r 3 -r 4 ../c
   pushing to ../c
   searching for changes
   all remote heads known locally
   new remote heads on branch 'default'
   new remote head a5dda829a167
   new remote head ee8fbc7a0295
   abort: push creates new remote head a5dda829a167!
   (did you forget to merge? use push -f to force)
   [255]
 
   $ hg push -v -f -r 3 -r 4 ../c
   pushing to ../c
   searching for changes
   all remote heads known locally
   2 changesets found
   adding changesets
   adding manifests
   adding file changes
   added 2 changesets with 2 changes to 1 files (+2 heads)
 
   $ hg push -r 5 ../c
   pushing to ../c
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files (-1 heads)
 
   $ hg in ../c
   comparing with ../c
   searching for changes
   no changes found
   [1]
 
 
 Issue450: push -r warns about remote head creation even if no heads
 will be created
 
   $ hg init ../e
   $ hg push -r 0 ../e
   pushing to ../e
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files
 
   $ hg push -r 1 ../e
   pushing to ../e
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files
 
   $ cd ..
 
 
 Issue736: named branches are not considered for detection of
 unmerged heads in "hg push"
 
   $ hg init f
   $ cd f
   $ hg -q branch a
   $ echo 0 > foo
   $ hg -q ci -Am 0
   $ echo 1 > foo
   $ hg -q ci -m 1
   $ hg -q up 0
   $ echo 2 > foo
   $ hg -q ci -m 2
   $ hg -q up 0
   $ hg -q branch b
   $ echo 3 > foo
   $ hg -q ci -m 3
   $ cd ..
 
   $ hg -q clone f g
   $ cd g
 
 Push on existing branch and new branch:
 
   $ hg -q up 1
   $ echo 4 > foo
   $ hg -q ci -m 4
   $ hg -q up 0
   $ echo 5 > foo
   $ hg -q branch c
   $ hg -q ci -m 5
 
   $ hg push ../f
   pushing to ../f
   searching for changes
   abort: push creates new remote branches: c!
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
   $ hg push -r 4 -r 5 ../f
   pushing to ../f
   searching for changes
   abort: push creates new remote branches: c!
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
 
 Multiple new branches:
 
   $ hg -q branch d
   $ echo 6 > foo
   $ hg -q ci -m 6
 
   $ hg push ../f
   pushing to ../f
   searching for changes
   abort: push creates new remote branches: c, d!
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
   $ hg push -r 4 -r 6 ../f
   pushing to ../f
   searching for changes
   abort: push creates new remote branches: c, d!
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
   $ cd ../g
 
 
 Fail on multiple head push:
 
   $ hg -q up 1
   $ echo 7 > foo
   $ hg -q ci -m 7
 
   $ hg push -r 4 -r 7 ../f
   pushing to ../f
   searching for changes
   abort: push creates new remote head 0b715ef6ff8f on branch 'a'!
   (did you forget to merge? use push -f to force)
   [255]
 
 Push replacement head on existing branches:
 
   $ hg -q up 3
   $ echo 8 > foo
   $ hg -q ci -m 8
 
   $ hg push -r 7 -r 8 ../f
   pushing to ../f
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 2 changesets with 2 changes to 1 files
 
 
 Merge of branch a to other branch b followed by unrelated push
 on branch a:
 
   $ hg -q up 7
   $ HGMERGE=true hg -q merge 8
   $ hg -q ci -m 9
   $ hg -q up 8
   $ echo 10 > foo
   $ hg -q ci -m 10
 
   $ hg push -r 9 ../f
   pushing to ../f
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files (-1 heads)
 
   $ hg push -r 10 ../f
   pushing to ../f
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files (+1 heads)
 
 
 Cheating the counting algorithm:
 
   $ hg -q up 9
   $ HGMERGE=true hg -q merge 2
   $ hg -q ci -m 11
   $ hg -q up 1
   $ echo 12 > foo
   $ hg -q ci -m 12
 
   $ hg push -r 11 -r 12 ../f
   pushing to ../f
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 2 changesets with 2 changes to 1 files
 
 
 Failed push of new named branch:
 
   $ echo 12 > foo
   $ hg -q ci -m 12a
   [1]
   $ hg -q up 11
   $ echo 13 > foo
   $ hg -q branch e
   $ hg -q ci -m 13d
 
   $ hg push -r 12 -r 13 ../f
   pushing to ../f
   searching for changes
   abort: push creates new remote branches: e!
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
 
 Using --new-branch to push new named branch:
 
   $ hg push --new-branch -r 12 -r 13 ../f
   pushing to ../f
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files
 
 
 Checking prepush logic does not allow silently pushing
 multiple new heads:
 
   $ cd ..
   $ hg init h
   $ echo init > h/init
   $ hg -R h ci -Am init
   adding init
   $ echo a > h/a
   $ hg -R h ci -Am a
   adding a
   $ hg clone h i
   updating to branch default
   2 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ hg -R h up 0
   0 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ echo b > h/b
   $ hg -R h ci -Am b
   adding b
   created new head
   $ hg -R i up 0
   0 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ echo c > i/c
   $ hg -R i ci -Am c
   adding c
   created new head
 
   $ hg -R i push h
   pushing to h
   searching for changes
   abort: push creates new remote head 97bd0c84d346!
   (you should pull and merge or use push -f to force)
   [255]
 
 
 Check prepush logic with merged branches:
 
   $ hg init j
   $ hg -R j branch a
   marked working directory as branch a
   $ echo init > j/foo
   $ hg -R j ci -Am init
   adding foo
   $ hg clone j k
   updating to branch a
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ echo a1 > j/foo
   $ hg -R j ci -m a1
   $ hg -R k branch b
   marked working directory as branch b
   $ echo b > k/foo
   $ hg -R k ci -m b
   $ hg -R k up 0
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 
   $ hg -R k merge b
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
   (branch merge, don't forget to commit)
 
   $ hg -R k ci -m merge
 
   $ hg -R k push -r a j
   pushing to j
   searching for changes
   abort: push creates new remote branches: b!
   (use 'hg push --new-branch' to create new remote branches)
   [255]
 
 
 Prepush -r should not allow you to sneak in new heads:
 
   $ hg init l
   $ cd l
   $ echo a >> foo
   $ hg -q add foo
   $ hg -q branch a
   $ hg -q ci -ma
   $ hg -q up null
   $ echo a >> foo
   $ hg -q add foo
   $ hg -q branch b
   $ hg -q ci -mb
   $ cd ..
   $ hg -q clone l m -u a
   $ cd m
   $ hg -q merge b
   $ hg -q ci -mmb
   $ hg -q up 0
   $ echo a >> foo
   $ hg -q ci -ma2
   $ hg -q up 2
   $ echo a >> foo
   $ hg -q branch -f b
   $ hg -q ci -mb2
   $ hg -q merge 3
   $ hg -q ci -mma
 
   $ hg push ../l -b b
   pushing to ../l
   searching for changes
   abort: push creates new remote head e7e31d71180f on branch 'a'!
   (did you forget to merge? use push -f to force)
   [255]
 
   $ cd ..
 
 
 Check prepush with new branch head on former topo non-head:
 
   $ hg init n
   $ cd n
   $ hg branch A
   marked working directory as branch A
   $ echo a >a
   $ hg ci -Ama
   adding a
   $ hg branch B
   marked working directory as branch B
   $ echo b >b
   $ hg ci -Amb
   adding b
 
 b is now branch head of B, and a topological head
 a is now branch head of A, but not a topological head
 
   $ hg clone . inner
   updating to branch B
   2 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ cd inner
   $ hg up B
   0 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ echo b1 >b1
   $ hg ci -Amb1
   adding b1
 
 in the clone b1 is now the head of B
 
   $ cd ..
   $ hg up 0
   0 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ echo a2 >a2
   $ hg ci -Ama2
   adding a2
 
 a2 is now the new branch head of A, and a new topological head
 it replaces a former inner branch head, so it should at most warn about
 A, not B
 
 glog of local:
 
   $ hg glog --template "{rev}: {branches} {desc}\n"
   @  2: A a2
   |
   | o  1: B b
   |/
   o  0: A a
   
 glog of remote:
 
   $ hg glog -R inner --template "{rev}: {branches} {desc}\n"
   @  2: B b1
   |
   o  1: B b
   |
   o  0: A a
   
 outgoing:
 
   $ hg out inner --template "{rev}: {branches} {desc}\n"
   comparing with inner
   searching for changes
   2: A a2
 
   $ hg push inner
   pushing to inner
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files (+1 heads)
 
   $ cd ..
 
 
 Check prepush with new branch head on former topo head:
 
   $ hg init o
   $ cd o
   $ hg branch A
   marked working directory as branch A
   $ echo a >a
   $ hg ci -Ama
   adding a
   $ hg branch B
   marked working directory as branch B
   $ echo b >b
   $ hg ci -Amb
   adding b
 
 b is now branch head of B, and a topological head
 
   $ hg up 0
   0 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ echo a1 >a1
   $ hg ci -Ama1
   adding a1
 
 a1 is now branch head of A, and a topological head
 
   $ hg clone . inner
   updating to branch A
   2 files updated, 0 files merged, 0 files removed, 0 files unresolved
   $ cd inner
   $ hg up B
   1 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ echo b1 >b1
   $ hg ci -Amb1
   adding b1
 
 in the clone b1 is now the head of B
 
   $ cd ..
   $ echo a2 >a2
   $ hg ci -Ama2
   adding a2
 
 a2 is now the new branch head of A, and a topological head
 it replaces a former topological and branch head, so this should not warn
 
 glog of local:
 
   $ hg glog --template "{rev}: {branches} {desc}\n"
   @  3: A a2
   |
   o  2: A a1
   |
   | o  1: B b
   |/
   o  0: A a
   
 glog of remote:
 
   $ hg glog -R inner --template "{rev}: {branches} {desc}\n"
   @  3: B b1
   |
   | o  2: A a1
   | |
   o |  1: B b
   |/
   o  0: A a
   
 outgoing:
 
   $ hg out inner --template "{rev}: {branches} {desc}\n"
   comparing with inner
   searching for changes
   3: A a2
 
   $ hg push inner
   pushing to inner
   searching for changes
   adding changesets
   adding manifests
   adding file changes
   added 1 changesets with 1 changes to 1 files
 
   $ cd ..
 
 
 Check prepush with new branch head and new child of former branch head
 but child is on different branch:
 
   $ hg init p
   $ cd p
   $ hg branch A
   marked working directory as branch A
   $ echo a0 >a
   $ hg ci -Ama0
   adding a
   $ echo a1 >a
   $ hg ci -ma1
   $ hg up null
   0 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ hg branch B
   marked working directory as branch B
   $ echo b0 >b
   $ hg ci -Amb0
   adding b
   $ echo b1 >b
   $ hg ci -mb1
 
   $ hg clone . inner
   updating to branch B
   1 files updated, 0 files merged, 0 files removed, 0 files unresolved
 
   $ hg up A
   1 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ hg branch -f B
   marked working directory as branch B
   $ echo a3 >a
   $ hg ci -ma3
   created new head
   $ hg up 3
   1 files updated, 0 files merged, 1 files removed, 0 files unresolved
   $ hg branch -f A
   marked working directory as branch A
   $ echo b3 >b
   $ hg ci -mb3
   created new head
 
 glog of local:
 
   $ hg glog --template "{rev}: {branches} {desc}\n"
   @  5: A b3
   |
   | o  4: B a3
   | |
   o |  3: B b1
   | |
   o |  2: B b0
    /
   o  1: A a1
   |
   o  0: A a0
   
 glog of remote:
 
   $ hg glog -R inner --template "{rev}: {branches} {desc}\n"
   @  3: B b1
   |
   o  2: B b0
   
   o  1: A a1
   |
   o  0: A a0
   
 outgoing:
 
   $ hg out inner --template "{rev}: {branches} {desc}\n"
   comparing with inner
   searching for changes
   4: B a3
   5: A b3
 
   $ hg push inner
   pushing to inner
   searching for changes
   abort: push creates new remote head 7d0f4fb6cf04 on branch 'A'!
   (did you forget to merge? use push -f to force)
   [255]
 
   $ hg push inner -r4 -r5
   pushing to inner
   searching for changes
   abort: push creates new remote head 7d0f4fb6cf04 on branch 'A'!
   (did you forget to merge? use push -f to force)
   [255]
 
   $ hg in inner
   comparing with inner
   searching for changes
   no changes found
   [1]

tests/test-schemes.t

@@ -1,47 +1,47
 
   $ cat <<EOF >> $HGRCPATH
   > [extensions]
   > schemes=
   > 
   > [schemes]
   > l = http://localhost:$HGPORT/
   > parts = http://{1}:$HGPORT/
   > z = file:\$PWD/
   > EOF
   $ hg init test
   $ cd test
   $ echo a > a
   $ hg ci -Am initial
   adding a
   $ hg serve -n test -p $HGPORT -d --pid-file=hg.pid -A access.log -E errors.log
   $ cat hg.pid >> $DAEMON_PIDS
   $ hg incoming l://
   comparing with l://
   searching for changes
   no changes found
   [1]
 
 check that {1} syntax works
 
   $ hg incoming --debug parts://localhost
   using http://localhost:$HGPORT/
   sending capabilities command
   comparing with parts://localhost/
   query 1; heads
-  sending heads command
+  sending batch command
   searching for changes
   all remote heads known locally
   no changes found
   [1]
 
 check that paths are expanded
 
   $ PWD=`pwd` hg incoming z://
   comparing with z://
   searching for changes
   no changes found
   [1]
 
 errors
 
   $ cat errors.log

tests/test-setdiscovery.t

@@ -1,271 +1,268
 
 Function to test discovery between two repos in both directions, using both the local shortcut
 (which is currently not activated by default) and the full remotable protocol:
 
   $ testdesc() { # revs_a, revs_b, dagdesc
   >     if [ -e foo ]; then rm -rf foo; fi
   >     hg init foo
   >     cd foo
   >     hg debugbuilddag "$3"
   >     hg clone . a $1 --quiet
   >     hg clone . b $2 --quiet
   >     echo
   >     echo "% -- a -> b tree"
   >     hg -R a debugdiscovery b --verbose --old
   >     echo
   >     echo "% -- a -> b set"
   >     hg -R a debugdiscovery b --verbose --debug
   >     echo
   >     echo "% -- b -> a tree"
   >     hg -R b debugdiscovery a --verbose --old
   >     echo
   >     echo "% -- b -> a set"
   >     hg -R b debugdiscovery a --verbose --debug
   >     cd ..
   > }
 
 
 Small superset:
 
   $ testdesc '-ra1 -ra2' '-rb1 -rb2 -rb3' '
   > +2:f +1:a1:b1
   > <f +4 :a2
   > +5 :b2
   > <f +3 :b3'
   
   % -- a -> b tree
   comparing with b
   searching for changes
   unpruned common: b5714e113bc0 66f7d451a68b 01241442b3c2
   common heads: b5714e113bc0 01241442b3c2
   local is subset
   
   % -- a -> b set
   comparing with b
   query 1; heads
   searching for changes
-  taking initial sample
-  searching: 2 queries
-  query 2; still undecided: 4, sample size is: 4
-  2 total queries
+  all local heads known remotely
   common heads: b5714e113bc0 01241442b3c2
   local is subset
   
   % -- b -> a tree
   comparing with a
   searching for changes
   unpruned common: b5714e113bc0 01241442b3c2
   common heads: b5714e113bc0 01241442b3c2
   remote is subset
   
   % -- b -> a set
   comparing with a
   query 1; heads
   searching for changes
   all remote heads known locally
   common heads: b5714e113bc0 01241442b3c2
   remote is subset
 
 
 Many new:
 
   $ testdesc '-ra1 -ra2' '-rb' '
   > +2:f +3:a1 +3:b
   > <f +30 :a2'
   
   % -- a -> b tree
   comparing with b
   searching for changes
   unpruned common: bebd167eb94d
   common heads: bebd167eb94d
   
   % -- a -> b set
   comparing with b
   query 1; heads
   searching for changes
-  taking quick initial sample
+  taking initial sample
   searching: 2 queries
-  query 2; still undecided: 35, sample size is: 35
+  query 2; still undecided: 29, sample size is: 29
   2 total queries
   common heads: bebd167eb94d
   
   % -- b -> a tree
   comparing with a
   searching for changes
   unpruned common: bebd167eb94d 66f7d451a68b
   common heads: bebd167eb94d
   
   % -- b -> a set
   comparing with a
   query 1; heads
   searching for changes
   taking initial sample
   searching: 2 queries
-  query 2; still undecided: 3, sample size is: 3
+  query 2; still undecided: 2, sample size is: 2
   2 total queries
   common heads: bebd167eb94d
 
 
 Both sides many new with stub:
 
   $ testdesc '-ra1 -ra2' '-rb' '
   > +2:f +2:a1 +30 :b
   > <f +30 :a2'
   
   % -- a -> b tree
   comparing with b
   searching for changes
   unpruned common: 2dc09a01254d
   common heads: 2dc09a01254d
   
   % -- a -> b set
   comparing with b
   query 1; heads
   searching for changes
-  taking quick initial sample
+  taking initial sample
   searching: 2 queries
-  query 2; still undecided: 34, sample size is: 34
+  query 2; still undecided: 29, sample size is: 29
   2 total queries
   common heads: 2dc09a01254d
   
   % -- b -> a tree
   comparing with a
   searching for changes
   unpruned common: 66f7d451a68b 2dc09a01254d
   common heads: 2dc09a01254d
   
   % -- b -> a set
   comparing with a
   query 1; heads
   searching for changes
   taking initial sample
   searching: 2 queries
-  query 2; still undecided: 30, sample size is: 30
+  query 2; still undecided: 29, sample size is: 29
   2 total queries
   common heads: 2dc09a01254d
 
 
 Both many new:
 
   $ testdesc '-ra' '-rb' '
   > +2:f +30 :b
   > <f +30 :a'
   
   % -- a -> b tree
   comparing with b
   searching for changes
   unpruned common: 66f7d451a68b
   common heads: 66f7d451a68b
   
   % -- a -> b set
   comparing with b
   query 1; heads
   searching for changes
   taking quick initial sample
   searching: 2 queries
-  query 2; still undecided: 32, sample size is: 32
+  query 2; still undecided: 31, sample size is: 31
   2 total queries
   common heads: 66f7d451a68b
   
   % -- b -> a tree
   comparing with a
   searching for changes
   unpruned common: 66f7d451a68b
   common heads: 66f7d451a68b
   
   % -- b -> a set
   comparing with a
   query 1; heads
   searching for changes
   taking quick initial sample
   searching: 2 queries
-  query 2; still undecided: 32, sample size is: 32
+  query 2; still undecided: 31, sample size is: 31
   2 total queries
   common heads: 66f7d451a68b
 
 
 Both many new skewed:
 
   $ testdesc '-ra' '-rb' '
   > +2:f +30 :b
   > <f +50 :a'
   
   % -- a -> b tree
   comparing with b
   searching for changes
   unpruned common: 66f7d451a68b
   common heads: 66f7d451a68b
   
   % -- a -> b set
   comparing with b
   query 1; heads
   searching for changes
   taking quick initial sample
   searching: 2 queries
-  query 2; still undecided: 52, sample size is: 52
+  query 2; still undecided: 51, sample size is: 51
   2 total queries
   common heads: 66f7d451a68b
   
   % -- b -> a tree
   comparing with a
   searching for changes
   unpruned common: 66f7d451a68b
   common heads: 66f7d451a68b
   
   % -- b -> a set
   comparing with a
   query 1; heads
   searching for changes
   taking quick initial sample
   searching: 2 queries
-  query 2; still undecided: 32, sample size is: 32
+  query 2; still undecided: 31, sample size is: 31
   2 total queries
   common heads: 66f7d451a68b
 
 
 Both many new on top of long history:
 
   $ testdesc '-ra' '-rb' '
   > +1000:f +30 :b
   > <f +50 :a'
   
   % -- a -> b tree
   comparing with b
   searching for changes
   unpruned common: 7ead0cba2838
   common heads: 7ead0cba2838
   
   % -- a -> b set
   comparing with b
   query 1; heads
   searching for changes
   taking quick initial sample
   searching: 2 queries
-  query 2; still undecided: 1050, sample size is: 11
+  query 2; still undecided: 1049, sample size is: 11
   sampling from both directions
   searching: 3 queries
   query 3; still undecided: 31, sample size is: 31
   3 total queries
   common heads: 7ead0cba2838
   
   % -- b -> a tree
   comparing with a
   searching for changes
   unpruned common: 7ead0cba2838
   common heads: 7ead0cba2838
   
   % -- b -> a set
   comparing with a
   query 1; heads
   searching for changes
   taking quick initial sample
   searching: 2 queries
-  query 2; still undecided: 1030, sample size is: 11
+  query 2; still undecided: 1029, sample size is: 11
   sampling from both directions
   searching: 3 queries
   query 3; still undecided: 16, sample size is: 16
   3 total queries
   common heads: 7ead0cba2838