upstream/mercurial-mirror Files · tests/blackbox-readonly-dispatch.py

phabricator: warn if unable to amend, instead of aborting after posting...

phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

Yuya Nishihara - - Load All Authors

File last commit:

r40760:c93d046d default


                r41198:0101a35d

default

Download file

             blackbox-readonly-dispatch.py
        
                    40 lines
            
             | 1.1 KiB
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / blackbox-readonly-dispatch.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      from __future__ import absolute_import

      import os

      from mercurial import (

          dispatch,

          extensions,

          ui as uimod,

      )

      def testdispatch(cmd):

          """Simple wrapper around dispatch.dispatch()

          Prints command and result value, but does not handle quoting.

          """

          ui = uimod.ui.load()

          extensions.populateui(ui)

          ui.status(b"running: %s\n" % cmd)

          req = dispatch.request(cmd.split(), ui)

          result = dispatch.dispatch(req)

          ui.status(b"result: %r\n" % result)

      # create file 'foo', add and commit

      f = open(b'foo', 'wb')

      f.write(b'foo\n')

      f.close()

      testdispatch(b"--debug add foo")

      testdispatch(b"--debug commit -m commit1 -d 2000-01-01 foo")

      # append to file 'foo' and commit

      f = open(b'foo', 'ab')

      f.write(b'bar\n')

      f.close()

      # remove blackbox.log directory (proxy for readonly log file)

      os.rmdir(b".hg/blackbox.log")

      # replace it with the real blackbox.log file

      os.rename(b".hg/blackbox.log-", b".hg/blackbox.log")

      testdispatch(b"--debug commit -m commit2 -d 2000-01-02 foo")

      # check 88803a69b24 (fancyopts modified command table)

      testdispatch(b"--debug log -r 0")

      testdispatch(b"--debug log -r tip")

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				from __future__ import absolute_import
				import os
				from mercurial import (
				dispatch,
				extensions,
				ui as uimod,
				)

				def testdispatch(cmd):
				"""Simple wrapper around dispatch.dispatch()

				Prints command and result value, but does not handle quoting.
				"""
				ui = uimod.ui.load()
				extensions.populateui(ui)
				ui.status(b"running: %s\n" % cmd)
				req = dispatch.request(cmd.split(), ui)
				result = dispatch.dispatch(req)
				ui.status(b"result: %r\n" % result)

				# create file 'foo', add and commit
				f = open(b'foo', 'wb')
				f.write(b'foo\n')
				f.close()
				testdispatch(b"--debug add foo")
				testdispatch(b"--debug commit -m commit1 -d 2000-01-01 foo")

				# append to file 'foo' and commit
				f = open(b'foo', 'ab')
				f.write(b'bar\n')
				f.close()
				# remove blackbox.log directory (proxy for readonly log file)
				os.rmdir(b".hg/blackbox.log")
				# replace it with the real blackbox.log file
				os.rename(b".hg/blackbox.log-", b".hg/blackbox.log")
				testdispatch(b"--debug commit -m commit2 -d 2000-01-02 foo")

				# check 88803a69b24 (fancyopts modified command table)
				testdispatch(b"--debug log -r 0")
				testdispatch(b"--debug log -r tip")