upstream/mercurial-mirror Files · tests/test-abort-checkin.t

phabricator: warn if unable to amend, instead of aborting after posting...

phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

Pulkit Goyal - - Load All Authors

File last commit:

r36393:f798709e default


                r41198:0101a35d

default

Download file

             test-abort-checkin.t
        
                    37 lines
            
             | 873 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-abort-checkin.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ cat > abortcommit.py <<EOF

        > from mercurial import error

        > def hook(**args):

        >     raise error.Abort(b"no commits allowed")

        > def reposetup(ui, repo):

        >     repo.ui.setconfig(b"hooks", b"pretxncommit.nocommits", hook)

        > EOF

        $ abspath=`pwd`/abortcommit.py

        $ cat <<EOF >> $HGRCPATH

        > [extensions]

        > mq =

        > abortcommit = $abspath

        > EOF

        $ hg init foo

        $ cd foo

        $ echo foo > foo

        $ hg add foo

      mq may keep a reference to the repository so __del__ will not be

      called and .hg/journal.dirstate will not be deleted:

        $ hg ci -m foo

        error: pretxncommit.nocommits hook failed: no commits allowed

        transaction abort!

        rollback completed

        abort: no commits allowed

        [255]

        $ hg ci -m foo

        error: pretxncommit.nocommits hook failed: no commits allowed

        transaction abort!

        rollback completed

        abort: no commits allowed

        [255]

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ cat > abortcommit.py <<EOF
				> from mercurial import error
				> def hook(**args):
				> raise error.Abort(b"no commits allowed")
				> def reposetup(ui, repo):
				> repo.ui.setconfig(b"hooks", b"pretxncommit.nocommits", hook)
				> EOF
				$ abspath=`pwd`/abortcommit.py

				$ cat <<EOF >> $HGRCPATH
				> [extensions]
				> mq =
				> abortcommit = $abspath
				> EOF

				$ hg init foo
				$ cd foo
				$ echo foo > foo
				$ hg add foo

				mq may keep a reference to the repository so __del__ will not be
				called and .hg/journal.dirstate will not be deleted:

				$ hg ci -m foo
				error: pretxncommit.nocommits hook failed: no commits allowed
				transaction abort!
				rollback completed
				abort: no commits allowed
				[255]
				$ hg ci -m foo
				error: pretxncommit.nocommits hook failed: no commits allowed
				transaction abort!
				rollback completed
				abort: no commits allowed
				[255]

				$ cd ..