upstream/mercurial-mirror Files · tests/test-merge10.t

phabricator: warn if unable to amend, instead of aborting after posting...

phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

Denis Laxalde - - Load All Authors

File last commit:

r34662:eb586ed5 default


                r41198:0101a35d

default

Download file

             test-merge10.t
        
                    54 lines
            
             | 1.4 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-merge10.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      Test for changeset 9fe267f77f56ff127cf7e65dc15dd9de71ce8ceb

      (merge correctly when all the files in a directory are moved

      but then local changes are added in the same directory)

        $ hg init a

        $ cd a

        $ mkdir -p testdir

        $ echo a > testdir/a

        $ hg add testdir/a

        $ hg commit -m a

        $ cd ..

        $ hg clone a b

        updating to branch default

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ cd a

        $ echo alpha > testdir/a

        $ hg commit -m remote-change

        $ cd ..

        $ cd b

        $ mkdir testdir/subdir

        $ hg mv testdir/a testdir/subdir/a

        $ hg commit -m move

        $ mkdir newdir

        $ echo beta > newdir/beta

        $ hg add newdir/beta

        $ hg commit -m local-addition

        $ hg pull ../a

        pulling from ../a

        searching for changes

        adding changesets

        adding manifests

        adding file changes

        added 1 changesets with 1 changes to 1 files (+1 heads)

        new changesets cc7000b01af9

        (run 'hg heads' to see heads, 'hg merge' to merge)

        $ hg up -C 2

        0 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ hg merge

        merging testdir/subdir/a and testdir/a to testdir/subdir/a

        0 files updated, 1 files merged, 0 files removed, 0 files unresolved

        (branch merge, don't forget to commit)

        $ hg stat

        M testdir/subdir/a

        $ hg diff --nodates

        diff -r bc21c9773bfa testdir/subdir/a

        --- a/testdir/subdir/a

        +++ b/testdir/subdir/a

        @@ -1,1 +1,1 @@

        -a

        +alpha

        $ cd ..

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				Test for changeset 9fe267f77f56ff127cf7e65dc15dd9de71ce8ceb
				(merge correctly when all the files in a directory are moved
				but then local changes are added in the same directory)

				$ hg init a
				$ cd a
				$ mkdir -p testdir
				$ echo a > testdir/a
				$ hg add testdir/a
				$ hg commit -m a
				$ cd ..

				$ hg clone a b
				updating to branch default
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved
				$ cd a
				$ echo alpha > testdir/a
				$ hg commit -m remote-change
				$ cd ..

				$ cd b
				$ mkdir testdir/subdir
				$ hg mv testdir/a testdir/subdir/a
				$ hg commit -m move
				$ mkdir newdir
				$ echo beta > newdir/beta
				$ hg add newdir/beta
				$ hg commit -m local-addition
				$ hg pull ../a
				pulling from ../a
				searching for changes
				adding changesets
				adding manifests
				adding file changes
				added 1 changesets with 1 changes to 1 files (+1 heads)
				new changesets cc7000b01af9
				(run 'hg heads' to see heads, 'hg merge' to merge)
				$ hg up -C 2
				0 files updated, 0 files merged, 0 files removed, 0 files unresolved
				$ hg merge
				merging testdir/subdir/a and testdir/a to testdir/subdir/a
				0 files updated, 1 files merged, 0 files removed, 0 files unresolved
				(branch merge, don't forget to commit)
				$ hg stat
				M testdir/subdir/a
				$ hg diff --nodates
				diff -r bc21c9773bfa testdir/subdir/a
				--- a/testdir/subdir/a
				+++ b/testdir/subdir/a
				@@ -1,1 +1,1 @@
				-a
				+alpha

				$ cd ..