upstream/mercurial-mirror Files · tests/test-narrow-clone-non-narrow-server.t

phabricator: warn if unable to amend, instead of aborting after posting...

phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

Pulkit Goyal - - Load All Authors

File last commit:

r40462:30a7d3b6 default


                r41198:0101a35d

default

Download file

             test-narrow-clone-non-narrow-server.t
        
                    67 lines
            
             | 2.0 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-narrow-clone-non-narrow-server.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      Test attempting a narrow clone against a server that doesn't support narrowhg.

        $ . "$TESTDIR/narrow-library.sh"

        $ hg init master

        $ cd master

        $ for x in `$TESTDIR/seq.py 10`; do

        >   echo $x > "f$x"

        >   hg add "f$x"

        >   hg commit -m "Add $x"

        > done

        $ hg serve -a localhost -p $HGPORT1 --config extensions.narrow=! -d \

        >    --pid-file=hg.pid

        $ cat hg.pid >> "$DAEMON_PIDS"

        $ hg serve -a localhost -p $HGPORT2 -d --pid-file=hg.pid

        $ cat hg.pid >> "$DAEMON_PIDS"

      Verify that narrow is advertised in the bundle2 capabilities:

        $ cat >> unquote.py <<EOF

        > from __future__ import print_function

        > import sys

        > if sys.version[0] == '3':

        >     import urllib.parse as up

        >     unquote = up.unquote_plus

        > else:

        >     import urllib

        >     unquote = urllib.unquote_plus

        > print(unquote(list(sys.stdin)[1]))

        > EOF

        $ echo hello | hg -R . serve --stdio | \

        >   "$PYTHON" unquote.py | tr ' ' '\n' | grep narrow

        exp-narrow-1

        $ cd ..

        $ hg clone --narrow --include f1 http://localhost:$HGPORT1/ narrowclone

        requesting all changes

        abort: server does not support narrow clones

        [255]

      Make a narrow clone (via HGPORT2), then try to narrow and widen

      into it (from HGPORT1) to prove that narrowing is fine and widening fails

      gracefully:

        $ hg clone -r 0 --narrow --include f1 http://localhost:$HGPORT2/ narrowclone

        adding changesets

        adding manifests

        adding file changes

        added 1 changesets with 1 changes to 1 files

        new changesets * (glob)

        updating to branch default

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ cd narrowclone

        $ hg tracked --addexclude f2 http://localhost:$HGPORT1/

        comparing with http://localhost:$HGPORT1/

        searching for changes

        looking for local changes to affected paths

        $ hg tracked --addinclude f1 http://localhost:$HGPORT1/

        nothing to widen or narrow

        $ hg tracked --addinclude f9 http://localhost:$HGPORT1/

        comparing with http://localhost:$HGPORT1/

        abort: server does not support narrow clones

        [255]

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				Test attempting a narrow clone against a server that doesn't support narrowhg.

				$ . "$TESTDIR/narrow-library.sh"

				$ hg init master
				$ cd master

				$ for x in `$TESTDIR/seq.py 10`; do
				> echo $x > "f$x"
				> hg add "f$x"
				> hg commit -m "Add $x"
				> done

				$ hg serve -a localhost -p $HGPORT1 --config extensions.narrow=! -d \
				> --pid-file=hg.pid
				$ cat hg.pid >> "$DAEMON_PIDS"
				$ hg serve -a localhost -p $HGPORT2 -d --pid-file=hg.pid
				$ cat hg.pid >> "$DAEMON_PIDS"

				Verify that narrow is advertised in the bundle2 capabilities:

				$ cat >> unquote.py <<EOF
				> from __future__ import print_function
				> import sys
				> if sys.version[0] == '3':
				> import urllib.parse as up
				> unquote = up.unquote_plus
				> else:
				> import urllib
				> unquote = urllib.unquote_plus
				> print(unquote(list(sys.stdin)[1]))
				> EOF
				$ echo hello \| hg -R . serve --stdio \| \
				> "$PYTHON" unquote.py \| tr ' ' '\n' \| grep narrow
				exp-narrow-1

				$ cd ..

				$ hg clone --narrow --include f1 http://localhost:$HGPORT1/ narrowclone
				requesting all changes
				abort: server does not support narrow clones
				[255]

				Make a narrow clone (via HGPORT2), then try to narrow and widen
				into it (from HGPORT1) to prove that narrowing is fine and widening fails
				gracefully:
				$ hg clone -r 0 --narrow --include f1 http://localhost:$HGPORT2/ narrowclone
				adding changesets
				adding manifests
				adding file changes
				added 1 changesets with 1 changes to 1 files
				new changesets * (glob)
				updating to branch default
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved
				$ cd narrowclone
				$ hg tracked --addexclude f2 http://localhost:$HGPORT1/
				comparing with http://localhost:$HGPORT1/
				searching for changes
				looking for local changes to affected paths

				$ hg tracked --addinclude f1 http://localhost:$HGPORT1/
				nothing to widen or narrow

				$ hg tracked --addinclude f9 http://localhost:$HGPORT1/
				comparing with http://localhost:$HGPORT1/
				abort: server does not support narrow clones
				[255]