upstream/mercurial-mirror Files · tests/test-revlog.t

phabricator: warn if unable to amend, instead of aborting after posting...

phabricator: warn if unable to amend, instead of aborting after posting There was a divergence in behavior here between obsolete and strip based amending. I first noticed the abort when testing outside of the test harness, but then had trouble recreating it here after reverting the code changes. It turns out, strip based amend was successfully amending the public commit after it was posted! It looks like the protection is in the `commit --amend` command, not in the underlying code that it calls. I considered doing a preflight check and aborting. But the locks are only acquired at the end, if amending, and this is too large a section of code to be wrapped in a maybe-it's-held-or-not context manager for my tastes. Additionally, some people do post-push reviews, and amending is the default behavior, so they shouldn't see a misleading error message. The lack of a 'Differential Revision' entry in the commit message breaks a {phabreview} test, so it had to be partially conditionalized.

Mark Thomas - - Load All Authors

File last commit:

r40317:29b0e9cd default


                r41198:0101a35d

default

Download file

             test-revlog.t
        
                    53 lines
            
             | 1.4 KiB
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-revlog.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

        $ hg init empty-repo

        $ cd empty-repo

      Flags on revlog version 0 are rejected

        >>> with open('.hg/store/00changelog.i', 'wb') as fh:

        ...     fh.write(b'\x00\x01\x00\x00') and None

        $ hg log

        abort: unknown flags (0x01) in version 0 revlog 00changelog.i!

        [255]

      Unknown flags on revlog version 1 are rejected

        >>> with open('.hg/store/00changelog.i', 'wb') as fh:

        ...     fh.write(b'\x00\x04\x00\x01') and None

        $ hg log

        abort: unknown flags (0x04) in version 1 revlog 00changelog.i!

        [255]

      Unknown version is rejected

        >>> with open('.hg/store/00changelog.i', 'wb') as fh:

        ...     fh.write(b'\x00\x00\x00\x02') and None

        $ hg log

        abort: unknown version (2) in revlog 00changelog.i!

        [255]

        $ cd ..

      Test for CVE-2016-3630

        $ hg init

        >>> import codecs

        >>> open("a.i", "wb").write(codecs.decode(codecs.decode(

        ... b"""eJxjYGZgZIAAYQYGxhgom+k/FMx8YKx9ZUaKSOyqo4cnuKb8mbqHV5cBCVTMWb1Cwqkhe4Gsg9AD

        ... Joa3dYtcYYYBAQ8Qr4OqZAYRICPTSr5WKd/42rV36d+8/VmrNpv7NP1jQAXrQE4BqQUARngwVA==""",

        ... "base64"), "zlib")) and None

        $ hg debugrevlogindex a.i

           rev linkrev nodeid       p1           p2

             0       2 99e0332bd498 000000000000 000000000000

             1       3 6674f57a23d8 99e0332bd498 000000000000

        >>> from mercurial import revlog, vfs

        >>> tvfs = vfs.vfs(b'.')

        >>> tvfs.options = {b'revlogv1': True}

        >>> rl = revlog.revlog(tvfs, b'a.i')

        >>> rl.revision(1)

        mpatchError(*'patch cannot be decoded'*) (glob)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				$ hg init empty-repo
				$ cd empty-repo

				Flags on revlog version 0 are rejected

				>>> with open('.hg/store/00changelog.i', 'wb') as fh:
				... fh.write(b'\x00\x01\x00\x00') and None

				$ hg log
				abort: unknown flags (0x01) in version 0 revlog 00changelog.i!
				[255]

				Unknown flags on revlog version 1 are rejected

				>>> with open('.hg/store/00changelog.i', 'wb') as fh:
				... fh.write(b'\x00\x04\x00\x01') and None

				$ hg log
				abort: unknown flags (0x04) in version 1 revlog 00changelog.i!
				[255]

				Unknown version is rejected

				>>> with open('.hg/store/00changelog.i', 'wb') as fh:
				... fh.write(b'\x00\x00\x00\x02') and None

				$ hg log
				abort: unknown version (2) in revlog 00changelog.i!
				[255]

				$ cd ..

				Test for CVE-2016-3630

				$ hg init

				>>> import codecs
				>>> open("a.i", "wb").write(codecs.decode(codecs.decode(
				... b"""eJxjYGZgZIAAYQYGxhgom+k/FMx8YKx9ZUaKSOyqo4cnuKb8mbqHV5cBCVTMWb1Cwqkhe4Gsg9AD
				... Joa3dYtcYYYBAQ8Qr4OqZAYRICPTSr5WKd/42rV36d+8/VmrNpv7NP1jQAXrQE4BqQUARngwVA==""",
				... "base64"), "zlib")) and None

				$ hg debugrevlogindex a.i
				rev linkrev nodeid p1 p2
				0 2 99e0332bd498 000000000000 000000000000
				1 3 6674f57a23d8 99e0332bd498 000000000000

				>>> from mercurial import revlog, vfs
				>>> tvfs = vfs.vfs(b'.')
				>>> tvfs.options = {b'revlogv1': True}
				>>> rl = revlog.revlog(tvfs, b'a.i')
				>>> rl.revision(1)
				mpatchError('patch cannot be decoded') (glob)