upstream/mercurial-mirror Files · rust/hg-cpython/src/debug.rs

dirstate-tree: Avoid BTreeMap double-lookup when inserting a dirstate entry...

dirstate-tree: Avoid BTreeMap double-lookup when inserting a dirstate entry The child nodes of a given node in the tree-shaped dirstate are kept in a `BTreeMap` where keys are file names as strings. Finding or inserting a value in the map takes `O(log(n))` string comparisons, which adds up when constructing the tree. The `entry` API allows finding a "spot" in the map that may or may not be occupied and then access that value or insert a new one without doing map lookup again. However the current API is limited in that calling `entry` requires an owned key (and so a memory allocation), even if it ends up not being used in the case where the map already has a value with an equal key. This is still a win, with 4% better end-to-end time for `hg status` measured here with hyperfine: ``` Benchmark : ../hg2/hg status -R $REPO --config=experimental.dirstate-tree.in-memory=1 Time (mean ± σ): 1.337 s ± 0.018 s [User: 892.9 ms, System: 437.5 ms] Range (min … max): 1.316 s … 1.373 s 10 runs Benchmark : ./hg status -R $REPO --config=experimental.dirstate-tree.in-memory=1 Time (mean ± σ): 1.291 s ± 0.008 s [User: 853.4 ms, System: 431.1 ms] Range (min … max): 1.283 s … 1.309 s 10 runs Summary './hg status -R $REPO --config=experimental.dirstate-tree.in-memory=1' ran 1.04 ± 0.02 times faster than '../hg2/hg status -R $REPO --config=experimental.dirstate-tree.in-memory=1' ``` * ./hg is this revision * ../hg2/hg is its parent * $REPO is an old snapshot of mozilla-central Differential Revision: https://phab.mercurial-scm.org/D10550

Raphaël Gomès - - Load All Authors

File last commit:

r45406:9f96beb9 default


                r47886:04bcba53

default

Download file

             debug.rs
        
                    24 lines
            
             | 822 B
            
                | application/rls-services+xml
            
             |
                RustLexer
            
             / rust / hg-cpython / src / debug.rs
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      // debug.rs

      //

      // Copyright 2020 Raphaël Gomès <rgomes@octobus.net>

      //

      // This software may be used and distributed according to the terms of the

      // GNU General Public License version 2 or any later version.

      //! Module to get debug information about Rust extensions.

      use cpython::{PyDict, PyModule, PyResult, Python};

      /// Create the module, with `__package__` given from parent

      pub fn init_module(py: Python, package: &str) -> PyResult<PyModule> {

          let dotted_name = &format!("{}.debug", package);

          let m = PyModule::new(py, dotted_name)?;

          m.add(py, "__package__", package)?;

          m.add(py, "__doc__", "Rust debugging information")?;

          let sys = PyModule::import(py, "sys")?;

          let sys_modules: PyDict = sys.get(py, "modules")?.extract(py)?;

          sys_modules.set_item(py, dotted_name, &m)?;

          Ok(m)

      }

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				// debug.rs
				//
				// Copyright 2020 Raphaël Gomès <rgomes@octobus.net>
				//
				// This software may be used and distributed according to the terms of the
				// GNU General Public License version 2 or any later version.

				//! Module to get debug information about Rust extensions.
				use cpython::{PyDict, PyModule, PyResult, Python};

				/// Create the module, with `__package__` given from parent
				pub fn init_module(py: Python, package: &str) -> PyResult<PyModule> {
				let dotted_name = &format!("{}.debug", package);
				let m = PyModule::new(py, dotted_name)?;

				m.add(py, "__package__", package)?;
				m.add(py, "__doc__", "Rust debugging information")?;

				let sys = PyModule::import(py, "sys")?;
				let sys_modules: PyDict = sys.get(py, "modules")?.extract(py)?;
				sys_modules.set_item(py, dotted_name, &m)?;

				Ok(m)
				}