upstream/mercurial-mirror Files · tests/hgweberror.py

tryimportone: use dirstateguard instead of beginparentchange/endparentchange...

tryimportone: use dirstateguard instead of beginparentchange/endparentchange To fix the issue that the recent (in memory) dirstate isn't visible to external process (e.g. "precommit" hook), a subsequent patch makes "localrepository.commit()" invoke "dirstate.write()" in it. This change will make "beginparentchange()" and "endparentchange()" on dirstate in "cmdutil.tryimportone()" meaningless, because: - "dirstate.write()" writes changed data into ".hg/dirstate", but - aborting between "beginparentchange()" and "endparentchange()" doesn't cause any restoring ".hg/dirstate" it just discards changes in memory. This patch uses "dirstateguard" instead of "beginparentchange()" and "endparentchange()" in "cmdutil.tryimportone()" to restore ".hg/dirstate" during a failure even if "dirstate.write()" is executed before a failure. This patch uses "lockmod.release(dsguard)" instead of "dsguard.release()", because processing may be aborted before assignment to "dsguard" , and the "if dsguard" examination for safety is redundant.

Gregory Szorc - - Load All Authors

File last commit:

r23409:dc4d2cd3 stable


                r24995:0579b0c2

default

Download file

             hgweberror.py
        
                    17 lines
            
             | 547 B
            
                | text/x-python
            
             |
                PythonLexer
            
             / tests / hgweberror.py
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      # A dummy extension that installs an hgweb command that throws an Exception.

      from mercurial.hgweb import webcommands

      def raiseerror(web, req, tmpl):

          '''Dummy web command that raises an uncaught Exception.'''

          # Simulate an error after partial response.

          if 'partialresponse' in req.form:

              req.respond(200, 'text/plain')

              req.write('partial content\n')

          raise AttributeError('I am an uncaught error!')

      def extsetup(ui):

          setattr(webcommands, 'raiseerror', raiseerror)

          webcommands.__all__.append('raiseerror')

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				# A dummy extension that installs an hgweb command that throws an Exception.

				from mercurial.hgweb import webcommands

				def raiseerror(web, req, tmpl):
				'''Dummy web command that raises an uncaught Exception.'''

				# Simulate an error after partial response.
				if 'partialresponse' in req.form:
				req.respond(200, 'text/plain')
				req.write('partial content\n')

				raise AttributeError('I am an uncaught error!')

				def extsetup(ui):
				setattr(webcommands, 'raiseerror', raiseerror)
				webcommands.__all__.append('raiseerror')