upstream/mercurial-mirror Files · tests/test-check-commit-hg.t

tryimportone: use dirstateguard instead of beginparentchange/endparentchange...

tryimportone: use dirstateguard instead of beginparentchange/endparentchange To fix the issue that the recent (in memory) dirstate isn't visible to external process (e.g. "precommit" hook), a subsequent patch makes "localrepository.commit()" invoke "dirstate.write()" in it. This change will make "beginparentchange()" and "endparentchange()" on dirstate in "cmdutil.tryimportone()" meaningless, because: - "dirstate.write()" writes changed data into ".hg/dirstate", but - aborting between "beginparentchange()" and "endparentchange()" doesn't cause any restoring ".hg/dirstate" it just discards changes in memory. This patch uses "dirstateguard" instead of "beginparentchange()" and "endparentchange()" in "cmdutil.tryimportone()" to restore ".hg/dirstate" during a failure even if "dirstate.write()" is executed before a failure. This patch uses "lockmod.release(dsguard)" instead of "dsguard.release()", because processing may be aborted before assignment to "dsguard" , and the "if dsguard" examination for safety is redundant.

Martin von Zweigbergk - - Load All Authors

File last commit:

r23623:80a37f70 default


                r24995:0579b0c2

default

Download file

             test-check-commit-hg.t
        
                    24 lines
            
             | 617 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-check-commit-hg.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #require test-repo

      Enable obsolescence to avoid the warning issue when obsmarker are found

        $ cat >> $HGRCPATH << EOF

        > [experimental]

        > evolution=createmarkers

        > EOF

      Go back in the hg repo

        $ cd $TESTDIR/..

        $ for node in `hg log --rev 'draft() and ::.' --template '{node|short}\n'`; do

        >    hg export $node | contrib/check-commit > ${TESTTMP}/check-commit.out

        >    if [ $? -ne 0 ]; then

        >        echo "Revision $node does not comply to rules"

        >        echo '------------------------------------------------------'

        >        cat ${TESTTMP}/check-commit.out

        >        echo

        >   fi

        > done

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#require test-repo

				Enable obsolescence to avoid the warning issue when obsmarker are found

				$ cat >> $HGRCPATH << EOF
				> [experimental]
				> evolution=createmarkers
				> EOF

				Go back in the hg repo

				$ cd $TESTDIR/..

				$ for node in `hg log --rev 'draft() and ::.' --template '{node\|short}\n'`; do
				> hg export $node \| contrib/check-commit > ${TESTTMP}/check-commit.out
				> if [ $? -ne 0 ]; then
				> echo "Revision $node does not comply to rules"
				> echo '------------------------------------------------------'
				> cat ${TESTTMP}/check-commit.out
				> echo
				> fi
				> done