upstream/mercurial-mirror Files · tests/test-execute-bit.t

tryimportone: use dirstateguard instead of beginparentchange/endparentchange...

tryimportone: use dirstateguard instead of beginparentchange/endparentchange To fix the issue that the recent (in memory) dirstate isn't visible to external process (e.g. "precommit" hook), a subsequent patch makes "localrepository.commit()" invoke "dirstate.write()" in it. This change will make "beginparentchange()" and "endparentchange()" on dirstate in "cmdutil.tryimportone()" meaningless, because: - "dirstate.write()" writes changed data into ".hg/dirstate", but - aborting between "beginparentchange()" and "endparentchange()" doesn't cause any restoring ".hg/dirstate" it just discards changes in memory. This patch uses "dirstateguard" instead of "beginparentchange()" and "endparentchange()" in "cmdutil.tryimportone()" to restore ".hg/dirstate" during a failure even if "dirstate.write()" is executed before a failure. This patch uses "lockmod.release(dsguard)" instead of "dsguard.release()", because processing may be aborted before assignment to "dsguard" , and the "if dsguard" examination for safety is redundant.

Matt Mackall - - Load All Authors

File last commit:

r22046:7a9cbb31 default


                r24995:0579b0c2

default

Download file

             test-execute-bit.t
        
                    28 lines
            
             | 541 B
            
                | text/troff
            
             |
                Tads3Lexer
            
             / tests / test-execute-bit.t
          
                    History
                
                 |
                  Annotation
                 | Raw
                 |Copy content
                 |Copy permalink

      #require execbit

        $ hg init

        $ echo a > a

        $ hg ci -Am'not executable'

        adding a

        $ chmod +x a

        $ hg ci -m'executable'

        $ hg id

        79abf14474dc tip

      Make sure we notice the change of mode if the cached size == -1:

        $ hg rm a

        $ hg revert -r 0 a

        $ hg debugstate

        n   0         -1 unset               a

        $ hg status

        M a

        $ hg up 0

        1 files updated, 0 files merged, 0 files removed, 0 files unresolved

        $ hg id

        d69afc33ff8a

        $ test -x a && echo executable -- bad || echo not executable -- good

        not executable -- good

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

				#require execbit

				$ hg init
				$ echo a > a
				$ hg ci -Am'not executable'
				adding a

				$ chmod +x a
				$ hg ci -m'executable'
				$ hg id
				79abf14474dc tip

				Make sure we notice the change of mode if the cached size == -1:

				$ hg rm a
				$ hg revert -r 0 a
				$ hg debugstate
				n 0 -1 unset a
				$ hg status
				M a

				$ hg up 0
				1 files updated, 0 files merged, 0 files removed, 0 files unresolved
				$ hg id
				d69afc33ff8a
				$ test -x a && echo executable -- bad \|\| echo not executable -- good
				not executable -- good